echo and hello bug

echo and hello bug

[James Jarvis]

I have submitted a bug in to the bugzilla at

https://savannah.gnu.org/bugs/?26744

in which hello just hangs.

I have tried a few tests around this to see if I can get any output via 
hello from the command line (from menu pressing C) but I cannot. The 
problem also occurs if I use echo. Any suggestions on how I might try to 
fix this (I am happy to test it)?

The fact that both hello and echo seem to exhibit the same problem 
suggests it is not the input as the former is set as a string in the code.

James



-- 
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.

Re: echo and hello bug

[Vladimir 'phcoder' Serbinenko]

On Mon, Jun 8, 2009 at 1:34 PM, James Jarvis<James.Jarvis@ed.ac.uk> wrote:
> I have submitted a bug in to the bugzilla at
>
> https://savannah.gnu.org/bugs/?26744
>
> in which hello just hangs.
>
> I have tried a few tests around this to see if I can get any output via
> hello from the command line (from menu pressing C) but I cannot. The problem
> also occurs if I use echo. Any suggestions on how I might try to fix this (I
> am happy to test it)?
>
> The fact that both hello and echo seem to exhibit the same problem suggests
> it is not the input as the former is set as a string in the code.
What is your build environment?
>
> James
>
>
>
> --
> The University of Edinburgh is a charitable body, registered in
> Scotland, with registration number SC005336.
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Re: echo and hello bug

[James Jarvis]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

Vladimir 'phcoder' Serbinenko wrote:
> On Mon, Jun 8, 2009 at 1:34 PM, James Jarvis<James.Jarvis@ed.ac.uk> wrote:
>   
>> I have submitted a bug in to the bugzilla at
>>
>> https://savannah.gnu.org/bugs/?26744
>>
>> in which hello just hangs.
>>
>> I have tried a few tests around this to see if I can get any output via
>> hello from the command line (from menu pressing C) but I cannot. The problem
>> also occurs if I use echo. Any suggestions on how I might try to fix this (I
>> am happy to test it)?
>>
>> The fact that both hello and echo seem to exhibit the same problem suggests
>> it is not the input as the former is set as a string in the code.
>>     
> What is your build environment?
>   
I build on Ubuntu 9.04 SMP x86_64 on the iMac 9,1

I tend to use a fat binary  using - the dev is towards a grub image to 
work on both 32 and 64 bit macs however I have tested just as 64 bit and 
it has the same error. As the bug report says I compile and build for 
efi platform. In OSX  the efi.tar.gz is unpacked to MacOSX root (hd0,1)/ 
and bless the (hd0,1)/efi/grub/grub.efi there.

Menus work. Appleloader works.

I have attached the script I use to build it.

James


>> James
>>
>>
>>
>> --
>> The University of Edinburgh is a charitable body, registered in
>> Scotland, with registration number SC005336.
>>
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>>     
>
>
>
>   


-- 
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.


[-- Attachment #2: makefatgrub.sh --]
[-- Type: application/x-shellscript, Size: 3240 bytes --]

Re: echo and hello bug

[Peter Cros]

[-- Attachment #1: Type: text/plain, Size: 2449 bytes --]

May be of interest -

This is the module subset I am using with fat grub efi rev 2202 for 64/32bit
efi on
Imac81, MacBookPro41, MacBook21.

(  ./fatglue.py grub2202fat.efi grub2202-32.efi grub2202-64.efi )

I dont use hello, but echo works.

appleldr boot cat cmp chain configfile crc date echo ext2 fixvideo fat
fs_uuid gpt gptsync halt help hexdump hfs  hfsplus iso9660 linux loopback
loadbios lspci ls minicmd memrw ntfs pc pci reboot reiserfs read scsi sleep
search sh video videotest xfs.



On Mon, Jun 8, 2009 at 11:39 PM, James Jarvis <James.Jarvis@ed.ac.uk> wrote:

> Vladimir 'phcoder' Serbinenko wrote:
>
>> On Mon, Jun 8, 2009 at 1:34 PM, James Jarvis<James.Jarvis@ed.ac.uk>
>> wrote:
>>
>>
>>> I have submitted a bug in to the bugzilla at
>>>
>>> https://savannah.gnu.org/bugs/?26744
>>>
>>> in which hello just hangs.
>>>
>>> I have tried a few tests around this to see if I can get any output via
>>> hello from the command line (from menu pressing C) but I cannot. The
>>> problem
>>> also occurs if I use echo. Any suggestions on how I might try to fix this
>>> (I
>>> am happy to test it)?
>>>
>>> The fact that both hello and echo seem to exhibit the same problem
>>> suggests
>>> it is not the input as the former is set as a string in the code.
>>>
>>>
>> What is your build environment?
>>
>>
> I build on Ubuntu 9.04 SMP x86_64 on the iMac 9,1
>
> I tend to use a fat binary  using - the dev is towards a grub image to work
> on both 32 and 64 bit macs however I have tested just as 64 bit and it has
> the same error. As the bug report says I compile and build for efi platform.
> In OSX  the efi.tar.gz is unpacked to MacOSX root (hd0,1)/ and bless the
> (hd0,1)/efi/grub/grub.efi there.
>
> Menus work. Appleloader works.
>
> I have attached the script I use to build it.
>
> James
>
>
>
>  James
>>>
>>>
>>>
>>> --
>>> The University of Edinburgh is a charitable body, registered in
>>> Scotland, with registration number SC005336.
>>>
>>>
>>>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> Grub-devel@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>>
>>>
>>>
>>
>>
>>
>>
>>
>
>
> --
> The University of Edinburgh is a charitable body, registered in
> Scotland, with registration number SC005336.
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>


-- 
Cros (pxw)

[-- Attachment #2: Type: text/html, Size: 3969 bytes --]

Re: echo and hello bug

[James Jarvis]

Peter Cros wrote:
> May be of interest -
>
> This is the module subset I am using with fat grub efi rev 2202 for 
> 64/32bit efi on
> Imac81, MacBookPro41, MacBook21.
>
> (  ./fatglue.py grub2202fat.efi grub2202-32.efi grub2202-64.efi )
>
Thanks Peter. I do something similar in the script
> I dont use hello, but echo works.
>
> appleldr boot cat cmp chain configfile crc date echo ext2 fixvideo fat 
> fs_uuid gpt gptsync halt help hexdump hfs  hfsplus iso9660 linux 
> loopback loadbios lspci ls minicmd memrw ntfs pc pci reboot reiserfs 
> read scsi sleep search sh video videotest xfs.
>
>
tried this module list in grub-mkimage on 2282 but it hung!

I had a few local mods so I am retrying. If that fails I may go back to 
2202 to see if I can replicate it working as you indicate.

James
>
> On Mon, Jun 8, 2009 at 11:39 PM, James Jarvis <James.Jarvis@ed.ac.uk 
> <mailto:James.Jarvis@ed.ac.uk>> wrote:
>
>     Vladimir 'phcoder' Serbinenko wrote:
>
>         On Mon, Jun 8, 2009 at 1:34 PM, James
>         Jarvis<James.Jarvis@ed.ac.uk <mailto:James.Jarvis@ed.ac.uk>>
>         wrote:
>          
>
>             I have submitted a bug in to the bugzilla at
>
>             https://savannah.gnu.org/bugs/?26744
>
>             in which hello just hangs.
>
>             I have tried a few tests around this to see if I can get
>             any output via
>             hello from the command line (from menu pressing C) but I
>             cannot. The problem
>             also occurs if I use echo. Any suggestions on how I might
>             try to fix this (I
>             am happy to test it)?
>
>             The fact that both hello and echo seem to exhibit the same
>             problem suggests
>             it is not the input as the former is set as a string in
>             the code.
>                
>
>         What is your build environment?
>          
>
>     I build on Ubuntu 9.04 SMP x86_64 on the iMac 9,1
>
>     I tend to use a fat binary  using - the dev is towards a grub
>     image to work on both 32 and 64 bit macs however I have tested
>     just as 64 bit and it has the same error. As the bug report says I
>     compile and build for efi platform. In OSX  the efi.tar.gz is
>     unpacked to MacOSX root (hd0,1)/ and bless the
>     (hd0,1)/efi/grub/grub.efi there.
>
>     Menus work. Appleloader works.
>
>     I have attached the script I use to build it.
>
>     James
>
>
>
>             James
>
>
>
>             --
>             The University of Edinburgh is a charitable body,
>             registered in
>             Scotland, with registration number SC005336.
>
>
>
>             _______________________________________________
>             Grub-devel mailing list
>             Grub-devel@gnu.org <mailto:Grub-devel@gnu.org>
>             http://lists.gnu.org/mailman/listinfo/grub-devel
>
>                
>
>
>
>
>          
>
>
>
>     -- 
>     The University of Edinburgh is a charitable body, registered in
>     Scotland, with registration number SC005336.
>
>
>     _______________________________________________
>     Grub-devel mailing list
>     Grub-devel@gnu.org <mailto:Grub-devel@gnu.org>
>     http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
>
>
> -- 
> Cros (pxw)
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>   


-- 
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.

Re: echo and hello bug

[Vladimir 'phcoder' Serbinenko]

> tried this module list in grub-mkimage on 2282 but it hung!
I think you have a problem with you building system. If you want ping
me (phcoder) on IRC and I'll compile for you
-- 
Regards
Vladimir 'phcoder' Serbinenko

Re: echo and hello bug

[James Jarvis]

Vladimir 'phcoder' Serbinenko wrote:
>> tried this module list in grub-mkimage on 2282 but it hung!
>>     
> I think you have a problem with you building system. If you want ping
> me (phcoder) on IRC and I'll compile for you
>   
Shamed me into looking deeper! I discover that by listing hello and echo 
first in the grub-mkimage command they both work as expected. Not sure 
why this occurs - is there a file detailing module dependencies one can 
look at?

Anyway, whilst looking through the code I did spot a semantic error, fix 
shown in this patch:
Index: echo.c
===================================================================
--- echo.c      (revision 2331)
+++ echo.c      (working copy)
@@ -113,7 +113,7 @@
 GRUB_MOD_INIT(echo)
 {
   cmd = grub_register_extcmd ("echo", grub_cmd_echo, 
GRUB_COMMAND_FLAG_BOTH,
-                             "echo [-e|-n] FILE", "Display a line of 
text.",
+                             "echo [-e|-n] STRING", "Display a line of 
text.",
                              options);
 }

James

-- 
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.

Re: echo and hello bug

[Felix Zielcke]

Am Dienstag, den 16.06.2009, 15:09 +0100 schrieb James Jarvis:
> Anyway, whilst looking through the code I did spot a semantic error,
> fix 
> shown in this patch:

Thanks, just commited it.
-- 
Felix Zielcke

Re: echo and hello bug

[Vladimir 'phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

On Tue, Jun 16, 2009 at 4:09 PM, James Jarvis <James.Jarvis@ed.ac.uk> wrote:

> Vladimir 'phcoder' Serbinenko wrote:
>
>> tried this module list in grub-mkimage on 2282 but it hung!
>>>
>>>
>> I think you have a problem with you building system. If you want ping
>> me (phcoder) on IRC and I'll compile for you
>>
>>
> Shamed me into looking deeper! I discover that by listing hello and echo
> first in the grub-mkimage command they both work as expected. Not sure why
> this occurs - is there a file detailing module dependencies one can look at?
>
You have probably hit a memory access bug in a secondary module. Post the
list of modules you integrate and try removing some of these modules

>
> Anyway, whilst looking through the code I did spot a semantic error, fix
> shown in this patch:
> Index: echo.c
> ===================================================================
> --- echo.c      (revision 2331)
> +++ echo.c      (working copy)
> @@ -113,7 +113,7 @@
> GRUB_MOD_INIT(echo)
> {
>  cmd = grub_register_extcmd ("echo", grub_cmd_echo, GRUB_COMMAND_FLAG_BOTH,
> -                             "echo [-e|-n] FILE", "Display a line of
> text.",
> +                             "echo [-e|-n] STRING", "Display a line of
> text.",
>                             options);
> }
>
> James
>
> --
> The University of Edinburgh is a charitable body, registered in
> Scotland, with registration number SC005336.
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

[-- Attachment #2: Type: text/html, Size: 2737 bytes --]

Re: echo and hello bug

[James Jarvis]

Vladimir 'phcoder' Serbinenko wrote:
>
>
> On Tue, Jun 16, 2009 at 4:09 PM, James Jarvis <James.Jarvis@ed.ac.uk 
> <mailto:James.Jarvis@ed.ac.uk>> wrote:
>
>     Vladimir 'phcoder' Serbinenko wrote:
>
>             tried this module list in grub-mkimage on 2282 but it hung!
>                
>
>         I think you have a problem with you building system. If you
>         want ping
>         me (phcoder) on IRC and I'll compile for you
>          
>
>     Shamed me into looking deeper! I discover that by listing hello
>     and echo first in the grub-mkimage command they both work as
>     expected. Not sure why this occurs - is there a file detailing
>     module dependencies one can look at?
>
> You have probably hit a memory access bug in a secondary module. Post 
> the list of modules you integrate and try removing some of these modules
It appears that if the "echo" and "hello" modules are in the efi image 
before the "kernel" module they work but if after they don't.

Moving "kernel" to the end means that "echo" "hello" and "ls" work 
correctly. I need kernel so I just need to remember to put it as the 
last module. Presumably I am not the first to come across this problem 
but it was not one that came up easily in searches. I'll add to the bug 
report.

James


-- 
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.

Re: echo and hello bug

[Vladimir 'phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1752 bytes --]

On Wed, Jun 17, 2009 at 5:24 PM, James Jarvis <James.Jarvis@ed.ac.uk> wrote:

> Vladimir 'phcoder' Serbinenko wrote:
>
>>
>>
>> On Tue, Jun 16, 2009 at 4:09 PM, James Jarvis <James.Jarvis@ed.ac.uk<mailto:
>> James.Jarvis@ed.ac.uk>> wrote:
>>
>>    Vladimir 'phcoder' Serbinenko wrote:
>>
>>            tried this module list in grub-mkimage on 2282 but it hung!
>>
>>        I think you have a problem with you building system. If you
>>        want ping
>>        me (phcoder) on IRC and I'll compile for you
>>
>>    Shamed me into looking deeper! I discover that by listing hello
>>    and echo first in the grub-mkimage command they both work as
>>    expected. Not sure why this occurs - is there a file detailing
>>    module dependencies one can look at?
>>
>> You have probably hit a memory access bug in a secondary module. Post the
>> list of modules you integrate and try removing some of these modules
>>
> It appears that if the "echo" and "hello" modules are in the efi image
> before the "kernel" module they work but if after they don't.
>
> Moving "kernel" to the end means that "echo" "hello" and "ls" work
> correctly. I need kernel so I just need to remember to put it as the last
> module. Presumably I am not the first to come across this problem but it was
> not one that came up easily in searches. I'll add to the bug report.
>
Never specify kernel.mod explicitely. It's added automatically

>
>
> James
>
>
> --
> The University of Edinburgh is a charitable body, registered in
> Scotland, with registration number SC005336.
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

[-- Attachment #2: Type: text/html, Size: 2936 bytes --]