From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nick Piggin <npiggin@suse.de>, Ingo Molnar <mingo@elte.hu>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
benh@kernel.crashing.org, akpm@linux-foundation.org,
cl@linux-foundation.org
Subject: Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending
Date: Fri, 12 Jun 2009 18:16:49 +0300 [thread overview]
Message-ID: <4A327161.7000803@cs.helsinki.fi> (raw)
In-Reply-To: <alpine.LFD.2.01.0906120809560.3237@localhost.localdomain>
Linus Torvalds wrote:
>
> On Fri, 12 Jun 2009, Pekka J Enberg wrote:
>> Hmm. This is turning into one epic patch discussion for sure! But here's a
>> patch to do what you suggested. With the amount of patches I am
>> generating, I'm bound to hit the right one sooner or later, no?-)
>
> Ok, this one looks pretty good. I like the statics, and I like how it lets
> each allocator decide what to do.
>
> Small nit: your mm/slab.c patch does an obviously unnecessary mask in:
>
> cache_alloc_debugcheck_before(cachep, flags & slab_gfp_flags);
>
> but that's stupid, because the bits were already masked earlier.
Yeah, the SLAB parts were completely untested. I have this in my tree
now (that I sent a pull request for):
http://git.kernel.org/?p=linux/kernel/git/penberg/slab-2.6.git;a=commitdiff;h=f6b726dae91cc74fb3a00f192932ec4fe0949875
Do you want me to drop it? I can also do an incremental patch to do the
unmasking as in this patch.
Pekka
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nick Piggin <npiggin@suse.de>, Ingo Molnar <mingo@elte.hu>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
benh@kernel.crashing.org, akpm@linux-foundation.org,
cl@linux-foundation.org
Subject: Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending
Date: Fri, 12 Jun 2009 18:16:49 +0300 [thread overview]
Message-ID: <4A327161.7000803@cs.helsinki.fi> (raw)
In-Reply-To: <alpine.LFD.2.01.0906120809560.3237@localhost.localdomain>
Linus Torvalds wrote:
>
> On Fri, 12 Jun 2009, Pekka J Enberg wrote:
>> Hmm. This is turning into one epic patch discussion for sure! But here's a
>> patch to do what you suggested. With the amount of patches I am
>> generating, I'm bound to hit the right one sooner or later, no?-)
>
> Ok, this one looks pretty good. I like the statics, and I like how it lets
> each allocator decide what to do.
>
> Small nit: your mm/slab.c patch does an obviously unnecessary mask in:
>
> cache_alloc_debugcheck_before(cachep, flags & slab_gfp_flags);
>
> but that's stupid, because the bits were already masked earlier.
Yeah, the SLAB parts were completely untested. I have this in my tree
now (that I sent a pull request for):
http://git.kernel.org/?p=linux/kernel/git/penberg/slab-2.6.git;a=commitdiff;h=f6b726dae91cc74fb3a00f192932ec4fe0949875
Do you want me to drop it? I can also do an incremental patch to do the
unmasking as in this patch.
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-12 15:21 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 8:13 [PATCH 2/2] slab,slub: ignore __GFP_WAIT if we're booting or suspending Pekka J Enberg
2009-06-12 8:13 ` Pekka J Enberg
2009-06-12 9:03 ` [PATCH v2] " Pekka J Enberg
2009-06-12 9:03 ` Pekka J Enberg
2009-06-12 9:10 ` Ingo Molnar
2009-06-12 9:10 ` Ingo Molnar
2009-06-12 9:21 ` Benjamin Herrenschmidt
2009-06-12 9:21 ` Benjamin Herrenschmidt
2009-06-12 9:24 ` Pekka Enberg
2009-06-12 9:24 ` Pekka Enberg
2009-06-12 9:36 ` Benjamin Herrenschmidt
2009-06-12 9:36 ` Benjamin Herrenschmidt
2009-06-12 9:45 ` Pekka J Enberg
2009-06-12 9:45 ` Pekka J Enberg
2009-06-12 9:58 ` Benjamin Herrenschmidt
2009-06-12 9:58 ` Benjamin Herrenschmidt
2009-06-12 10:00 ` Pekka Enberg
2009-06-12 10:00 ` Pekka Enberg
2009-06-12 15:22 ` Andrew Morton
2009-06-12 15:22 ` Andrew Morton
2009-06-12 9:49 ` Pekka Enberg
2009-06-12 9:49 ` Pekka Enberg
2009-06-12 9:52 ` Nick Piggin
2009-06-12 9:52 ` Nick Piggin
2009-06-12 9:54 ` Pekka Enberg
2009-06-12 9:54 ` Pekka Enberg
2009-06-12 9:59 ` Benjamin Herrenschmidt
2009-06-12 9:59 ` Benjamin Herrenschmidt
2009-06-25 4:38 ` Nick Piggin
2009-06-25 4:38 ` Nick Piggin
2009-06-12 10:07 ` Ingo Molnar
2009-06-12 10:07 ` Ingo Molnar
2009-06-12 10:11 ` Pekka Enberg
2009-06-12 10:11 ` Pekka Enberg
2009-06-12 10:15 ` Nick Piggin
2009-06-12 10:15 ` Nick Piggin
2009-06-12 10:30 ` Pekka J Enberg
2009-06-12 10:30 ` Pekka J Enberg
2009-06-12 10:32 ` Pekka Enberg
2009-06-12 10:32 ` Pekka Enberg
2009-06-12 15:16 ` Linus Torvalds
2009-06-12 15:16 ` Linus Torvalds
2009-06-12 15:16 ` Pekka Enberg [this message]
2009-06-12 15:16 ` Pekka Enberg
2009-06-12 11:13 ` Benjamin Herrenschmidt
2009-06-12 11:13 ` Benjamin Herrenschmidt
2009-06-12 11:24 ` Benjamin Herrenschmidt
2009-06-12 11:24 ` Benjamin Herrenschmidt
2009-06-12 11:11 ` Benjamin Herrenschmidt
2009-06-12 11:11 ` Benjamin Herrenschmidt
2009-06-12 11:34 ` Pekka Enberg
2009-06-12 11:34 ` Pekka Enberg
2009-06-12 11:41 ` Benjamin Herrenschmidt
2009-06-12 11:41 ` Benjamin Herrenschmidt
2009-06-12 11:43 ` Pekka Enberg
2009-06-12 11:43 ` Pekka Enberg
2009-06-12 15:30 ` Andrew Morton
2009-06-12 15:30 ` Andrew Morton
2009-06-12 21:42 ` Benjamin Herrenschmidt
2009-06-12 21:42 ` Benjamin Herrenschmidt
2009-06-25 4:41 ` Nick Piggin
2009-06-25 4:41 ` Nick Piggin
2009-06-12 11:09 ` Benjamin Herrenschmidt
2009-06-12 11:09 ` Benjamin Herrenschmidt
2009-06-12 15:04 ` Linus Torvalds
2009-06-12 15:04 ` Linus Torvalds
2009-06-12 15:05 ` Pekka Enberg
2009-06-12 15:05 ` Pekka Enberg
2009-06-19 14:59 ` Pavel Machek
2009-06-19 14:59 ` Pavel Machek
2009-06-19 22:27 ` Benjamin Herrenschmidt
2009-06-19 22:27 ` Benjamin Herrenschmidt
2009-06-19 23:23 ` Pavel Machek
2009-06-19 23:23 ` Pavel Machek
2009-06-19 23:50 ` Benjamin Herrenschmidt
2009-06-19 23:50 ` Benjamin Herrenschmidt
2009-06-20 0:28 ` Pavel Machek
2009-06-20 0:28 ` Pavel Machek
2009-06-20 2:10 ` Benjamin Herrenschmidt
2009-06-20 2:10 ` Benjamin Herrenschmidt
2009-06-21 6:18 ` Pavel Machek
2009-06-21 6:18 ` Pavel Machek
2009-06-21 9:31 ` Benjamin Herrenschmidt
2009-06-21 9:31 ` Benjamin Herrenschmidt
2009-06-25 4:34 ` Nick Piggin
2009-06-25 4:34 ` Nick Piggin
2009-06-25 9:56 ` Benjamin Herrenschmidt
2009-06-25 9:56 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A327161.7000803@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.