All of lore.kernel.org
 help / color / mirror / Atom feed
* patch for compcache recipe
@ 2009-08-13 19:10 Ming Chow 周明
  2009-08-14  2:06 ` Holger Hans Peter Freyther
  0 siblings, 1 reply; 13+ messages in thread
From: Ming Chow 周明 @ 2009-08-13 19:10 UTC (permalink / raw)
  To: openembedded-devel@lists.openembedded.org

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Hi,

I have tried compcache from code.google.com on beagleboard rev B5 and 
n800 for a couple of weeks. It seems helping me getting more usable memory.
The patch will add compcache stuff which provides both compcache kernel 
modules and managing tool.
Tested with recent oe repo on my boards, more evaluation on various real 
hardware platforms needed though.
BTW not touched checksum.ini for the tarball yet.

Cheers,

Zhou Ming



[-- Attachment #2: patch-compcache-0.6pre3.diff --]
[-- Type: text/x-patch, Size: 4288 bytes --]

diff --git a/recipes/compcache/compcache/000-compcache-KERNELDIR.patch b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
new file mode 100644
index 0000000..e80f75b
--- /dev/null
+++ b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
@@ -0,0 +1,34 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 00:25:45.904934007 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 00:25:58.404938574 +0800
+@@ -1,17 +1,17 @@
+ EXTRA_CFLAGS	:=	-DCONFIG_BLK_DEV_RAMZSWAP_STATS \
+ 			-g -Wall
+ 
+-ifndef $(KERNEL_BUILD_PATH)
+-	KERNEL_BUILD_PATH="/lib/modules/$(shell uname -r)/build"
++ifndef $(KERNELDIR)
++	KERNELDIR="/lib/modules/$(shell uname -r)/build"
+ endif
+ 
+ obj-m	+=	sub-projects/allocators/xvmalloc-kmod/xvmalloc.o \
+ 		ramzswap.o
+ 
+ all:
+-	make -C $(KERNEL_BUILD_PATH) \
++	make -C $(KERNELDIR) \
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) modules
++	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+ 	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
+ 
+@@ -19,7 +19,7 @@
+ 	make -C sub-projects/rzscontrol doc
+ 
+ clean:
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) clean
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
++	make -C $(KERNELDIR) M=$(PWD) clean
++	make -C $(KERNELDIR) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
+ 	make -C sub-projects/rzscontrol clean
+ 	@rm -rf *.ko
diff --git a/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
new file mode 100644
index 0000000..8dbb590
--- /dev/null
+++ b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
@@ -0,0 +1,9 @@
+--- compcache-0.6pre3.orig/sub-projects/rzscontrol/Makefile	2009-08-06 23:27:40.000000000 +0800
++++ compcache-0.6pre3/sub-projects/rzscontrol/Makefile	2009-08-14 00:19:38.374938229 +0800
+@@ -1,5 +1,5 @@
+ all:
+-	@gcc -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
++	${CCLD} -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
+ 
+ doc:
+ 	@xmllint --noout --valid man/rzscontrol.xml
diff --git a/recipes/compcache/compcache/002-compcache-modules-install.patch b/recipes/compcache/compcache/002-compcache-modules-install.patch
new file mode 100644
index 0000000..cf9b9b1
--- /dev/null
+++ b/recipes/compcache/compcache/002-compcache-modules-install.patch
@@ -0,0 +1,13 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 02:33:45.169249060 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 02:34:15.594938335 +0800
+@@ -13,7 +13,9 @@
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+ 	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+-	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
++
++modules_install:
++	make -C $(KERNELDIR) M=$(PWD) modules_install
+ 
+ doc:
+ 	make -C sub-projects/rzscontrol doc
diff --git a/recipes/compcache/compcache_0.6pre3.bb b/recipes/compcache/compcache_0.6pre3.bb
new file mode 100644
index 0000000..0b59815
--- /dev/null
+++ b/recipes/compcache/compcache_0.6pre3.bb
@@ -0,0 +1,28 @@
+HOMEPAGE = "http://code.google.com/p/compcache"
+DESCRIPTION = "Kernel drivers version 0.6x and related tool for the compcache (compressed in-memory swap device for linux)"
+LICENSE = "GPLv2"
+
+inherit module
+
+SRC_URI = "http://compcache.googlecode.com/files/compcache-${PV}.tar.gz \
+	file://000-compcache-KERNELDIR.patch;patch=1 \
+	file://001-compcache-rzscontrol-cross-compile.patch;patch=1 \
+	file://002-compcache-modules-install.patch;patch=1 \
+	   "
+
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+PACKAGES = "compcache-modules rzscontrol rzscontrol-dbg rzscontrol-doc"
+
+FILES_compcache-modules = ${FILES_compcache}
+FILES_rzscontrol = "${bindir}/rzscontrol"
+FILES_rzscontrol-dbg = "${bindir}/.debug/rzscontrol"
+FILES_rzscontrol-doc = "${mandir}/man1/rzscontrol.1"
+
+do_install_prepend() {
+	mkdir -p ${D}${bindir}
+	mkdir -p ${D}${mandir}/man1
+	install -m 0755 ${S}/sub-projects/rzscontrol/rzscontrol ${D}${bindir}
+	install -m 0644 ${S}/sub-projects/rzscontrol/man/rzscontrol.1 ${D}${mandir}/man1
+}
+

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-13 19:10 patch for compcache recipe Ming Chow 周明
@ 2009-08-14  2:06 ` Holger Hans Peter Freyther
  2009-08-14  6:29   ` Ming Chow 周明
  0 siblings, 1 reply; 13+ messages in thread
From: Holger Hans Peter Freyther @ 2009-08-14  2:06 UTC (permalink / raw)
  To: openembedded-devel

On Thursday 13 August 2009 21:10:07 Ming Chow 周明 wrote:
> Hi,
>
> I have tried compcache from code.google.com on beagleboard rev B5 and
> n800 for a couple of weeks. It seems helping me getting more usable memory.
> The patch will add compcache stuff which provides both compcache kernel
> modules and managing tool.
> Tested with recent oe repo on my boards, more evaluation on various real
> hardware platforms needed though.
> BTW not touched checksum.ini for the tarball yet.

Hi,

the patch looks nice. I have three minor comments. 

Would you please add the checksums.ini entry and send the mail with a Signed-
off-by: line?

I think sending the last two patches (modules_instal target) and not using gcc 
directly upstream would make sense? Did you already do that?

This one is on naming. The exmap kernel module is called "kernel-module-
exmap", for the sake of consistency you should consider renaming "compach-
modules" to "kernel-module-compcache"? And maybe install rzscontrol into the 
compache package too. The reason is that it is not easy to spot the 
relationship from compache to the rzscontrol package.

z.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-14  2:06 ` Holger Hans Peter Freyther
@ 2009-08-14  6:29   ` Ming Chow 周明
  2009-08-14 14:39     ` Rolf Leggewie
  2009-08-14 15:05     ` Ming Chow 周明
  0 siblings, 2 replies; 13+ messages in thread
From: Ming Chow 周明 @ 2009-08-14  6:29 UTC (permalink / raw)
  To: openembedded-devel

Holger Hans Peter Freyther wrote:
> On Thursday 13 August 2009 21:10:07 Ming Chow 周明 wrote:
>   
>> Hi,
>>
>> I have tried compcache from code.google.com on beagleboard rev B5 and
>> n800 for a couple of weeks. It seems helping me getting more usable memory.
>> The patch will add compcache stuff which provides both compcache kernel
>> modules and managing tool.
>> Tested with recent oe repo on my boards, more evaluation on various real
>> hardware platforms needed though.
>> BTW not touched checksum.ini for the tarball yet.
>>     
>
> Hi,
>
> the patch looks nice. I have three minor comments. 
>   
thanks for your kind advices.
> Would you please add the checksums.ini entry and send the mail with a Signed-
> off-by: line?
>   
Sure. I added the checksum entry.

BTW. I had experienced some checksum mismatch before. A few packages 
which just work can not pass checksum matching. I guess it may be caused 
by hosting or tarball changing without notice. For I am not very clear 
how the global checksum.ini is maintained. I lazily set 
OE_ALLOW_INSECURE_DOWNLOADS.
> I think sending the last two patches (modules_instal target) and not using gcc 
> directly upstream would make sense? Did you already do that?
>
>   
The modules_install patch is for enable "make modules_install" work when 
use the Kernel kbuild system which make it kernel independent. 
Originally, people have to use a load_modules.sh script instead install 
.kos to lib/modules directory. I think a startup script in /etc/init.d 
and a setting file in /etc is a next step work, after find out some 
optimal settings on certain platform/distro combination.

The rzscontrol is compiled to native binary with hardcoded in stock tar 
ball, change to use ${CCLD} make it work arch independent.
> This one is on naming. The exmap kernel module is called "kernel-module-
> exmap", for the sake of consistency you should consider renaming "compach-
> modules" to "kernel-module-compcache"? And maybe install rzscontrol into the 
> compache package too. The reason is that it is not easy to spot the 
> relationship from compache to the rzscontrol package.
>
> z.
>   
Good point. I am sorry for mis-naming the module package. Agree with you.
And which is better do you think:
mix rzscontrol and kernel modules
or
put modules in kernel-module-compcache
put rzscontrol in kernel-module-compcache-utils (or compcache-utils)
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>   




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-14  6:29   ` Ming Chow 周明
@ 2009-08-14 14:39     ` Rolf Leggewie
  2009-08-14 14:55       ` Ming Chow 周明
  2009-08-14 15:05     ` Ming Chow 周明
  1 sibling, 1 reply; 13+ messages in thread
From: Rolf Leggewie @ 2009-08-14 14:39 UTC (permalink / raw)
  To: openembedded-devel

Ming Chow 周明 wrote:
> BTW. I had experienced some checksum mismatch before. A few packages 
> which just work can not pass checksum matching. I guess it may be caused 
> by hosting or tarball changing without notice. For I am not very clear 
> how the global checksum.ini is maintained. I lazily set 
> OE_ALLOW_INSECURE_DOWNLOADS.

Take a look at
http://wiki.openembedded.net/index.php/Dealing_with_checksum_mismatch

Let us know about the packages failing the checksum test so we can fix
things.




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-14 14:39     ` Rolf Leggewie
@ 2009-08-14 14:55       ` Ming Chow 周明
  0 siblings, 0 replies; 13+ messages in thread
From: Ming Chow 周明 @ 2009-08-14 14:55 UTC (permalink / raw)
  To: openembedded-devel

Got it, thank you.
I will try the checksum stuff.

Rolf Leggewie wrote:
> Ming Chow 周明 wrote:
>   
>> BTW. I had experienced some checksum mismatch before. A few packages 
>> which just work can not pass checksum matching. I guess it may be caused 
>> by hosting or tarball changing without notice. For I am not very clear 
>> how the global checksum.ini is maintained. I lazily set 
>> OE_ALLOW_INSECURE_DOWNLOADS.
>>     
>
> Take a look at
> http://wiki.openembedded.net/index.php/Dealing_with_checksum_mismatch
>
> Let us know about the packages failing the checksum test so we can fix
> things.
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>   




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-14  6:29   ` Ming Chow 周明
  2009-08-14 14:39     ` Rolf Leggewie
@ 2009-08-14 15:05     ` Ming Chow 周明
  2009-08-14 15:19       ` Koen Kooi
  1 sibling, 1 reply; 13+ messages in thread
From: Ming Chow 周明 @ 2009-08-14 15:05 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 3388 bytes --]

Signed-off-by: Zhou Ming <chow.ming@linuxbj.com>

I have renewed the patch looks like:

- added the checksum entry
- use kernel-module-compcache as the package name which results throwing 
out packages like "kernel-module-compcache_0.6pre3-r41.3_beagleboard.ipk"
- use compcache-utils as the tool package name which looks like 
"compcache-utils_0.6pre3-r41.3_beagleboard.ipk"

Ming Chow 周明 wrote:
> Holger Hans Peter Freyther wrote:
>> On Thursday 13 August 2009 21:10:07 Ming Chow 周明 wrote:
>>  
>>> Hi,
>>>
>>> I have tried compcache from code.google.com on beagleboard rev B5 and
>>> n800 for a couple of weeks. It seems helping me getting more usable 
>>> memory.
>>> The patch will add compcache stuff which provides both compcache kernel
>>> modules and managing tool.
>>> Tested with recent oe repo on my boards, more evaluation on various 
>>> real
>>> hardware platforms needed though.
>>> BTW not touched checksum.ini for the tarball yet.
>>>     
>>
>> Hi,
>>
>> the patch looks nice. I have three minor comments.   
> thanks for your kind advices.
>> Would you please add the checksums.ini entry and send the mail with a 
>> Signed-
>> off-by: line?
>>   
> Sure. I added the checksum entry.
>
> BTW. I had experienced some checksum mismatch before. A few packages 
> which just work can not pass checksum matching. I guess it may be 
> caused by hosting or tarball changing without notice. For I am not 
> very clear how the global checksum.ini is maintained. I lazily set 
> OE_ALLOW_INSECURE_DOWNLOADS.
>> I think sending the last two patches (modules_instal target) and not 
>> using gcc directly upstream would make sense? Did you already do that?
>>
>>   
> The modules_install patch is for enable "make modules_install" work 
> when use the Kernel kbuild system which make it kernel independent. 
> Originally, people have to use a load_modules.sh script instead 
> install .kos to lib/modules directory. I think a startup script in 
> /etc/init.d and a setting file in /etc is a next step work, after find 
> out some optimal settings on certain platform/distro combination.
>
> The rzscontrol is compiled to native binary with hardcoded in stock 
> tar ball, change to use ${CCLD} make it work arch independent.
>> This one is on naming. The exmap kernel module is called "kernel-module-
>> exmap", for the sake of consistency you should consider renaming 
>> "compach-
>> modules" to "kernel-module-compcache"? And maybe install rzscontrol 
>> into the compache package too. The reason is that it is not easy to 
>> spot the relationship from compache to the rzscontrol package.
>>
>> z.
>>   
> Good point. I am sorry for mis-naming the module package. Agree with you.
> And which is better do you think:
> mix rzscontrol and kernel modules
> or
> put modules in kernel-module-compcache
> put rzscontrol in kernel-module-compcache-utils (or compcache-utils)
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>   
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel


[-- Attachment #2: patch-compcache-0.6pre3.diff --]
[-- Type: text/x-patch, Size: 4863 bytes --]

diff --git a/recipes/compcache/compcache/000-compcache-KERNELDIR.patch b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
new file mode 100644
index 0000000..e80f75b
--- /dev/null
+++ b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
@@ -0,0 +1,34 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 00:25:45.904934007 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 00:25:58.404938574 +0800
+@@ -1,17 +1,17 @@
+ EXTRA_CFLAGS	:=	-DCONFIG_BLK_DEV_RAMZSWAP_STATS \
+ 			-g -Wall
+ 
+-ifndef $(KERNEL_BUILD_PATH)
+-	KERNEL_BUILD_PATH="/lib/modules/$(shell uname -r)/build"
++ifndef $(KERNELDIR)
++	KERNELDIR="/lib/modules/$(shell uname -r)/build"
+ endif
+ 
+ obj-m	+=	sub-projects/allocators/xvmalloc-kmod/xvmalloc.o \
+ 		ramzswap.o
+ 
+ all:
+-	make -C $(KERNEL_BUILD_PATH) \
++	make -C $(KERNELDIR) \
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) modules
++	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+ 	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
+ 
+@@ -19,7 +19,7 @@
+ 	make -C sub-projects/rzscontrol doc
+ 
+ clean:
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) clean
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
++	make -C $(KERNELDIR) M=$(PWD) clean
++	make -C $(KERNELDIR) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
+ 	make -C sub-projects/rzscontrol clean
+ 	@rm -rf *.ko
diff --git a/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
new file mode 100644
index 0000000..8dbb590
--- /dev/null
+++ b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
@@ -0,0 +1,9 @@
+--- compcache-0.6pre3.orig/sub-projects/rzscontrol/Makefile	2009-08-06 23:27:40.000000000 +0800
++++ compcache-0.6pre3/sub-projects/rzscontrol/Makefile	2009-08-14 00:19:38.374938229 +0800
+@@ -1,5 +1,5 @@
+ all:
+-	@gcc -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
++	${CCLD} -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
+ 
+ doc:
+ 	@xmllint --noout --valid man/rzscontrol.xml
diff --git a/recipes/compcache/compcache/002-compcache-modules-install.patch b/recipes/compcache/compcache/002-compcache-modules-install.patch
new file mode 100644
index 0000000..cf9b9b1
--- /dev/null
+++ b/recipes/compcache/compcache/002-compcache-modules-install.patch
@@ -0,0 +1,13 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 02:33:45.169249060 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 02:34:15.594938335 +0800
+@@ -13,7 +13,9 @@
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+ 	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+-	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
++
++modules_install:
++	make -C $(KERNELDIR) M=$(PWD) modules_install
+ 
+ doc:
+ 	make -C sub-projects/rzscontrol doc
diff --git a/recipes/compcache/compcache_0.6pre3.bb b/recipes/compcache/compcache_0.6pre3.bb
new file mode 100644
index 0000000..ea8772c
--- /dev/null
+++ b/recipes/compcache/compcache_0.6pre3.bb
@@ -0,0 +1,28 @@
+HOMEPAGE = "http://code.google.com/p/compcache"
+DESCRIPTION = "Kernel drivers version 0.6x and related tool for the compcache (compressed in-memory swap device for linux)"
+LICENSE = "GPLv2"
+
+inherit module
+
+SRC_URI = "http://compcache.googlecode.com/files/compcache-${PV}.tar.gz \
+	file://000-compcache-KERNELDIR.patch;patch=1 \
+	file://001-compcache-rzscontrol-cross-compile.patch;patch=1 \
+	file://002-compcache-modules-install.patch;patch=1 \
+	   "
+
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+PACKAGES = "kernel-module-compcache compcache-utils compcache-utils-dbg compcache-utils-doc"
+
+FILES_kernel-module-compcache = ${FILES_compcache}
+FILES_compcache-utils = "${bindir}/rzscontrol"
+FILES_compcache-utils-dbg = "${bindir}/.debug/rzscontrol"
+FILES_compcache-utils-doc = "${mandir}/man1/rzscontrol.1"
+
+do_install_prepend() {
+	mkdir -p ${D}${bindir}
+	mkdir -p ${D}${mandir}/man1
+	install -m 0755 ${S}/sub-projects/rzscontrol/rzscontrol ${D}${bindir}
+	install -m 0644 ${S}/sub-projects/rzscontrol/man/rzscontrol.1 ${D}${mandir}/man1
+}
+
diff --git a/conf/checksums.ini b/conf/checksums.ini
index bc214eb..2fc1abb 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -28578,3 +28578,7 @@ sha256=f57c4e33eb2cdd87a6c2f01bfa4794340fbe61ea1a1cfc7dac3b6671e1dd22af
 md5=5f7b88ebb2bcd7e8044328482d079661
 sha256=f57c4e33eb2cdd87a6c2f01bfa4794340fbe61ea1a1cfc7dac3b6671e1dd22af
 
+[http://compcache.googlecode.com/files/compcache-0.6pre3.tar.gz]
+md5=532fbc4e6a8ae0670ec15a49484f313f
+sha256=3e54f26665bd1b7ece4e4621a15f82da66a95bafd04286d447be5a596790a7db
+

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-14 15:05     ` Ming Chow 周明
@ 2009-08-14 15:19       ` Koen Kooi
  2009-08-14 15:33         ` Rolf Leggewie
  2009-08-19 16:32         ` Ming Chow 周明
  0 siblings, 2 replies; 13+ messages in thread
From: Koen Kooi @ 2009-08-14 15:19 UTC (permalink / raw)
  To: openembedded-devel

On 14-08-09 17:05, Ming Chow 周明 wrote:
> Signed-off-by: Zhou Ming <chow.ming@linuxbj.com>
>
> I have renewed the patch looks like:
>
> - added the checksum entry
> - use kernel-module-compcache as the package name which results throwing
> out packages like "kernel-module-compcache_0.6pre3-r41.3_beagleboard.ipk"
> - use compcache-utils as the tool package name which looks like
> "compcache-utils_0.6pre3-r41.3_beagleboard.ipk"

NAK, 0.6pre3 violated the OE versioning policy, you want something like 
0.5+0.6pre3

regards,

Koen




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-14 15:19       ` Koen Kooi
@ 2009-08-14 15:33         ` Rolf Leggewie
  2009-08-19 16:32         ` Ming Chow 周明
  1 sibling, 0 replies; 13+ messages in thread
From: Rolf Leggewie @ 2009-08-14 15:33 UTC (permalink / raw)
  To: openembedded-devel

Koen Kooi wrote:
> NAK, 0.6pre3 violated the OE versioning policy, you want something like 
> 0.5+0.6pre3

and the corresponding wiki page:

http://wiki.openembedded.net/index.php/Versioning_Policy
http://wiki.openembedded.net/index.php/Category:Policy




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-14 15:19       ` Koen Kooi
  2009-08-14 15:33         ` Rolf Leggewie
@ 2009-08-19 16:32         ` Ming Chow 周明
  2009-08-19 16:50           ` Koen Kooi
  1 sibling, 1 reply; 13+ messages in thread
From: Ming Chow 周明 @ 2009-08-19 16:32 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

Hi,

Thanks for your kind information.
I have changed the package version to 0.5+0.6pre3 following the policy 
guideline Rolf showed to me.

Koen Kooi wrote:
> On 14-08-09 17:05, Ming Chow 周明 wrote:
>> Signed-off-by: Zhou Ming <chow.ming@linuxbj.com>
>>
>> I have renewed the patch looks like:
>>
>> - added the checksum entry
>> - use kernel-module-compcache as the package name which results throwing
>> out packages like 
>> "kernel-module-compcache_0.6pre3-r41.3_beagleboard.ipk"
>> - use compcache-utils as the tool package name which looks like
>> "compcache-utils_0.6pre3-r41.3_beagleboard.ipk"
>
> NAK, 0.6pre3 violated the OE versioning policy, you want something 
> like 0.5+0.6pre3
>
> regards,
>
> Koen
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel



[-- Attachment #2: patch-compcache-0.5+0.6pre3.diff --]
[-- Type: text/x-patch, Size: 3564 bytes --]

diff --git a/conf/checksums.ini b/conf/checksums.ini
index bc214eb..2fc1abb 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -28578,3 +28578,7 @@ sha256=f57c4e33eb2cdd87a6c2f01bfa4794340fbe61ea1a1cfc7dac3b6671e1dd22af
 md5=5f7b88ebb2bcd7e8044328482d079661
 sha256=f57c4e33eb2cdd87a6c2f01bfa4794340fbe61ea1a1cfc7dac3b6671e1dd22af
 
+[http://compcache.googlecode.com/files/compcache-0.6pre3.tar.gz]
+md5=532fbc4e6a8ae0670ec15a49484f313f
+sha256=3e54f26665bd1b7ece4e4621a15f82da66a95bafd04286d447be5a596790a7db
+
diff --git a/recipes/compcache/compcache/000-compcache-KERNELDIR.patch b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
new file mode 100644
index 0000000..e80f75b
--- /dev/null
+++ b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
@@ -0,0 +1,34 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 00:25:45.904934007 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 00:25:58.404938574 +0800
+@@ -1,17 +1,17 @@
+ EXTRA_CFLAGS	:=	-DCONFIG_BLK_DEV_RAMZSWAP_STATS \
+ 			-g -Wall
+ 
+-ifndef $(KERNEL_BUILD_PATH)
+-	KERNEL_BUILD_PATH="/lib/modules/$(shell uname -r)/build"
++ifndef $(KERNELDIR)
++	KERNELDIR="/lib/modules/$(shell uname -r)/build"
+ endif
+ 
+ obj-m	+=	sub-projects/allocators/xvmalloc-kmod/xvmalloc.o \
+ 		ramzswap.o
+ 
+ all:
+-	make -C $(KERNEL_BUILD_PATH) \
++	make -C $(KERNELDIR) \
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) modules
++	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+ 	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
+ 
+@@ -19,7 +19,7 @@
+ 	make -C sub-projects/rzscontrol doc
+ 
+ clean:
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) clean
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
++	make -C $(KERNELDIR) M=$(PWD) clean
++	make -C $(KERNELDIR) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
+ 	make -C sub-projects/rzscontrol clean
+ 	@rm -rf *.ko
diff --git a/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
new file mode 100644
index 0000000..8dbb590
--- /dev/null
+++ b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
@@ -0,0 +1,9 @@
+--- compcache-0.6pre3.orig/sub-projects/rzscontrol/Makefile	2009-08-06 23:27:40.000000000 +0800
++++ compcache-0.6pre3/sub-projects/rzscontrol/Makefile	2009-08-14 00:19:38.374938229 +0800
+@@ -1,5 +1,5 @@
+ all:
+-	@gcc -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
++	${CCLD} -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
+ 
+ doc:
+ 	@xmllint --noout --valid man/rzscontrol.xml
diff --git a/recipes/compcache/compcache/002-compcache-modules-install.patch b/recipes/compcache/compcache/002-compcache-modules-install.patch
new file mode 100644
index 0000000..cf9b9b1
--- /dev/null
+++ b/recipes/compcache/compcache/002-compcache-modules-install.patch
@@ -0,0 +1,13 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 02:33:45.169249060 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 02:34:15.594938335 +0800
+@@ -13,7 +13,9 @@
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+ 	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+-	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
++
++modules_install:
++	make -C $(KERNELDIR) M=$(PWD) modules_install
+ 
+ doc:
+ 	make -C sub-projects/rzscontrol doc


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-19 16:32         ` Ming Chow 周明
@ 2009-08-19 16:50           ` Koen Kooi
  2009-08-20  1:36             ` Ming Chow 周明
  0 siblings, 1 reply; 13+ messages in thread
From: Koen Kooi @ 2009-08-19 16:50 UTC (permalink / raw)
  To: openembedded-devel

Please send it in git format-patch format so we can keep all metadata 
when applying it.

regards,

Koen

On 19-08-09 18:32, Ming Chow 周明 wrote:
> Hi,
>
> Thanks for your kind information.
> I have changed the package version to 0.5+0.6pre3 following the policy
> guideline Rolf showed to me.
>
> Koen Kooi wrote:
>> On 14-08-09 17:05, Ming Chow 周明 wrote:
>>> Signed-off-by: Zhou Ming <chow.ming@linuxbj.com>
>>>
>>> I have renewed the patch looks like:
>>>
>>> - added the checksum entry
>>> - use kernel-module-compcache as the package name which results throwing
>>> out packages like
>>> "kernel-module-compcache_0.6pre3-r41.3_beagleboard.ipk"
>>> - use compcache-utils as the tool package name which looks like
>>> "compcache-utils_0.6pre3-r41.3_beagleboard.ipk"
>>
>> NAK, 0.6pre3 violated the OE versioning policy, you want something
>> like 0.5+0.6pre3
>>
>> regards,
>>
>> Koen
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel





^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-19 16:50           ` Koen Kooi
@ 2009-08-20  1:36             ` Ming Chow 周明
  2009-08-20  2:09               ` Holger Hans Peter Freyther
  0 siblings, 1 reply; 13+ messages in thread
From: Ming Chow 周明 @ 2009-08-20  1:36 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1855 bytes --]

Signed-off-by: Zhou Ming <chow.ming@linuxbj.com>

Thank you for your kind advice. 4 commits due to the modifications.

Koen Kooi wrote:
> Please send it in git format-patch format so we can keep all metadata 
> when applying it.
>
> regards,
>
> Koen
>
> On 19-08-09 18:32, Ming Chow 周明 wrote:
>> Hi,
>>
>> Thanks for your kind information.
>> I have changed the package version to 0.5+0.6pre3 following the policy
>> guideline Rolf showed to me.
>>
>> Koen Kooi wrote:
>>> On 14-08-09 17:05, Ming Chow 周明 wrote:
>>>> Signed-off-by: Zhou Ming <chow.ming@linuxbj.com>
>>>>
>>>> I have renewed the patch looks like:
>>>>
>>>> - added the checksum entry
>>>> - use kernel-module-compcache as the package name which results 
>>>> throwing
>>>> out packages like
>>>> "kernel-module-compcache_0.6pre3-r41.3_beagleboard.ipk"
>>>> - use compcache-utils as the tool package name which looks like
>>>> "compcache-utils_0.6pre3-r41.3_beagleboard.ipk"
>>>
>>> NAK, 0.6pre3 violated the OE versioning policy, you want something
>>> like 0.5+0.6pre3
>>>
>>> regards,
>>>
>>> Koen
>>>
>>>
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel


[-- Attachment #2: 0001-added-compcache.patch --]
[-- Type: text/x-patch, Size: 5161 bytes --]

From 84da7c0eed1865914981ed9625fa02e8468ecf9d Mon Sep 17 00:00:00 2001
From: Ming Zhou <chow.ming@linuxbj.com>
Date: Fri, 14 Aug 2009 03:53:41 +0800
Subject: [PATCH] added compcache

---
 .../compcache/000-compcache-KERNELDIR.patch        |   34 ++++++++++++++++++++
 .../001-compcache-rzscontrol-cross-compile.patch   |    9 +++++
 .../compcache/002-compcache-modules-install.patch  |   13 +++++++
 recipes/compcache/compcache_0.6pre3.bb             |   28 ++++++++++++++++
 4 files changed, 84 insertions(+), 0 deletions(-)
 create mode 100644 recipes/compcache/compcache/000-compcache-KERNELDIR.patch
 create mode 100644 recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
 create mode 100644 recipes/compcache/compcache/002-compcache-modules-install.patch
 create mode 100644 recipes/compcache/compcache_0.6pre3.bb

diff --git a/recipes/compcache/compcache/000-compcache-KERNELDIR.patch b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
new file mode 100644
index 0000000..e80f75b
--- /dev/null
+++ b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
@@ -0,0 +1,34 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 00:25:45.904934007 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 00:25:58.404938574 +0800
+@@ -1,17 +1,17 @@
+ EXTRA_CFLAGS	:=	-DCONFIG_BLK_DEV_RAMZSWAP_STATS \
+ 			-g -Wall
+ 
+-ifndef $(KERNEL_BUILD_PATH)
+-	KERNEL_BUILD_PATH="/lib/modules/$(shell uname -r)/build"
++ifndef $(KERNELDIR)
++	KERNELDIR="/lib/modules/$(shell uname -r)/build"
+ endif
+ 
+ obj-m	+=	sub-projects/allocators/xvmalloc-kmod/xvmalloc.o \
+ 		ramzswap.o
+ 
+ all:
+-	make -C $(KERNEL_BUILD_PATH) \
++	make -C $(KERNELDIR) \
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) modules
++	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+ 	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
+ 
+@@ -19,7 +19,7 @@
+ 	make -C sub-projects/rzscontrol doc
+ 
+ clean:
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) clean
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
++	make -C $(KERNELDIR) M=$(PWD) clean
++	make -C $(KERNELDIR) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
+ 	make -C sub-projects/rzscontrol clean
+ 	@rm -rf *.ko
diff --git a/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
new file mode 100644
index 0000000..8dbb590
--- /dev/null
+++ b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
@@ -0,0 +1,9 @@
+--- compcache-0.6pre3.orig/sub-projects/rzscontrol/Makefile	2009-08-06 23:27:40.000000000 +0800
++++ compcache-0.6pre3/sub-projects/rzscontrol/Makefile	2009-08-14 00:19:38.374938229 +0800
+@@ -1,5 +1,5 @@
+ all:
+-	@gcc -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
++	${CCLD} -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
+ 
+ doc:
+ 	@xmllint --noout --valid man/rzscontrol.xml
diff --git a/recipes/compcache/compcache/002-compcache-modules-install.patch b/recipes/compcache/compcache/002-compcache-modules-install.patch
new file mode 100644
index 0000000..cf9b9b1
--- /dev/null
+++ b/recipes/compcache/compcache/002-compcache-modules-install.patch
@@ -0,0 +1,13 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 02:33:45.169249060 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 02:34:15.594938335 +0800
+@@ -13,7 +13,9 @@
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+ 	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+-	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
++
++modules_install:
++	make -C $(KERNELDIR) M=$(PWD) modules_install
+ 
+ doc:
+ 	make -C sub-projects/rzscontrol doc
diff --git a/recipes/compcache/compcache_0.6pre3.bb b/recipes/compcache/compcache_0.6pre3.bb
new file mode 100644
index 0000000..0b59815
--- /dev/null
+++ b/recipes/compcache/compcache_0.6pre3.bb
@@ -0,0 +1,28 @@
+HOMEPAGE = "http://code.google.com/p/compcache"
+DESCRIPTION = "Kernel drivers version 0.6x and related tool for the compcache (compressed in-memory swap device for linux)"
+LICENSE = "GPLv2"
+
+inherit module
+
+SRC_URI = "http://compcache.googlecode.com/files/compcache-${PV}.tar.gz \
+	file://000-compcache-KERNELDIR.patch;patch=1 \
+	file://001-compcache-rzscontrol-cross-compile.patch;patch=1 \
+	file://002-compcache-modules-install.patch;patch=1 \
+	   "
+
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+PACKAGES = "compcache-modules rzscontrol rzscontrol-dbg rzscontrol-doc"
+
+FILES_compcache-modules = ${FILES_compcache}
+FILES_rzscontrol = "${bindir}/rzscontrol"
+FILES_rzscontrol-dbg = "${bindir}/.debug/rzscontrol"
+FILES_rzscontrol-doc = "${mandir}/man1/rzscontrol.1"
+
+do_install_prepend() {
+	mkdir -p ${D}${bindir}
+	mkdir -p ${D}${mandir}/man1
+	install -m 0755 ${S}/sub-projects/rzscontrol/rzscontrol ${D}${bindir}
+	install -m 0644 ${S}/sub-projects/rzscontrol/man/rzscontrol.1 ${D}${mandir}/man1
+}
+
-- 
1.5.4.3


[-- Attachment #3: 0002-modified-compcache-to-make-a-more-meanful-package-na.patch --]
[-- Type: text/x-patch, Size: 1946 bytes --]

From cd6bb9cd23bed6ac2132c4b0e6db026aebd7e884 Mon Sep 17 00:00:00 2001
From: Ming Zhou <chow.ming@linuxbj.com>
Date: Fri, 14 Aug 2009 22:46:13 +0800
Subject: [PATCH] modified compcache to make a more meanful package name

---
 conf/checksums.ini                     |    4 ++++
 recipes/compcache/compcache_0.6pre3.bb |   10 +++++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/conf/checksums.ini b/conf/checksums.ini
index bc214eb..2fc1abb 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -28578,3 +28578,7 @@ sha256=f57c4e33eb2cdd87a6c2f01bfa4794340fbe61ea1a1cfc7dac3b6671e1dd22af
 md5=5f7b88ebb2bcd7e8044328482d079661
 sha256=f57c4e33eb2cdd87a6c2f01bfa4794340fbe61ea1a1cfc7dac3b6671e1dd22af
 
+[http://compcache.googlecode.com/files/compcache-0.6pre3.tar.gz]
+md5=532fbc4e6a8ae0670ec15a49484f313f
+sha256=3e54f26665bd1b7ece4e4621a15f82da66a95bafd04286d447be5a596790a7db
+
diff --git a/recipes/compcache/compcache_0.6pre3.bb b/recipes/compcache/compcache_0.6pre3.bb
index 0b59815..ea8772c 100644
--- a/recipes/compcache/compcache_0.6pre3.bb
+++ b/recipes/compcache/compcache_0.6pre3.bb
@@ -12,12 +12,12 @@ SRC_URI = "http://compcache.googlecode.com/files/compcache-${PV}.tar.gz \
 
 TARGET_CC_ARCH += "${LDFLAGS}"
 
-PACKAGES = "compcache-modules rzscontrol rzscontrol-dbg rzscontrol-doc"
+PACKAGES = "kernel-module-compcache compcache-utils compcache-utils-dbg compcache-utils-doc"
 
-FILES_compcache-modules = ${FILES_compcache}
-FILES_rzscontrol = "${bindir}/rzscontrol"
-FILES_rzscontrol-dbg = "${bindir}/.debug/rzscontrol"
-FILES_rzscontrol-doc = "${mandir}/man1/rzscontrol.1"
+FILES_kernel-module-compcache = ${FILES_compcache}
+FILES_compcache-utils = "${bindir}/rzscontrol"
+FILES_compcache-utils-dbg = "${bindir}/.debug/rzscontrol"
+FILES_compcache-utils-doc = "${mandir}/man1/rzscontrol.1"
 
 do_install_prepend() {
 	mkdir -p ${D}${bindir}
-- 
1.5.4.3


[-- Attachment #4: 0003-modified-compcache_0.6pre3-to-compcache_0.5-0.6pre3.patch --]
[-- Type: text/x-patch, Size: 1771 bytes --]

From 22463fbc29215968710fb47d55001099e98541f6 Mon Sep 17 00:00:00 2001
From: Ming Zhou <chow.ming@linuxbj.com>
Date: Wed, 19 Aug 2009 23:38:59 +0800
Subject: [PATCH] modified compcache_0.6pre3 to compcache_0.5+0.6pre3 and added related corrections

---
 recipes/compcache/compcache_0.6pre3.bb |   28 ----------------------------
 1 files changed, 0 insertions(+), 28 deletions(-)
 delete mode 100644 recipes/compcache/compcache_0.6pre3.bb

diff --git a/recipes/compcache/compcache_0.6pre3.bb b/recipes/compcache/compcache_0.6pre3.bb
deleted file mode 100644
index ea8772c..0000000
--- a/recipes/compcache/compcache_0.6pre3.bb
+++ /dev/null
@@ -1,28 +0,0 @@
-HOMEPAGE = "http://code.google.com/p/compcache"
-DESCRIPTION = "Kernel drivers version 0.6x and related tool for the compcache (compressed in-memory swap device for linux)"
-LICENSE = "GPLv2"
-
-inherit module
-
-SRC_URI = "http://compcache.googlecode.com/files/compcache-${PV}.tar.gz \
-	file://000-compcache-KERNELDIR.patch;patch=1 \
-	file://001-compcache-rzscontrol-cross-compile.patch;patch=1 \
-	file://002-compcache-modules-install.patch;patch=1 \
-	   "
-
-TARGET_CC_ARCH += "${LDFLAGS}"
-
-PACKAGES = "kernel-module-compcache compcache-utils compcache-utils-dbg compcache-utils-doc"
-
-FILES_kernel-module-compcache = ${FILES_compcache}
-FILES_compcache-utils = "${bindir}/rzscontrol"
-FILES_compcache-utils-dbg = "${bindir}/.debug/rzscontrol"
-FILES_compcache-utils-doc = "${mandir}/man1/rzscontrol.1"
-
-do_install_prepend() {
-	mkdir -p ${D}${bindir}
-	mkdir -p ${D}${mandir}/man1
-	install -m 0755 ${S}/sub-projects/rzscontrol/rzscontrol ${D}${bindir}
-	install -m 0644 ${S}/sub-projects/rzscontrol/man/rzscontrol.1 ${D}${mandir}/man1
-}
-
-- 
1.5.4.3


[-- Attachment #5: 0004-fixed-compcache-source-directory.patch --]
[-- Type: text/x-patch, Size: 1769 bytes --]

From fc97de55643a0c2aab0645e56137fb0854c9a58b Mon Sep 17 00:00:00 2001
From: Ming Zhou <chow.ming@linuxbj.com>
Date: Thu, 20 Aug 2009 09:31:49 +0800
Subject: [PATCH] fixed compcache source directory

---
 recipes/compcache/compcache_0.5+0.6pre3.bb |   29 ++++++++++++++++++++++++++++
 1 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 recipes/compcache/compcache_0.5+0.6pre3.bb

diff --git a/recipes/compcache/compcache_0.5+0.6pre3.bb b/recipes/compcache/compcache_0.5+0.6pre3.bb
new file mode 100644
index 0000000..7cd2997
--- /dev/null
+++ b/recipes/compcache/compcache_0.5+0.6pre3.bb
@@ -0,0 +1,29 @@
+HOMEPAGE = "http://code.google.com/p/compcache"
+DESCRIPTION = "Kernel drivers version 0.6x and related tool for the compcache (compressed in-memory swap device for linux)"
+LICENSE = "GPLv2"
+
+inherit module
+
+SRC_URI = "http://compcache.googlecode.com/files/${PN}-0.6pre3.tar.gz \
+	file://000-compcache-KERNELDIR.patch;patch=1 \
+	file://001-compcache-rzscontrol-cross-compile.patch;patch=1 \
+	file://002-compcache-modules-install.patch;patch=1 \
+	   "
+S = "${WORKDIR}/${PN}-0.6pre3"
+
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+PACKAGES = "kernel-module-compcache compcache-utils compcache-utils-dbg compcache-utils-doc"
+
+FILES_kernel-module-compcache = ${FILES_compcache}
+FILES_compcache-utils = "${bindir}/rzscontrol"
+FILES_compcache-utils-dbg = "${bindir}/.debug/rzscontrol"
+FILES_compcache-utils-doc = "${mandir}/man1/rzscontrol.1"
+
+do_install_prepend() {
+	mkdir -p ${D}${bindir}
+	mkdir -p ${D}${mandir}/man1
+	install -m 0755 ${S}/sub-projects/rzscontrol/rzscontrol ${D}${bindir}
+	install -m 0644 ${S}/sub-projects/rzscontrol/man/rzscontrol.1 ${D}${mandir}/man1
+}
+
-- 
1.5.4.3


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-20  1:36             ` Ming Chow 周明
@ 2009-08-20  2:09               ` Holger Hans Peter Freyther
  2009-08-20 17:20                 ` Ming Chow 周明
  0 siblings, 1 reply; 13+ messages in thread
From: Holger Hans Peter Freyther @ 2009-08-20  2:09 UTC (permalink / raw)
  To: openembedded-devel

On Thursday 20 August 2009 03:36:51 Ming Chow 周明 wrote:
> Signed-off-by: Zhou Ming <chow.ming@linuxbj.com>
>
> Thank you for your kind advice. 4 commits due to the modifications.

Great! Our wishes might sound a bit weird... quite you squash them in one 
commit with one good commit message and add a Signed-off-by to the end of the 
commit?

The reason is that patchwork does not like more than one patch in a mail, and 
I love to use git-am to apply your patch and having one patch is more efficient 
for me.

thanks a lot
	z.




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: patch for compcache recipe
  2009-08-20  2:09               ` Holger Hans Peter Freyther
@ 2009-08-20 17:20                 ` Ming Chow 周明
  0 siblings, 0 replies; 13+ messages in thread
From: Ming Chow 周明 @ 2009-08-20 17:20 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

Hi,

I reproduced the patch with '-s --stdout' options. Wish it helps.

Holger Hans Peter Freyther wrote:
> On Thursday 20 August 2009 03:36:51 Ming Chow 周明 wrote:
>   
>> Signed-off-by: Zhou Ming <chow.ming@linuxbj.com>
>>
>> Thank you for your kind advice. 4 commits due to the modifications.
>>     
>
> Great! Our wishes might sound a bit weird... quite you squash them in one 
> commit with one good commit message and add a Signed-off-by to the end of the 
> commit?
>
> The reason is that patchwork does not like more than one patch in a mail, and 
> I love to use git-am to apply your patch and having one patch is more efficient 
> for me.
>
> thanks a lot
> 	z.
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>   


[-- Attachment #2: all-in-one-compcache-0.5+0.6pre3.patch --]
[-- Type: text/x-patch, Size: 10861 bytes --]

From 84da7c0eed1865914981ed9625fa02e8468ecf9d Mon Sep 17 00:00:00 2001
From: Ming Zhou <chow.ming@linuxbj.com>
Date: Fri, 14 Aug 2009 03:53:41 +0800
Subject: [PATCH] added compcache


Signed-off-by: Ming Zhou <chow.ming@linuxbj.com>
---
 .../compcache/000-compcache-KERNELDIR.patch        |   34 ++++++++++++++++++++
 .../001-compcache-rzscontrol-cross-compile.patch   |    9 +++++
 .../compcache/002-compcache-modules-install.patch  |   13 +++++++
 recipes/compcache/compcache_0.6pre3.bb             |   28 ++++++++++++++++
 4 files changed, 84 insertions(+), 0 deletions(-)
 create mode 100644 recipes/compcache/compcache/000-compcache-KERNELDIR.patch
 create mode 100644 recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
 create mode 100644 recipes/compcache/compcache/002-compcache-modules-install.patch
 create mode 100644 recipes/compcache/compcache_0.6pre3.bb

diff --git a/recipes/compcache/compcache/000-compcache-KERNELDIR.patch b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
new file mode 100644
index 0000000..e80f75b
--- /dev/null
+++ b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
@@ -0,0 +1,34 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 00:25:45.904934007 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 00:25:58.404938574 +0800
+@@ -1,17 +1,17 @@
+ EXTRA_CFLAGS	:=	-DCONFIG_BLK_DEV_RAMZSWAP_STATS \
+ 			-g -Wall
+ 
+-ifndef $(KERNEL_BUILD_PATH)
+-	KERNEL_BUILD_PATH="/lib/modules/$(shell uname -r)/build"
++ifndef $(KERNELDIR)
++	KERNELDIR="/lib/modules/$(shell uname -r)/build"
+ endif
+ 
+ obj-m	+=	sub-projects/allocators/xvmalloc-kmod/xvmalloc.o \
+ 		ramzswap.o
+ 
+ all:
+-	make -C $(KERNEL_BUILD_PATH) \
++	make -C $(KERNELDIR) \
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) modules
++	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+ 	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
+ 
+@@ -19,7 +19,7 @@
+ 	make -C sub-projects/rzscontrol doc
+ 
+ clean:
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) clean
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
++	make -C $(KERNELDIR) M=$(PWD) clean
++	make -C $(KERNELDIR) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
+ 	make -C sub-projects/rzscontrol clean
+ 	@rm -rf *.ko
diff --git a/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
new file mode 100644
index 0000000..8dbb590
--- /dev/null
+++ b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
@@ -0,0 +1,9 @@
+--- compcache-0.6pre3.orig/sub-projects/rzscontrol/Makefile	2009-08-06 23:27:40.000000000 +0800
++++ compcache-0.6pre3/sub-projects/rzscontrol/Makefile	2009-08-14 00:19:38.374938229 +0800
+@@ -1,5 +1,5 @@
+ all:
+-	@gcc -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
++	${CCLD} -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
+ 
+ doc:
+ 	@xmllint --noout --valid man/rzscontrol.xml
diff --git a/recipes/compcache/compcache/002-compcache-modules-install.patch b/recipes/compcache/compcache/002-compcache-modules-install.patch
new file mode 100644
index 0000000..cf9b9b1
--- /dev/null
+++ b/recipes/compcache/compcache/002-compcache-modules-install.patch
@@ -0,0 +1,13 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 02:33:45.169249060 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 02:34:15.594938335 +0800
+@@ -13,7 +13,9 @@
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+ 	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+-	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
++
++modules_install:
++	make -C $(KERNELDIR) M=$(PWD) modules_install
+ 
+ doc:
+ 	make -C sub-projects/rzscontrol doc
diff --git a/recipes/compcache/compcache_0.6pre3.bb b/recipes/compcache/compcache_0.6pre3.bb
new file mode 100644
index 0000000..0b59815
--- /dev/null
+++ b/recipes/compcache/compcache_0.6pre3.bb
@@ -0,0 +1,28 @@
+HOMEPAGE = "http://code.google.com/p/compcache"
+DESCRIPTION = "Kernel drivers version 0.6x and related tool for the compcache (compressed in-memory swap device for linux)"
+LICENSE = "GPLv2"
+
+inherit module
+
+SRC_URI = "http://compcache.googlecode.com/files/compcache-${PV}.tar.gz \
+	file://000-compcache-KERNELDIR.patch;patch=1 \
+	file://001-compcache-rzscontrol-cross-compile.patch;patch=1 \
+	file://002-compcache-modules-install.patch;patch=1 \
+	   "
+
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+PACKAGES = "compcache-modules rzscontrol rzscontrol-dbg rzscontrol-doc"
+
+FILES_compcache-modules = ${FILES_compcache}
+FILES_rzscontrol = "${bindir}/rzscontrol"
+FILES_rzscontrol-dbg = "${bindir}/.debug/rzscontrol"
+FILES_rzscontrol-doc = "${mandir}/man1/rzscontrol.1"
+
+do_install_prepend() {
+	mkdir -p ${D}${bindir}
+	mkdir -p ${D}${mandir}/man1
+	install -m 0755 ${S}/sub-projects/rzscontrol/rzscontrol ${D}${bindir}
+	install -m 0644 ${S}/sub-projects/rzscontrol/man/rzscontrol.1 ${D}${mandir}/man1
+}
+
-- 
1.5.4.3


From cd6bb9cd23bed6ac2132c4b0e6db026aebd7e884 Mon Sep 17 00:00:00 2001
From: Ming Zhou <chow.ming@linuxbj.com>
Date: Fri, 14 Aug 2009 22:46:13 +0800
Subject: [PATCH] modified compcache to make a more meanful package name


Signed-off-by: Ming Zhou <chow.ming@linuxbj.com>
---
 conf/checksums.ini                     |    4 ++++
 recipes/compcache/compcache_0.6pre3.bb |   10 +++++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/conf/checksums.ini b/conf/checksums.ini
index bc214eb..2fc1abb 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -28578,3 +28578,7 @@ sha256=f57c4e33eb2cdd87a6c2f01bfa4794340fbe61ea1a1cfc7dac3b6671e1dd22af
 md5=5f7b88ebb2bcd7e8044328482d079661
 sha256=f57c4e33eb2cdd87a6c2f01bfa4794340fbe61ea1a1cfc7dac3b6671e1dd22af
 
+[http://compcache.googlecode.com/files/compcache-0.6pre3.tar.gz]
+md5=532fbc4e6a8ae0670ec15a49484f313f
+sha256=3e54f26665bd1b7ece4e4621a15f82da66a95bafd04286d447be5a596790a7db
+
diff --git a/recipes/compcache/compcache_0.6pre3.bb b/recipes/compcache/compcache_0.6pre3.bb
index 0b59815..ea8772c 100644
--- a/recipes/compcache/compcache_0.6pre3.bb
+++ b/recipes/compcache/compcache_0.6pre3.bb
@@ -12,12 +12,12 @@ SRC_URI = "http://compcache.googlecode.com/files/compcache-${PV}.tar.gz \
 
 TARGET_CC_ARCH += "${LDFLAGS}"
 
-PACKAGES = "compcache-modules rzscontrol rzscontrol-dbg rzscontrol-doc"
+PACKAGES = "kernel-module-compcache compcache-utils compcache-utils-dbg compcache-utils-doc"
 
-FILES_compcache-modules = ${FILES_compcache}
-FILES_rzscontrol = "${bindir}/rzscontrol"
-FILES_rzscontrol-dbg = "${bindir}/.debug/rzscontrol"
-FILES_rzscontrol-doc = "${mandir}/man1/rzscontrol.1"
+FILES_kernel-module-compcache = ${FILES_compcache}
+FILES_compcache-utils = "${bindir}/rzscontrol"
+FILES_compcache-utils-dbg = "${bindir}/.debug/rzscontrol"
+FILES_compcache-utils-doc = "${mandir}/man1/rzscontrol.1"
 
 do_install_prepend() {
 	mkdir -p ${D}${bindir}
-- 
1.5.4.3


From 22463fbc29215968710fb47d55001099e98541f6 Mon Sep 17 00:00:00 2001
From: Ming Zhou <chow.ming@linuxbj.com>
Date: Wed, 19 Aug 2009 23:38:59 +0800
Subject: [PATCH] modified compcache_0.6pre3 to compcache_0.5+0.6pre3 and added related corrections


Signed-off-by: Ming Zhou <chow.ming@linuxbj.com>
---
 recipes/compcache/compcache_0.6pre3.bb |   28 ----------------------------
 1 files changed, 0 insertions(+), 28 deletions(-)
 delete mode 100644 recipes/compcache/compcache_0.6pre3.bb

diff --git a/recipes/compcache/compcache_0.6pre3.bb b/recipes/compcache/compcache_0.6pre3.bb
deleted file mode 100644
index ea8772c..0000000
--- a/recipes/compcache/compcache_0.6pre3.bb
+++ /dev/null
@@ -1,28 +0,0 @@
-HOMEPAGE = "http://code.google.com/p/compcache"
-DESCRIPTION = "Kernel drivers version 0.6x and related tool for the compcache (compressed in-memory swap device for linux)"
-LICENSE = "GPLv2"
-
-inherit module
-
-SRC_URI = "http://compcache.googlecode.com/files/compcache-${PV}.tar.gz \
-	file://000-compcache-KERNELDIR.patch;patch=1 \
-	file://001-compcache-rzscontrol-cross-compile.patch;patch=1 \
-	file://002-compcache-modules-install.patch;patch=1 \
-	   "
-
-TARGET_CC_ARCH += "${LDFLAGS}"
-
-PACKAGES = "kernel-module-compcache compcache-utils compcache-utils-dbg compcache-utils-doc"
-
-FILES_kernel-module-compcache = ${FILES_compcache}
-FILES_compcache-utils = "${bindir}/rzscontrol"
-FILES_compcache-utils-dbg = "${bindir}/.debug/rzscontrol"
-FILES_compcache-utils-doc = "${mandir}/man1/rzscontrol.1"
-
-do_install_prepend() {
-	mkdir -p ${D}${bindir}
-	mkdir -p ${D}${mandir}/man1
-	install -m 0755 ${S}/sub-projects/rzscontrol/rzscontrol ${D}${bindir}
-	install -m 0644 ${S}/sub-projects/rzscontrol/man/rzscontrol.1 ${D}${mandir}/man1
-}
-
-- 
1.5.4.3


From fc97de55643a0c2aab0645e56137fb0854c9a58b Mon Sep 17 00:00:00 2001
From: Ming Zhou <chow.ming@linuxbj.com>
Date: Thu, 20 Aug 2009 09:31:49 +0800
Subject: [PATCH] fixed compcache source directory


Signed-off-by: Ming Zhou <chow.ming@linuxbj.com>
---
 recipes/compcache/compcache_0.5+0.6pre3.bb |   29 ++++++++++++++++++++++++++++
 1 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 recipes/compcache/compcache_0.5+0.6pre3.bb

diff --git a/recipes/compcache/compcache_0.5+0.6pre3.bb b/recipes/compcache/compcache_0.5+0.6pre3.bb
new file mode 100644
index 0000000..7cd2997
--- /dev/null
+++ b/recipes/compcache/compcache_0.5+0.6pre3.bb
@@ -0,0 +1,29 @@
+HOMEPAGE = "http://code.google.com/p/compcache"
+DESCRIPTION = "Kernel drivers version 0.6x and related tool for the compcache (compressed in-memory swap device for linux)"
+LICENSE = "GPLv2"
+
+inherit module
+
+SRC_URI = "http://compcache.googlecode.com/files/${PN}-0.6pre3.tar.gz \
+	file://000-compcache-KERNELDIR.patch;patch=1 \
+	file://001-compcache-rzscontrol-cross-compile.patch;patch=1 \
+	file://002-compcache-modules-install.patch;patch=1 \
+	   "
+S = "${WORKDIR}/${PN}-0.6pre3"
+
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+PACKAGES = "kernel-module-compcache compcache-utils compcache-utils-dbg compcache-utils-doc"
+
+FILES_kernel-module-compcache = ${FILES_compcache}
+FILES_compcache-utils = "${bindir}/rzscontrol"
+FILES_compcache-utils-dbg = "${bindir}/.debug/rzscontrol"
+FILES_compcache-utils-doc = "${mandir}/man1/rzscontrol.1"
+
+do_install_prepend() {
+	mkdir -p ${D}${bindir}
+	mkdir -p ${D}${mandir}/man1
+	install -m 0755 ${S}/sub-projects/rzscontrol/rzscontrol ${D}${bindir}
+	install -m 0644 ${S}/sub-projects/rzscontrol/man/rzscontrol.1 ${D}${mandir}/man1
+}
+
-- 
1.5.4.3


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2009-08-20 17:38 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-13 19:10 patch for compcache recipe Ming Chow 周明
2009-08-14  2:06 ` Holger Hans Peter Freyther
2009-08-14  6:29   ` Ming Chow 周明
2009-08-14 14:39     ` Rolf Leggewie
2009-08-14 14:55       ` Ming Chow 周明
2009-08-14 15:05     ` Ming Chow 周明
2009-08-14 15:19       ` Koen Kooi
2009-08-14 15:33         ` Rolf Leggewie
2009-08-19 16:32         ` Ming Chow 周明
2009-08-19 16:50           ` Koen Kooi
2009-08-20  1:36             ` Ming Chow 周明
2009-08-20  2:09               ` Holger Hans Peter Freyther
2009-08-20 17:20                 ` Ming Chow 周明

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.