All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>,
	qemu-devel@nongnu.org, Carsten Otte <cotte@de.ibm.com>,
	kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
	virtualization@lists.linux-foundation.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: pci: is reset incomplete?
Date: Mon, 14 Sep 2009 12:15:29 -0500	[thread overview]
Message-ID: <4AAE7A31.9080600@codemonkey.ws> (raw)
In-Reply-To: <20090914154822.GA3745@redhat.com>

Michael S. Tsirkin wrote:
> Hi!
> pci bus reset does not seem to clear pci config registers, such as BAR
> registers, or memory space enable, of the attached devices: it only
> clears the interrupt state.
>
> This seems wrong, but easy to fix.
>   

I don't think most pci devices reset their config space in their reset 
callbacks.

I would think that making most of the config space (if not the entire) 
qdev properties would make sense.  You can then get reset for free and 
it's possible for users to tweak things like class codes universally.

Regards,

Anthony Liguori

> Comments?
>
>   


WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Carsten Otte <cotte@de.ibm.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
	qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: pci: is reset incomplete?
Date: Mon, 14 Sep 2009 12:15:29 -0500	[thread overview]
Message-ID: <4AAE7A31.9080600@codemonkey.ws> (raw)
In-Reply-To: <20090914154822.GA3745@redhat.com>

Michael S. Tsirkin wrote:
> Hi!
> pci bus reset does not seem to clear pci config registers, such as BAR
> registers, or memory space enable, of the attached devices: it only
> clears the interrupt state.
>
> This seems wrong, but easy to fix.
>   

I don't think most pci devices reset their config space in their reset 
callbacks.

I would think that making most of the config space (if not the entire) 
qdev properties would make sense.  You can then get reset for free and 
it's possible for users to tweak things like class codes universally.

Regards,

Anthony Liguori

> Comments?
>
>   

  reply	other threads:[~2009-09-14 17:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14 15:48 pci: is reset incomplete? Michael S. Tsirkin
2009-09-14 15:48 ` [Qemu-devel] " Michael S. Tsirkin
2009-09-14 17:15 ` Anthony Liguori [this message]
2009-09-14 17:15   ` [Qemu-devel] " Anthony Liguori
2009-09-14 17:36   ` Michael S. Tsirkin
2009-09-14 17:36   ` Michael S. Tsirkin
2009-09-14 17:36     ` [Qemu-devel] " Michael S. Tsirkin
2009-09-14 22:54     ` Anthony Liguori
2009-09-14 22:54       ` [Qemu-devel] " Anthony Liguori
2009-09-14 22:54     ` Anthony Liguori
2009-09-14 17:15 ` Anthony Liguori
  -- strict thread matches above, loose matches on Subject: below --
2009-09-14 15:48 Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AAE7A31.9080600@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cotte@de.ibm.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.