gettext order

gettext order

[Carles Pina i Estany]

Hello,

Tomorrow Monday I will probably gettextize the help of the all
grub_register_command.

Is it all right?

In general, I would translate mainly all grub_printf that has user
messages. I will do it in a different patch set than the
grub_register_command.

From the utilities, something that would be good to priorize?

-- 
Carles Pina i Estany
	http://pinux.info

Re: gettext order

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

Carles Pina i Estany wrote:
> Hello,
>
> Tomorrow Monday I will probably gettextize the help of the all
> grub_register_command.
>
> Is it all right?
>
> In general, I would translate mainly all grub_printf that has user
> messages. I will do it in a different patch set than the
> grub_register_command.
>
>   
If you see a good spot where all messages should be translated avoid
adding _ to it. Function calls are expensive. Rather than that add
gettext call in callee and register a new gettext keyword for .pot
generation.
> >From the utilities, something that would be good to priorize?
>
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]

Re: gettext order

[Robert Millan]

On Mon, Nov 23, 2009 at 01:18:18AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Carles Pina i Estany wrote:
> > Hello,
> >
> > Tomorrow Monday I will probably gettextize the help of the all
> > grub_register_command.
> >
> > Is it all right?
> >
> > In general, I would translate mainly all grub_printf that has user
> > messages. I will do it in a different patch set than the
> > grub_register_command.
> >
> >   
> If you see a good spot where all messages should be translated avoid
> adding _ to it. Function calls are expensive.

Uhm I agree, but I'm not sure if grub_register_command() would be such
spot.  Are we sure we want to translate _all_ of its messages?

--
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

Re: gettext order

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

Robert Millan wrote:
> On Mon, Nov 23, 2009 at 01:18:18AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>   
>> Carles Pina i Estany wrote:
>>     
>>> Hello,
>>>
>>> Tomorrow Monday I will probably gettextize the help of the all
>>> grub_register_command.
>>>
>>> Is it all right?
>>>
>>> In general, I would translate mainly all grub_printf that has user
>>> messages. I will do it in a different patch set than the
>>> grub_register_command.
>>>
>>>   
>>>       
>> If you see a good spot where all messages should be translated avoid
>> adding _ to it. Function calls are expensive.
>>     
>
> Uhm I agree, but I'm not sure if grub_register_command() would be such
> spot.  Are we sure we want to translate _all_ of its messages?
>
>   
We don't have to translate all of arguments. All depends on how we
declare gettext keywords
> --
> Robert Millan
>
>   The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>   how) you may access your data; but nobody's threatening your freedom: we
>   still allow you to remove your data and not access it at all."
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]

Re: gettext order

[Robert Millan]

On Mon, Nov 23, 2009 at 12:15:18AM +0000, Carles Pina i Estany wrote:
> >From the utilities, something that would be good to priorize?

I think that, barring the obvious strings we'd like to translate (which
you already spotted), utilities should be the top priority.  The other
non-util strings need to be considered carefully, there's no hurry about
them.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."