* [Patch 1/1] CLD: forgot FD_ZERO in test/large-object.c
@ 2009-12-03 1:53 Pete Zaitcev
2009-12-03 7:24 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Pete Zaitcev @ 2009-12-03 1:53 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Project Hail List
Signed-Off-By: Pete Zaitcev <zaitcev@redhat.com>
---
test/large-object.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/test/large-object.c b/test/large-object.c
index f0884b8..fbed9b7 100644
--- a/test/large-object.c
+++ b/test/large-object.c
@@ -28,6 +28,7 @@ static bool send_buf(struct st_client *stc, int sfd, void *buf, size_t buf_len)
while (buf_len) {
FD_ZERO(&wset);
FD_SET(sfd, &wset);
+ FD_ZERO(&rset);
FD_SET(sfd, &rset);
rc = select(sfd + 1, &rset, &wset, NULL, NULL);
OK(rc >= 0);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch 1/1] CLD: forgot FD_ZERO in test/large-object.c
2009-12-03 1:53 [Patch 1/1] CLD: forgot FD_ZERO in test/large-object.c Pete Zaitcev
@ 2009-12-03 7:24 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2009-12-03 7:24 UTC (permalink / raw)
To: Pete Zaitcev; +Cc: Project Hail List
On 12/02/2009 08:53 PM, Pete Zaitcev wrote:
> Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com>
> ---
> test/large-object.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/large-object.c b/test/large-object.c
> index f0884b8..fbed9b7 100644
> --- a/test/large-object.c
> +++ b/test/large-object.c
> @@ -28,6 +28,7 @@ static bool send_buf(struct st_client *stc, int sfd, void *buf, size_t buf_len)
> while (buf_len) {
> FD_ZERO(&wset);
> FD_SET(sfd,&wset);
> + FD_ZERO(&rset);
> FD_SET(sfd,&rset);
> rc = select(sfd + 1,&rset,&wset, NULL, NULL);
> OK(rc>= 0);
applied to chunkd ($subject indicated cld)
This is one of the many reasons why I prefer poll(2). One record per
poll entry, which is quite convenient for small numbers of fd's.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-03 7:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-03 1:53 [Patch 1/1] CLD: forgot FD_ZERO in test/large-object.c Pete Zaitcev
2009-12-03 7:24 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.