[Qemu-devel] Re: [PATCH V10 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c

[Qemu-devel] Re: [PATCH V10 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c

[Gerd Hoffmann]

> +void pc_smbus_init(PCSMBus *smb)
> +{
> +    smb->smbus = i2c_init_bus(NULL, "i2c");
> +}

This function should take a additional "DeviceState *parent" argument 
and pass it down to i2c_init_bus() instead of NULL.  Patch #21 
(acpi_piix4: qdevfy) should pass the piix4-pm DeviceState to 
pc_smbus_init().  Then the smbus and all connected devices should be 
correctly hooked up in the device tree and visible in 'info qtree'.

cheers,
   Gerd

[Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback.

[Gerd Hoffmann]

On 12/24/09 09:09, Isaku Yamahata wrote:
> The argument will be used later to remove global variable.

> -static int piix4_device_hotplug(PCIDevice *dev, int state);
> +static int piix4_device_hotplug(void *opaque, PCIDevice *dev, int state);

You are using that to pass the piix4-pm device state.  How about using 
"DeviceState*" instead of "void*" then?

cheers,
   Gerd

[Qemu-devel] Re: [PATCH V10 00/27] split out piix specific part from pc emulator and some clean ups

[Gerd Hoffmann]

On 12/24/09 09:08, Isaku Yamahata wrote:
> Anthony. Can you please merge those patches as Gerd has agreed
> with the direction of this patch series.
> Gerd, can you provide acked-by or reviewed-by for patches
> you like?

Whole series looks pretty good to me, except for two minor nits (see 
replies to individual patches).

cheers,
   Gerd

[Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback.

[Isaku Yamahata]

On Mon, Jan 04, 2010 at 03:56:50PM +0100, Gerd Hoffmann wrote:
> On 12/24/09 09:09, Isaku Yamahata wrote:
>> The argument will be used later to remove global variable.
>
>> -static int piix4_device_hotplug(PCIDevice *dev, int state);
>> +static int piix4_device_hotplug(void *opaque, PCIDevice *dev, int state);
>
> You are using that to pass the piix4-pm device state.  How about using  
> "DeviceState*" instead of "void*" then?

Ok. I'll use DeviceState*.

-- 
yamahata