* [Qemu-devel] Re: [PATCH V10 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c [not found] ` <1261642160-22754-2-git-send-email-yamahata@valinux.co.jp> @ 2010-01-04 14:52 ` Gerd Hoffmann 0 siblings, 0 replies; 4+ messages in thread From: Gerd Hoffmann @ 2010-01-04 14:52 UTC (permalink / raw) To: Isaku Yamahata; +Cc: qemu-devel > +void pc_smbus_init(PCSMBus *smb) > +{ > + smb->smbus = i2c_init_bus(NULL, "i2c"); > +} This function should take a additional "DeviceState *parent" argument and pass it down to i2c_init_bus() instead of NULL. Patch #21 (acpi_piix4: qdevfy) should pass the piix4-pm DeviceState to pc_smbus_init(). Then the smbus and all connected devices should be correctly hooked up in the device tree and visible in 'info qtree'. cheers, Gerd ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1261642160-22754-23-git-send-email-yamahata@valinux.co.jp>]
* [Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback. [not found] ` <1261642160-22754-23-git-send-email-yamahata@valinux.co.jp> @ 2010-01-04 14:56 ` Gerd Hoffmann 2010-01-05 5:34 ` Isaku Yamahata 0 siblings, 1 reply; 4+ messages in thread From: Gerd Hoffmann @ 2010-01-04 14:56 UTC (permalink / raw) To: Isaku Yamahata; +Cc: qemu-devel On 12/24/09 09:09, Isaku Yamahata wrote: > The argument will be used later to remove global variable. > -static int piix4_device_hotplug(PCIDevice *dev, int state); > +static int piix4_device_hotplug(void *opaque, PCIDevice *dev, int state); You are using that to pass the piix4-pm device state. How about using "DeviceState*" instead of "void*" then? cheers, Gerd ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback. 2010-01-04 14:56 ` [Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback Gerd Hoffmann @ 2010-01-05 5:34 ` Isaku Yamahata 0 siblings, 0 replies; 4+ messages in thread From: Isaku Yamahata @ 2010-01-05 5:34 UTC (permalink / raw) To: Gerd Hoffmann; +Cc: qemu-devel On Mon, Jan 04, 2010 at 03:56:50PM +0100, Gerd Hoffmann wrote: > On 12/24/09 09:09, Isaku Yamahata wrote: >> The argument will be used later to remove global variable. > >> -static int piix4_device_hotplug(PCIDevice *dev, int state); >> +static int piix4_device_hotplug(void *opaque, PCIDevice *dev, int state); > > You are using that to pass the piix4-pm device state. How about using > "DeviceState*" instead of "void*" then? Ok. I'll use DeviceState*. -- yamahata ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] Re: [PATCH V10 00/27] split out piix specific part from pc emulator and some clean ups [not found] <1261642160-22754-1-git-send-email-yamahata@valinux.co.jp> [not found] ` <1261642160-22754-2-git-send-email-yamahata@valinux.co.jp> [not found] ` <1261642160-22754-23-git-send-email-yamahata@valinux.co.jp> @ 2010-01-04 14:59 ` Gerd Hoffmann 2 siblings, 0 replies; 4+ messages in thread From: Gerd Hoffmann @ 2010-01-04 14:59 UTC (permalink / raw) To: Isaku Yamahata; +Cc: qemu-devel On 12/24/09 09:08, Isaku Yamahata wrote: > Anthony. Can you please merge those patches as Gerd has agreed > with the direction of this patch series. > Gerd, can you provide acked-by or reviewed-by for patches > you like? Whole series looks pretty good to me, except for two minor nits (see replies to individual patches). cheers, Gerd ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-05 19:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1261642160-22754-1-git-send-email-yamahata@valinux.co.jp>
[not found] ` <1261642160-22754-2-git-send-email-yamahata@valinux.co.jp>
2010-01-04 14:52 ` [Qemu-devel] Re: [PATCH V10 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c Gerd Hoffmann
[not found] ` <1261642160-22754-23-git-send-email-yamahata@valinux.co.jp>
2010-01-04 14:56 ` [Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback Gerd Hoffmann
2010-01-05 5:34 ` Isaku Yamahata
2010-01-04 14:59 ` [Qemu-devel] Re: [PATCH V10 00/27] split out piix specific part from pc emulator and some clean ups Gerd Hoffmann
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.