From: Alexander Graf <agraf@suse.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Avi Kivity <avi@redhat.com>,
OHMURA Kei <ohmura.kei@lab.ntt.co.jp>,
mtosatti@redhat.com,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling
Date: Wed, 10 Feb 2010 17:00:56 +0100 [thread overview]
Message-ID: <4B72D838.9060603@suse.de> (raw)
In-Reply-To: <4B72D69D.7050005@codemonkey.ws>
Anthony Liguori wrote:
> On 02/10/2010 07:20 AM, Avi Kivity wrote:
>
>> On 02/10/2010 12:52 PM, OHMURA Kei wrote:
>>
>>
>>> dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c.
>>> But We think that dirty-bitmap-traveling by long size is faster than by byte
>>> size especially when most of memory is not dirty.
>>>
>>> --- a/bswap.h
>>> +++ b/bswap.h
>>> @@ -209,7 +209,6 @@ static inline void cpu_to_be32wu(uint32_t *p, uint32_t v)
>>> #define cpu_to_32wu cpu_to_le32wu
>>> #endif
>>>
>>> -#undef le_bswap
>>> #undef be_bswap
>>> #undef le_bswaps
>>>
>>>
>>>
>> Anthony, is it okay to export le_bswap this way, or will you want
>> leul_to_cpu()?
>>
>>
>
> kvm_get_dirty_pages_log_range() is kvm-specific code. We're guaranteed
> that when we're using kvm, target byte order == host byte order.
>
> So is it really necessary to use a byte swapping function at all?
>
On PPC the bitmap is Little Endian.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
mtosatti@redhat.com, OHMURA Kei <ohmura.kei@lab.ntt.co.jp>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling
Date: Wed, 10 Feb 2010 17:00:56 +0100 [thread overview]
Message-ID: <4B72D838.9060603@suse.de> (raw)
In-Reply-To: <4B72D69D.7050005@codemonkey.ws>
Anthony Liguori wrote:
> On 02/10/2010 07:20 AM, Avi Kivity wrote:
>
>> On 02/10/2010 12:52 PM, OHMURA Kei wrote:
>>
>>
>>> dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c.
>>> But We think that dirty-bitmap-traveling by long size is faster than by byte
>>> size especially when most of memory is not dirty.
>>>
>>> --- a/bswap.h
>>> +++ b/bswap.h
>>> @@ -209,7 +209,6 @@ static inline void cpu_to_be32wu(uint32_t *p, uint32_t v)
>>> #define cpu_to_32wu cpu_to_le32wu
>>> #endif
>>>
>>> -#undef le_bswap
>>> #undef be_bswap
>>> #undef le_bswaps
>>>
>>>
>>>
>> Anthony, is it okay to export le_bswap this way, or will you want
>> leul_to_cpu()?
>>
>>
>
> kvm_get_dirty_pages_log_range() is kvm-specific code. We're guaranteed
> that when we're using kvm, target byte order == host byte order.
>
> So is it really necessary to use a byte swapping function at all?
>
On PPC the bitmap is Little Endian.
Alex
next prev parent reply other threads:[~2010-02-10 16:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 10:52 [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling OHMURA Kei
2010-02-10 10:52 ` [Qemu-devel] " OHMURA Kei
2010-02-10 13:10 ` Ulrich Drepper
2010-02-10 13:10 ` [Qemu-devel] " Ulrich Drepper
2010-02-10 13:20 ` Avi Kivity
2010-02-10 13:20 ` [Qemu-devel] " Avi Kivity
2010-02-10 15:54 ` Anthony Liguori
2010-02-10 15:54 ` [Qemu-devel] " Anthony Liguori
2010-02-10 15:57 ` Avi Kivity
2010-02-10 15:57 ` [Qemu-devel] " Avi Kivity
2010-02-10 16:00 ` Alexander Graf [this message]
2010-02-10 16:00 ` Alexander Graf
2010-02-10 16:35 ` Anthony Liguori
2010-02-10 16:35 ` Anthony Liguori
2010-02-10 16:43 ` Alexander Graf
2010-02-10 16:43 ` Alexander Graf
2010-02-10 16:46 ` Avi Kivity
2010-02-10 16:46 ` Avi Kivity
2010-02-10 16:47 ` Alexander Graf
2010-02-10 16:47 ` Alexander Graf
2010-02-10 16:52 ` Avi Kivity
2010-02-10 16:52 ` Avi Kivity
2010-02-10 16:54 ` Alexander Graf
2010-02-10 16:54 ` Alexander Graf
2010-02-10 16:43 ` Avi Kivity
2010-02-10 16:43 ` Avi Kivity
2010-02-10 15:55 ` Anthony Liguori
2010-02-10 15:55 ` [Qemu-devel] " Anthony Liguori
2010-02-12 2:03 ` OHMURA Kei
2010-02-12 2:03 ` [Qemu-devel] " OHMURA Kei
2010-02-14 12:34 ` Avi Kivity
2010-02-14 12:34 ` [Qemu-devel] " Avi Kivity
2010-02-15 6:12 ` OHMURA Kei
2010-02-15 6:12 ` [Qemu-devel] " OHMURA Kei
2010-02-15 8:24 ` Alexander Graf
2010-02-15 8:24 ` Alexander Graf
2010-02-16 11:16 ` OHMURA Kei
2010-02-16 11:16 ` OHMURA Kei
2010-02-16 11:18 ` Alexander Graf
2010-02-16 11:18 ` Alexander Graf
2010-02-17 9:42 ` OHMURA Kei
2010-02-17 9:42 ` OHMURA Kei
2010-02-17 9:46 ` Alexander Graf
2010-02-17 9:46 ` Alexander Graf
2010-02-18 5:57 ` OHMURA Kei
2010-02-18 5:57 ` OHMURA Kei
2010-02-18 10:30 ` Alexander Graf
2010-02-18 10:30 ` Alexander Graf
2010-02-17 9:47 ` Avi Kivity
2010-02-17 9:47 ` Avi Kivity
2010-02-17 9:49 ` Alexander Graf
2010-02-17 9:49 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B72D838.9060603@suse.de \
--to=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=ohmura.kei@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.