All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Alexander Graf <agraf@suse.de>,
	OHMURA Kei <ohmura.kei@lab.ntt.co.jp>,
	mtosatti@redhat.com,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the	dirty-bitmap-traveling
Date: Wed, 10 Feb 2010 18:43:18 +0200	[thread overview]
Message-ID: <4B72E226.9010100@redhat.com> (raw)
In-Reply-To: <4B72E051.8090008@codemonkey.ws>

On 02/10/2010 06:35 PM, Anthony Liguori wrote:
> On 02/10/2010 10:00 AM, Alexander Graf wrote:
>   
>> On PPC the bitmap is Little Endian.
>>   
>>     
> Out of curiousity, why? It seems like an odd interface.
>
>   

Exactly this issue. If you specify it as unsigned long native endian,
there is ambiguity between 32-bit and 64-bit userspace. If you specify
it as uint64_t native endian, you have an inefficient implementation on
32-bit userspace. So we went for unsigned byte native endian, which is
the same as any size little endian.

(well I think the real reason is that it just grew that way out of x86,
but the above is quite plausible).

-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	mtosatti@redhat.com, OHMURA Kei <ohmura.kei@lab.ntt.co.jp>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the	dirty-bitmap-traveling
Date: Wed, 10 Feb 2010 18:43:18 +0200	[thread overview]
Message-ID: <4B72E226.9010100@redhat.com> (raw)
In-Reply-To: <4B72E051.8090008@codemonkey.ws>

On 02/10/2010 06:35 PM, Anthony Liguori wrote:
> On 02/10/2010 10:00 AM, Alexander Graf wrote:
>   
>> On PPC the bitmap is Little Endian.
>>   
>>     
> Out of curiousity, why? It seems like an odd interface.
>
>   

Exactly this issue. If you specify it as unsigned long native endian,
there is ambiguity between 32-bit and 64-bit userspace. If you specify
it as uint64_t native endian, you have an inefficient implementation on
32-bit userspace. So we went for unsigned byte native endian, which is
the same as any size little endian.

(well I think the real reason is that it just grew that way out of x86,
but the above is quite plausible).

-- 
error compiling committee.c: too many arguments to function

  parent reply	other threads:[~2010-02-10 16:43 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10 10:52 [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling OHMURA Kei
2010-02-10 10:52 ` [Qemu-devel] " OHMURA Kei
2010-02-10 13:10 ` Ulrich Drepper
2010-02-10 13:10   ` [Qemu-devel] " Ulrich Drepper
2010-02-10 13:20 ` Avi Kivity
2010-02-10 13:20   ` [Qemu-devel] " Avi Kivity
2010-02-10 15:54   ` Anthony Liguori
2010-02-10 15:54     ` [Qemu-devel] " Anthony Liguori
2010-02-10 15:57     ` Avi Kivity
2010-02-10 15:57       ` [Qemu-devel] " Avi Kivity
2010-02-10 16:00     ` Alexander Graf
2010-02-10 16:00       ` Alexander Graf
2010-02-10 16:35       ` Anthony Liguori
2010-02-10 16:35         ` Anthony Liguori
2010-02-10 16:43         ` Alexander Graf
2010-02-10 16:43           ` Alexander Graf
2010-02-10 16:46           ` Avi Kivity
2010-02-10 16:46             ` Avi Kivity
2010-02-10 16:47             ` Alexander Graf
2010-02-10 16:47               ` Alexander Graf
2010-02-10 16:52               ` Avi Kivity
2010-02-10 16:52                 ` Avi Kivity
2010-02-10 16:54                 ` Alexander Graf
2010-02-10 16:54                   ` Alexander Graf
2010-02-10 16:43         ` Avi Kivity [this message]
2010-02-10 16:43           ` Avi Kivity
2010-02-10 15:55   ` Anthony Liguori
2010-02-10 15:55     ` [Qemu-devel] " Anthony Liguori
2010-02-12  2:03     ` OHMURA Kei
2010-02-12  2:03       ` [Qemu-devel] " OHMURA Kei
2010-02-14 12:34       ` Avi Kivity
2010-02-14 12:34         ` [Qemu-devel] " Avi Kivity
2010-02-15  6:12         ` OHMURA Kei
2010-02-15  6:12           ` [Qemu-devel] " OHMURA Kei
2010-02-15  8:24           ` Alexander Graf
2010-02-15  8:24             ` Alexander Graf
2010-02-16 11:16             ` OHMURA Kei
2010-02-16 11:16               ` OHMURA Kei
2010-02-16 11:18               ` Alexander Graf
2010-02-16 11:18                 ` Alexander Graf
2010-02-17  9:42                 ` OHMURA Kei
2010-02-17  9:42                   ` OHMURA Kei
2010-02-17  9:46                   ` Alexander Graf
2010-02-17  9:46                     ` Alexander Graf
2010-02-18  5:57                     ` OHMURA Kei
2010-02-18  5:57                       ` OHMURA Kei
2010-02-18 10:30                       ` Alexander Graf
2010-02-18 10:30                         ` Alexander Graf
2010-02-17  9:47                   ` Avi Kivity
2010-02-17  9:47                     ` Avi Kivity
2010-02-17  9:49                     ` Alexander Graf
2010-02-17  9:49                       ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B72E226.9010100@redhat.com \
    --to=avi@redhat.com \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=ohmura.kei@lab.ntt.co.jp \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.