All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Blue Swirl <blauwirbel@gmail.com>,
	ceph-devel@vger.kernel.org, Christian Brunner <chb@muc.de>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm
Date: Tue, 25 May 2010 08:35:10 -0500	[thread overview]
Message-ID: <4BFBD20E.5060207@codemonkey.ws> (raw)
In-Reply-To: <4BFBD13C.60605@redhat.com>

On 05/25/2010 08:31 AM, Avi Kivity wrote:
>> A protocol based mechanism has the advantage of being more robust in 
>> the face of poorly written block backends so if it's possible to make 
>> it perform as well as a plugin, it's a preferable approach.
>
> May be hard due to difficulty of exposing guest memory.

If someone did a series to add plugins, I would expect a very strong 
argument as to why a shared memory mechanism was not possible or at 
least plausible.

I'm not sure I understand why shared memory is such a bad thing wrt 
KVM.  Can you elaborate?  Is it simply a matter of fork()?

>>
>> Plugins that just expose chunks of QEMU internal state directly (like 
>> BlockDriver) are a really bad idea IMHO.
>
> Also, we don't want to expose all of the qemu API.  We should default 
> the visibility attribute to "hidden" and expose only select functions, 
> perhaps under their own interface.  And no inlines.

Yeah, if we did plugins, this would be a key requirement.

Regards,

Anthony Liguori

WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org,
	Blue Swirl <blauwirbel@gmail.com>,
	ceph-devel@vger.kernel.org, Christian Brunner <chb@muc.de>
Subject: Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm
Date: Tue, 25 May 2010 08:35:10 -0500	[thread overview]
Message-ID: <4BFBD20E.5060207@codemonkey.ws> (raw)
In-Reply-To: <4BFBD13C.60605@redhat.com>

On 05/25/2010 08:31 AM, Avi Kivity wrote:
>> A protocol based mechanism has the advantage of being more robust in 
>> the face of poorly written block backends so if it's possible to make 
>> it perform as well as a plugin, it's a preferable approach.
>
> May be hard due to difficulty of exposing guest memory.

If someone did a series to add plugins, I would expect a very strong 
argument as to why a shared memory mechanism was not possible or at 
least plausible.

I'm not sure I understand why shared memory is such a bad thing wrt 
KVM.  Can you elaborate?  Is it simply a matter of fork()?

>>
>> Plugins that just expose chunks of QEMU internal state directly (like 
>> BlockDriver) are a really bad idea IMHO.
>
> Also, we don't want to expose all of the qemu API.  We should default 
> the visibility attribute to "hidden" and expose only select functions, 
> perhaps under their own interface.  And no inlines.

Yeah, if we did plugins, this would be a key requirement.

Regards,

Anthony Liguori

  reply	other threads:[~2010-05-25 13:41 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19 19:22 [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm Christian Brunner
2010-05-19 19:22 ` [Qemu-devel] " Christian Brunner
2010-05-20 20:31 ` Blue Swirl
2010-05-20 20:31   ` Blue Swirl
2010-05-20 21:18   ` Christian Brunner
2010-05-20 21:18     ` Christian Brunner
2010-05-20 21:29     ` Anthony Liguori
2010-05-20 21:29       ` Anthony Liguori
2010-05-20 22:16       ` Christian Brunner
2010-05-20 22:16         ` Christian Brunner
2010-05-21  5:28         ` Stefan Hajnoczi
2010-05-21  5:28           ` Stefan Hajnoczi
2010-05-21  6:13           ` MORITA Kazutaka
2010-05-21  6:13             ` MORITA Kazutaka
2010-05-21  5:54         ` MORITA Kazutaka
2010-05-21  5:54           ` MORITA Kazutaka
2010-05-23 12:01       ` Avi Kivity
2010-05-23 12:01         ` Avi Kivity
2010-05-24  7:12         ` MORITA Kazutaka
2010-05-24  7:12           ` MORITA Kazutaka
2010-05-24 11:05           ` Avi Kivity
2010-05-24 11:05             ` Avi Kivity
2010-05-24 11:42             ` MORITA Kazutaka
2010-05-24 11:42               ` MORITA Kazutaka
2010-05-24 11:56               ` Avi Kivity
2010-05-24 11:56                 ` Avi Kivity
2010-05-24 12:07                 ` Cláudio Martins
2010-05-24 12:07                   ` Cláudio Martins
2010-05-24 14:01                 ` MORITA Kazutaka
2010-05-24 14:01                   ` MORITA Kazutaka
2010-05-24 19:07                   ` Christian Brunner
2010-05-24 19:07                     ` Christian Brunner
2010-05-24 19:38                     ` Anthony Liguori
2010-05-24 19:38                       ` Anthony Liguori
2010-05-25  9:14                       ` Avi Kivity
2010-05-25  9:14                         ` Avi Kivity
2010-05-25 13:17                         ` Anthony Liguori
2010-05-25 13:17                           ` Anthony Liguori
2010-05-25 13:25                           ` Avi Kivity
2010-05-25 13:25                             ` Avi Kivity
2010-05-25 13:29                             ` Anthony Liguori
2010-05-25 13:29                               ` Anthony Liguori
2010-05-25 13:36                               ` Avi Kivity
2010-05-25 13:36                                 ` Avi Kivity
2010-05-25 13:54                                 ` Anthony Liguori
2010-05-25 13:54                                   ` Anthony Liguori
2010-05-25 13:57                                   ` Avi Kivity
2010-05-25 13:57                                     ` Avi Kivity
2010-05-25 14:02                                     ` Anthony Liguori
2010-05-25 14:02                                       ` Anthony Liguori
2010-05-26  8:44                                       ` Avi Kivity
2010-05-26  8:44                                         ` Avi Kivity
2010-05-25 14:01                             ` Kevin Wolf
2010-05-25 14:01                               ` Kevin Wolf
2010-05-25 16:21                               ` Avi Kivity
2010-05-25 16:21                                 ` Avi Kivity
2010-05-25 17:12                                 ` Sage Weil
2010-05-25 17:12                                   ` Sage Weil
2010-05-25 17:12                                   ` Sage Weil
2010-05-26  5:24                                   ` MORITA Kazutaka
2010-05-26  5:24                                     ` MORITA Kazutaka
2010-05-26  8:46                                   ` Avi Kivity
2010-05-26  8:46                                     ` Avi Kivity
2010-05-24 19:16                 ` Anthony Liguori
2010-05-24 19:16                   ` Anthony Liguori
2010-05-25  9:19                   ` Avi Kivity
2010-05-25  9:19                     ` Avi Kivity
2010-05-25 13:26                   ` MORITA Kazutaka
2010-05-25 13:26                     ` MORITA Kazutaka
2010-05-24  8:27         ` Stefan Hajnoczi
2010-05-24  8:27           ` Stefan Hajnoczi
2010-05-24 11:03           ` Avi Kivity
2010-05-24 11:03             ` Avi Kivity
2010-05-24 19:19             ` Anthony Liguori
2010-05-24 19:19               ` Anthony Liguori
2010-05-25  9:22               ` Avi Kivity
2010-05-25  9:22                 ` Avi Kivity
2010-05-25 11:02         ` Kevin Wolf
2010-05-25 11:02           ` Kevin Wolf
2010-05-25 11:25           ` Avi Kivity
2010-05-25 11:25             ` Avi Kivity
2010-05-25 12:03             ` Christoph Hellwig
2010-05-25 12:03               ` Christoph Hellwig
2010-05-25 12:13               ` Avi Kivity
2010-05-25 12:13                 ` Avi Kivity
2010-05-25 13:25             ` Anthony Liguori
2010-05-25 13:25               ` Anthony Liguori
2010-05-25 13:31               ` Avi Kivity
2010-05-25 13:31                 ` Avi Kivity
2010-05-25 13:35                 ` Anthony Liguori [this message]
2010-05-25 13:35                   ` Anthony Liguori
2010-05-25 13:38                   ` Avi Kivity
2010-05-25 13:38                     ` Avi Kivity
2010-05-25 13:55                     ` Anthony Liguori
2010-05-25 13:55                       ` Anthony Liguori
2010-05-25 14:01                       ` Avi Kivity
2010-05-25 14:01                         ` Avi Kivity
2010-05-25 14:05                         ` Anthony Liguori
2010-05-25 14:05                           ` Anthony Liguori
2010-05-25 15:00                           ` Avi Kivity
2010-05-25 15:00                             ` Avi Kivity
2010-05-25 15:01                             ` Anthony Liguori
2010-05-25 15:01                               ` Anthony Liguori
2010-05-25 16:16                               ` Avi Kivity
2010-05-25 16:16                                 ` Avi Kivity
2010-05-25 16:21                                 ` Anthony Liguori
2010-05-25 16:21                                   ` Anthony Liguori
2010-05-25 16:27                                   ` Avi Kivity
2010-05-25 16:27                                     ` Avi Kivity
2010-05-25 13:53               ` Kevin Wolf
2010-05-25 13:53                 ` Kevin Wolf
2010-05-25 13:55                 ` Avi Kivity
2010-05-25 13:55                   ` Avi Kivity
2010-05-25 14:03                   ` Anthony Liguori
2010-05-25 14:03                     ` Anthony Liguori
2010-05-25 15:02                     ` Avi Kivity
2010-05-25 15:02                       ` Avi Kivity
2010-05-25 14:09                   ` Kevin Wolf
2010-05-25 14:09                     ` Kevin Wolf
2010-05-25 15:01                     ` Avi Kivity
2010-05-25 15:01                       ` Avi Kivity
2010-05-20 23:02   ` Yehuda Sadeh Weinraub
2010-05-20 23:02     ` Yehuda Sadeh Weinraub
2010-05-23  7:59     ` Blue Swirl
2010-05-23  7:59       ` Blue Swirl
2010-05-24  2:17       ` Yehuda Sadeh Weinraub
2010-05-24  2:17         ` Yehuda Sadeh Weinraub
2010-05-25 20:13         ` Blue Swirl
2010-05-25 20:13           ` [Qemu-devel] " Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFBD20E.5060207@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=chb@muc.de \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.