From: Cong Wang <amwang@redhat.com>
To: Flavio Leitner <fbl@sysclose.org>
Cc: Jay Vosburgh <fubar@us.ibm.com>,
Neil Horman <nhorman@tuxdriver.com>,
netdev@vger.kernel.org, Matt Mackall <mpm@selenic.com>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
David Miller <davem@davemloft.net>,
Jeff Moyer <jmoyer@redhat.com>,
Andy Gospodarek <gospo@redhat.com>,
bonding-devel@lists.sourceforge.net
Subject: Re: [Bridge] [v5 Patch 1/3] netpoll: add generic support for bridge and bonding devices
Date: Mon, 31 May 2010 13:56:52 +0800 [thread overview]
Message-ID: <4C034FA4.5000401@redhat.com> (raw)
In-Reply-To: <20100528194041.GC2345@sysclose.org>
[-- Attachment #1: Type: text/plain, Size: 111 bytes --]
Hi, Flavio,
Please use the attached patch instead, try to see if it solves
all your problems.
Thanks a lot!
[-- Attachment #2: drivers-net-bonding-fix-activebackup-deadlock.diff --]
[-- Type: text/x-patch, Size: 837 bytes --]
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index ca142c4..2d1d594 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -666,7 +666,8 @@ static int netconsole_netdev_event(struct notifier_block *this,
struct net_device *dev = ptr;
if (!(event == NETDEV_CHANGENAME || event == NETDEV_UNREGISTER ||
- event == NETDEV_BONDING_DESLAVE || event == NETDEV_GOING_DOWN))
+ event == NETDEV_BONDING_DESLAVE || event == NETDEV_GOING_DOWN ||
+ event == NETDEV_BONDING_FAILOVER))
goto done;
spin_lock_irqsave(&target_list_lock, flags);
@@ -682,6 +683,7 @@ static int netconsole_netdev_event(struct notifier_block *this,
/* Fall through */
case NETDEV_GOING_DOWN:
case NETDEV_BONDING_DESLAVE:
+ case NETDEV_BONDING_FAILOVER:
nt->enabled = 0;
break;
}
WARNING: multiple messages have this Message-ID (diff)
From: Cong Wang <amwang@redhat.com>
To: Flavio Leitner <fbl@sysclose.org>
Cc: linux-kernel@vger.kernel.org, Matt Mackall <mpm@selenic.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Andy Gospodarek <gospo@redhat.com>,
Neil Horman <nhorman@tuxdriver.com>,
Jeff Moyer <jmoyer@redhat.com>,
Stephen Hemminger <shemminger@linux-foundation.org>,
bonding-devel@lists.sourceforge.net,
Jay Vosburgh <fubar@us.ibm.com>,
David Miller <davem@davemloft.net>
Subject: Re: [v5 Patch 1/3] netpoll: add generic support for bridge and bonding devices
Date: Mon, 31 May 2010 13:56:52 +0800 [thread overview]
Message-ID: <4C034FA4.5000401@redhat.com> (raw)
In-Reply-To: <20100528194041.GC2345@sysclose.org>
[-- Attachment #1: Type: text/plain, Size: 111 bytes --]
Hi, Flavio,
Please use the attached patch instead, try to see if it solves
all your problems.
Thanks a lot!
[-- Attachment #2: drivers-net-bonding-fix-activebackup-deadlock.diff --]
[-- Type: text/x-patch, Size: 837 bytes --]
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index ca142c4..2d1d594 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -666,7 +666,8 @@ static int netconsole_netdev_event(struct notifier_block *this,
struct net_device *dev = ptr;
if (!(event == NETDEV_CHANGENAME || event == NETDEV_UNREGISTER ||
- event == NETDEV_BONDING_DESLAVE || event == NETDEV_GOING_DOWN))
+ event == NETDEV_BONDING_DESLAVE || event == NETDEV_GOING_DOWN ||
+ event == NETDEV_BONDING_FAILOVER))
goto done;
spin_lock_irqsave(&target_list_lock, flags);
@@ -682,6 +683,7 @@ static int netconsole_netdev_event(struct notifier_block *this,
/* Fall through */
case NETDEV_GOING_DOWN:
case NETDEV_BONDING_DESLAVE:
+ case NETDEV_BONDING_FAILOVER:
nt->enabled = 0;
break;
}
next prev parent reply other threads:[~2010-05-31 5:56 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 8:11 [Bridge] [v5 Patch 1/3] netpoll: add generic support for bridge and bonding devices Amerigo Wang
2010-05-05 8:11 ` Amerigo Wang
2010-05-05 8:11 ` Amerigo Wang
2010-05-05 8:11 ` [Bridge] [v5 Patch 2/3] bridge: make bridge support netpoll Amerigo Wang
2010-05-05 8:11 ` Amerigo Wang
2010-05-05 8:11 ` Amerigo Wang
2010-05-05 8:11 ` [Bridge] [v5 Patch 3/3] bonding: make bonding " Amerigo Wang
2010-05-05 8:11 ` Amerigo Wang
2010-05-05 8:11 ` Amerigo Wang
2010-05-06 2:05 ` [Bridge] [v5 Patch 1/3] netpoll: add generic support for bridge and bonding devices Matt Mackall
2010-05-06 2:05 ` Matt Mackall
2010-05-06 7:44 ` [Bridge] " David Miller
2010-05-06 7:44 ` David Miller
2010-05-07 3:24 ` [Bridge] " Cong Wang
2010-05-07 3:24 ` Cong Wang
2010-05-27 18:05 ` [Bridge] " Flavio Leitner
2010-05-27 18:05 ` Flavio Leitner
2010-05-27 20:35 ` [Bridge] " David Miller
2010-05-27 20:35 ` David Miller
2010-05-27 21:25 ` [Bridge] " Flavio Leitner
2010-05-27 21:25 ` Flavio Leitner
2010-05-28 2:47 ` [Bridge] " Cong Wang
2010-05-28 2:47 ` Cong Wang
2010-05-28 19:40 ` [Bridge] " Flavio Leitner
2010-05-28 19:40 ` Flavio Leitner
2010-05-31 5:56 ` Cong Wang [this message]
2010-05-31 5:56 ` Cong Wang
2010-05-31 19:08 ` [Bridge] " Flavio Leitner
2010-05-31 19:08 ` Flavio Leitner
2010-06-01 9:57 ` [Bridge] " Cong Wang
2010-06-01 9:57 ` Cong Wang
2010-06-01 18:42 ` [Bridge] " Jay Vosburgh
2010-06-01 18:42 ` Jay Vosburgh
2010-06-02 10:04 ` [Bridge] " Cong Wang
2010-06-02 10:04 ` Cong Wang
2010-06-04 19:18 ` [Bridge] " Andy Gospodarek
2010-06-04 19:18 ` Andy Gospodarek
2010-06-07 9:57 ` [Bridge] " Cong Wang
2010-06-07 9:57 ` Cong Wang
2010-06-07 10:01 ` [Bridge] " David Miller
2010-06-07 10:01 ` David Miller
2010-06-08 8:36 ` [Bridge] " Cong Wang
2010-06-08 8:36 ` Cong Wang
2010-06-07 13:03 ` [Bridge] " Andy Gospodarek
2010-06-07 13:03 ` Andy Gospodarek
2010-06-08 8:38 ` [Bridge] " Cong Wang
2010-06-08 8:38 ` Cong Wang
2010-06-07 19:24 ` [Bridge] [PATCH] netconsole: queue console messages to send later Flavio Leitner
2010-06-07 19:24 ` Flavio Leitner
2010-06-07 19:50 ` [Bridge] " Matt Mackall
2010-06-07 19:50 ` Matt Mackall
2010-06-07 20:00 ` [Bridge] " Stephen Hemminger
2010-06-07 20:00 ` Stephen Hemminger
2010-06-07 20:21 ` [Bridge] " Matt Mackall
2010-06-07 20:21 ` Matt Mackall
2010-06-07 23:52 ` [Bridge] " David Miller
2010-06-07 23:52 ` David Miller
2010-06-07 23:50 ` [Bridge] " David Miller
2010-06-07 23:50 ` David Miller
2010-06-08 0:37 ` [Bridge] " Flavio Leitner
2010-06-08 0:37 ` Flavio Leitner
2010-06-08 8:59 ` [Bridge] " Cong Wang
2010-06-08 8:59 ` Cong Wang
2010-05-28 8:16 ` [Bridge] [v5 Patch 1/3] netpoll: add generic support for bridge and bonding devices Cong Wang
2010-05-28 8:16 ` Cong Wang
2010-05-28 20:42 ` [Bridge] " Flavio Leitner
2010-05-28 20:42 ` Flavio Leitner
2010-05-28 21:03 ` [Bridge] " Jay Vosburgh
2010-05-28 21:03 ` Jay Vosburgh
2010-05-31 5:29 ` [Bridge] " Cong Wang
2010-05-31 5:29 ` Cong Wang
2010-05-31 5:37 ` [Bridge] " Cong Wang
2010-05-31 5:37 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C034FA4.5000401@redhat.com \
--to=amwang@redhat.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fbl@sysclose.org \
--cc=fubar@us.ibm.com \
--cc=gospo@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.