All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nitin Gupta <ngupta@vflare.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	akpm@linux-foundation.org, Chris Mason <chris.mason@oracle.com>,
	viro@zeniv.linux.org.uk, adilger@sun.com, tytso@mit.edu,
	mfasheh@suse.com, Joel Becker <joel.becker@oracle.com>,
	matthew@wil.cx, linux-btrfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org, jeremy@goop.org, JBeulich@novell.com,
	Kurt Hackel <kurt.hackel@oracle.com>,
	npiggin@suse.de, Dave Mccracken <dave.mccracken@oracle.com>,
	riel@redhat.com, avi@redhat.com,
	Konrad Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH V3 0/8] Cleancache: overview
Date: Fri, 23 Jul 2010 20:35:18 +0530	[thread overview]
Message-ID: <4C49AFAE.1070300@vflare.org> (raw)
In-Reply-To: <364c83bd-ccb2-48cc-920d-ffcf9ca7df19@default>

On 07/23/2010 08:14 PM, Dan Magenheimer wrote:
>> From: Christoph Hellwig [mailto:hch@infradead.org]


>> Also making the ops vector global is just a bad idea.
>> There is nothing making this sort of caching inherently global.
> 
> I'm not sure I understand your point, but two very different
> users of cleancache have been provided, and more will be
> discussed at the MM summit next month.
> 
> Do you have a suggestion on how to avoid a global ops
> vector while still serving the needs of both existing
> users?

Maybe introduce cleancache_register(struct cleancache_ops *ops)?
This will allow making cleancache_ops non-global. No value add
but maybe that's cleaner?

Thanks,
Nitin

WARNING: multiple messages have this Message-ID (diff)
From: Nitin Gupta <ngupta@vflare.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	akpm@linux-foundation.org, Chris Mason <chris.mason@oracle.com>,
	viro@zeniv.linux.org.uk, adilger@sun.com, tytso@mit.edu,
	mfasheh@suse.com, Joel Becker <joel.becker@oracle.com>,
	matthew@wil.cx, linux-btrfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org, jeremy@goop.org, JBeulich@novell.com,
	Kurt Hackel <kurt.hackel@oracle.com>,
	npiggin@suse.de, Dave Mccracken <dave.mccracken@oracle.com>,
	riel@redhat.com, avi@redhat.com,
	Konrad Wilk <konrad.wilk@oracle.com>
Subject: [Ocfs2-devel] [PATCH V3 0/8] Cleancache: overview
Date: Fri, 23 Jul 2010 20:35:18 +0530	[thread overview]
Message-ID: <4C49AFAE.1070300@vflare.org> (raw)
In-Reply-To: <364c83bd-ccb2-48cc-920d-ffcf9ca7df19@default>

On 07/23/2010 08:14 PM, Dan Magenheimer wrote:
>> From: Christoph Hellwig [mailto:hch at infradead.org]


>> Also making the ops vector global is just a bad idea.
>> There is nothing making this sort of caching inherently global.
> 
> I'm not sure I understand your point, but two very different
> users of cleancache have been provided, and more will be
> discussed at the MM summit next month.
> 
> Do you have a suggestion on how to avoid a global ops
> vector while still serving the needs of both existing
> users?

Maybe introduce cleancache_register(struct cleancache_ops *ops)?
This will allow making cleancache_ops non-global. No value add
but maybe that's cleaner?

Thanks,
Nitin

WARNING: multiple messages have this Message-ID (diff)
From: Nitin Gupta <ngupta@vflare.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	akpm@linux-foundation.org, Chris Mason <chris.mason@oracle.com>,
	viro@zeniv.linux.org.uk, adilger@sun.com, tytso@mit.edu,
	mfasheh@suse.com, Joel Becker <joel.becker@oracle.com>,
	matthew@wil.cx, linux-btrfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org, jeremy@goop.org, JBeulich@novell.com,
	Kurt Hackel <kurt.hackel@oracle.com>,
	npiggin@suse.de, Dave Mccracken <dave.mccracken@oracle.com>,
	riel@redhat.com, avi@redhat.com,
	Konrad Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH V3 0/8] Cleancache: overview
Date: Fri, 23 Jul 2010 20:35:18 +0530	[thread overview]
Message-ID: <4C49AFAE.1070300@vflare.org> (raw)
In-Reply-To: <364c83bd-ccb2-48cc-920d-ffcf9ca7df19@default>

On 07/23/2010 08:14 PM, Dan Magenheimer wrote:
>> From: Christoph Hellwig [mailto:hch@infradead.org]


>> Also making the ops vector global is just a bad idea.
>> There is nothing making this sort of caching inherently global.
> 
> I'm not sure I understand your point, but two very different
> users of cleancache have been provided, and more will be
> discussed at the MM summit next month.
> 
> Do you have a suggestion on how to avoid a global ops
> vector while still serving the needs of both existing
> users?

Maybe introduce cleancache_register(struct cleancache_ops *ops)?
This will allow making cleancache_ops non-global. No value add
but maybe that's cleaner?

Thanks,
Nitin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-07-23 15:05 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-21 23:18 [Ocfs2-devel] [PATCH V3 0/8] Cleancache: overview Dan Magenheimer
2010-06-21 23:18 ` Dan Magenheimer
2010-06-21 23:18 ` Dan Magenheimer
2010-06-22  6:40 ` Christoph Hellwig
2010-06-22  6:40   ` Christoph Hellwig
2010-06-22  6:40   ` [Ocfs2-devel] " Christoph Hellwig
2010-07-06 20:58 ` Konrad Rzeszutek Wilk
2010-07-06 20:58   ` Konrad Rzeszutek Wilk
2010-07-06 20:58   ` [Ocfs2-devel] " Konrad Rzeszutek Wilk
2010-07-23  7:36 ` Nitin Gupta
2010-07-23  7:36   ` Nitin Gupta
2010-07-23  7:36   ` [Ocfs2-devel] " Nitin Gupta
2010-07-23  8:16   ` Minchan Kim
2010-07-23  8:16     ` Minchan Kim
2010-07-23  8:16     ` [Ocfs2-devel] " Minchan Kim
2010-07-23  8:16     ` Minchan Kim
2010-07-23 14:56     ` Nitin Gupta
2010-07-23 14:56       ` Nitin Gupta
2010-07-23 14:56       ` [Ocfs2-devel] " Nitin Gupta
2010-07-23  8:17   ` Minchan Kim
2010-07-23  8:17     ` Minchan Kim
2010-07-23  8:17     ` [Ocfs2-devel] " Minchan Kim
2010-07-23  8:17     ` Minchan Kim
2010-07-23 13:58   ` Dan Magenheimer
2010-07-23 13:58     ` Dan Magenheimer
2010-07-23 13:58     ` [Ocfs2-devel] " Dan Magenheimer
2010-07-23 14:04     ` Christoph Hellwig
2010-07-23 14:04       ` Christoph Hellwig
2010-07-23 14:04       ` [Ocfs2-devel] " Christoph Hellwig
2010-07-23 14:44       ` Dan Magenheimer
2010-07-23 14:44         ` Dan Magenheimer
2010-07-23 14:44         ` [Ocfs2-devel] " Dan Magenheimer
2010-07-23 14:44         ` Dan Magenheimer
2010-07-23 15:05         ` Nitin Gupta [this message]
2010-07-23 15:05           ` Nitin Gupta
2010-07-23 15:05           ` [Ocfs2-devel] " Nitin Gupta
2010-07-23 17:43           ` Dan Magenheimer
2010-07-23 17:43             ` Dan Magenheimer
2010-07-23 17:43             ` [Ocfs2-devel] " Dan Magenheimer
2010-07-23 17:43             ` Dan Magenheimer
2010-07-23 17:37         ` Dan Magenheimer
2010-07-23 17:37           ` Dan Magenheimer
2010-07-23 17:37           ` [Ocfs2-devel] " Dan Magenheimer
2010-07-23 17:37           ` Dan Magenheimer
2010-07-23 18:36           ` Nitin Gupta
2010-07-23 18:36             ` Nitin Gupta
2010-07-23 18:36             ` [Ocfs2-devel] " Nitin Gupta
2010-07-23 21:17         ` Dan Magenheimer
2010-07-23 21:17           ` Dan Magenheimer
2010-07-23 21:17           ` [Ocfs2-devel] " Dan Magenheimer
2010-07-23 21:17           ` Dan Magenheimer
2010-08-03 16:22           ` Boaz Harrosh
2010-08-03 16:22             ` Boaz Harrosh
2010-08-03 16:22             ` [Ocfs2-devel] " Boaz Harrosh
2010-08-03 17:35             ` Dan Magenheimer
2010-08-03 17:35               ` Dan Magenheimer
2010-08-03 17:35               ` [Ocfs2-devel] " Dan Magenheimer
2010-08-03 17:35               ` Dan Magenheimer
2010-08-03 18:34               ` Andreas Dilger
2010-08-03 18:34                 ` Andreas Dilger
2010-08-03 18:34                 ` [Ocfs2-devel] " Andreas Dilger
2010-08-03 18:34                 ` Andreas Dilger
2010-08-03 19:09                 ` Dan Magenheimer
2010-08-03 19:09                   ` Dan Magenheimer
2010-08-03 19:09                   ` [Ocfs2-devel] " Dan Magenheimer
2010-08-03 19:09                   ` Dan Magenheimer
  -- strict thread matches above, loose matches on Subject: below --
2010-06-21 23:18 Dan Magenheimer
2010-06-21 23:18 Dan Magenheimer
2010-06-21 23:18 Dan Magenheimer
     [not found] <20100621231809.GA11111@ca-server1.us.oracle.com4C49468B.40307@vflare.org>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C49AFAE.1070300@vflare.org \
    --to=ngupta@vflare.org \
    --cc=JBeulich@novell.com \
    --cc=adilger@sun.com \
    --cc=akpm@linux-foundation.org \
    --cc=avi@redhat.com \
    --cc=chris.mason@oracle.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=dave.mccracken@oracle.com \
    --cc=hch@infradead.org \
    --cc=jeremy@goop.org \
    --cc=joel.becker@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kurt.hackel@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew@wil.cx \
    --cc=mfasheh@suse.com \
    --cc=npiggin@suse.de \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=riel@redhat.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.