All of lore.kernel.org
 help / color / mirror / Atom feed
* Fallback to scanning OF tree if no devaliases
@ 2010-07-29  6:21 Doug Nazar
  2010-07-29 15:36 ` Lennart Sorensen
  2010-08-01 14:48 ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 2 replies; 14+ messages in thread
From: Doug Nazar @ 2010-07-29  6:21 UTC (permalink / raw)
  To: grub-devel, Lennart Sorensen

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

  Lennart, try giving this patch a whirl. In the case after we scan the 
aliases list and we haven't found any block devices it will now try to 
scan the entire tree. It kinda worked under OpenBios although I ran into 
another bug where it can't open a device path that it gave me for the 
pci ide controller. It found the other 2 drives fine.

I think this maintains the correct balance of using short pretty names 
if available but working if they are not available.

There is a case where it will mess up however. If you only specify an 
alias for one device but need another device to build a raid or lvm it 
will fail. Although, thinking about it, this already would happen.

As always, you can specify the either path manually.

Doug


[-- Attachment #2: grub-fallback-to-scanning-of-tree.diff --]
[-- Type: text/plain, Size: 922 bytes --]

=== modified file 'disk/ieee1275/ofdisk.c'
--- disk/ieee1275/ofdisk.c	2010-07-29 03:58:16 +0000
+++ disk/ieee1275/ofdisk.c	2010-07-29 06:02:06 +0000
@@ -76,6 +76,9 @@
 grub_ofdisk_iterate (int (*hook) (const char *name))
 {
   auto int dev_iterate (struct grub_ieee1275_devalias *alias);
+  int disks_found = 0;
+  int use_path = 0;
+  int result;
 
   int dev_iterate (struct grub_ieee1275_devalias *alias)
     {
@@ -110,11 +113,20 @@
 
       if (! grub_strcmp (alias->type, "block") &&
 	  grub_strncmp (alias->name, "cdrom", 5))
-	ret = hook (alias->name);
+      {
+	disks_found++;
+	ret = hook (use_path ? alias->path : alias->name);
+      }
       return ret;
     }
 
-  return grub_devalias_iterate (dev_iterate);
+  result = grub_devalias_iterate (dev_iterate);
+  if (!disks_found)
+  {
+    use_path = 1;
+    result = grub_ieee1275_devices_iterate (dev_iterate);
+  }
+  return result;
 }
 
 static char *


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-07-29  6:21 Fallback to scanning OF tree if no devaliases Doug Nazar
@ 2010-07-29 15:36 ` Lennart Sorensen
  2010-07-29 15:57   ` Doug Nazar
  2010-07-29 17:08   ` Doug Nazar
  2010-08-01 14:48 ` Vladimir 'φ-coder/phcoder' Serbinenko
  1 sibling, 2 replies; 14+ messages in thread
From: Lennart Sorensen @ 2010-07-29 15:36 UTC (permalink / raw)
  To: Doug Nazar; +Cc: grub-devel, Lennart Sorensen

On Thu, Jul 29, 2010 at 02:21:36AM -0400, Doug Nazar wrote:
>  Lennart, try giving this patch a whirl. In the case after we scan the  
> aliases list and we haven't found any block devices it will now try to  
> scan the entire tree. It kinda worked under OpenBios although I ran into  
> another bug where it can't open a device path that it gave me for the  
> pci ide controller. It found the other 2 drives fine.
>
> I think this maintains the correct balance of using short pretty names  
> if available but working if they are not available.
>
> There is a case where it will mess up however. If you only specify an  
> alias for one device but need another device to build a raid or lvm it  
> will fail. Although, thinking about it, this already would happen.
>
> As always, you can specify the either path manually.
>
> Doug
>

> === modified file 'disk/ieee1275/ofdisk.c'
> --- disk/ieee1275/ofdisk.c	2010-07-29 03:58:16 +0000
> +++ disk/ieee1275/ofdisk.c	2010-07-29 06:02:06 +0000
> @@ -76,6 +76,9 @@
>  grub_ofdisk_iterate (int (*hook) (const char *name))
>  {
>    auto int dev_iterate (struct grub_ieee1275_devalias *alias);
> +  int disks_found = 0;
> +  int use_path = 0;
> +  int result;
>  
>    int dev_iterate (struct grub_ieee1275_devalias *alias)
>      {
> @@ -110,11 +113,20 @@
>  
>        if (! grub_strcmp (alias->type, "block") &&
>  	  grub_strncmp (alias->name, "cdrom", 5))
> -	ret = hook (alias->name);
> +      {
> +	disks_found++;
> +	ret = hook (use_path ? alias->path : alias->name);
> +      }
>        return ret;
>      }
>  
> -  return grub_devalias_iterate (dev_iterate);
> +  result = grub_devalias_iterate (dev_iterate);
> +  if (!disks_found)
> +  {
> +    use_path = 1;
> +    result = grub_ieee1275_devices_iterate (dev_iterate);
> +  }
> +  return result;
>  }
>  
>  static char *
> 

I removed the nvalias's and got:

0 > boot /pci@800000020000200/pci1014,02BD@1/sas/disk@20000 |                                                                                                                                                                                                                  
Elapsed time since release of system processors: 7 mins 55 secs                                                                                                                                                                                                                
Welcome to GRUB!                                                                                                                                                                                                                                                               
                                                                                                                                                                                                                                                                               
                                                                                                                                                                                                                                                                               
Detected bad memory access to address: 727461736261739d                                                                                                                                                                                                                        
Package path = /packages/gscsi/disk                                                                                                                                                                                                                                            
Loc-code =                                                                                                                                                                                                                                                                     
Return Stack Trace                                                                                                                                                                                                                                                             
------------------                                                                                                                                                                                                                                                             
@  - c3e530                                                                                                                                                                                                                                                                    
find-method  - c48b9c                                                                                                                                                                                                                                                          
(poplocals)  - c3c9e8                                                                                                                                                                                                                                                          
$call-method  - c48c54                                                                                                                                                                                                                                                         
(poplocals)  - c3c9e8                                                                                                                                                                                                                                                          
$CALL-R/W-DEV  - d54a70                                                                                                                                                                                                                                                        
(EXEC)  - d54d24                                                                                                                                                                                                                                                               
EXECUTE-COMMAND  - d54db4                                                                                                                                                                                                                                                      
RETRY-COMMAND  - d55ca4                                                                                                                                                                                                                                                        
INQUIRY  - d55fd0                                                                                                                                                                                                                                                              
SCSI-DEVICE-TYPE  - d5672c                                                                                                                                                                                                                                                     
catch  - c3aff0                                                                                                                                                                                                                                                                
$call-method  - c48c78                                                                                                                                                                                                                                                         
(poplocals)  - c3c9e8                                                                                                                                                                                                                                                          
$call-parent  - c48e98                                                                                                                                                                                                                                                         
SCSI-DEVICE-TYPE  - d56df4                                                                                                                                                                                                                                                     
OPEN  - d58200                                                                                                                                                                                                                                                                 
catch  - c3aff0                                                                                                                                                                                                                                                                
$call-method  - c48c78                                                                                                                                                                                                                                                         
(poplocals)  - c3c9e8                                                                                                                                                                                                                                                          
                                                                                                                                                                                                                                                                               
Detected bad memory access to address: 727461736261739d                                                                                                                                                                                                                        
Package path = /packages/gscsi/disk                                                                                                                                                                                                                                            
Loc-code =                                                                                                                                                                                                                                                                     
Return Stack Trace                                                                                                                                                                                                                                                             
------------------                                                                                                                                                                                                                                                             
@  - c3e530                                                                                                                                                                                                                                                                    
find-method  - c48b9c                                                                                                                                                                                                                                                          
(poplocals)  - c3c9e8                                                                                                                                                                                                                                                          
$call-method  - c48c54                                                                                                                                                                                                                                                         
(poplocals)  - c3c9e8                                                                                                                                                                                                                                                          
$CALL-R/W-DEV  - d54a70                                                                                                                                                                                                                                                        
(EXEC)  - d54d24                                                                                                                                                                                                                                                               
EXECUTE-COMMAND  - d54db4                                                                                                                                                                                                                                                      
RETRY-COMMAND  - d55ca4                                                                                                                                                                                                                                                        
INQUIRY  - d55fd0                                                                                                                                                                                                                                                              
SCSI-DEVICE-TYPE  - d5672c                                                                                                                                                                                                                                                     
catch  - c3aff0                                                                                                                                                                                                                                                                
$call-method  - c48c78                                                                                                                                                                                                                                                         
(poplocals)  - c3c9e8                                                                                                                                                                                                                                                          
$call-parent  - c48e98                                                                                                                                                                                                                                                         
SCSI-DEVICE-TYPE  - d56df4                                                                                                                                                                                                                                                     
OPEN  - d58200                                                                                                                                                                                                                                                                 
catch  - c3aff0                                                                                                                                                                                                                                                                
$call-method  - c48c78                                                                                                                                                                                                                                                         
(poplocals)  - c3c9e8                                                                                                                                                                                                                                                          
diskOPEN: can't find hw device                                                                                                                                                                                                                                                 
diskOPEN: can't find hw device                                                                                                                                                                                                                                                 
error: no such disk.                                                                                                                                                                                                                                                           
Entering rescue mode...                                                                                                                                                                                                                                                        
grub rescue>

Any idea what went wrong?

-- 
Len Sorensen


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-07-29 15:36 ` Lennart Sorensen
@ 2010-07-29 15:57   ` Doug Nazar
  2010-07-29 16:52     ` David Miller
  2010-07-29 16:57     ` Lennart Sorensen
  2010-07-29 17:08   ` Doug Nazar
  1 sibling, 2 replies; 14+ messages in thread
From: Doug Nazar @ 2010-07-29 15:57 UTC (permalink / raw)
  To: Lennart Sorensen; +Cc: grub-devel

  On 2010-07-29 11:36 AM, Lennart Sorensen wrote:
>
> I removed the nvalias's and got:
>
> 0>  boot /pci@800000020000200/pci1014,02BD@1/sas/disk@20000 |
I'm guessing the ',' throws everything for a loop. Grub is probably 
interpreting it as a partition. Interesting little quirk. Have to think 
about how to handle that. Escaping is probably too intrusive. I guess 
substitution or abandon the idea.

How common is it not to have nvalias's? Is that usual operating procedure?

Doug



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-07-29 15:57   ` Doug Nazar
@ 2010-07-29 16:52     ` David Miller
  2010-07-29 16:59       ` Lennart Sorensen
  2010-07-29 16:57     ` Lennart Sorensen
  1 sibling, 1 reply; 14+ messages in thread
From: David Miller @ 2010-07-29 16:52 UTC (permalink / raw)
  To: grub-devel, nazard.michi; +Cc: lsorense

From: Doug Nazar <nazard.michi@gmail.com>
Date: Thu, 29 Jul 2010 11:57:50 -0400

> How common is it not to have nvalias's? Is that usual operating
> procedure?

FWIW, I've never seen this on a sparc64 system, ever.


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-07-29 15:57   ` Doug Nazar
  2010-07-29 16:52     ` David Miller
@ 2010-07-29 16:57     ` Lennart Sorensen
  1 sibling, 0 replies; 14+ messages in thread
From: Lennart Sorensen @ 2010-07-29 16:57 UTC (permalink / raw)
  To: Doug Nazar; +Cc: grub-devel, Lennart Sorensen

On Thu, Jul 29, 2010 at 11:57:50AM -0400, Doug Nazar wrote:
> I'm guessing the ',' throws everything for a loop. Grub is probably  
> interpreting it as a partition. Interesting little quirk. Have to think  
> about how to handle that. Escaping is probably too intrusive. I guess  
> substitution or abandon the idea.
>
> How common is it not to have nvalias's? Is that usual operating procedure?

As far as I can tell, on an IBM it is not normally done, although you can.

I am personally fine having to do it to get the box working, which it
now does.  Everything else currently works (well except grub-install
which is currently clueless about IBM machines, but I filled a bug with
details on that).

-- 
Len Sorensen


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-07-29 16:52     ` David Miller
@ 2010-07-29 16:59       ` Lennart Sorensen
  2010-07-29 17:28         ` David Miller
  0 siblings, 1 reply; 14+ messages in thread
From: Lennart Sorensen @ 2010-07-29 16:59 UTC (permalink / raw)
  To: David Miller; +Cc: grub-devel, lsorense, nazard.michi

On Thu, Jul 29, 2010 at 09:52:18AM -0700, David Miller wrote:
> From: Doug Nazar <nazard.michi@gmail.com>
> Date: Thu, 29 Jul 2010 11:57:50 -0400
> 
> > How common is it not to have nvalias's? Is that usual operating
> > procedure?
> 
> FWIW, I've never seen this on a sparc64 system, ever.

So the sparc does not have devaliases by default and people don't
normally use them, or the sparc (like the powermac) automatically
creates useful devalises?

-- 
Len Sorensen


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-07-29 15:36 ` Lennart Sorensen
  2010-07-29 15:57   ` Doug Nazar
@ 2010-07-29 17:08   ` Doug Nazar
  2010-07-29 17:37     ` Lennart Sorensen
  1 sibling, 1 reply; 14+ messages in thread
From: Doug Nazar @ 2010-07-29 17:08 UTC (permalink / raw)
  To: Lennart Sorensen; +Cc: grub-devel

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

  On 2010-07-29 11:36 AM, Lennart Sorensen wrote:
>
> I removed the nvalias's and got:
>
> 0>  boot /pci@800000020000200/pci1014,02BD@1/sas/disk@20000 |

Can you add this on top? Grub already has support to escape the commas. 
Just needed to actually do it. I can't really test it here but it didn't 
break anything.

I'll let you guys decide if we should actually do this or not although 
I'm of the philosophy of "it should just work, damn it". :-)

Doug


[-- Attachment #2: grub-escape-of-path.diff --]
[-- Type: text/plain, Size: 1178 bytes --]

=== modified file 'disk/ieee1275/ofdisk.c'
--- disk/ieee1275/ofdisk.c	2010-07-29 06:04:55 +0000
+++ disk/ieee1275/ofdisk.c	2010-07-29 17:00:01 +0000
@@ -72,6 +72,39 @@
   return p;
 }
 
+static char *
+escape_of_path (const char *orig_path)
+{
+  char *new_path, *d, c;
+  const char *p;
+  int i;
+    
+  if (!grub_strchr (orig_path, ','))
+    return (char *) orig_path;
+
+  new_path = grub_malloc (grub_strlen (orig_path) + 32);
+    
+  p = orig_path;
+  d = new_path;
+  i = 0;
+  while ((c = *p++) != '\0')
+  {
+    if (c == ',')
+    {
+      if (++i == 32)
+      {
+	/* oops, too many commas */
+	break;
+      }
+      *d++ = '\\';
+    }
+    *d++ = c;
+  }
+
+  return new_path;
+}
+
+
 static int
 grub_ofdisk_iterate (int (*hook) (const char *name))
 {
@@ -114,8 +147,11 @@
       if (! grub_strcmp (alias->type, "block") &&
 	  grub_strncmp (alias->name, "cdrom", 5))
       {
+        char *name_path = use_path ? escape_of_path(alias->path) : alias->name;
 	disks_found++;
-	ret = hook (use_path ? alias->path : alias->name);
+	ret = hook (name_path);
+	if (use_path && name_path != alias->path)
+	  grub_free(name_path);
       }
       return ret;
     }


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-07-29 16:59       ` Lennart Sorensen
@ 2010-07-29 17:28         ` David Miller
  0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2010-07-29 17:28 UTC (permalink / raw)
  To: lsorense; +Cc: grub-devel, nazard.michi

From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen)
Date: Thu, 29 Jul 2010 12:59:08 -0400

> On Thu, Jul 29, 2010 at 09:52:18AM -0700, David Miller wrote:
>> From: Doug Nazar <nazard.michi@gmail.com>
>> Date: Thu, 29 Jul 2010 11:57:50 -0400
>> 
>> > How common is it not to have nvalias's? Is that usual operating
>> > procedure?
>> 
>> FWIW, I've never seen this on a sparc64 system, ever.
> 
> So the sparc does not have devaliases by default and people don't
> normally use them, or the sparc (like the powermac) automatically
> creates useful devalises?

Sparc64 always has useful aliases.


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-07-29 17:08   ` Doug Nazar
@ 2010-07-29 17:37     ` Lennart Sorensen
  2010-07-29 19:11       ` Doug Nazar
  0 siblings, 1 reply; 14+ messages in thread
From: Lennart Sorensen @ 2010-07-29 17:37 UTC (permalink / raw)
  To: The development of GNU GRUB; +Cc: Lennart Sorensen

On Thu, Jul 29, 2010 at 01:08:15PM -0400, Doug Nazar wrote:
>  On 2010-07-29 11:36 AM, Lennart Sorensen wrote:
>>
>> I removed the nvalias's and got:
>>
>> 0>  boot /pci@800000020000200/pci1014,02BD@1/sas/disk@20000 |
>
> Can you add this on top? Grub already has support to escape the commas.  
> Just needed to actually do it. I can't really test it here but it didn't  
> break anything.
>
> I'll let you guys decide if we should actually do this or not although  
> I'm of the philosophy of "it should just work, damn it". :-)

I will try to test it soon, but I just put the machine into production
use, so rebooting a lot won't be popular.  I will try to test it in
the evening.  Unfortunately I am going on vacation for a week, so it
probably won't be until after that.

Thanks for trying to fix it though.

-- 
Len Sorensen

> === modified file 'disk/ieee1275/ofdisk.c'
> --- disk/ieee1275/ofdisk.c	2010-07-29 06:04:55 +0000
> +++ disk/ieee1275/ofdisk.c	2010-07-29 17:00:01 +0000
> @@ -72,6 +72,39 @@
>    return p;
>  }
>  
> +static char *
> +escape_of_path (const char *orig_path)
> +{
> +  char *new_path, *d, c;
> +  const char *p;
> +  int i;
> +    
> +  if (!grub_strchr (orig_path, ','))
> +    return (char *) orig_path;
> +
> +  new_path = grub_malloc (grub_strlen (orig_path) + 32);
> +    
> +  p = orig_path;
> +  d = new_path;
> +  i = 0;
> +  while ((c = *p++) != '\0')
> +  {
> +    if (c == ',')
> +    {
> +      if (++i == 32)
> +      {
> +	/* oops, too many commas */
> +	break;
> +      }
> +      *d++ = '\\';
> +    }
> +    *d++ = c;
> +  }
> +
> +  return new_path;
> +}
> +
> +
>  static int
>  grub_ofdisk_iterate (int (*hook) (const char *name))
>  {
> @@ -114,8 +147,11 @@
>        if (! grub_strcmp (alias->type, "block") &&
>  	  grub_strncmp (alias->name, "cdrom", 5))
>        {
> +        char *name_path = use_path ? escape_of_path(alias->path) : alias->name;
>  	disks_found++;
> -	ret = hook (use_path ? alias->path : alias->name);
> +	ret = hook (name_path);
> +	if (use_path && name_path != alias->path)
> +	  grub_free(name_path);
>        }
>        return ret;
>      }
> 



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-07-29 17:37     ` Lennart Sorensen
@ 2010-07-29 19:11       ` Doug Nazar
  0 siblings, 0 replies; 14+ messages in thread
From: Doug Nazar @ 2010-07-29 19:11 UTC (permalink / raw)
  To: grub-devel

  On 2010-07-29 1:37 PM, Lennart Sorensen wrote:
> I will try to test it soon, but I just put the machine into production
> use, so rebooting a lot won't be popular.  I will try to test it in
> the evening.  Unfortunately I am going on vacation for a week, so it
> probably won't be until after that.
>
> Thanks for trying to fix it though.
>
No problem. I was having fun..... :-)

I'm gonna try hacking on OpenBios for a bit. I should be able to get an 
older version working and then I can fix a few annoying things and I'll 
be able to inject a comma into a devpath as a test. However I don't know 
if that's what was in fact crashing your box.

Doug



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-07-29  6:21 Fallback to scanning OF tree if no devaliases Doug Nazar
  2010-07-29 15:36 ` Lennart Sorensen
@ 2010-08-01 14:48 ` Vladimir 'φ-coder/phcoder' Serbinenko
  2010-08-09 15:41   ` Lennart Sorensen
  1 sibling, 1 reply; 14+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2010-08-01 14:48 UTC (permalink / raw)
  To: grub-devel

[-- Attachment #1: Type: text/plain, Size: 1699 bytes --]

As I already told on IRC such a behaviour isn't of a good design. A
simple example is when one add a devalias and then all other disks
disappear. Moreover in experimental branch I have a solution for such a
problem: we scan all the devices and then show only the simpliest form.
That code just needs some testing. Could you do that? I'm sorry for not
having been available for last few days and this resulted in a mountain
of useless work by Doug and Lennart. I assume that the rest of this
thread is a discussion of this issue and is moot given the code which is
already in experimental. If it's not a case please start a new thread
per issue
On 07/29/2010 08:21 AM, Doug Nazar wrote:
>  Lennart, try giving this patch a whirl. In the case after we scan the
> aliases list and we haven't found any block devices it will now try to
> scan the entire tree. It kinda worked under OpenBios although I ran
> into another bug where it can't open a device path that it gave me for
> the pci ide controller. It found the other 2 drives fine.
>
> I think this maintains the correct balance of using short pretty names
> if available but working if they are not available.
>
> There is a case where it will mess up however. If you only specify an
> alias for one device but need another device to build a raid or lvm it
> will fail. Although, thinking about it, this already would happen.
>
> As always, you can specify the either path manually.
>
> Doug
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-08-01 14:48 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2010-08-09 15:41   ` Lennart Sorensen
  2010-08-09 16:09     ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 1 reply; 14+ messages in thread
From: Lennart Sorensen @ 2010-08-09 15:41 UTC (permalink / raw)
  To: The development of GNU GRUB

On Sun, Aug 01, 2010 at 04:48:04PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> As I already told on IRC such a behaviour isn't of a good design. A
> simple example is when one add a devalias and then all other disks
> disappear. Moreover in experimental branch I have a solution for such a
> problem: we scan all the devices and then show only the simpliest form.
> That code just needs some testing. Could you do that? I'm sorry for not
> having been available for last few days and this resulted in a mountain
> of useless work by Doug and Lennart. I assume that the rest of this
> thread is a discussion of this issue and is moot given the code which is
> already in experimental. If it's not a case please start a new thread
> per issue

Where do I find that?  I would love to test it.

I currently have the machine down because someone made a mistake that
killed the box (or so they thought).  Nothing actually wrong with the
box fortunately, but it means I can spend a few hours testing things
before getting back to normal use again.

-- 
Len Sorensen


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-08-09 15:41   ` Lennart Sorensen
@ 2010-08-09 16:09     ` Vladimir 'φ-coder/phcoder' Serbinenko
  2010-08-09 17:01       ` Lennart Sorensen
  0 siblings, 1 reply; 14+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2010-08-09 16:09 UTC (permalink / raw)
  To: grub-devel

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

On 08/09/2010 05:41 PM, Lennart Sorensen wrote:
> On Sun, Aug 01, 2010 at 04:48:04PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>   
>> As I already told on IRC such a behaviour isn't of a good design. A
>> simple example is when one add a devalias and then all other disks
>> disappear. Moreover in experimental branch I have a solution for such a
>> problem: we scan all the devices and then show only the simpliest form.
>> That code just needs some testing. Could you do that? I'm sorry for not
>> having been available for last few days and this resulted in a mountain
>> of useless work by Doug and Lennart. I assume that the rest of this
>> thread is a discussion of this issue and is moot given the code which is
>> already in experimental. If it's not a case please start a new thread
>> per issue
>>     
> Where do I find that?  I would love to test it.
>
>   
BZR checkout from http://bzr.savannah.gnu.org/r/grub/branches/experimental/
I'm especially interested in testing on multi-disk config (both my OFW
boxes have only one disk)
> I currently have the machine down because someone made a mistake that
> killed the box (or so they thought).  Nothing actually wrong with the
> box fortunately, but it means I can spend a few hours testing things
> before getting back to normal use again.
>
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Fallback to scanning OF tree if no devaliases
  2010-08-09 16:09     ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2010-08-09 17:01       ` Lennart Sorensen
  0 siblings, 0 replies; 14+ messages in thread
From: Lennart Sorensen @ 2010-08-09 17:01 UTC (permalink / raw)
  To: The development of GNU GRUB

On Mon, Aug 09, 2010 at 06:09:10PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> BZR checkout from http://bzr.savannah.gnu.org/r/grub/branches/experimental/
> I'm especially interested in testing on multi-disk config (both my OFW
> boxes have only one disk)

I will see if I can get that built somehow and try it (I am running dual
disk for raid1).

-- 
Len Sorensen


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2010-08-09 17:01 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-29  6:21 Fallback to scanning OF tree if no devaliases Doug Nazar
2010-07-29 15:36 ` Lennart Sorensen
2010-07-29 15:57   ` Doug Nazar
2010-07-29 16:52     ` David Miller
2010-07-29 16:59       ` Lennart Sorensen
2010-07-29 17:28         ` David Miller
2010-07-29 16:57     ` Lennart Sorensen
2010-07-29 17:08   ` Doug Nazar
2010-07-29 17:37     ` Lennart Sorensen
2010-07-29 19:11       ` Doug Nazar
2010-08-01 14:48 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-08-09 15:41   ` Lennart Sorensen
2010-08-09 16:09     ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-08-09 17:01       ` Lennart Sorensen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.