From: Avi Kivity <avi@redhat.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Alexander Graf <agraf@suse.de>,
Joerg Roedel <joerg.roedel@amd.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features
Date: Sun, 12 Sep 2010 08:05:55 +0200 [thread overview]
Message-ID: <4C8C6DC3.9030009@redhat.com> (raw)
In-Reply-To: <20100911142018.GA680@8bytes.org>
On 09/11/2010 05:20 PM, Joerg Roedel wrote:
> On Sat, Sep 11, 2010 at 03:43:02PM +0200, Alexander Graf wrote:
>>> @@ -305,6 +322,8 @@ static x86_def_t builtin_x86_defs[] = {
>>> CPUID_EXT3_OSVW, CPUID_EXT3_IBS */
>>> .ext3_features = CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM |
>>> CPUID_EXT3_ABM | CPUID_EXT3_SSE4A,
>>> + .svm_features = CPUID_SVM_NPT | CPUID_SVM_LBRV | CPUID_SVM_NRIPSAVE |
>>> + CPUID_SVM_VMCBCLEAN,
>> Does that phenom already do all those? It does NPT, but I'm not sure
>> about NRIPSAVE for example.
> Depends on which Phenom you have. A Phenom II has NRIPSAVE but the old
> Phenoms don't have it. For the SVM features it is not that important
> what the host hardware supports but what KVM can emulate. VMCBCLEAN can
> be emulated without supporting it in the host for example.
Well, let's have a phenom2 type for those new features (and any other
features the phenom 2 has). What's the point of using the name of
existing hardware if it doesn't match that hardware?
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Alexander Graf <agraf@suse.de>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features
Date: Sun, 12 Sep 2010 08:05:55 +0200 [thread overview]
Message-ID: <4C8C6DC3.9030009@redhat.com> (raw)
In-Reply-To: <20100911142018.GA680@8bytes.org>
On 09/11/2010 05:20 PM, Joerg Roedel wrote:
> On Sat, Sep 11, 2010 at 03:43:02PM +0200, Alexander Graf wrote:
>>> @@ -305,6 +322,8 @@ static x86_def_t builtin_x86_defs[] = {
>>> CPUID_EXT3_OSVW, CPUID_EXT3_IBS */
>>> .ext3_features = CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM |
>>> CPUID_EXT3_ABM | CPUID_EXT3_SSE4A,
>>> + .svm_features = CPUID_SVM_NPT | CPUID_SVM_LBRV | CPUID_SVM_NRIPSAVE |
>>> + CPUID_SVM_VMCBCLEAN,
>> Does that phenom already do all those? It does NPT, but I'm not sure
>> about NRIPSAVE for example.
> Depends on which Phenom you have. A Phenom II has NRIPSAVE but the old
> Phenoms don't have it. For the SVM features it is not that important
> what the host hardware supports but what KVM can emulate. VMCBCLEAN can
> be emulated without supporting it in the host for example.
Well, let's have a phenom2 type for those new features (and any other
features the phenom 2 has). What's the point of using the name of
existing hardware if it doesn't match that hardware?
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-09-12 6:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 15:38 [PATCH 0/2] Add SVM feature flags to qemu Joerg Roedel
2010-09-10 15:38 ` [Qemu-devel] " Joerg Roedel
2010-09-10 15:38 ` [PATCH 1/2] qemu-kvm: Set cpuid definition to 0 before initializing it Joerg Roedel
2010-09-10 15:38 ` [Qemu-devel] " Joerg Roedel
2010-09-10 15:38 ` [PATCH 2/2] qemu-kvm: Add svm cpuid features Joerg Roedel
2010-09-10 15:38 ` [Qemu-devel] " Joerg Roedel
2010-09-11 13:43 ` Alexander Graf
2010-09-11 13:43 ` Alexander Graf
2010-09-11 14:20 ` Joerg Roedel
2010-09-11 14:20 ` Joerg Roedel
2010-09-11 14:29 ` Alexander Graf
2010-09-11 14:29 ` Alexander Graf
2010-09-11 14:36 ` Joerg Roedel
2010-09-11 14:36 ` Joerg Roedel
2010-09-11 14:38 ` Alexander Graf
2010-09-11 14:38 ` Alexander Graf
2010-09-11 14:42 ` Joerg Roedel
2010-09-11 14:42 ` Joerg Roedel
2010-09-11 14:45 ` Alexander Graf
2010-09-11 14:45 ` Alexander Graf
2010-09-12 6:05 ` Avi Kivity [this message]
2010-09-12 6:05 ` Avi Kivity
2010-09-12 7:16 ` Alexander Graf
2010-09-12 7:16 ` Alexander Graf
2010-09-12 8:01 ` Avi Kivity
2010-09-12 8:01 ` Avi Kivity
2010-09-12 10:06 ` Alexander Graf
2010-09-12 10:06 ` Alexander Graf
2010-09-12 10:22 ` Avi Kivity
2010-09-12 10:22 ` Avi Kivity
2010-09-12 11:14 ` Alexander Graf
2010-09-12 11:14 ` Alexander Graf
2010-09-12 12:02 ` Avi Kivity
2010-09-12 12:02 ` Avi Kivity
2010-09-12 14:30 ` Joerg Roedel
2010-09-12 14:30 ` Joerg Roedel
2010-09-12 14:36 ` Avi Kivity
2010-09-12 14:36 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2010-09-18 22:16 garymberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8C6DC3.9030009@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=joerg.roedel@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.