All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Joerg Roedel <joro@8bytes.org>,
	Joerg Roedel <joerg.roedel@amd.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features
Date: Sun, 12 Sep 2010 12:22:16 +0200	[thread overview]
Message-ID: <4C8CA9D8.4020102@redhat.com> (raw)
In-Reply-To: <EE267C74-95C7-43B6-8070-8CEACAB60610@suse.de>

  On 09/12/2010 12:06 PM, Alexander Graf wrote:
>>> For the Phenom type, I honestly don't remember why, but there was also a good reason to add it. In fact, I use it today to have nested virt without -cpu host on hardware that's too new for my guests.
>> Curious, what guests balk at modern hardware but are fine with phenom?
> Sles11 GA ;).

Still curious, how does -cpu host break it?

>>> Either way, I don't think we need a phenom2 type. The features additional are minor enough to not really matter and all use cases I can come up with require either -cpu host (local virt) or -cpu phenom (migration).
>> I'm fine with this (or with adding phenom2).  But don't make phenom contain flags that real phenoms don't have.
> Those were my words :).

Then we are in agreement.

-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
	Joerg Roedel <joro@8bytes.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features
Date: Sun, 12 Sep 2010 12:22:16 +0200	[thread overview]
Message-ID: <4C8CA9D8.4020102@redhat.com> (raw)
In-Reply-To: <EE267C74-95C7-43B6-8070-8CEACAB60610@suse.de>

  On 09/12/2010 12:06 PM, Alexander Graf wrote:
>>> For the Phenom type, I honestly don't remember why, but there was also a good reason to add it. In fact, I use it today to have nested virt without -cpu host on hardware that's too new for my guests.
>> Curious, what guests balk at modern hardware but are fine with phenom?
> Sles11 GA ;).

Still curious, how does -cpu host break it?

>>> Either way, I don't think we need a phenom2 type. The features additional are minor enough to not really matter and all use cases I can come up with require either -cpu host (local virt) or -cpu phenom (migration).
>> I'm fine with this (or with adding phenom2).  But don't make phenom contain flags that real phenoms don't have.
> Those were my words :).

Then we are in agreement.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2010-09-12 10:22 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10 15:38 [PATCH 0/2] Add SVM feature flags to qemu Joerg Roedel
2010-09-10 15:38 ` [Qemu-devel] " Joerg Roedel
2010-09-10 15:38 ` [PATCH 1/2] qemu-kvm: Set cpuid definition to 0 before initializing it Joerg Roedel
2010-09-10 15:38   ` [Qemu-devel] " Joerg Roedel
2010-09-10 15:38 ` [PATCH 2/2] qemu-kvm: Add svm cpuid features Joerg Roedel
2010-09-10 15:38   ` [Qemu-devel] " Joerg Roedel
2010-09-11 13:43   ` Alexander Graf
2010-09-11 13:43     ` Alexander Graf
2010-09-11 14:20     ` Joerg Roedel
2010-09-11 14:20       ` Joerg Roedel
2010-09-11 14:29       ` Alexander Graf
2010-09-11 14:29         ` Alexander Graf
2010-09-11 14:36         ` Joerg Roedel
2010-09-11 14:36           ` Joerg Roedel
2010-09-11 14:38           ` Alexander Graf
2010-09-11 14:38             ` Alexander Graf
2010-09-11 14:42             ` Joerg Roedel
2010-09-11 14:42               ` Joerg Roedel
2010-09-11 14:45               ` Alexander Graf
2010-09-11 14:45                 ` Alexander Graf
2010-09-12  6:05       ` Avi Kivity
2010-09-12  6:05         ` Avi Kivity
2010-09-12  7:16         ` Alexander Graf
2010-09-12  7:16           ` Alexander Graf
2010-09-12  8:01           ` Avi Kivity
2010-09-12  8:01             ` Avi Kivity
2010-09-12 10:06             ` Alexander Graf
2010-09-12 10:06               ` Alexander Graf
2010-09-12 10:22               ` Avi Kivity [this message]
2010-09-12 10:22                 ` Avi Kivity
2010-09-12 11:14                 ` Alexander Graf
2010-09-12 11:14                   ` Alexander Graf
2010-09-12 12:02                   ` Avi Kivity
2010-09-12 12:02                     ` Avi Kivity
2010-09-12 14:30             ` Joerg Roedel
2010-09-12 14:30               ` Joerg Roedel
2010-09-12 14:36               ` Avi Kivity
2010-09-12 14:36                 ` Avi Kivity
  -- strict thread matches above, loose matches on Subject: below --
2010-09-18 22:16 garymberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8CA9D8.4020102@redhat.com \
    --to=avi@redhat.com \
    --cc=agraf@suse.de \
    --cc=joerg.roedel@amd.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.