[PATCH] Remove dbus support from wvstreams-4.6 because it breaks the build

[PATCH] Remove dbus support from wvstreams-4.6 because it breaks the build

[Thilo Fromm]

If wvstreams is configured with DBus support enabled (by not providing
--without-dbus) the the build fails at link time as libdbus cannot be
found:

| ./CXX -c dbus/wvdbusconn
| ./CXX -c dbus/wvdbusmarshal
| ./CXX -c dbus/wvdbusmsg
| ./CXX -c dbus/wvdbusserver
| linking libwvdbus.so...
| arm-angstrom-linux-gnueabi-g++: /libdbus-1.a: No such file or
directory
| make: *** [libwvdbus.so] Error 1
| FATAL: oe_runmake failed
NOTE: Task failed:
/SCRATCH/maniac/oe-merge-test/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/wvstreams-4.6-r0/temp/log.do_compile.6422
ERROR: TaskFailed event exception, aborting
ERROR: Build of
/home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb
do_compile failed
ERROR: Task 2024
(/home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb,
 do_compile) failed

The root cause for this behaviour is in wvstreams' configure.ac; the
weird dbus detection and library path handling breaks successive builds.

This patch, however, does not fix the configure.ac file but disables
DBus support for wvstreams at configure time. This at least fixes the
broken build.

Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
---
 recipes/wvstreams/wvstreams_4.6.bb |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/recipes/wvstreams/wvstreams_4.6.bb b/recipes/wvstreams/wvstreams_4.6.bb
index 91abc7d..b298a97 100644
--- a/recipes/wvstreams/wvstreams_4.6.bb
+++ b/recipes/wvstreams/wvstreams_4.6.bb
@@ -1,7 +1,7 @@
 HOMEPAGE = "http://alumnit.ca/wiki/index.php?page=WvStreams"
 LICENSE = "LGPL"
 DESCRIPTION = "WvStreams is a network programming library in C++"
-DEPENDS = "zlib openssl (>= 0.9.8)"
+DEPENDS = "zlib openssl (>= 0.9.8) dbus (> 1.2.14)"
 
 SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \
 	"
@@ -10,7 +10,8 @@ inherit autotools pkgconfig
 
 LDFLAGS_append = " -Wl,-rpath-link,${TOOLCHAIN_PATH}/${TARGET_SYS}/lib"
 
-EXTRA_OECONF = " --without-tcl --without-qt --without-pam"
+# tfm: dbus build currently broken
+EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"
 
 PACKAGES_prepend = "libuniconf libuniconf-dbg "
 PACKAGES_prepend = "uniconfd uniconfd-dbg "
-- 
1.7.0.4

Re: [PATCH] Remove dbus support from wvstreams-4.6 because it breaks the build

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 3174 bytes --]

Dear Thilo,


please adhere to the commit policy regarding the commit summary, i. e.,
it has to start with the package name.

wvstreams-4.6: remove DBus support, because configure.ac is faulty.

Am Dienstag, den 28.09.2010, 09:28 +0200 schrieb Thilo Fromm:
> If wvstreams is configured with DBus support enabled (by not providing
> --without-dbus) the the build fails at link time as libdbus cannot be
> found:
> 
> | ./CXX -c dbus/wvdbusconn
> | ./CXX -c dbus/wvdbusmarshal
> | ./CXX -c dbus/wvdbusmsg
> | ./CXX -c dbus/wvdbusserver
> | linking libwvdbus.so...
> | arm-angstrom-linux-gnueabi-g++: /libdbus-1.a: No such file or
> directory

Can your editor be configured to not add line breaks to quotes? I would
prefer that.

> | make: *** [libwvdbus.so] Error 1
> | FATAL: oe_runmake failed
> NOTE: Task failed:
> /SCRATCH/maniac/oe-merge-test/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/wvstreams-4.6-r0/temp/log.do_compile.6422
> ERROR: TaskFailed event exception, aborting
> ERROR: Build of
> /home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb
> do_compile failed
> ERROR: Task 2024
> (/home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb,
>  do_compile) failed
> 
> The root cause for this behaviour is in wvstreams' configure.ac; the
> weird dbus detection and library path handling breaks successive builds.
> 
> This patch, however, does not fix the configure.ac file but disables
> DBus support for wvstreams at configure time. This at least fixes the
> broken build.
> 
> Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
> ---
>  recipes/wvstreams/wvstreams_4.6.bb |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/wvstreams/wvstreams_4.6.bb b/recipes/wvstreams/wvstreams_4.6.bb
> index 91abc7d..b298a97 100644
> --- a/recipes/wvstreams/wvstreams_4.6.bb
> +++ b/recipes/wvstreams/wvstreams_4.6.bb
> @@ -1,7 +1,7 @@
>  HOMEPAGE = "http://alumnit.ca/wiki/index.php?page=WvStreams"
>  LICENSE = "LGPL"
>  DESCRIPTION = "WvStreams is a network programming library in C++"
> -DEPENDS = "zlib openssl (>= 0.9.8)"
> +DEPENDS = "zlib openssl (>= 0.9.8) dbus (> 1.2.14)"

Since you remove DBus support, can this dependency be removed? Maybe add
a note to the comment below to not forget to put `dbus` into `DEPENDS`.
 
>  SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \
>  	"
> @@ -10,7 +10,8 @@ inherit autotools pkgconfig
>  
>  LDFLAGS_append = " -Wl,-rpath-link,${TOOLCHAIN_PATH}/${TARGET_SYS}/lib"
>  
> -EXTRA_OECONF = " --without-tcl --without-qt --without-pam"
> +# tfm: dbus build currently broken
> +EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"
>  
>  PACKAGES_prepend = "libuniconf libuniconf-dbg "
>  PACKAGES_prepend = "uniconfd uniconfd-dbg "

I think you also need to increment `PR`.

Can you resend the patch as v2 (`--subject-prefix in `git help
format-patch`) and update the status in the patch queue [2].


Thanks,

Paul


[1] http://wiki.openembedded.net/index.php/Commit_Policy
[2] http://wiki.openembedded.net/index.php/Patchwork

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

[v2] wvstreams-4.6: Remove dbus support because it breaks the build

[Thilo Fromm]

From: t.fromm <t.fromm@ba11ecae-741b-462f-8724-1218f99f5906>

If wvstreams is configured with DBus support enabled (by not providing
--without-dbus) the the build fails at link time as libdbus cannot be
found:

| ./CXX -c dbus/wvdbusconn
| ./CXX -c dbus/wvdbusmarshal
| ./CXX -c dbus/wvdbusmsg
| ./CXX -c dbus/wvdbusserver
| linking libwvdbus.so...
| arm-angstrom-linux-gnueabi-g++: /libdbus-1.a: No such file or directory
| make: *** [libwvdbus.so] Error 1
| FATAL: oe_runmake failed
NOTE: Task failed: /SCRATCH/maniac/oe-merge-test/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/wvstreams-4.6-r0/temp/log.do_compile.6422
ERROR: TaskFailed event exception, aborting
ERROR: Build of /home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
ERROR: Task 2024 (/home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed

The root cause for this behaviour is in wvstreams' configure.ac; the
weird dbus detection and library path handling breaks successive builds.

This patch, however, does not fix the configure.ac file but disables
DBus support for wvstreams at configure time. This at least fixes the
broken build.

Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
---
 recipes/wvstreams/wvstreams_4.6.bb |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/recipes/wvstreams/wvstreams_4.6.bb b/recipes/wvstreams/wvstreams_4.6.bb
index 91abc7d..688a80f 100644
--- a/recipes/wvstreams/wvstreams_4.6.bb
+++ b/recipes/wvstreams/wvstreams_4.6.bb
@@ -3,6 +3,8 @@ LICENSE = "LGPL"
 DESCRIPTION = "WvStreams is a network programming library in C++"
 DEPENDS = "zlib openssl (>= 0.9.8)"
 
+PR = "r2"
+
 SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \
 	"
 
@@ -10,7 +12,8 @@ inherit autotools pkgconfig
 
 LDFLAGS_append = " -Wl,-rpath-link,${TOOLCHAIN_PATH}/${TARGET_SYS}/lib"
 
-EXTRA_OECONF = " --without-tcl --without-qt --without-pam"
+# dbus detection currently broken in configure.ac; remember to add "dbus (>= 1.2.14)" to DEPENDS  when fixed
+EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"
 
 PACKAGES_prepend = "libuniconf libuniconf-dbg "
 PACKAGES_prepend = "uniconfd uniconfd-dbg "
-- 
1.7.0.4

Re: [v2] wvstreams-4.6: Remove dbus support because it breaks the build

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 3054 bytes --]

Do you know, if and how »PATCH« got stripped in the subject? Without it,
Patchwork will not pick it up, I think.


Am Dienstag, den 28.09.2010, 10:12 +0200 schrieb Thilo Fromm:
> From: t.fromm <t.fromm@ba11ecae-741b-462f-8724-1218f99f5906>

Where does that line come from. Did you send this patch from the same
system and did you configure git correctly?

	git config user.name Thilo Fromm
	git config user.email t.fromm@dresearch.de

It is just a cosmetic error, but this line will be shown in the commit
history and used for the weekly changelog generation.

> If wvstreams is configured with DBus support enabled (by not providing
> --without-dbus) the the build fails at link time as libdbus cannot be
> found:
> 
> | ./CXX -c dbus/wvdbusconn
> | ./CXX -c dbus/wvdbusmarshal
> | ./CXX -c dbus/wvdbusmsg
> | ./CXX -c dbus/wvdbusserver
> | linking libwvdbus.so...
> | arm-angstrom-linux-gnueabi-g++: /libdbus-1.a: No such file or directory
> | make: *** [libwvdbus.so] Error 1
> | FATAL: oe_runmake failed
> NOTE: Task failed: /SCRATCH/maniac/oe-merge-test/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/wvstreams-4.6-r0/temp/log.do_compile.6422
> ERROR: TaskFailed event exception, aborting
> ERROR: Build of /home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
> ERROR: Task 2024 (/home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed
> 
> The root cause for this behaviour is in wvstreams' configure.ac; the
> weird dbus detection and library path handling breaks successive builds.
> 
> This patch, however, does not fix the configure.ac file but disables
> DBus support for wvstreams at configure time. This at least fixes the
> broken build.
> 
> Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
> ---
>  recipes/wvstreams/wvstreams_4.6.bb |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/wvstreams/wvstreams_4.6.bb b/recipes/wvstreams/wvstreams_4.6.bb
> index 91abc7d..688a80f 100644
> --- a/recipes/wvstreams/wvstreams_4.6.bb
> +++ b/recipes/wvstreams/wvstreams_4.6.bb
> @@ -3,6 +3,8 @@ LICENSE = "LGPL"
>  DESCRIPTION = "WvStreams is a network programming library in C++"
>  DEPENDS = "zlib openssl (>= 0.9.8)"
>  
> +PR = "r2"
> +

I think `PR` starts at 0 by default.

>  SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \
>  	"
>  
> @@ -10,7 +12,8 @@ inherit autotools pkgconfig
>  
>  LDFLAGS_append = " -Wl,-rpath-link,${TOOLCHAIN_PATH}/${TARGET_SYS}/lib"
>  
> -EXTRA_OECONF = " --without-tcl --without-qt --without-pam"
> +# dbus detection currently broken in configure.ac; remember to add "dbus (>= 1.2.14)" to DEPENDS  when fixed
> +EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"
>  
>  PACKAGES_prepend = "libuniconf libuniconf-dbg "
>  PACKAGES_prepend = "uniconfd uniconfd-dbg "

Just a question. Do you know if the other version of wvstreams suffer
from the same problem?


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [v2] wvstreams-4.6: Remove dbus support because it breaks the build

[Thilo Fromm]

Helo Paul,

> Do you know, if and how »PATCH« got stripped in the subject? Without it,
> Patchwork will not pick it up, I think.

It got stripped because of your recommendation to use 
--subject-prefix="v2". The "How to submit a patch to OpenEmbedded" wiki 
page at 
<http://wiki.openembedded.net/index.php/How_to_submit_a_patch_to_OpenEmbedded#Create_and_Commit_your_patch> 
recommends the same.

Anyway, the patch got picked up by patchwork.

>> From: t.fromm<t.fromm@ba11ecae-741b-462f-8724-1218f99f5906>
>
> Where does that line come from. Did you send this patch from the same
> system and did you configure git correctly?
>
> 	git config user.name Thilo Fromm
> 	git config user.email t.fromm@dresearch.de
>
> It is just a cosmetic error, but this line will be shown in the commit
> history and used for the weekly changelog generation.

I have these two config fields set up exactly like this. Git, however, 
chooses to generate a mail with two From: header lines.

>> If wvstreams is configured with DBus support enabled (by not providing
>> --without-dbus) the the build fails at link time as libdbus cannot be
>> found:
>>
>> | ./CXX -c dbus/wvdbusconn
>> | ./CXX -c dbus/wvdbusmarshal
>> | ./CXX -c dbus/wvdbusmsg

[...]

>>
>> +PR = "r2"
>> +
>
> I think `PR` starts at 0 by default.

Well, I though this recipe was already *there* before I started, so it's 
not a "r0". But all right, I'll reset this ro "r0" in [v3].

>
>>   SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \
>>   	"
>>
>> @@ -10,7 +12,8 @@ inherit autotools pkgconfig
>>
>>   LDFLAGS_append = " -Wl,-rpath-link,${TOOLCHAIN_PATH}/${TARGET_SYS}/lib"
>>
>> -EXTRA_OECONF = " --without-tcl --without-qt --without-pam"
>> +# dbus detection currently broken in configure.ac; remember to add "dbus (>= 1.2.14)" to DEPENDS  when fixed
>> +EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"
>>
>>   PACKAGES_prepend = "libuniconf libuniconf-dbg "
>>   PACKAGES_prepend = "uniconfd uniconfd-dbg "
>
> Just a question. Do you know if the other version of wvstreams suffer
> from the same problem?

Nope, no idea. I am merely trying to get one single build from start to 
finish, but OpenEmbeddded keeps breaking all the time. I've been doing 
this for about a week now without success.

Given the current (in)stability of the build framework I think I'm far, 
far away from a system state reliable enough to even think about the 
cross-versioning build tests you're suggesting.

Regards, Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle

Re: [v2] wvstreams-4.6: Remove dbus support because it breaks the build

[Thilo Fromm]

Hello Paul,

>>> From: t.fromm<t.fromm@ba11ecae-741b-462f-8724-1218f99f5906>
>>
>> Where does that line come from. Did you send this patch from the same
>> system and did you configure git correctly?
>>
>> git config user.name Thilo Fromm
>> git config user.email t.fromm@dresearch.de
>>
>> It is just a cosmetic error, but this line will be shown in the commit
>> history and used for the weekly changelog generation.
>
> I have these two config fields set up exactly like this. Git, however,
> chooses to generate a mail with two From: header lines.

Wait, I got it - I had to reset the original author. I committed this 
patch before I configured my git to use a real email address.



Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle

Re: [v2] wvstreams-4.6: Remove dbus support because it breaks the build

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 3155 bytes --]

Dear Thilo,


Am Dienstag, den 28.09.2010, 11:08 +0200 schrieb Thilo Fromm:

> > Do you know, if and how »PATCH« got stripped in the subject? Without it,
> > Patchwork will not pick it up, I think.
> 
> It got stripped because of your recommendation to use 
> --subject-prefix="v2". The "How to submit a patch to OpenEmbedded" wiki 
> page at 
> <http://wiki.openembedded.net/index.php/How_to_submit_a_patch_to_OpenEmbedded#Create_and_Commit_your_patch> 
> recommends the same.

I see. Thank you for clarification. I always thought `--subject-prefix`
got added after »PATCH«.

> Anyway, the patch got picked up by patchwork.

Good. Probably because you replied and it stayed in the thread.

> >> From: t.fromm<t.fromm@ba11ecae-741b-462f-8724-1218f99f5906>
> >
> > Where does that line come from. Did you send this patch from the same
> > system and did you configure git correctly?
> >
> > 	git config user.name Thilo Fromm
> > 	git config user.email t.fromm@dresearch.de
> >
> > It is just a cosmetic error, but this line will be shown in the commit
> > history and used for the weekly changelog generation.
> 
> I have these two config fields set up exactly like this. Git, however, 
> chooses to generate a mail with two From: header lines.

Strange Maybe you can take a look in `~/.gitconfig` and `.git/config` in
your local repository.

> >> If wvstreams is configured with DBus support enabled (by not providing
> >> --without-dbus) the the build fails at link time as libdbus cannot be
> >> found:
> >>
> >> | ./CXX -c dbus/wvdbusconn
> >> | ./CXX -c dbus/wvdbusmarshal
> >> | ./CXX -c dbus/wvdbusmsg
> 
> [...]
> 
> >>
> >> +PR = "r2"
> >> +
> >
> > I think `PR` starts at 0 by default.
> 
> Well, I though this recipe was already *there* before I started, so it's 
> not a "r0". But all right, I'll reset this ro "r0" in [v3].

No I meant you can set it to »r1«.

> >>   SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \
> >>   	"
> >>
> >> @@ -10,7 +12,8 @@ inherit autotools pkgconfig
> >>
> >>   LDFLAGS_append = " -Wl,-rpath-link,${TOOLCHAIN_PATH}/${TARGET_SYS}/lib"
> >>
> >> -EXTRA_OECONF = " --without-tcl --without-qt --without-pam"
> >> +# dbus detection currently broken in configure.ac; remember to add "dbus (>= 1.2.14)" to DEPENDS  when fixed
> >> +EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"
> >>
> >>   PACKAGES_prepend = "libuniconf libuniconf-dbg "
> >>   PACKAGES_prepend = "uniconfd uniconfd-dbg "
> >
> > Just a question. Do you know if the other version of wvstreams suffer
> > from the same problem?
> 
> Nope, no idea. I am merely trying to get one single build from start to 
> finish, but OpenEmbeddded keeps breaking all the time. I've been doing 
> this for about a week now without success.
> 
> Given the current (in)stability of the build framework I think I'm far, 
> far away from a system state reliable enough to even think about the 
> cross-versioning build tests you're suggesting.

Good luck with your builds and thank you for your contribution.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

[v4] wvstreams-4.6: Remove dbus support (breaks build)

[Thilo Fromm]

If wvstreams is configured with DBus support enabled (by not providing
--without-dbus) the the build fails at link time as libdbus cannot be
found:

| ./CXX -c dbus/wvdbusconn
| ./CXX -c dbus/wvdbusmarshal
| ./CXX -c dbus/wvdbusmsg
| ./CXX -c dbus/wvdbusserver
| linking libwvdbus.so...
| arm-angstrom-linux-gnueabi-g++: /libdbus-1.a: No such file or directory
| make: *** [libwvdbus.so] Error 1
| FATAL: oe_runmake failed
NOTE: Task failed: /SCRATCH/maniac/oe-merge-test/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/wvstreams-4.6-r0/temp/log.do_compile.6422
ERROR: TaskFailed event exception, aborting
ERROR: Build of /home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
ERROR: Task 2024 (/home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed

The root cause for this behaviour is in wvstreams' configure.ac; the
weird dbus detection and library path handling breaks successive builds.

This patch, however, does not fix the configure.ac file but disables
DBus support for wvstreams at configure time. This at least fixes the
broken build.

Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
---
 recipes/wvstreams/wvstreams_4.6.bb |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/recipes/wvstreams/wvstreams_4.6.bb b/recipes/wvstreams/wvstreams_4.6.bb
index 91abc7d..1c11268 100644
--- a/recipes/wvstreams/wvstreams_4.6.bb
+++ b/recipes/wvstreams/wvstreams_4.6.bb
@@ -3,6 +3,8 @@ LICENSE = "LGPL"
 DESCRIPTION = "WvStreams is a network programming library in C++"
 DEPENDS = "zlib openssl (>= 0.9.8)"
 
+PR = "r1"
+
 SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \
 	"
 
@@ -10,7 +12,8 @@ inherit autotools pkgconfig
 
 LDFLAGS_append = " -Wl,-rpath-link,${TOOLCHAIN_PATH}/${TARGET_SYS}/lib"
 
-EXTRA_OECONF = " --without-tcl --without-qt --without-pam"
+# dbus detection currently broken in configure.ac; remember to add "dbus (>= 1.2.14)" to DEPENDS  when fixed
+EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"
 
 PACKAGES_prepend = "libuniconf libuniconf-dbg "
 PACKAGES_prepend = "uniconfd uniconfd-dbg "
-- 
1.7.0.4

Re: [v4] wvstreams-4.6: Remove dbus support (breaks build)

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 7691 bytes --]

Am Dienstag, den 28.09.2010, 11:34 +0200 schrieb Thilo Fromm: 
> If wvstreams is configured with DBus support enabled (by not providing
> --without-dbus) the the build fails at link time as libdbus cannot be
> found:
> 
> | ./CXX -c dbus/wvdbusconn
> | ./CXX -c dbus/wvdbusmarshal
> | ./CXX -c dbus/wvdbusmsg
> | ./CXX -c dbus/wvdbusserver
> | linking libwvdbus.so...
> | arm-angstrom-linux-gnueabi-g++: /libdbus-1.a: No such file or directory
> | make: *** [libwvdbus.so] Error 1
> | FATAL: oe_runmake failed
> NOTE: Task failed: /SCRATCH/maniac/oe-merge-test/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/wvstreams-4.6-r0/temp/log.do_compile.6422
> ERROR: TaskFailed event exception, aborting
> ERROR: Build of /home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
> ERROR: Task 2024 (/home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed
> 
> The root cause for this behaviour is in wvstreams' configure.ac; the
> weird dbus detection and library path handling breaks successive builds.
> 
> This patch, however, does not fix the configure.ac file but disables
> DBus support for wvstreams at configure time. This at least fixes the
> broken build.
> 
> Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>

I build tested your patch with `MACHINE = "beagleboard"` and
distributions Ȧngström 2008.1 and Minimal with `LIBC = "libc"`.

But it fails for me for Minimal with `LIBC = "eglibc"`

	| make[1]: Leaving directory `/oe/build-minimal-uclibc/minimal-uclibc-dev/work/armv7a-oe-linux-uclibceabi/wvstreams-4.6-r1/wvstreams-4.6/argp'
	| ./CXX -c utils/wvbuffer
	| ./CXX -c utils/wvbufferstore
	| ./CXX -c utils/wvcont
	| ./CXX -c utils/wverror
	| ./CXX -c streams/wvfdstream
	| ./CXX -c utils/wvfork
	| ./CXX -c utils/wvhash
	| ./CXX -c utils/wvhashtable
	| ./CXX -c utils/wvlinklist
	| ./CXX -c utils/wvmoniker
	| ./CXX -c utils/wvregex
	| ./CXX -c utils/wvscatterhash
	| ./CXX -c utils/wvsorter
	| ./CXX -c utils/wvattrs
	| ./CXX -c utils/wvstring
	| ./CXX -c utils/wvstringlist
	| ./CXX -c utils/wvstringmask
	| ./CXX -c utils/strutils
	| ./CXX -c utils/wvtask
	| utils/wvtask.cc: In constructor 'WvTaskMan::WvTaskMan()':
	| utils/wvtask.cc:202:5: error: 'getcontext' was not declared in this scope
	| utils/wvtask.cc: In static member function 'static int WvTaskMan::run(WvTask&, int)':
	| utils/wvtask.cc:268:5: error: 'getcontext' was not declared in this scope
	| utils/wvtask.cc:274:33: error: 'setcontext' was not declared in this scope
	| utils/wvtask.cc: In static member function 'static int WvTaskMan::yield(int)':
	| utils/wvtask.cc:322:5: error: 'getcontext' was not declared in this scope
	| utils/wvtask.cc:328:29: error: 'setcontext' was not declared in this scope
	| utils/wvtask.cc: In static member function 'static void WvTaskMan::get_stack(WvTask&, size_t)':
	| utils/wvtask.cc:344:5: error: 'getcontext' was not declared in this scope
	| utils/wvtask.cc:374:30: error: 'setcontext' was not declared in this scope
	| utils/wvtask.cc: In static member function 'static void WvTaskMan::_stackmaster()':
	| utils/wvtask.cc:412:9: error: 'getcontext' was not declared in this scope
	| utils/wvtask.cc:422:41: error: 'setcontext' was not declared in this scope
	| utils/wvtask.cc: In static member function 'static void WvTaskMan::do_task()':
	| utils/wvtask.cc:477:5: error: 'getcontext' was not declared in this scope
	| utils/wvtask.cc:521:63: error: 'makecontext' was not declared in this scope
	| utils/wvtask.cc:526:52: error: 'setcontext' was not declared in this scope
	| make: *** [utils/wvtask.o] Error 1
	| FATAL: oe_runmake failed
	| ERROR: Function do_compile failed
	NOTE: package wvstreams-4.6-r1: task do_compile: Failed
	ERROR: TaskFailed event exception, aborting
	ERROR: Build of /oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
	ERROR: Task 11 (/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed with 256
	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed

and minimal-uclibc.

	| ./CXX -c ipstreams/wvaddr
	| In file included from ipstreams/wvaddr.cc:19:0:
	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
	| ./CXX -c ipstreams/wvipraw
	| In file included from ./include/wvipraw.h:10:0,
	|                  from ipstreams/wvipraw.cc:8:
	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
	| ./CXX -c ipstreams/wvlistener
	| In file included from ipstreams/wvlistener.cc:10:0:
	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
	| ./CXX -c ipstreams/wvresolver
	| In file included from ./include/wvresolver.h:10:0,
	|                  from ipstreams/wvresolver.cc:7:
	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
	| ./CXX -c ipstreams/wvstreamsdebuggerserver
	| In file included from ./include/wvstreamsdebuggerserver.h:12:0,
	|                  from ipstreams/wvstreamsdebuggerserver.cc:6:
	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
	| ./CXX -c ipstreams/wvtcp
	| In file included from ./include/wvtcplistener.h:11:0,
	|                  from ipstreams/wvtcp.cc:7:
	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
	| ./CXX -c ipstreams/wvudp
	| In file included from ./include/wvudp.h:10:0,
	|                  from ipstreams/wvudp.cc:8:
	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
	| ./CXX -c ipstreams/wvunixdgsocket
	| In file included from ./include/wvunixdgsocket.h:13:0,
	|                  from ipstreams/wvunixdgsocket.cc:1:
	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
	| ipstreams/wvunixdgsocket.cc: In constructor 'WvUnixDGSocket::WvUnixDGSocket(const WvFastString&, bool, int)':
	| ipstreams/wvunixdgsocket.cc:50:32: error: 'chmod' was not declared in this scope
	| make: *** [ipstreams/wvunixdgsocket.o] Error 1
	| FATAL: oe_runmake failed
	| ERROR: Function do_compile failed
	NOTE: package wvstreams-4.6-r1: task do_compile: Failed
	ERROR: TaskFailed event exception, aborting
	ERROR: Build of /oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
	ERROR: Task 12 (/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed with 256
	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed

[…]

I am not sure, but your patch is an improvement for GNU Libc based
distributions and so your patch could as well be commit.

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [v4] wvstreams-4.6: Remove dbus support (breaks build)

[Thilo Fromm]

Hello Paul,

>> If wvstreams is configured with DBus support enabled (by not providing
>> --without-dbus) the the build fails at link time as libdbus cannot be
>> found.
>>
>> This patch, however, does not fix the configure.ac file but disables
>> DBus support for wvstreams at configure time. This at least fixes the
>> broken build.
>>
>> Signed-off-by: Thilo Fromm<t.fromm@dresearch.de>
>
> I build tested your patch with `MACHINE = "beagleboard"` and
> distributions Ȧngström 2008.1 and Minimal with `LIBC = "libc"`.
>
> But it fails for me for Minimal with `LIBC = "eglibc"`
[...]
> 	| utils/wvtask.cc:477:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:521:63: error: 'makecontext' was not declared in this scope
> 	| utils/wvtask.cc:526:52: error: 'setcontext' was not declared in this scope
> 	| make: *** [utils/wvtask.o] Error 1
> 	| FATAL: oe_runmake failed
> 	| ERROR: Function do_compile failed
> 	NOTE: package wvstreams-4.6-r1: task do_compile: Failed
> 	ERROR: TaskFailed event exception, aborting
> 	ERROR: Build of /oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
> 	ERROR: Task 11 (/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed with 256
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed

I see. I've never seen these failures, but then, I always run glibc builds.

> and minimal-uclibc.
[...]
> 	| ./CXX -c ipstreams/wvunixdgsocket
> 	| In file included from ./include/wvunixdgsocket.h:13:0,
> 	|                  from ipstreams/wvunixdgsocket.cc:1:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ipstreams/wvunixdgsocket.cc: In constructor 'WvUnixDGSocket::WvUnixDGSocket(const WvFastString&, bool, int)':
> 	| ipstreams/wvunixdgsocket.cc:50:32: error: 'chmod' was not declared in this scope
> 	| make: *** [ipstreams/wvunixdgsocket.o] Error 1
> 	| FATAL: oe_runmake failed
> 	| ERROR: Function do_compile failed
> 	NOTE: package wvstreams-4.6-r1: task do_compile: Failed
> 	ERROR: TaskFailed event exception, aborting
> 	ERROR: Build of /oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
> 	ERROR: Task 12 (/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed with 256
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
>
> […]
>
> I am not sure, but your patch is an improvement for GNU Libc based
> distributions and so your patch could as well be commit.

Weird, though. My patch didn't introduce anything obvious that would 
make non-glibc builds fail. Did you try building wvstreams-4.6 / eglibc 
or wvstreams-4.6 / uClibc without my patch applied?

Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle

Re: [v4] wvstreams-4.6: Remove dbus support (breaks build)

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

Am Mittwoch, den 29.09.2010, 10:52 +0200 schrieb Thilo Fromm:

[…]

> > I am not sure, but your patch is an improvement for GNU Libc based
> > distributions and so your patch could as well be commit.
> 
> Weird, though. My patch didn't introduce anything obvious that would 
> make non-glibc builds fail. Did you try building wvstreams-4.6 / eglibc 
> or wvstreams-4.6 / uClibc without my patch applied?

Yes and it failed with the same error your patch is fixing. I guess it
has never worked with uClibc or eglibc.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [v4] wvstreams-4.6: Remove dbus support (breaks build)

[Steffen Sledz]

Am 29.09.2010 10:20, schrieb Paul Menzel:
> Am Dienstag, den 28.09.2010, 11:34 +0200 schrieb Thilo Fromm: 
>> If wvstreams is configured with DBus support enabled (by not providing
>> --without-dbus) the the build fails at link time as libdbus cannot be
>> found:
>>
>> | ./CXX -c dbus/wvdbusconn
>> | ./CXX -c dbus/wvdbusmarshal
>> | ./CXX -c dbus/wvdbusmsg
>> | ./CXX -c dbus/wvdbusserver
>> | linking libwvdbus.so...
>> | arm-angstrom-linux-gnueabi-g++: /libdbus-1.a: No such file or directory
>> | make: *** [libwvdbus.so] Error 1
>> | FATAL: oe_runmake failed
>> NOTE: Task failed: /SCRATCH/maniac/oe-merge-test/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/wvstreams-4.6-r0/temp/log.do_compile.6422
>> ERROR: TaskFailed event exception, aborting
>> ERROR: Build of /home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
>> ERROR: Task 2024 (/home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed
>>
>> The root cause for this behaviour is in wvstreams' configure.ac; the
>> weird dbus detection and library path handling breaks successive builds.
>>
>> This patch, however, does not fix the configure.ac file but disables
>> DBus support for wvstreams at configure time. This at least fixes the
>> broken build.
>>
>> Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
> 
> I build tested your patch with `MACHINE = "beagleboard"` and
> distributions Ȧngström 2008.1 and Minimal with `LIBC = "libc"`.
> 
> But it fails for me for Minimal with `LIBC = "eglibc"`
> 
> 	| make[1]: Leaving directory `/oe/build-minimal-uclibc/minimal-uclibc-dev/work/armv7a-oe-linux-uclibceabi/wvstreams-4.6-r1/wvstreams-4.6/argp'
> 	| ./CXX -c utils/wvbuffer
> 	| ./CXX -c utils/wvbufferstore
> 	| ./CXX -c utils/wvcont
> 	| ./CXX -c utils/wverror
> 	| ./CXX -c streams/wvfdstream
> 	| ./CXX -c utils/wvfork
> 	| ./CXX -c utils/wvhash
> 	| ./CXX -c utils/wvhashtable
> 	| ./CXX -c utils/wvlinklist
> 	| ./CXX -c utils/wvmoniker
> 	| ./CXX -c utils/wvregex
> 	| ./CXX -c utils/wvscatterhash
> 	| ./CXX -c utils/wvsorter
> 	| ./CXX -c utils/wvattrs
> 	| ./CXX -c utils/wvstring
> 	| ./CXX -c utils/wvstringlist
> 	| ./CXX -c utils/wvstringmask
> 	| ./CXX -c utils/strutils
> 	| ./CXX -c utils/wvtask
> 	| utils/wvtask.cc: In constructor 'WvTaskMan::WvTaskMan()':
> 	| utils/wvtask.cc:202:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc: In static member function 'static int WvTaskMan::run(WvTask&, int)':
> 	| utils/wvtask.cc:268:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:274:33: error: 'setcontext' was not declared in this scope
> 	| utils/wvtask.cc: In static member function 'static int WvTaskMan::yield(int)':
> 	| utils/wvtask.cc:322:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:328:29: error: 'setcontext' was not declared in this scope
> 	| utils/wvtask.cc: In static member function 'static void WvTaskMan::get_stack(WvTask&, size_t)':
> 	| utils/wvtask.cc:344:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:374:30: error: 'setcontext' was not declared in this scope
> 	| utils/wvtask.cc: In static member function 'static void WvTaskMan::_stackmaster()':
> 	| utils/wvtask.cc:412:9: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:422:41: error: 'setcontext' was not declared in this scope
> 	| utils/wvtask.cc: In static member function 'static void WvTaskMan::do_task()':
> 	| utils/wvtask.cc:477:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:521:63: error: 'makecontext' was not declared in this scope
> 	| utils/wvtask.cc:526:52: error: 'setcontext' was not declared in this scope
> 	| make: *** [utils/wvtask.o] Error 1
> 	| FATAL: oe_runmake failed
> 	| ERROR: Function do_compile failed
> 	NOTE: package wvstreams-4.6-r1: task do_compile: Failed
> 	ERROR: TaskFailed event exception, aborting
> 	ERROR: Build of /oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
> 	ERROR: Task 11 (/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed with 256
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 
> and minimal-uclibc.
> 
> 	| ./CXX -c ipstreams/wvaddr
> 	| In file included from ipstreams/wvaddr.cc:19:0:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvipraw
> 	| In file included from ./include/wvipraw.h:10:0,
> 	|                  from ipstreams/wvipraw.cc:8:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvlistener
> 	| In file included from ipstreams/wvlistener.cc:10:0:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvresolver
> 	| In file included from ./include/wvresolver.h:10:0,
> 	|                  from ipstreams/wvresolver.cc:7:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvstreamsdebuggerserver
> 	| In file included from ./include/wvstreamsdebuggerserver.h:12:0,
> 	|                  from ipstreams/wvstreamsdebuggerserver.cc:6:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvtcp
> 	| In file included from ./include/wvtcplistener.h:11:0,
> 	|                  from ipstreams/wvtcp.cc:7:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvudp
> 	| In file included from ./include/wvudp.h:10:0,
> 	|                  from ipstreams/wvudp.cc:8:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvunixdgsocket
> 	| In file included from ./include/wvunixdgsocket.h:13:0,
> 	|                  from ipstreams/wvunixdgsocket.cc:1:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ipstreams/wvunixdgsocket.cc: In constructor 'WvUnixDGSocket::WvUnixDGSocket(const WvFastString&, bool, int)':
> 	| ipstreams/wvunixdgsocket.cc:50:32: error: 'chmod' was not declared in this scope
> 	| make: *** [ipstreams/wvunixdgsocket.o] Error 1
> 	| FATAL: oe_runmake failed
> 	| ERROR: Function do_compile failed
> 	NOTE: package wvstreams-4.6-r1: task do_compile: Failed
> 	ERROR: TaskFailed event exception, aborting
> 	ERROR: Build of /oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
> 	ERROR: Task 12 (/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed with 256
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 
> […]
> 
> I am not sure, but your patch is an improvement for GNU Libc based
> distributions and so your patch could as well be commit.
> 
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

Acked-by: Steffen Sledz <sledz@dresearch.de>

and applied

-- 
Steffen Sledz
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str.3, D-10319 Berlin, Germany
Tel: +49 (30) 515932237 mailto:sledz@DResearch.DE
Fax: +49 (30) 515932299 http://www.DResearch.DE
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 54412;
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642

Re: [v2] wvstreams-4.6: Remove dbus support because it breaks the build

[Thilo Fromm]

Hello, Paul,

>> [...]
>>
>>>>
>>>> +PR = "r2"
>>>> +
>>>
>>> I think `PR` starts at 0 by default.
>>
>> Well, I though this recipe was already *there* before I started, so it's
>> not a "r0". But all right, I'll reset this ro "r0" in [v3].
>
> No I meant you can set it to »r1«.

Awwww. OK, [v4] is out...

>
> Good luck with your builds and thank you for your contribution.
 >

Thanks for your support, Paul.

Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle

Re: [v2] wvstreams-4.6: Remove dbus support because it breaks the build

[Steffen Sledz]

Am 28.09.2010 11:08, schrieb Thilo Fromm:
>> Do you know, if and how »PATCH« got stripped in the subject?
>> Without it, Patchwork will not pick it up, I think.
> 
> It got stripped because of your recommendation to use
> --subject-prefix="v2". The "How to submit a patch to OpenEmbedded"
> wiki page at
> <http://wiki.openembedded.net/index.php/How_to_submit_a_patch_to_OpenEmbedded#Create_and_Commit_your_patch>
> recommends the same.

Wiki is updated.

Steffen

-- 
Steffen Sledz
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str.3, D-10319 Berlin, Germany
Tel: +49 (30) 515932237 mailto:sledz@DResearch.DE
Fax: +49 (30) 515932299 http://www.DResearch.DE
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 54412;
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642

[v3] wvstreams-4.6: Remove dbus support (breaks build)

[Thilo Fromm]

If wvstreams is configured with DBus support enabled (by not providing
--without-dbus) the the build fails at link time as libdbus cannot be
found:

| ./CXX -c dbus/wvdbusconn
| ./CXX -c dbus/wvdbusmarshal
| ./CXX -c dbus/wvdbusmsg
| ./CXX -c dbus/wvdbusserver
| linking libwvdbus.so...
| arm-angstrom-linux-gnueabi-g++: /libdbus-1.a: No such file or directory
| make: *** [libwvdbus.so] Error 1
| FATAL: oe_runmake failed
NOTE: Task failed: /SCRATCH/maniac/oe-merge-test/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/wvstreams-4.6-r0/temp/log.do_compile.6422
ERROR: TaskFailed event exception, aborting
ERROR: Build of /home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
ERROR: Task 2024 (/home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed

The root cause for this behaviour is in wvstreams' configure.ac; the
weird dbus detection and library path handling breaks successive builds.

This patch, however, does not fix the configure.ac file but disables
DBus support for wvstreams at configure time. This at least fixes the
broken build.

Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
---
 recipes/wvstreams/wvstreams_4.6.bb |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/recipes/wvstreams/wvstreams_4.6.bb b/recipes/wvstreams/wvstreams_4.6.bb
index 91abc7d..f33955f 100644
--- a/recipes/wvstreams/wvstreams_4.6.bb
+++ b/recipes/wvstreams/wvstreams_4.6.bb
@@ -3,6 +3,8 @@ LICENSE = "LGPL"
 DESCRIPTION = "WvStreams is a network programming library in C++"
 DEPENDS = "zlib openssl (>= 0.9.8)"
 
+PR = "r0"
+
 SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \
 	"
 
@@ -10,7 +12,8 @@ inherit autotools pkgconfig
 
 LDFLAGS_append = " -Wl,-rpath-link,${TOOLCHAIN_PATH}/${TARGET_SYS}/lib"
 
-EXTRA_OECONF = " --without-tcl --without-qt --without-pam"
+# dbus detection currently broken in configure.ac; remember to add "dbus (>= 1.2.14)" to DEPENDS  when fixed
+EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"
 
 PACKAGES_prepend = "libuniconf libuniconf-dbg "
 PACKAGES_prepend = "uniconfd uniconfd-dbg "
-- 
1.7.0.4

Re: [PATCH] Remove dbus support from wvstreams-4.6 because it breaks the build

[Frans Meulenbroeks]

2010/9/28 Thilo Fromm <t.fromm@dresearch.de>:

I'd say it is either this

> -DEPENDS = "zlib openssl (>= 0.9.8)"
> +DEPENDS = "zlib openssl (>= 0.9.8) dbus (> 1.2.14)"

which makes sure dbus is build and available.

Or this:

> -EXTRA_OECONF = " --without-tcl --without-qt --without-pam"
> +# tfm: dbus build currently broken
> +EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"

but not both.
If wvstreams should be build with dbus support you should use the
former, it is should be build without it, it should be the latter.

Frans

Re: [PATCH] Remove dbus support from wvstreams-4.6 because it breaks the build

[Thilo Fromm]

Hello, Frans,

> I'd say it is either this
>
>> -DEPENDS = "zlib openssl (>= 0.9.8)"
>> +DEPENDS = "zlib openssl (>= 0.9.8) dbus (>  1.2.14)"
>
> which makes sure dbus is build and available.

Nope, it doesn't. Not for wvstreams, at least. Configure.ac is broken 
and the package will fail to build at link time because it is looking 
for libdbus-1.a in the system root ( "/libdbus-1.a"; see first mail ).

However, I forgot to remove this little helper.

>
> Or this:
>
>> -EXTRA_OECONF = " --without-tcl --without-qt --without-pam"
>> +# tfm: dbus build currently broken
>> +EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"
>
> but not both.
> If wvstreams should be build with dbus support you should use the
> former, it is should be build without it, it should be the latter.
>

So it is the latter. [v2] is out.

Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle

Re: [PATCH] Remove dbus support from wvstreams-4.6 because it breaks the build

[Holger Freyther]

On 09/28/2010 03:28 PM, Thilo Fromm wrote:

> 
> This patch, however, does not fix the configure.ac file but disables
> DBus support for wvstreams at configure time. This at least fixes the
> broken build.

well, then don't add extra depends on dbus? Otherwise it seems fine for now to
disable dbus support.


> -DEPENDS = "zlib openssl (>= 0.9.8)"
> +DEPENDS = "zlib openssl (>= 0.9.8) dbus (> 1.2.14)"
>