piglit regression on sandybridge

piglit regression on sandybridge

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 1034 bytes --]


Eric,

Looks the culprit for recent piglit regression on sandybridge
that caused hang is bisected to

commit 9effc1adf1e7ba57fb3b10909762b76c1ae12f61
Author: Eric Anholt <eric@anholt.net>
Date:   Mon Oct 11 16:02:08 2010 -0700

i965: re-enable gen6 IF statements in the fragment shader.

IF statements were getting flattened while they were broken.  With
Zhenyu's last fix for ENDIF's type, everything appears to have lined
up to actually work.

This regresses two tests:
glsl1-! (not) operator (1, fail)
glsl1-! (not) operator (1, pass)

but fixes tests that couldn't work before because the IFs couldn't
be flattened:
glsl-fs-discard-01
occlusion-query-discard

(and, naturally, this should be a performance improvement for apps
 that actually use IF statements to avoid executing a bunch of code).

What may go wrong with this? QA is stalled on this to continue on
running piglit..

thanks.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: piglit regression on sandybridge

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/29/2010 12:52 AM, Zhenyu Wang wrote:

> Looks the culprit for recent piglit regression on sandybridge
> that caused hang is bisected to

Could you be more specific about the regression?  The commit message
mentions two tests that regress with this change.  Are there other
regressions?  If yes, what are they?

> commit 9effc1adf1e7ba57fb3b10909762b76c1ae12f61
> Author: Eric Anholt <eric@anholt.net>
> Date:   Mon Oct 11 16:02:08 2010 -0700
> 
> i965: re-enable gen6 IF statements in the fragment shader.
> 
> IF statements were getting flattened while they were broken.  With
> Zhenyu's last fix for ENDIF's type, everything appears to have lined
> up to actually work.
> 
> This regresses two tests:
> glsl1-! (not) operator (1, fail)
> glsl1-! (not) operator (1, pass)
> 
> but fixes tests that couldn't work before because the IFs couldn't
> be flattened:
> glsl-fs-discard-01
> occlusion-query-discard
> 
> (and, naturally, this should be a performance improvement for apps
>  that actually use IF statements to avoid executing a bunch of code).
> 
> What may go wrong with this? QA is stalled on this to continue on
> running piglit..

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkzz+L8ACgkQX1gOwKyEAw9OMwCgmWz6YYEkX0glsmf4wSngfi1x
dFYAn0F0d5AzQJCxhlBHTjZb/U+CYkC4
=Qt8Y
-----END PGP SIGNATURE-----

Re: piglit regression on sandybridge

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 2019 bytes --]

On 2010.11.29 11:02:26 -0800, Ian Romanick wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 11/29/2010 12:52 AM, Zhenyu Wang wrote:
> 
> > Looks the culprit for recent piglit regression on sandybridge
> > that caused hang is bisected to
> 
> Could you be more specific about the regression?  The commit message
> mentions two tests that regress with this change.  Are there other
> regressions?  If yes, what are they?
> 

Sorry I missed that point. It's piglit shaders/glsl-fs-convolution-2
that caused hang now.

> > commit 9effc1adf1e7ba57fb3b10909762b76c1ae12f61
> > Author: Eric Anholt <eric@anholt.net>
> > Date:   Mon Oct 11 16:02:08 2010 -0700
> > 
> > i965: re-enable gen6 IF statements in the fragment shader.
> > 
> > IF statements were getting flattened while they were broken.  With
> > Zhenyu's last fix for ENDIF's type, everything appears to have lined
> > up to actually work.
> > 
> > This regresses two tests:
> > glsl1-! (not) operator (1, fail)
> > glsl1-! (not) operator (1, pass)
> > 
> > but fixes tests that couldn't work before because the IFs couldn't
> > be flattened:
> > glsl-fs-discard-01
> > occlusion-query-discard
> > 
> > (and, naturally, this should be a performance improvement for apps
> >  that actually use IF statements to avoid executing a bunch of code).
> > 
> > What may go wrong with this? QA is stalled on this to continue on
> > running piglit..
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
> 
> iEYEARECAAYFAkzz+L8ACgkQX1gOwKyEAw9OMwCgmWz6YYEkX0glsmf4wSngfi1x
> dFYAn0F0d5AzQJCxhlBHTjZb/U+CYkC4
> =Qt8Y
> -----END PGP SIGNATURE-----
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: piglit regression on sandybridge

[Jin, Gordon]

Zhenyu Wang wrote on Tuesday, November 30, 2010 9:50 AM:
> On 2010.11.29 11:02:26 -0800, Ian Romanick wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> 
>> On 11/29/2010 12:52 AM, Zhenyu Wang wrote:
>> 
>>> Looks the culprit for recent piglit regression on sandybridge
>>> that caused hang is bisected to
>> 
>> Could you be more specific about the regression?  The commit message
>> mentions two tests that regress with this change.  Are there other
>> regressions?  If yes, what are they?
>> 
> 
> Sorry I missed that point. It's piglit shaders/glsl-fs-convolution-2
> that caused hang now.

Here's the bug link: https://bugs.freedesktop.org/show_bug.cgi?id=31651