All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
Cc: ext Jean Pihet <jean.pihet@newoldbits.com>,
	linux-omap <linux-omap@vger.kernel.org>,
	linux-arm <linux-arm-kernel@lists.infradead.org>,
	Kevin <khilman@deeprootsystems.com>, Tony <tony@atomide.com>
Subject: Re: [PATCH v4 2/7] OMAP3: PM: Erratum i581 support: dll kick strategy
Date: Mon, 20 Dec 2010 08:21:19 -0600	[thread overview]
Message-ID: <4D0F665F.8050804@ti.com> (raw)
In-Reply-To: <20101220113322.GS31404@nokia.com>

Peter 'p2' De Schrijver had written, on 12/20/2010 05:33 AM, the following:
[..]
>>> +       /* these 2 words need to be at the end !!! */
>>> +kick_counter:
>>> +       .word   0
>>> +wait_dll_lock_counter:
>>> +       .word   0
>> Why do they need to be at the end? Also, at the end of what do they need to be?
>>
> 
> At the end of omap34xx_cpu_suspend. As we don't know where in SRAM the
> counters will be, the code accessing those counters addresses them
> relative from (_omap_sram_idle + omap34xx_cpu_suspend_sz). Not sure if
> this part of the code made it to linux-omap though.
I have not posted the change needed to expose these counters to 
userspace waiting for the churn in sleep34xx.S to settle down.

-- 
Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/7] OMAP3: PM: Erratum i581 support: dll kick strategy
Date: Mon, 20 Dec 2010 08:21:19 -0600	[thread overview]
Message-ID: <4D0F665F.8050804@ti.com> (raw)
In-Reply-To: <20101220113322.GS31404@nokia.com>

Peter 'p2' De Schrijver had written, on 12/20/2010 05:33 AM, the following:
[..]
>>> +       /* these 2 words need to be at the end !!! */
>>> +kick_counter:
>>> +       .word   0
>>> +wait_dll_lock_counter:
>>> +       .word   0
>> Why do they need to be at the end? Also, at the end of what do they need to be?
>>
> 
> At the end of omap34xx_cpu_suspend. As we don't know where in SRAM the
> counters will be, the code accessing those counters addresses them
> relative from (_omap_sram_idle + omap34xx_cpu_suspend_sz). Not sure if
> this part of the code made it to linux-omap though.
I have not posted the change needed to expose these counters to 
userspace waiting for the churn in sleep34xx.S to settle down.

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2010-12-20 14:21 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-18 22:53 [PATCH v4 0/7] OMAP: idle path errata fixes Nishanth Menon
2010-12-18 22:53 ` Nishanth Menon
2010-12-18 22:53 ` [PATCH v4 1/7] OMAP3: PM: Update clean_l2 to use v7_flush_dcache_all Nishanth Menon
2010-12-18 22:53   ` Nishanth Menon
2010-12-20  6:43   ` Santosh Shilimkar
2010-12-20  6:43     ` Santosh Shilimkar
2010-12-20 10:19     ` Jean Pihet
2010-12-20 10:19       ` Jean Pihet
2010-12-18 22:53 ` [PATCH v4 2/7] OMAP3: PM: Erratum i581 support: dll kick strategy Nishanth Menon
2010-12-18 22:53   ` Nishanth Menon
2010-12-20  6:47   ` Santosh Shilimkar
2010-12-20  6:47     ` Santosh Shilimkar
2010-12-20 14:16     ` Nishanth Menon
2010-12-20 14:16       ` Nishanth Menon
2010-12-20 10:23   ` Jean Pihet
2010-12-20 10:23     ` Jean Pihet
2010-12-20 11:33     ` Peter 'p2' De Schrijver
2010-12-20 14:21       ` Nishanth Menon [this message]
2010-12-20 14:21         ` Nishanth Menon
2010-12-18 22:53 ` [PATCH v4 3/7] omap3: pm: introduce errata handling Nishanth Menon
2010-12-18 22:53   ` Nishanth Menon
2010-12-20 10:18   ` Jean Pihet
2010-12-20 10:18     ` Jean Pihet
2010-12-20 14:39     ` Nishanth Menon
2010-12-20 14:39       ` Nishanth Menon
2010-12-18 22:53 ` [PATCH v4 4/7] OMAP3630: PM: Erratum i608: disable RTA Nishanth Menon
2010-12-18 22:53   ` Nishanth Menon
2010-12-20  6:59   ` Santosh Shilimkar
2010-12-20  6:59     ` Santosh Shilimkar
2010-12-20 11:23     ` Nishanth Menon
2010-12-20 11:23       ` Nishanth Menon
2010-12-20 12:15       ` Santosh Shilimkar
2010-12-20 12:15         ` Santosh Shilimkar
2010-12-20 10:27   ` Jean Pihet
2010-12-20 10:27     ` Jean Pihet
2010-12-20 14:45     ` Nishanth Menon
2010-12-20 14:45       ` Nishanth Menon
2010-12-18 22:53 ` [PATCH v4 5/7] OMAP3630: PM: Disable L2 cache while invalidating L2 cache Nishanth Menon
2010-12-18 22:53   ` Nishanth Menon
2010-12-20  7:13   ` Santosh Shilimkar
2010-12-20  7:13     ` Santosh Shilimkar
2010-12-20 11:44     ` Nishanth Menon
2010-12-20 11:44       ` Nishanth Menon
2010-12-20 12:14       ` Santosh Shilimkar
2010-12-20 12:14         ` Santosh Shilimkar
2010-12-20 13:08         ` Nishanth Menon
2010-12-20 13:08           ` Nishanth Menon
2010-12-20 13:29           ` Santosh Shilimkar
2010-12-20 13:29             ` Santosh Shilimkar
2010-12-20 13:33             ` Nishanth Menon
2010-12-20 13:33               ` Nishanth Menon
2010-12-20 13:37               ` Santosh Shilimkar
2010-12-20 13:37                 ` Santosh Shilimkar
2010-12-20 10:28   ` Jean Pihet
2010-12-20 10:28     ` Jean Pihet
2010-12-18 22:53 ` [PATCH v4 6/7] OMAP3: PM: make omap3_cpuidle_update_states independent of enable_off_mode Nishanth Menon
2010-12-18 22:53   ` Nishanth Menon
2010-12-20  7:16   ` Santosh Shilimkar
2010-12-20  7:16     ` Santosh Shilimkar
2010-12-20 10:28   ` Jean Pihet
2010-12-20 10:28     ` Jean Pihet
2010-12-18 22:53 ` [PATCH v4 7/7] OMAP3630: PM: Erratum i583: disable coreoff if < ES1.2 Nishanth Menon
2010-12-18 22:53   ` Nishanth Menon
2010-12-20  6:51   ` Santosh Shilimkar
2010-12-20  6:51     ` Santosh Shilimkar
2010-12-20 10:26     ` Jean Pihet
2010-12-20 10:26       ` Jean Pihet
2010-12-20 11:22     ` Nishanth Menon
2010-12-20 11:22       ` Nishanth Menon
2010-12-20 19:05   ` Kevin Hilman
2010-12-20 19:05     ` Kevin Hilman
2010-12-20 19:07     ` Nishanth Menon
2010-12-20 19:07       ` Nishanth Menon
2010-12-20 10:17 ` [PATCH v4 0/7] OMAP: idle path errata fixes Jean Pihet
2010-12-20 10:17   ` Jean Pihet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0F665F.8050804@ti.com \
    --to=nm@ti.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.de-schrijver@nokia.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.