Re: [PATCH V3 25/63 resend] Newly erased page read workaround

All of lore.kernel.org
 help / color / mirror / Atom feed

From: viresh kumar <viresh.kumar@st.com>
To: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"linus.walleij@stericsson.com" <linus.walleij@stericsson.com>
Cc: Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
	Armando VISCONTI <armando.visconti@st.com>,
	Vipin KUMAR <vipin.kumar@st.com>,
	Shiraz HASHIM <shiraz.hashim@st.com>,
	Amit VIRDI <Amit.VIRDI@st.com>,
	Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
	Deepak SIKRI <deepak.sikri@st.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V3 25/63 resend] Newly erased page read workaround
Date: Fri, 14 Jan 2011 10:51:38 +0530	[thread overview]
Message-ID: <4D2FDD62.4040106@st.com> (raw)
In-Reply-To: <6187de0568d1ea8a6aeb6c3ca54ac6684bee9973.1292833228.git.viresh.kumar@st.com>

On 12/20/2010 02:49 PM, Viresh KUMAR wrote:
> From: Vipin Kumar <vipin.kumar@st.com>
> 
> A newly erased page contains ff in data as well as spare area. While reading an
> erased page, the read out ecc from spare area does not match the ecc generated
> by fsmc ecc hardware accelarator. This is because ecc of data ff ff is not ff
> ff. This leads to errors when jffs2 fs erases and reads back the pages to
> ensure consistency.
> 
> This patch adds a software workaround to ensure that the ecc check is not
> performed for erased pages. An erased page is checked by checking data as ff ff.

David,

Does this patch looks fine to you??

--
viresh

WARNING: multiple messages have this Message-ID (diff)

From: viresh.kumar@st.com (viresh kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 25/63 resend] Newly erased page read workaround
Date: Fri, 14 Jan 2011 10:51:38 +0530	[thread overview]
Message-ID: <4D2FDD62.4040106@st.com> (raw)
In-Reply-To: <6187de0568d1ea8a6aeb6c3ca54ac6684bee9973.1292833228.git.viresh.kumar@st.com>

On 12/20/2010 02:49 PM, Viresh KUMAR wrote:
> From: Vipin Kumar <vipin.kumar@st.com>
> 
> A newly erased page contains ff in data as well as spare area. While reading an
> erased page, the read out ecc from spare area does not match the ecc generated
> by fsmc ecc hardware accelarator. This is because ecc of data ff ff is not ff
> ff. This leads to errors when jffs2 fs erases and reads back the pages to
> ensure consistency.
> 
> This patch adds a software workaround to ensure that the ecc check is not
> performed for erased pages. An erased page is checked by checking data as ff ff.

David,

Does this patch looks fine to you??

--
viresh

next prev parent reply	other threads:[~2011-01-14  5:21 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20  8:25 [PATCH V3 00/63] Updating SPEAr Support Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 01/63] ARM: move sev definition to common system.h include file Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 02/63] sp810 Fix: Switch to slow mode before sysctl_soft_reset Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 03/63] ST SPEAr: Padmux code Updated Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 04/63] ST SPEAr: Making clock functions more generic Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 05/63] ST SPEAr: Formalized timer support Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 06/63] ST SPEAr13XX: Adding machine specific header files Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 07/63] ST SPEAr13XX: Adding machine specific src files Viresh Kumar
2011-01-14 10:08   ` stanley.miao
2011-01-14 10:09     ` viresh kumar
2010-12-20  8:25 ` [PATCH V3 08/63] ST SPEAr: Adding support for SPEAr13xx SoC in spear generic plat/ Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 09/63] ST SPEAr13XX: Added compilation support in arch/arm/ Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 10/63] ST SPEAr1300: Adding default config file Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 11/63] ST SPEAr: Adding support for CLCD on SPEAr3xx/6xx Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 12/63] ST SPEAr: Updating Clock Support Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 13/63] ST SPEAr: Adding Debugfs support on clock framework Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 14/63] ST SPEAr: Correcting SOC Config base address for spear320 Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 15/63] ST SPEAr: Adding PLGPIO driver for spear platform Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 17/63] ST SPEAr: Adding machine support for rtc-spear Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 18/63] ST SPEAr: adding support for synopsis i2c designware Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 19/63] ST SPEAr: Adding machine support for USB host Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 20/63] ST SPEAr: Adding machine support for keyboard Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 21/63] ST SPEAr: Added ARM PL061 GPIO Support on SPEAr13xx and modified resource size Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 22/63] ST SPEAr: Adding support for ST's PWM IP Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 23/63] ST SPEAr: Adding Watchdog support Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 24/63] ST SPEAr: Adding machine support for nand Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 25/63] Newly erased page read workaround Viresh Kumar
2010-12-20  9:19   ` [PATCH V3 25/63 resend] " Viresh Kumar
2011-01-14  5:21   ` viresh kumar [this message]
2011-01-14  5:21     ` viresh kumar
2011-01-14 12:36   ` [PATCH V3 25/63] " Linus Walleij
2010-12-20  8:25 ` [PATCH V3 26/63] ST SPEAr: Added PCIE host controller base driver support Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 27/63] ST SPEAr: Adding support for SSP PL022 Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 28/63] ST SPEAr: Adding support for SDHCI (SDIO) Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 29/63] ST SPEAr: Changing resource size of amba devices to SZ_4K Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 30/63] ST SPEAr: Replacing SIZE macro's with actual required size Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 31/63] SPEAr: defines base addresses as ulong Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 32/63] ST SPEAr: Adding miscellaneous devices Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 33/63] ST SPEAr 13xx : Adding support for SPEAr1310 Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 34/63] ST SPEAr: Adding support for DDR in clock framework Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 35/63] ST SPEAr : EMI (Extrenal Memory Interface) controller driver Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 36/63] ST SPEAr : FSMC (Flexible Static Memory Controller) NOR interface driver Viresh Kumar
2010-12-26 15:38   ` Linus Walleij
2010-12-26 15:38     ` Linus Walleij
2011-01-03  3:48     ` viresh kumar
2011-01-03  3:48       ` viresh kumar
2010-12-20  8:25 ` [PATCH V3 37/63] SPEAr Clock Framework: Adding support for PLL frequency change Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 38/63] SPEAr Power Management: Added the support for Standby mode Viresh Kumar
2010-12-20  8:25 ` [PATCH V3 39/63] GIC: Added dummy handlers for Power Management Suspend Resume Viresh Kumar
2010-12-20 11:10   ` Russell King - ARM Linux
2010-12-20 11:32     ` viresh kumar
2010-12-20 11:49       ` Russell King - ARM Linux
2010-12-20 12:20         ` [PATCH V3 39/63] GIC: Added dummy handlers for Power ManagementSuspend Resume Santosh Shilimkar
2010-12-20 12:28           ` Russell King - ARM Linux
2010-12-20 12:34             ` [PATCH V3 39/63] GIC: Added dummy handlers for PowerManagementSuspend Resume Santosh Shilimkar
2010-12-21  4:17         ` [PATCH V3 39/63] GIC: Added dummy handlers for Power Management Suspend Resume viresh kumar
2010-12-20  8:26 ` [PATCH V3 40/63] SPEAr CPU freq: Adding support for CPU Freq framework Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 41/63] ST SPEAr13xx: Adding CPU hotplug support added for SMP platforms Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 42/63] ST SPEAr: replace readl, writel with __raw_readl, __raw_writel in uncompress.h Viresh Kumar
2011-01-07  2:26   ` stanley.miao
2011-01-07  9:17     ` Russell King - ARM Linux
2011-01-07  9:38       ` stanley.miao
2011-01-11  5:39         ` viresh kumar
2010-12-20  8:26 ` [PATCH V3 43/63] ST SPEAr13xx: add L2 cache support Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 44/63] ST SPEAr13xx: Modified static mappings Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 45/63] SPEAr: Adding and Updating Clock definitions Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 46/63] SPEAr : Pad multiplexing handling modified Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 47/63] SPEAr13xx : Fixed part devices in SPEAr13xx addded to the generic implementation Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 48/63] SPEAr : Updating pad multiplexing support Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 49/63] ST SPEAr3xx: Passing pmx devices address from machine *.c files Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 50/63] ST SPEAr Clock Framework: Updating for single image solution Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 51/63] SPEAr3xx: Make local structures static Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 52/63] SPEAR3xx: Rename register/irq defines to remove naming conflicts Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 53/63] SPEAr3xx: Rework pmx_dev code to remove conflicts Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 54/63] SPEAr3xx: Rework KConfig to allow all boards to be compiled in Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 55/63] SPEAr3xx: Replace defconfigs with single unified defconfig Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 56/63] ST SPEAr: Appending spear3** with global structures Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 57/63] ST SPEAr3xx: Updating plgpio and emi source to make it compliant with single image strategy Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 58/63] SPEAr6xx: Rework Kconfig for single image solution Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 59/63] ST SPEAR6xx: renaming spear600_defconfig as spear6xx_defconfig Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 60/63] ST SPEAr13xx: Pass default padmux settings as parameter to spear13**_init routine Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 61/63] ST SPEAr: Adding devices & clocks Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 62/63] ST SPEAr: Adding information in Documentation/ and MAINTAINERS Viresh Kumar
2010-12-20  8:26 ` [PATCH V3 63/63] ST SPEAr: Updating defconfigs Viresh Kumar
2010-12-20  8:28 ` [PATCH V3 16/63 resend] rtc: Adding support for spear rtc Viresh Kumar
2011-01-12  9:41   ` viresh kumar
2010-12-23 12:13 ` [PATCH V3 00/63] Updating SPEAr Support Russell King - ARM Linux
2010-12-24  4:01   ` viresh kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2FDD62.4040106@st.com \
    --to=viresh.kumar@st.com \
    --cc=Amit.VIRDI@st.com \
    --cc=armando.visconti@st.com \
    --cc=deepak.sikri@st.com \
    --cc=dwmw2@infradead.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=rajeev-dlh.kumar@st.com \
    --cc=shiraz.hashim@st.com \
    --cc=vipin.kumar@st.com \
    --cc=vipulkumar.samar@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.