* [PATCH 05/25][v3] u-boot: disable -Os option not supported by gcc
@ 2011-01-26 17:42 Adrian Alonso
2011-01-26 18:00 ` Darren Hart
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Alonso @ 2011-01-26 17:42 UTC (permalink / raw)
To: poky; +Cc: Adrian Alonso
* Disable -Os optspace option not supported by gcc use insted -O2
* v2 Remove Make file patch
* v3 use EXTRA_OEMAKE variable, override default OPTFLAGS settings
in u-boot.inc, Powerpc targets build only with -O1, -O2 optflags
Build failures are related to gcc bugs #44392 and #45052
* Bump PR
Signed-off-by: Adrian Alonso <aalonso@secretlab.ca>
---
recipes-bsp/uboot/u-boot-xilinx_git.bb | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/recipes-bsp/uboot/u-boot-xilinx_git.bb b/recipes-bsp/uboot/u-boot-xilinx_git.bb
index 50d99e3..a373428 100644
--- a/recipes-bsp/uboot/u-boot-xilinx_git.bb
+++ b/recipes-bsp/uboot/u-boot-xilinx_git.bb
@@ -1,9 +1,11 @@
require ../meta/recipes-bsp/uboot/u-boot.inc
-PR = "r2"
+PR = "r3"
+EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS='-O2'"
BRANCH="master"
TAG="e094f2479ea339d7f48b6826f06f0be4984d9a98"
-SRC_URI = "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git"
+SRC_URI = "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git \
+ "
SRCREV = "${TAG}"
inherit xilinx-boot
--
1.7.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 05/25][v3] u-boot: disable -Os option not supported by gcc
2011-01-26 17:42 [PATCH 05/25][v3] u-boot: disable -Os option not supported by gcc Adrian Alonso
@ 2011-01-26 18:00 ` Darren Hart
2011-01-26 18:28 ` Saul Wold
0 siblings, 1 reply; 5+ messages in thread
From: Darren Hart @ 2011-01-26 18:00 UTC (permalink / raw)
To: Adrian Alonso; +Cc: poky
On 01/26/2011 09:42 AM, Adrian Alonso wrote:
> * Disable -Os optspace option not supported by gcc use insted -O2
> * v2 Remove Make file patch
> * v3 use EXTRA_OEMAKE variable, override default OPTFLAGS settings
> in u-boot.inc, Powerpc targets build only with -O1, -O2 optflags
> Build failures are related to gcc bugs #44392 and #45052
> * Bump PR
>
> Signed-off-by: Adrian Alonso<aalonso@secretlab.ca>
Looks good for the -Os problem.
Reviewed-by: Darren Hart<dvhart@linux.intel.com>
I noticed that the SRCREV is defined in this file.
Typically this should be in
meta/conf/distro/include/poky-default-revisions.inc
--
Darren
> ---
> recipes-bsp/uboot/u-boot-xilinx_git.bb | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-bsp/uboot/u-boot-xilinx_git.bb b/recipes-bsp/uboot/u-boot-xilinx_git.bb
> index 50d99e3..a373428 100644
> --- a/recipes-bsp/uboot/u-boot-xilinx_git.bb
> +++ b/recipes-bsp/uboot/u-boot-xilinx_git.bb
> @@ -1,9 +1,11 @@
> require ../meta/recipes-bsp/uboot/u-boot.inc
> -PR = "r2"
> +PR = "r3"
>
> +EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS='-O2'"
> BRANCH="master"
> TAG="e094f2479ea339d7f48b6826f06f0be4984d9a98"
> -SRC_URI = "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git"
> +SRC_URI = "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git \
> + "
> SRCREV = "${TAG}"
>
> inherit xilinx-boot
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 05/25][v3] u-boot: disable -Os option not supported by gcc
2011-01-26 18:00 ` Darren Hart
@ 2011-01-26 18:28 ` Saul Wold
2011-01-26 18:55 ` Adrian Alonso
0 siblings, 1 reply; 5+ messages in thread
From: Saul Wold @ 2011-01-26 18:28 UTC (permalink / raw)
To: Darren Hart; +Cc: Adrian Alonso, poky
On 01/26/2011 10:00 AM, Darren Hart wrote:
> On 01/26/2011 09:42 AM, Adrian Alonso wrote:
>> * Disable -Os optspace option not supported by gcc use insted -O2
>> * v2 Remove Make file patch
>> * v3 use EXTRA_OEMAKE variable, override default OPTFLAGS settings
>> in u-boot.inc, Powerpc targets build only with -O1, -O2 optflags
>> Build failures are related to gcc bugs #44392 and #45052
>> * Bump PR
>>
>> Signed-off-by: Adrian Alonso<aalonso@secretlab.ca>
>
> Looks good for the -Os problem.
>
> Reviewed-by: Darren Hart<dvhart@linux.intel.com>
>
> I noticed that the SRCREV is defined in this file.
> Typically this should be in
> meta/conf/distro/include/poky-default-revisions.inc
>
If I remember this correctly, these are in a layer, so the
default-revision.inc does not get updated.
Sau!
> --
> Darren
>
>
>> ---
>> recipes-bsp/uboot/u-boot-xilinx_git.bb | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes-bsp/uboot/u-boot-xilinx_git.bb
>> b/recipes-bsp/uboot/u-boot-xilinx_git.bb
>> index 50d99e3..a373428 100644
>> --- a/recipes-bsp/uboot/u-boot-xilinx_git.bb
>> +++ b/recipes-bsp/uboot/u-boot-xilinx_git.bb
>> @@ -1,9 +1,11 @@
>> require ../meta/recipes-bsp/uboot/u-boot.inc
>> -PR = "r2"
>> +PR = "r3"
>>
>> +EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS='-O2'"
>> BRANCH="master"
>> TAG="e094f2479ea339d7f48b6826f06f0be4984d9a98"
>> -SRC_URI =
>> "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git"
>> +SRC_URI =
>> "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git \
>> + "
>> SRCREV = "${TAG}"
>>
>> inherit xilinx-boot
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 05/25][v3] u-boot: disable -Os option not supported by gcc
2011-01-26 18:28 ` Saul Wold
@ 2011-01-26 18:55 ` Adrian Alonso
2011-01-26 19:32 ` Darren Hart
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Alonso @ 2011-01-26 18:55 UTC (permalink / raw)
To: Saul Wold; +Cc: poky
[-- Attachment #1: Type: text/plain, Size: 2322 bytes --]
Yep that's correct all 25 patch's belong to xilinx bsp meta layer;
I could define in the meta layer a revision inc file for all the recipes
that set a SRCREV version.
Regards
On Wed, Jan 26, 2011 at 12:28 PM, Saul Wold <sgw@linux.intel.com> wrote:
> On 01/26/2011 10:00 AM, Darren Hart wrote:
>
>> On 01/26/2011 09:42 AM, Adrian Alonso wrote:
>>
>>> * Disable -Os optspace option not supported by gcc use insted -O2
>>> * v2 Remove Make file patch
>>> * v3 use EXTRA_OEMAKE variable, override default OPTFLAGS settings
>>> in u-boot.inc, Powerpc targets build only with -O1, -O2 optflags
>>> Build failures are related to gcc bugs #44392 and #45052
>>> * Bump PR
>>>
>>> Signed-off-by: Adrian Alonso<aalonso@secretlab.ca>
>>>
>>
>> Looks good for the -Os problem.
>>
>> Reviewed-by: Darren Hart<dvhart@linux.intel.com>
>>
>> I noticed that the SRCREV is defined in this file.
>> Typically this should be in
>> meta/conf/distro/include/poky-default-revisions.inc
>>
>> If I remember this correctly, these are in a layer, so the
> default-revision.inc does not get updated.
>
> Sau!
>
>
> --
>> Darren
>>
>>
>> ---
>>> recipes-bsp/uboot/u-boot-xilinx_git.bb | 6 ++++--
>>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/recipes-bsp/uboot/u-boot-xilinx_git.bb
>>> b/recipes-bsp/uboot/u-boot-xilinx_git.bb
>>> index 50d99e3..a373428 100644
>>> --- a/recipes-bsp/uboot/u-boot-xilinx_git.bb
>>> +++ b/recipes-bsp/uboot/u-boot-xilinx_git.bb
>>> @@ -1,9 +1,11 @@
>>> require ../meta/recipes-bsp/uboot/u-boot.inc
>>> -PR = "r2"
>>> +PR = "r3"
>>>
>>> +EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS='-O2'"
>>> BRANCH="master"
>>> TAG="e094f2479ea339d7f48b6826f06f0be4984d9a98"
>>> -SRC_URI =
>>> "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git<http://git.xilinx.com/u-boot-xlnx.git;branch=$%7BBRANCH%7D;protocol=git>
>>> "
>>> +SRC_URI =
>>> "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git<http://git.xilinx.com/u-boot-xlnx.git;branch=$%7BBRANCH%7D;protocol=git>\
>>> + "
>>> SRCREV = "${TAG}"
>>>
>>> inherit xilinx-boot
>>>
>>
>>
>>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>
[-- Attachment #2: Type: text/html, Size: 3882 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 05/25][v3] u-boot: disable -Os option not supported by gcc
2011-01-26 18:55 ` Adrian Alonso
@ 2011-01-26 19:32 ` Darren Hart
0 siblings, 0 replies; 5+ messages in thread
From: Darren Hart @ 2011-01-26 19:32 UTC (permalink / raw)
To: Adrian Alonso; +Cc: poky
On 01/26/2011 10:55 AM, Adrian Alonso wrote:
> Yep that's correct all 25 patch's belong to xilinx bsp meta layer;
> I could define in the meta layer a revision inc file for all the recipes
> that set a SRCREV version.
Apologies, I missed that this was a layer. Putting the revisions in a
layer default-revisions include isn't a bad idea - it would make merging
anything into meta at a later date pretty easy. But there's nothing
wrong with it as is.
--
Darren
>
> Regards
>
> On Wed, Jan 26, 2011 at 12:28 PM, Saul Wold <sgw@linux.intel.com
> <mailto:sgw@linux.intel.com>> wrote:
>
> On 01/26/2011 10:00 AM, Darren Hart wrote:
>
> On 01/26/2011 09:42 AM, Adrian Alonso wrote:
>
> * Disable -Os optspace option not supported by gcc use
> insted -O2
> * v2 Remove Make file patch
> * v3 use EXTRA_OEMAKE variable, override default OPTFLAGS
> settings
> in u-boot.inc, Powerpc targets build only with -O1, -O2 optflags
> Build failures are related to gcc bugs #44392 and #45052
> * Bump PR
>
> Signed-off-by: Adrian Alonso<aalonso@secretlab.ca
> <mailto:aalonso@secretlab.ca>>
>
>
> Looks good for the -Os problem.
>
> Reviewed-by: Darren Hart<dvhart@linux.intel.com
> <mailto:dvhart@linux.intel.com>>
>
> I noticed that the SRCREV is defined in this file.
> Typically this should be in
> meta/conf/distro/include/poky-default-revisions.inc
>
> If I remember this correctly, these are in a layer, so the
> default-revision.inc does not get updated.
>
> Sau!
>
>
> --
> Darren
>
>
> ---
> recipes-bsp/uboot/u-boot-xilinx_git.bb
> <http://u-boot-xilinx_git.bb> | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-bsp/uboot/u-boot-xilinx_git.bb
> <http://u-boot-xilinx_git.bb>
> b/recipes-bsp/uboot/u-boot-xilinx_git.bb
> <http://u-boot-xilinx_git.bb>
> index 50d99e3..a373428 100644
> --- a/recipes-bsp/uboot/u-boot-xilinx_git.bb
> <http://u-boot-xilinx_git.bb>
> +++ b/recipes-bsp/uboot/u-boot-xilinx_git.bb
> <http://u-boot-xilinx_git.bb>
> @@ -1,9 +1,11 @@
> require ../meta/recipes-bsp/uboot/u-boot.inc
> -PR = "r2"
> +PR = "r3"
>
> +EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS='-O2'"
> BRANCH="master"
> TAG="e094f2479ea339d7f48b6826f06f0be4984d9a98"
> -SRC_URI =
> "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git
> <http://git.xilinx.com/u-boot-xlnx.git;branch=$%7BBRANCH%7D;protocol=git>"
> +SRC_URI =
> "git://git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git
> <http://git.xilinx.com/u-boot-xlnx.git;branch=$%7BBRANCH%7D;protocol=git>
> \
> + "
> SRCREV = "${TAG}"
>
> inherit xilinx-boot
>
>
>
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org <mailto:poky@yoctoproject.org>
> https://lists.yoctoproject.org/listinfo/poky
>
>
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-26 19:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-26 17:42 [PATCH 05/25][v3] u-boot: disable -Os option not supported by gcc Adrian Alonso
2011-01-26 18:00 ` Darren Hart
2011-01-26 18:28 ` Saul Wold
2011-01-26 18:55 ` Adrian Alonso
2011-01-26 19:32 ` Darren Hart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.