[lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of

[lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of

[Jean Delvare]

Hi all,

Here is a patch set moving lis3lv02d and hp_accel out of drivers/hwmon.
hp_accel goes where it belongs, i.e. drivers/platform/x86 (next to
hdaps.) For lis3lv02d, I would have preferred a more specific home, but
none seems to be suitable at the moment, so I went for drivers/misc. We
might revisit this later.

[PATCH 1/4] Let Kconfig handle lis3lv02d dependencies
[PATCH 2/4] Move hp_accel to drivers/platform/x86
[PATCH 3/4] Move lis3lv02d drivers to drivers/misc
[PATCH 4/4] hp_accel: Fix driver name

As with every patch moving files around, the patches look very large
but most of them can be ignored, all you really have to look at are the
Kconfig and Makefile changes.

Note that I don't have supported hardware so I wasn't able to test the
patches. So I would welcome testing as much as review.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of

[Éric Piel]

Op 19-02-11 14:12, Jean Delvare schreef:
> Hi all,
>
> Here is a patch set moving lis3lv02d and hp_accel out of drivers/hwmon.
> hp_accel goes where it belongs, i.e. drivers/platform/x86 (next to
> hdaps.) For lis3lv02d, I would have preferred a more specific home, but
> none seems to be suitable at the moment, so I went for drivers/misc. We
> might revisit this later.
>
> [PATCH 1/4] Let Kconfig handle lis3lv02d dependencies
> [PATCH 2/4] Move hp_accel to drivers/platform/x86
> [PATCH 3/4] Move lis3lv02d drivers to drivers/misc
> [PATCH 4/4] hp_accel: Fix driver name
>
> As with every patch moving files around, the patches look very large
> but most of them can be ignored, all you really have to look at are the
> Kconfig and Makefile changes.
>
> Note that I don't have supported hardware so I wasn't able to test the
> patches. So I would welcome testing as much as review.
>
Hello,
I'm completely fine with the move (it was in hwmon only because in the 
first place there were other accelerometers there). So here is my:
Acked-by: Éric Piel <eric.piel@tremplin-utc.net>

I'll try to test the changes tomorrow (on an HP notebook), to confirm.

BTW, why do hp_accel has to be in a different directory than the rest? 
To me it's just a different interface to the chip: ACPI/HP, instead of 
SPI or I²C.

See you,
Eric


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of

[Jean Delvare]

Hi Éric,

On Sun, 20 Feb 2011 19:16:24 +0100, Éric Piel wrote:
> Op 19-02-11 14:12, Jean Delvare schreef:
> > Hi all,
> >
> > Here is a patch set moving lis3lv02d and hp_accel out of drivers/hwmon.
> > hp_accel goes where it belongs, i.e. drivers/platform/x86 (next to
> > hdaps.) For lis3lv02d, I would have preferred a more specific home, but
> > none seems to be suitable at the moment, so I went for drivers/misc. We
> > might revisit this later.
> >
> > [PATCH 1/4] Let Kconfig handle lis3lv02d dependencies
> > [PATCH 2/4] Move hp_accel to drivers/platform/x86
> > [PATCH 3/4] Move lis3lv02d drivers to drivers/misc
> > [PATCH 4/4] hp_accel: Fix driver name
> >
> > As with every patch moving files around, the patches look very large
> > but most of them can be ignored, all you really have to look at are the
> > Kconfig and Makefile changes.
> >
> > Note that I don't have supported hardware so I wasn't able to test the
> > patches. So I would welcome testing as much as review.
> >
> Hello,
> I'm completely fine with the move (it was in hwmon only because in the 
> first place there were other accelerometers there). So here is my:
> Acked-by: Éric Piel <eric.piel@tremplin-utc.net>
> 
> I'll try to test the changes tomorrow (on an HP notebook), to confirm.

Thanks.

> BTW, why do hp_accel has to be in a different directory than the rest? 
> To me it's just a different interface to the chip: ACPI/HP, instead of 
> SPI or I²C.

The difference is that the interface is platform-specific, contrary to
the SPI and I2C interfaces which are platform-neutral.
Platform-specific drivers are supposed to go to drivers/platform, or at
least this is my understanding. Plus, hp_accel isn't only an interface
to the accelerometer chip, it also links with a led. Having hp_accel
next to hdaps does make sense, don't you think?

That being said, I don't have a strong opinion on this, and it will
have to be revisited the day all accelerometer drivers gain a dedicated
home anyway. If anyone disagree with my decision and has a motivated
suggestion for something better, please speak up.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of

[Jonathan Cameron]

On 02/19/11 13:12, Jean Delvare wrote:
> Hi all,
> 
> Here is a patch set moving lis3lv02d and hp_accel out of drivers/hwmon.
> hp_accel goes where it belongs, i.e. drivers/platform/x86 (next to
> hdaps.) For lis3lv02d, I would have preferred a more specific home, but
> none seems to be suitable at the moment, so I went for drivers/misc. We
> might revisit this later.
> 
> [PATCH 1/4] Let Kconfig handle lis3lv02d dependencies
> [PATCH 2/4] Move hp_accel to drivers/platform/x86
> [PATCH 3/4] Move lis3lv02d drivers to drivers/misc
> [PATCH 4/4] hp_accel: Fix driver name
> 
> As with every patch moving files around, the patches look very large
> but most of them can be ignored, all you really have to look at are the
> Kconfig and Makefile changes.
> 
> Note that I don't have supported hardware so I wasn't able to test the
> patches. So I would welcome testing as much as review.
Can't test either I'm afraid, but glad to see this move happened.
Fingers cross no one will ever submit an accelerometer to hwmon
again!

I was kind of hoping that Dmitry would be happy to take the lis3lv02d bit
into input given that seems to be the primary use of the device, but
this is probably a simpler move to make.

If they haven't already merged, feel free to add:

Acked-by: Jonathan Cameron <jic23@cam.ac.uk> to 

Jonathan

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of

[Jean Delvare]

Hi Jonathan,

On Mon, 21 Feb 2011 18:24:21 +0000, Jonathan Cameron wrote:
> On 02/19/11 13:12, Jean Delvare wrote:
> > Hi all,
> > 
> > Here is a patch set moving lis3lv02d and hp_accel out of drivers/hwmon.
> > hp_accel goes where it belongs, i.e. drivers/platform/x86 (next to
> > hdaps.) For lis3lv02d, I would have preferred a more specific home, but
> > none seems to be suitable at the moment, so I went for drivers/misc. We
> > might revisit this later.
> > 
> > [PATCH 1/4] Let Kconfig handle lis3lv02d dependencies
> > [PATCH 2/4] Move hp_accel to drivers/platform/x86
> > [PATCH 3/4] Move lis3lv02d drivers to drivers/misc
> > [PATCH 4/4] hp_accel: Fix driver name
> > 
> > As with every patch moving files around, the patches look very large
> > but most of them can be ignored, all you really have to look at are the
> > Kconfig and Makefile changes.
> > 
> > Note that I don't have supported hardware so I wasn't able to test the
> > patches. So I would welcome testing as much as review.
>
> Can't test either I'm afraid, but glad to see this move happened.
> Fingers cross no one will ever submit an accelerometer to hwmon
> again!
> 
> I was kind of hoping that Dmitry would be happy to take the lis3lv02d bit
> into input given that seems to be the primary use of the device, but
> this is probably a simpler move to make.

The last statement I have from Dmitry is from
http://lists.lm-sensors.org/pipermail/lm-sensors/2010-October/029814.html

"lis3lv02d could either go into drivers/misc or stay where it is for the
time being, pending resolution on overall IIO/Input/accelerometers
decision. I'd take it in input/misc but accelerometer guys need to
decide on common sysfs layout for such devices."

I don't know if things changed is this area?

> If they haven't already merged,

They are in my staging tree for the time being, which means they can
easily be amended. We have a few weeks left to do so if needed (until
the next merge window opens.)

> feel free to add:
> 
> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> to 

Thank you!

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of

[Jonathan Cameron]

On 02/22/11 09:21, Jean Delvare wrote:
> Hi Jonathan,
> 
> On Mon, 21 Feb 2011 18:24:21 +0000, Jonathan Cameron wrote:
>> On 02/19/11 13:12, Jean Delvare wrote:
>>> Hi all,
>>>
>>> Here is a patch set moving lis3lv02d and hp_accel out of drivers/hwmon.
>>> hp_accel goes where it belongs, i.e. drivers/platform/x86 (next to
>>> hdaps.) For lis3lv02d, I would have preferred a more specific home, but
>>> none seems to be suitable at the moment, so I went for drivers/misc. We
>>> might revisit this later.
>>>
>>> [PATCH 1/4] Let Kconfig handle lis3lv02d dependencies
>>> [PATCH 2/4] Move hp_accel to drivers/platform/x86
>>> [PATCH 3/4] Move lis3lv02d drivers to drivers/misc
>>> [PATCH 4/4] hp_accel: Fix driver name
>>>
>>> As with every patch moving files around, the patches look very large
>>> but most of them can be ignored, all you really have to look at are the
>>> Kconfig and Makefile changes.
>>>
>>> Note that I don't have supported hardware so I wasn't able to test the
>>> patches. So I would welcome testing as much as review.
>>
>> Can't test either I'm afraid, but glad to see this move happened.
>> Fingers cross no one will ever submit an accelerometer to hwmon
>> again!
>>
>> I was kind of hoping that Dmitry would be happy to take the lis3lv02d bit
>> into input given that seems to be the primary use of the device, but
>> this is probably a simpler move to make.
> 
> The last statement I have from Dmitry is from
> http://lists.lm-sensors.org/pipermail/lm-sensors/2010-October/029814.html
> 
> "lis3lv02d could either go into drivers/misc or stay where it is for the
> time being, pending resolution on overall IIO/Input/accelerometers
> decision. I'd take it in input/misc but accelerometer guys need to
> decide on common sysfs layout for such devices."
> 
> I don't know if things changed is this area?
Sadly not.  Hemanth contribute some thoughts on this when we were discussing
his cma3000 driver, but in the end for ease of merging, the sysfs bits were
dropped entirely.  Alan Cox has been posting a bma023 driver to linux-input
which has a totally device specific interface.  I suspect Dmitry will 
block that one on this basis so the discussion may well reopen. (I've just
written a reply to that suggesting that perhaps it should). Alan is
making some progress towards at least getting rid of some of the magic
numbers attributes in that driver.

Eric, are you happy to contribute on such a discussion?

As ever I'll approach it from what we have for IIO as we have a wider
range of device types than anyone else, but within reason I'm happy to
propose changes to IIO's interfaces as long as they don't break with
our requirements of generality, specificness and ease of understanding.
> 
>> If they haven't already merged,
> 
> They are in my staging tree for the time being, which means they can
> easily be amended. We have a few weeks left to do so if needed (until
> the next merge window opens.)
Cool.
> 
>> feel free to add:
>>
>> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> to 
> 
> Thank you!
> 


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of

[Éric Piel]

Op 20-02-11 19:16, Éric Piel schreef:
> Op 19-02-11 14:12, Jean Delvare schreef:
:
> Hello,
> I'm completely fine with the move (it was in hwmon only because in the
> first place there were other accelerometers there). So here is my:
> Acked-by: Éric Piel <eric.piel@tremplin-utc.net>
>
> I'll try to test the changes tomorrow (on an HP notebook), to confirm.
Hi,
I've tested the patches. They work fine on my hardware :-)

Éric




_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of

[Takashi Iwai]

At Sat, 19 Feb 2011 14:12:19 +0100,
Jean Delvare wrote:
> 
> Hi all,
> 
> Here is a patch set moving lis3lv02d and hp_accel out of drivers/hwmon.
> hp_accel goes where it belongs, i.e. drivers/platform/x86 (next to
> hdaps.) For lis3lv02d, I would have preferred a more specific home, but
> none seems to be suitable at the moment, so I went for drivers/misc. We
> might revisit this later.
> 
> [PATCH 1/4] Let Kconfig handle lis3lv02d dependencies
> [PATCH 2/4] Move hp_accel to drivers/platform/x86
> [PATCH 3/4] Move lis3lv02d drivers to drivers/misc
> [PATCH 4/4] hp_accel: Fix driver name
> 
> As with every patch moving files around, the patches look very large
> but most of them can be ignored, all you really have to look at are the
> Kconfig and Makefile changes.
> 
> Note that I don't have supported hardware so I wasn't able to test the
> patches. So I would welcome testing as much as review.

It worked fine on a HP laptop here.

Tested-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 0/4] Move lis3lv02d and hp_accel out of

[Jean Delvare]

On Thu, 24 Feb 2011 10:14:50 +0100, Takashi Iwai wrote:
> At Sat, 19 Feb 2011 14:12:19 +0100,
> Jean Delvare wrote:
> > 
> > Hi all,
> > 
> > Here is a patch set moving lis3lv02d and hp_accel out of drivers/hwmon.
> > hp_accel goes where it belongs, i.e. drivers/platform/x86 (next to
> > hdaps.) For lis3lv02d, I would have preferred a more specific home, but
> > none seems to be suitable at the moment, so I went for drivers/misc. We
> > might revisit this later.
> > 
> > [PATCH 1/4] Let Kconfig handle lis3lv02d dependencies
> > [PATCH 2/4] Move hp_accel to drivers/platform/x86
> > [PATCH 3/4] Move lis3lv02d drivers to drivers/misc
> > [PATCH 4/4] hp_accel: Fix driver name
> > 
> > As with every patch moving files around, the patches look very large
> > but most of them can be ignored, all you really have to look at are the
> > Kconfig and Makefile changes.
> > 
> > Note that I don't have supported hardware so I wasn't able to test the
> > patches. So I would welcome testing as much as review.
> 
> It worked fine on a HP laptop here.
> 
> Tested-by: Takashi Iwai <tiwai@suse.de>

Thanks for the testing, Éric and Takashi!

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors