* [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection
@ 2011-05-25 4:39 Angus Ainslie
2011-05-25 17:54 ` Kukjin Kim
0 siblings, 1 reply; 8+ messages in thread
From: Angus Ainslie @ 2011-05-25 4:39 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Giridhar Maruthy, samsung, kgene.kim, patches, angus.ainslie
From: Giridhar Maruthy <giridhar.maruthy@linaro.org>
Whenever I2S is selected, select MFD for WM8994 and I2C
to avoid manual enabling of the codec and I2C.
Signed-off-by: Giridhar Maruthy <giridhar.maruthy@linaro.org>
Signed-off-by: Angus Ainslie <angus.ainslie@linaro.org>
---
sound/soc/samsung/Kconfig | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
index a3fdfb6..a80eeb1 100644
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -65,6 +65,9 @@ config SND_SOC_SAMSUNG_SMDK_WM8994
tristate "SoC I2S Audio support for WM8994 on SMDK"
depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210)
select SND_SOC_WM8994
+ select MFD_SUPPORT
+ select I2C_S3C2410
+ select MFD_WM8994
select SND_SAMSUNG_I2S
help
Say Y if you want to add support for SoC audio on the SMDKs.
--
1.7.4.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection
2011-05-25 4:39 [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection Angus Ainslie
@ 2011-05-25 17:54 ` Kukjin Kim
2011-05-25 18:15 ` Jassi Brar
0 siblings, 1 reply; 8+ messages in thread
From: Kukjin Kim @ 2011-05-25 17:54 UTC (permalink / raw)
To: Angus Ainslie
Cc: linux-samsung-soc, Giridhar Maruthy, samsung, kgene.kim, patches,
jassisinghbrar, lrg, broonie
On 05/24/11 21:39, Angus Ainslie wrote:
> From: Giridhar Maruthy<giridhar.maruthy@linaro.org>
>
> Whenever I2S is selected, select MFD for WM8994 and I2C
> to avoid manual enabling of the codec and I2C.
>
> Signed-off-by: Giridhar Maruthy<giridhar.maruthy@linaro.org>
> Signed-off-by: Angus Ainslie<angus.ainslie@linaro.org>
> ---
> sound/soc/samsung/Kconfig | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
Hi Angus :)
Hmm...first of all, should add proper maintainers in Cc. In this case,
Jassi, Liam, and Mark should be added in Cc. (Cc'ed them)
> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
> index a3fdfb6..a80eeb1 100644
> --- a/sound/soc/samsung/Kconfig
> +++ b/sound/soc/samsung/Kconfig
> @@ -65,6 +65,9 @@ config SND_SOC_SAMSUNG_SMDK_WM8994
> tristate "SoC I2S Audio support for WM8994 on SMDK"
> depends on SND_SOC_SAMSUNG&& (MACH_SMDKV310 || MACH_SMDKC210)
> select SND_SOC_WM8994
> + select MFD_SUPPORT
> + select I2C_S3C2410
> + select MFD_WM8994
I'm not sure about MFD configs, but if "select I2C_S3C2410" is required,
it should be moved into regarding Kconfig of arch/arm, because it is
related to dependency of ARCH. Maybe in this case,
arch/arm/mach-exynos4/Kconfig?
diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
index e849f67..30b716e 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -12,6 +12,7 @@ if ARCH_EXYNOS4
config CPU_EXYNOS4210
bool
select S3C_PL330_DMA
+ select I2C_S3C2410
help
Enable EXYNOS4210 CPU support
> select SND_SAMSUNG_I2S
> help
> Say Y if you want to add support for SoC audio on the SMDKs.
--
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection
2011-05-25 17:54 ` Kukjin Kim
@ 2011-05-25 18:15 ` Jassi Brar
2011-05-25 18:48 ` Kukjin Kim
2011-05-26 14:24 ` Mark Brown
0 siblings, 2 replies; 8+ messages in thread
From: Jassi Brar @ 2011-05-25 18:15 UTC (permalink / raw)
To: Kukjin Kim
Cc: Angus Ainslie, linux-samsung-soc, Giridhar Maruthy, samsung,
patches, lrg, broonie
>> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
>> index a3fdfb6..a80eeb1 100644
>> --- a/sound/soc/samsung/Kconfig
>> +++ b/sound/soc/samsung/Kconfig
>> @@ -65,6 +65,9 @@ config SND_SOC_SAMSUNG_SMDK_WM8994
>> tristate "SoC I2S Audio support for WM8994 on SMDK"
>> depends on SND_SOC_SAMSUNG&& (MACH_SMDKV310 || MACH_SMDKC210)
>> select SND_SOC_WM8994
>> + select MFD_SUPPORT
>> + select I2C_S3C2410
>> + select MFD_WM8994
>
> I'm not sure about MFD configs, but if "select I2C_S3C2410" is required, it
> should be moved into regarding Kconfig of arch/arm, because it is related to
> dependency of ARCH. Maybe in this case, arch/arm/mach-exynos4/Kconfig?
I2C here is a SMDK specific requirement and even if most devices need I2C,
selecting I2C for every EXYNOS4210 based device is not ideal. IMO it'd better
be tied to some SMDK specific config option.
Cheer!
Jassi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection
2011-05-25 18:15 ` Jassi Brar
@ 2011-05-25 18:48 ` Kukjin Kim
2011-05-26 14:24 ` Mark Brown
1 sibling, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2011-05-25 18:48 UTC (permalink / raw)
To: Jassi Brar
Cc: Kukjin Kim, Angus Ainslie, linux-samsung-soc, Giridhar Maruthy,
samsung, patches, lrg, broonie
On 05/25/11 11:15, Jassi Brar wrote:
>>> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
>>> index a3fdfb6..a80eeb1 100644
>>> --- a/sound/soc/samsung/Kconfig
>>> +++ b/sound/soc/samsung/Kconfig
>>> @@ -65,6 +65,9 @@ config SND_SOC_SAMSUNG_SMDK_WM8994
>>> tristate "SoC I2S Audio support for WM8994 on SMDK"
>>> depends on SND_SOC_SAMSUNG&& (MACH_SMDKV310 || MACH_SMDKC210)
>>> select SND_SOC_WM8994
>>> + select MFD_SUPPORT
>>> + select I2C_S3C2410
>>> + select MFD_WM8994
>>
>> I'm not sure about MFD configs, but if "select I2C_S3C2410" is required, it
>> should be moved into regarding Kconfig of arch/arm, because it is related to
>> dependency of ARCH. Maybe in this case, arch/arm/mach-exynos4/Kconfig?
>
> I2C here is a SMDK specific requirement and even if most devices need I2C,
> selecting I2C for every EXYNOS4210 based device is not ideal. IMO it'd better
> be tied to some SMDK specific config option.
>
Hi Jassi :)
How are you?
Hmm...need to think again because as you know, basically all of boards
can be compiled with one exynos4_defconfig.
Ok, so you agreed it should be moved into some Kconfig of arch/arm/ :)
I will think again which one is more reasonable then let you know.
--
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection
2011-05-25 18:15 ` Jassi Brar
2011-05-25 18:48 ` Kukjin Kim
@ 2011-05-26 14:24 ` Mark Brown
2011-05-26 15:02 ` Jassi Brar
1 sibling, 1 reply; 8+ messages in thread
From: Mark Brown @ 2011-05-26 14:24 UTC (permalink / raw)
To: Jassi Brar
Cc: Kukjin Kim, Angus Ainslie, linux-samsung-soc, Giridhar Maruthy,
samsung, patches, lrg
On Wed, May 25, 2011 at 11:45:37PM +0530, Jassi Brar wrote:
> I2C here is a SMDK specific requirement and even if most devices need I2C,
> selecting I2C for every EXYNOS4210 based device is not ideal. IMO it'd better
> be tied to some SMDK specific config option.
Given that it's the audio machine driver the dependency on I2C doesn't
seem unreasonable - the CODEC will generally be I2C connected so I2C is
going to be required for the driver to do anything useful. Might be
better to just add a dependency on the WM8994 MFD, though, which does
roughly the same thing.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection
2011-05-26 14:24 ` Mark Brown
@ 2011-05-26 15:02 ` Jassi Brar
0 siblings, 0 replies; 8+ messages in thread
From: Jassi Brar @ 2011-05-26 15:02 UTC (permalink / raw)
To: Mark Brown
Cc: Kukjin Kim, Angus Ainslie, linux-samsung-soc, Giridhar Maruthy,
samsung, patches, lrg
On Thu, May 26, 2011 at 7:54 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, May 25, 2011 at 11:45:37PM +0530, Jassi Brar wrote:
>
>> I2C here is a SMDK specific requirement and even if most devices need I2C,
>> selecting I2C for every EXYNOS4210 based device is not ideal. IMO it'd better
>> be tied to some SMDK specific config option.
>
> Given that it's the audio machine driver the dependency on I2C doesn't
> seem unreasonable
Yup, actually I am not dead against the submitted patch... it's just
that historically
Samsung ASoC doesn't include I2C dependency, so why now.
> - the CODEC will generally be I2C connected so I2C is
> going to be required for the driver to do anything useful. Might be
> better to just add a dependency on the WM8994 MFD, though, which does
> roughly the same thing.
Should do too.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection
@ 2011-05-31 5:40 Giridhar Maruthy
2011-05-31 10:07 ` Mark Brown
0 siblings, 1 reply; 8+ messages in thread
From: Giridhar Maruthy @ 2011-05-31 5:40 UTC (permalink / raw)
To: linux-samsung-soc
Cc: angus.ainslie, kgene.kim, samsung, jassisinghbrar, lrg, broonie,
Giridhar Maruthy
Whenever I2S is selected, select MFD for WM8994 and I2C
to avoid manual enabling of the codec and I2C.
Signed-off-by: Giridhar Maruthy <giridhar.maruthy@linaro.org>
Signed-off-by: Angus Ainslie <angus.ainslie@linaro.org>
---
arch/arm/mach-exynos4/Kconfig | 1 +
sound/soc/samsung/Kconfig | 2 ++
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
index e849f67..da00863 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -12,6 +12,7 @@ if ARCH_EXYNOS4
config CPU_EXYNOS4210
bool
select S3C_PL330_DMA
+ select I2C_S3C2410 if MFD_WM8994
help
Enable EXYNOS4210 CPU support
diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
index a3fdfb6..d8654c6 100644
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -65,6 +65,8 @@ config SND_SOC_SAMSUNG_SMDK_WM8994
tristate "SoC I2S Audio support for WM8994 on SMDK"
depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210)
select SND_SOC_WM8994
+ select MFD_SUPPORT
+ select MFD_WM8994
select SND_SAMSUNG_I2S
help
Say Y if you want to add support for SoC audio on the SMDKs.
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection
2011-05-31 5:40 Giridhar Maruthy
@ 2011-05-31 10:07 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2011-05-31 10:07 UTC (permalink / raw)
To: Giridhar Maruthy
Cc: linux-samsung-soc, angus.ainslie, kgene.kim, samsung,
jassisinghbrar, lrg
On Tue, May 31, 2011 at 11:10:36AM +0530, Giridhar Maruthy wrote:
> --- a/arch/arm/mach-exynos4/Kconfig
> +++ b/arch/arm/mach-exynos4/Kconfig
> @@ -12,6 +12,7 @@ if ARCH_EXYNOS4
> config CPU_EXYNOS4210
> bool
> select S3C_PL330_DMA
> + select I2C_S3C2410 if MFD_WM8994
> help
> Enable EXYNOS4210 CPU support
>
No, this is all due to the audio machine. Put this in the individual
boards or in the audio driver.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-05-31 10:07 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-25 4:39 [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection Angus Ainslie
2011-05-25 17:54 ` Kukjin Kim
2011-05-25 18:15 ` Jassi Brar
2011-05-25 18:48 ` Kukjin Kim
2011-05-26 14:24 ` Mark Brown
2011-05-26 15:02 ` Jassi Brar
-- strict thread matches above, loose matches on Subject: below --
2011-05-31 5:40 Giridhar Maruthy
2011-05-31 10:07 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.