From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: david@fromorbit.com
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong
Date: Mon, 20 Jun 2011 13:30:29 +0900 [thread overview]
Message-ID: <4DFECCE5.5030409@jp.fujitsu.com> (raw)
In-Reply-To: <20110620012531.GN561@dastard>
>> Looks great fix. Please remove tracepoint change from this patch and send it
>> to -stable. iow, I expect I'll ack your next spin.
>
> I don't believe such a change belongs in -stable. This code has been
> buggy for many years and as I mentioned it actually makes existing
> bad shrinker behaviour worse. I don't test stable kernels, so I've
> got no idea what side effects it will have outside of this series.
> I'm extremely hesitant to change VM behaviour in stable kernels
> without having tested first, so I'm not going to push it for stable
> kernels.
Ok, I have no strong opinion.
>
> If you want it in stable kernels, then you can always let
> stable@kernel.org know once the commits are in the mainline tree and
> you've tested them...
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: david@fromorbit.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, xfs@oss.sgi.com
Subject: Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong
Date: Mon, 20 Jun 2011 13:30:29 +0900 [thread overview]
Message-ID: <4DFECCE5.5030409@jp.fujitsu.com> (raw)
In-Reply-To: <20110620012531.GN561@dastard>
>> Looks great fix. Please remove tracepoint change from this patch and send it
>> to -stable. iow, I expect I'll ack your next spin.
>
> I don't believe such a change belongs in -stable. This code has been
> buggy for many years and as I mentioned it actually makes existing
> bad shrinker behaviour worse. I don't test stable kernels, so I've
> got no idea what side effects it will have outside of this series.
> I'm extremely hesitant to change VM behaviour in stable kernels
> without having tested first, so I'm not going to push it for stable
> kernels.
Ok, I have no strong opinion.
>
> If you want it in stable kernels, then you can always let
> stable@kernel.org know once the commits are in the mainline tree and
> you've tested them...
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: david@fromorbit.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, xfs@oss.sgi.com
Subject: Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong
Date: Mon, 20 Jun 2011 13:30:29 +0900 [thread overview]
Message-ID: <4DFECCE5.5030409@jp.fujitsu.com> (raw)
In-Reply-To: <20110620012531.GN561@dastard>
>> Looks great fix. Please remove tracepoint change from this patch and send it
>> to -stable. iow, I expect I'll ack your next spin.
>
> I don't believe such a change belongs in -stable. This code has been
> buggy for many years and as I mentioned it actually makes existing
> bad shrinker behaviour worse. I don't test stable kernels, so I've
> got no idea what side effects it will have outside of this series.
> I'm extremely hesitant to change VM behaviour in stable kernels
> without having tested first, so I'm not going to push it for stable
> kernels.
Ok, I have no strong opinion.
>
> If you want it in stable kernels, then you can always let
> stable@kernel.org know once the commits are in the mainline tree and
> you've tested them...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-20 4:30 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 7:00 [PATCH 0/12] Per superblock cache reclaim Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-02 7:00 ` [PATCH 01/12] vmscan: add shrink_slab tracepoints Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-20 0:44 ` KOSAKI Motohiro
2011-06-20 0:44 ` KOSAKI Motohiro
2011-06-20 0:44 ` KOSAKI Motohiro
2011-06-20 0:44 ` KOSAKI Motohiro
2011-06-20 0:53 ` Dave Chinner
2011-06-20 0:53 ` Dave Chinner
2011-06-20 0:53 ` Dave Chinner
2011-06-20 0:53 ` Dave Chinner
2011-06-02 7:00 ` [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-20 0:46 ` KOSAKI Motohiro
2011-06-20 0:46 ` KOSAKI Motohiro
2011-06-20 0:46 ` KOSAKI Motohiro
2011-06-20 1:25 ` Dave Chinner
2011-06-20 1:25 ` Dave Chinner
2011-06-20 1:25 ` Dave Chinner
2011-06-20 4:30 ` KOSAKI Motohiro [this message]
2011-06-20 4:30 ` KOSAKI Motohiro
2011-06-20 4:30 ` KOSAKI Motohiro
2011-06-02 7:00 ` [PATCH 03/12] vmscan: reduce wind up shrinker->nr when shrinker can't do work Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-20 0:51 ` KOSAKI Motohiro
2011-06-20 0:51 ` KOSAKI Motohiro
2011-06-20 0:51 ` KOSAKI Motohiro
2011-06-20 0:51 ` KOSAKI Motohiro
2011-06-21 5:09 ` Dave Chinner
2011-06-21 5:09 ` Dave Chinner
2011-06-21 5:09 ` Dave Chinner
2011-06-21 5:09 ` Dave Chinner
2011-06-21 5:27 ` KOSAKI Motohiro
2011-06-21 5:27 ` KOSAKI Motohiro
2011-06-21 5:27 ` KOSAKI Motohiro
2011-06-02 7:00 ` [PATCH 04/12] vmscan: add customisable shrinker batch size Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-02 7:00 ` Dave Chinner
2011-06-02 7:01 ` [PATCH 05/12] inode: convert inode_stat.nr_unused to per-cpu counters Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` [PATCH 06/12] inode: Make unused inode LRU per superblock Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-04 0:25 ` Al Viro
2011-06-04 0:25 ` Al Viro
2011-06-04 0:25 ` Al Viro
2011-06-04 1:40 ` Dave Chinner
2011-06-04 1:40 ` Dave Chinner
2011-06-04 1:40 ` Dave Chinner
2011-06-02 7:01 ` [PATCH 07/12] inode: move to per-sb LRU locks Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-04 0:42 ` Al Viro
2011-06-04 0:42 ` Al Viro
2011-06-04 0:42 ` Al Viro
2011-06-04 1:52 ` Dave Chinner
2011-06-04 1:52 ` Dave Chinner
2011-06-04 1:52 ` Dave Chinner
2011-06-04 14:08 ` Christoph Hellwig
2011-06-04 14:08 ` Christoph Hellwig
2011-06-04 14:08 ` Christoph Hellwig
2011-06-04 14:19 ` Al Viro
2011-06-04 14:19 ` Al Viro
2011-06-04 14:19 ` Al Viro
2011-06-04 14:24 ` Al Viro
2011-06-04 14:24 ` Al Viro
2011-06-04 14:24 ` Al Viro
2011-06-02 7:01 ` [PATCH 09/12] inode: remove iprune_sem Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` [PATCH 10/12] superblock: add filesystem shrinker operations Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` [PATCH 11/12] vfs: increase shrinker batch size Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 9:30 ` Nicolas Kaiser
2011-06-02 9:30 ` Nicolas Kaiser
2011-06-02 9:30 ` Nicolas Kaiser
2011-06-02 7:01 ` [PATCH 12/12] xfs: make use of new shrinker callout for the inode cache Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-02 7:01 ` Dave Chinner
2011-06-16 11:33 ` [PATCH 0/12] Per superblock cache reclaim Christoph Hellwig
2011-06-16 11:33 ` Christoph Hellwig
2011-06-16 11:33 ` Christoph Hellwig
2011-06-17 3:35 ` KOSAKI Motohiro
2011-06-17 3:35 ` KOSAKI Motohiro
2011-06-17 3:35 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFECCE5.5030409@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.