* Re: [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem
2011-06-20 8:14 [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem tunables Max Matveev
@ 2011-06-20 8:29 ` Shan Wei
2011-06-20 8:36 ` Max Matveev
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Shan Wei @ 2011-06-20 8:29 UTC (permalink / raw)
To: linux-sctp
Max Matveev wrote, at 06/20/2011 04:14 PM:
>
> sctp does not use second and third ("default" and "max") values
> of sctp_(r|w)mem tunables. The format is the same and tcp_(r|w)mem
> but the meaning is different so make the documentation explicit to
> avoid confusion.
>
> Signed-off-by: Max Matveev <makc@redhat.com>
I can't open the attachment.
Please include your patch contents in the mail.
So that be convenient to review.
--
Best Regards
-----
Shan Wei
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem
2011-06-20 8:14 [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem tunables Max Matveev
2011-06-20 8:29 ` [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem Shan Wei
@ 2011-06-20 8:36 ` Max Matveev
2011-06-20 9:41 ` Shan Wei
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Max Matveev @ 2011-06-20 8:36 UTC (permalink / raw)
To: linux-sctp
On Mon, 20 Jun 2011 16:29:25 +0800, Shan Wei wrote:
shanwei> I can't open the attachment.
shanwei> Please include your patch contents in the mail.
shanwei> So that be convenient to review.
commit 7bc21f45041b9e2619e59c9c1f8a2368f0bb0aa1
Author: Max Matveev <makc@redhat.com>
Date: Mon Jun 20 18:08:10 2011 +1000
Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem tunables
sctp does not use second and third ("default" and "max") values
of sctp_(r|w)mem tunables. The format is the same and tcp_(r|w)mem
but the meaning is different so make the documentation explicit to
avoid confusion.
Signed-off-by: Max Matveev <makc@redhat.com>
diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index d3d653a..81734c0 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -1465,10 +1465,23 @@ sctp_mem - vector of 3 INTEGERs: min, pressure, max
Default is calculated at boot time from amount of available memory.
sctp_rmem - vector of 3 INTEGERs: min, default, max
- See tcp_rmem for a description.
+ Only the first value ("min") is used, "default" and "max" are
+ ignored and may be removed in the future versions.
+
+ min: Minimal size of receive buffer used by SCTP socket.
+ It is guaranteed to each STCP socket (but not association) even
+ under moderate memory pressure.
+
+ Default: 1 page
sctp_wmem - vector of 3 INTEGERs: min, default, max
- See tcp_wmem for a description.
+ Only the first value ("min") is used, "default" and "max" are
+ ignored and may be removed in the future versions.
+
+ min: Amount of memory reserved for send buffers for SCTP sockets.
+ Each SCTP socket has rights to use it due to fact of its birth.
+
+ Default: 1 page
addr_scope_policy - INTEGER
Control IPv4 address scoping - draft-stewart-tsvwg-sctp-ipv4-00
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem
2011-06-20 8:14 [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem tunables Max Matveev
2011-06-20 8:29 ` [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem Shan Wei
2011-06-20 8:36 ` Max Matveev
@ 2011-06-20 9:41 ` Shan Wei
2011-06-20 18:49 ` [PATCH] Update description of net.sctp.sctp_rmem and David Miller
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Shan Wei @ 2011-06-20 9:41 UTC (permalink / raw)
To: linux-sctp
Hi
Some comments inline.
And Cc David Miller who maybe will accepte your patch.
Max Matveev wrote, at 06/20/2011 04:36 PM:
> On Mon, 20 Jun 2011 16:29:25 +0800, Shan Wei wrote:
>
> shanwei> I can't open the attachment.
> shanwei> Please include your patch contents in the mail.
> shanwei> So that be convenient to review.
>
> commit 7bc21f45041b9e2619e59c9c1f8a2368f0bb0aa1
> Author: Max Matveev <makc@redhat.com>
> Date: Mon Jun 20 18:08:10 2011 +1000
>
> Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem tunables
>
> sctp does not use second and third ("default" and "max") values
> of sctp_(r|w)mem tunables. The format is the same and tcp_(r|w)mem
> but the meaning is different so make the documentation explicit to
> avoid confusion.
>
> Signed-off-by: Max Matveev <makc@redhat.com>
>
> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> index d3d653a..81734c0 100644
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -1465,10 +1465,23 @@ sctp_mem - vector of 3 INTEGERs: min, pressure, max
> Default is calculated at boot time from amount of available memory.
>
> sctp_rmem - vector of 3 INTEGERs: min, default, max
> - See tcp_rmem for a description.
> + Only the first value ("min") is used, "default" and "max" are
> + ignored and may be removed in the future versions.
> +
> + min: Minimal size of receive buffer used by SCTP socket.
> + It is guaranteed to each STCP socket (but not association) even
> + under moderate memory pressure.
> +
> + Default: 1 page
how about 4K?
>
> sctp_wmem - vector of 3 INTEGERs: min, default, max
> - See tcp_wmem for a description.
> + Only the first value ("min") is used, "default" and "max" are
> + ignored and may be removed in the future versions.
sctp_wmem parameter include all three fields never be used by sctp protocol.
The min value is not used.
> +
> + min: Amount of memory reserved for send buffers for SCTP sockets.
> + Each SCTP socket has rights to use it due to fact of its birth.
> +
> + Default: 1 page
>
> addr_scope_policy - INTEGER
> Control IPv4 address scoping - draft-stewart-tsvwg-sctp-ipv4-00
>
>
>
--
Best Regards
-----
Shan Wei
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Update description of net.sctp.sctp_rmem and
2011-06-20 8:14 [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem tunables Max Matveev
` (2 preceding siblings ...)
2011-06-20 9:41 ` Shan Wei
@ 2011-06-20 18:49 ` David Miller
2011-06-21 1:29 ` [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem Max Matveev
2011-06-21 2:16 ` Shan Wei
5 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2011-06-20 18:49 UTC (permalink / raw)
To: linux-sctp
From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Mon, 20 Jun 2011 17:41:07 +0800
> Hi
>
> Some comments inline.
> And Cc David Miller who maybe will accepte your patch.
Patches need to be submitted to netdev@vger.kernel.org
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem
2011-06-20 8:14 [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem tunables Max Matveev
` (3 preceding siblings ...)
2011-06-20 18:49 ` [PATCH] Update description of net.sctp.sctp_rmem and David Miller
@ 2011-06-21 1:29 ` Max Matveev
2011-06-21 2:16 ` Shan Wei
5 siblings, 0 replies; 7+ messages in thread
From: Max Matveev @ 2011-06-21 1:29 UTC (permalink / raw)
To: linux-sctp
On Mon, 20 Jun 2011 17:41:07 +0800, Shan Wei wrote:
shanwei> Max Matveev wrote, at 06/20/2011 04:36 PM:
>> On Mon, 20 Jun 2011 16:29:25 +0800, Shan Wei wrote:
>>
>> + Default: 1 page
shanwei> how about 4K?
Not everybody uses 4K pages. I can change it to 4K but it will be
(technically) incorrect.
>>
>> sctp_wmem - vector of 3 INTEGERs: min, default, max
>> - See tcp_wmem for a description.
>> + Only the first value ("min") is used, "default" and "max" are
>> + ignored and may be removed in the future versions.
shanwei> sctp_wmem parameter include all three fields never be used
shanwei> by sctp protocol. The min value is not used.
I was trying to avoid the embarrassment of admitting that there is a
tunable which does nothing. Should I add another patch to remove
the tunable?
max
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem
2011-06-20 8:14 [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem tunables Max Matveev
` (4 preceding siblings ...)
2011-06-21 1:29 ` [PATCH] Update description of net.sctp.sctp_rmem and net.sctp.sctp_wmem Max Matveev
@ 2011-06-21 2:16 ` Shan Wei
5 siblings, 0 replies; 7+ messages in thread
From: Shan Wei @ 2011-06-21 2:16 UTC (permalink / raw)
To: linux-sctp
Max Matveev wrote, at 06/21/2011 09:29 AM:
> On Mon, 20 Jun 2011 17:41:07 +0800, Shan Wei wrote:
>
> shanwei> Max Matveev wrote, at 06/20/2011 04:36 PM:
> >> On Mon, 20 Jun 2011 16:29:25 +0800, Shan Wei wrote:
> >>
> >> + Default: 1 page
>
> shanwei> how about 4K?
>
> Not everybody uses 4K pages. I can change it to 4K but it will be
> (technically) incorrect.
Use "1 Page" is more exact.
Other parameters(tcp_rmem, tcp_rmem, udp_rmem_min) directly
use magic number(4K or 4096).
So also need same change.
>
> >>
> >> sctp_wmem - vector of 3 INTEGERs: min, default, max
> >> - See tcp_wmem for a description.
> >> + Only the first value ("min") is used, "default" and "max" are
> >> + ignored and may be removed in the future versions.
>
> shanwei> sctp_wmem parameter include all three fields never be used
> shanwei> by sctp protocol. The min value is not used.
>
> I was trying to avoid the embarrassment of admitting that there is a
> tunable which does nothing. Should I add another patch to remove
> the tunable?
No.
Currently, sctp protocol does't implement tunable memory management.
Just provide an interface to user, but no function.
What we need is to implement it, not remove the interface simply.
>
> max
>
--
Best Regards
-----
Shan Wei
^ permalink raw reply [flat|nested] 7+ messages in thread