Re: [Qemu-devel] [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids

[Alexander Graf <agraf@suse.de>]

On 06/22/2011 05:58 PM, anthony.perard@citrix.com wrote:
> From: Anthony PERARD<anthony.perard@citrix.com>
>
> Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
> ---
>   hw/piix_pci.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 26ce904..d08b31a 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
>           .no_hotplug   = 1,
>           .init         = piix3_initfn,
>           .config_write = piix3_write_config_xen,
> +        .vendor_id    = PCI_VENDOR_ID_INTEL,
> +        .device_id    = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1)
> +        .class_id     = PCI_CLASS_BRIDGE_ISA,
>       },{
>           /* end of list */
>       }

$ ./scripts/checkpatch.pl ~/patch-xen/anthony1/\[PATCH\]\ 
hw_piix_pci.c\:\ Fix\ PIIX3-xen\ to\ initialize\ ids.eml
WARNING: line over 80 characters
#70: FILE: hw/piix_pci.c:482:
+        .device_id    = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 
PCI-to-ISA bridge (Step A1)

ERROR: do not use C99 // comments
#70: FILE: hw/piix_pci.c:482:
+        .device_id    = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 
PCI-to-ISA bridge (Step A1)

total: 1 errors, 1 warnings, 9 lines checked