* [Qemu-devel] [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
@ 2011-06-22 15:58 ` anthony.perard
0 siblings, 0 replies; 10+ messages in thread
From: anthony.perard @ 2011-06-22 15:58 UTC (permalink / raw)
To: QEMU-devel, Anthony Liguori
Cc: Anthony PERARD, Xen Devel, Alexander Graf, Stefano Stabellini
From: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
hw/piix_pci.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 26ce904..d08b31a 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
.no_hotplug = 1,
.init = piix3_initfn,
.config_write = piix3_write_config_xen,
+ .vendor_id = PCI_VENDOR_ID_INTEL,
+ .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1)
+ .class_id = PCI_CLASS_BRIDGE_ISA,
},{
/* end of list */
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
@ 2011-06-22 15:58 ` anthony.perard
0 siblings, 0 replies; 10+ messages in thread
From: anthony.perard @ 2011-06-22 15:58 UTC (permalink / raw)
To: QEMU-devel, Anthony Liguori
Cc: Anthony PERARD, Xen Devel, Alexander Graf, Stefano Stabellini
From: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
hw/piix_pci.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 26ce904..d08b31a 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
.no_hotplug = 1,
.init = piix3_initfn,
.config_write = piix3_write_config_xen,
+ .vendor_id = PCI_VENDOR_ID_INTEL,
+ .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1)
+ .class_id = PCI_CLASS_BRIDGE_ISA,
},{
/* end of list */
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
2011-06-22 15:58 ` anthony.perard
@ 2011-06-22 17:43 ` Stefano Stabellini
-1 siblings, 0 replies; 10+ messages in thread
From: Stefano Stabellini @ 2011-06-22 17:43 UTC (permalink / raw)
To: anthony.perard@citrix.com
Cc: Alexander Graf, Xen Devel, QEMU-devel, Stefano Stabellini
On Wed, 22 Jun 2011, anthony.perard@citrix.com wrote:
> From: Anthony PERARD <anthony.perard@citrix.com>
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> hw/piix_pci.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 26ce904..d08b31a 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
> .no_hotplug = 1,
> .init = piix3_initfn,
> .config_write = piix3_write_config_xen,
> + .vendor_id = PCI_VENDOR_ID_INTEL,
> + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1)
> + .class_id = PCI_CLASS_BRIDGE_ISA,
> },{
> /* end of list */
> }
shouldn't piix3_initfn take care of setting vendor_id, device_id and
class_id, as in the normal PIIX3 case?
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
@ 2011-06-22 17:43 ` Stefano Stabellini
0 siblings, 0 replies; 10+ messages in thread
From: Stefano Stabellini @ 2011-06-22 17:43 UTC (permalink / raw)
To: anthony.perard@citrix.com
Cc: Alexander Graf, Xen Devel, QEMU-devel, Anthony Liguori,
Stefano Stabellini
On Wed, 22 Jun 2011, anthony.perard@citrix.com wrote:
> From: Anthony PERARD <anthony.perard@citrix.com>
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> hw/piix_pci.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 26ce904..d08b31a 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
> .no_hotplug = 1,
> .init = piix3_initfn,
> .config_write = piix3_write_config_xen,
> + .vendor_id = PCI_VENDOR_ID_INTEL,
> + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1)
> + .class_id = PCI_CLASS_BRIDGE_ISA,
> },{
> /* end of list */
> }
shouldn't piix3_initfn take care of setting vendor_id, device_id and
class_id, as in the normal PIIX3 case?
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [Xen-devel] Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
2011-06-22 17:43 ` Stefano Stabellini
@ 2011-06-22 17:48 ` Anthony PERARD
-1 siblings, 0 replies; 10+ messages in thread
From: Anthony PERARD @ 2011-06-22 17:48 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: Anthony PERARD, Xen Devel, Alexander Graf, QEMU-devel
On Wed, Jun 22, 2011 at 18:43, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:
> On Wed, 22 Jun 2011, anthony.perard@citrix.com wrote:
>> From: Anthony PERARD <anthony.perard@citrix.com>
>>
>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>> ---
>> hw/piix_pci.c | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
>> index 26ce904..d08b31a 100644
>> --- a/hw/piix_pci.c
>> +++ b/hw/piix_pci.c
>> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
>> .no_hotplug = 1,
>> .init = piix3_initfn,
>> .config_write = piix3_write_config_xen,
>> + .vendor_id = PCI_VENDOR_ID_INTEL,
>> + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1)
>> + .class_id = PCI_CLASS_BRIDGE_ISA,
>> },{
>> /* end of list */
>> }
>
> shouldn't piix3_initfn take care of setting vendor_id, device_id and
> class_id, as in the normal PIIX3 case?
Not anymore. These ids have been removed from piix3_initfn and added
to the PCIDeviceInfo of PIIX3 in the last update.
--
Anthony PERARD
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
@ 2011-06-22 17:48 ` Anthony PERARD
0 siblings, 0 replies; 10+ messages in thread
From: Anthony PERARD @ 2011-06-22 17:48 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: Anthony PERARD, Xen Devel, Alexander Graf, QEMU-devel
On Wed, Jun 22, 2011 at 18:43, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:
> On Wed, 22 Jun 2011, anthony.perard@citrix.com wrote:
>> From: Anthony PERARD <anthony.perard@citrix.com>
>>
>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>> ---
>> hw/piix_pci.c | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
>> index 26ce904..d08b31a 100644
>> --- a/hw/piix_pci.c
>> +++ b/hw/piix_pci.c
>> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
>> .no_hotplug = 1,
>> .init = piix3_initfn,
>> .config_write = piix3_write_config_xen,
>> + .vendor_id = PCI_VENDOR_ID_INTEL,
>> + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1)
>> + .class_id = PCI_CLASS_BRIDGE_ISA,
>> },{
>> /* end of list */
>> }
>
> shouldn't piix3_initfn take care of setting vendor_id, device_id and
> class_id, as in the normal PIIX3 case?
Not anymore. These ids have been removed from piix3_initfn and added
to the PCIDeviceInfo of PIIX3 in the last update.
--
Anthony PERARD
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [Xen-devel] Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
2011-06-22 17:48 ` Anthony PERARD
@ 2011-06-22 18:00 ` Stefano Stabellini
-1 siblings, 0 replies; 10+ messages in thread
From: Stefano Stabellini @ 2011-06-22 18:00 UTC (permalink / raw)
To: Anthony PERARD; +Cc: QEMU-devel, Xen Devel, Alexander Graf, Stefano Stabellini
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
On Wed, 22 Jun 2011, Anthony PERARD wrote:
> On Wed, Jun 22, 2011 at 18:43, Stefano Stabellini
> <stefano.stabellini@eu.citrix.com> wrote:
> > On Wed, 22 Jun 2011, anthony.perard@citrix.com wrote:
> >> From: Anthony PERARD <anthony.perard@citrix.com>
> >>
> >> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> >> ---
> >> hw/piix_pci.c | 3 +++
> >> 1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> >> index 26ce904..d08b31a 100644
> >> --- a/hw/piix_pci.c
> >> +++ b/hw/piix_pci.c
> >> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
> >> .no_hotplug = 1,
> >> .init = piix3_initfn,
> >> .config_write = piix3_write_config_xen,
> >> + .vendor_id = PCI_VENDOR_ID_INTEL,
> >> + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1)
> >> + .class_id = PCI_CLASS_BRIDGE_ISA,
> >> },{
> >> /* end of list */
> >> }
> >
> > shouldn't piix3_initfn take care of setting vendor_id, device_id and
> > class_id, as in the normal PIIX3 case?
>
> Not anymore. These ids have been removed from piix3_initfn and added
> to the PCIDeviceInfo of PIIX3 in the last update.
I see. Good catch.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
@ 2011-06-22 18:00 ` Stefano Stabellini
0 siblings, 0 replies; 10+ messages in thread
From: Stefano Stabellini @ 2011-06-22 18:00 UTC (permalink / raw)
To: Anthony PERARD; +Cc: QEMU-devel, Xen Devel, Alexander Graf, Stefano Stabellini
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
On Wed, 22 Jun 2011, Anthony PERARD wrote:
> On Wed, Jun 22, 2011 at 18:43, Stefano Stabellini
> <stefano.stabellini@eu.citrix.com> wrote:
> > On Wed, 22 Jun 2011, anthony.perard@citrix.com wrote:
> >> From: Anthony PERARD <anthony.perard@citrix.com>
> >>
> >> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> >> ---
> >> hw/piix_pci.c | 3 +++
> >> 1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> >> index 26ce904..d08b31a 100644
> >> --- a/hw/piix_pci.c
> >> +++ b/hw/piix_pci.c
> >> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
> >> .no_hotplug = 1,
> >> .init = piix3_initfn,
> >> .config_write = piix3_write_config_xen,
> >> + .vendor_id = PCI_VENDOR_ID_INTEL,
> >> + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1)
> >> + .class_id = PCI_CLASS_BRIDGE_ISA,
> >> },{
> >> /* end of list */
> >> }
> >
> > shouldn't piix3_initfn take care of setting vendor_id, device_id and
> > class_id, as in the normal PIIX3 case?
>
> Not anymore. These ids have been removed from piix3_initfn and added
> to the PCIDeviceInfo of PIIX3 in the last update.
I see. Good catch.
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
2011-06-22 15:58 ` anthony.perard
@ 2011-06-30 11:34 ` Alexander Graf
-1 siblings, 0 replies; 10+ messages in thread
From: Alexander Graf @ 2011-06-30 11:34 UTC (permalink / raw)
To: anthony.perard; +Cc: Xen Devel, QEMU-devel, Stefano Stabellini
On 06/22/2011 05:58 PM, anthony.perard@citrix.com wrote:
> From: Anthony PERARD<anthony.perard@citrix.com>
>
> Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
> ---
> hw/piix_pci.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 26ce904..d08b31a 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
> .no_hotplug = 1,
> .init = piix3_initfn,
> .config_write = piix3_write_config_xen,
> + .vendor_id = PCI_VENDOR_ID_INTEL,
> + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1)
> + .class_id = PCI_CLASS_BRIDGE_ISA,
> },{
> /* end of list */
> }
$ ./scripts/checkpatch.pl ~/patch-xen/anthony1/\[PATCH\]\
hw_piix_pci.c\:\ Fix\ PIIX3-xen\ to\ initialize\ ids.eml
WARNING: line over 80 characters
#70: FILE: hw/piix_pci.c:482:
+ .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3
PCI-to-ISA bridge (Step A1)
ERROR: do not use C99 // comments
#70: FILE: hw/piix_pci.c:482:
+ .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3
PCI-to-ISA bridge (Step A1)
total: 1 errors, 1 warnings, 9 lines checked
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids
@ 2011-06-30 11:34 ` Alexander Graf
0 siblings, 0 replies; 10+ messages in thread
From: Alexander Graf @ 2011-06-30 11:34 UTC (permalink / raw)
To: anthony.perard; +Cc: Xen Devel, QEMU-devel, Anthony Liguori, Stefano Stabellini
On 06/22/2011 05:58 PM, anthony.perard@citrix.com wrote:
> From: Anthony PERARD<anthony.perard@citrix.com>
>
> Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
> ---
> hw/piix_pci.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 26ce904..d08b31a 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
> .no_hotplug = 1,
> .init = piix3_initfn,
> .config_write = piix3_write_config_xen,
> + .vendor_id = PCI_VENDOR_ID_INTEL,
> + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1)
> + .class_id = PCI_CLASS_BRIDGE_ISA,
> },{
> /* end of list */
> }
$ ./scripts/checkpatch.pl ~/patch-xen/anthony1/\[PATCH\]\
hw_piix_pci.c\:\ Fix\ PIIX3-xen\ to\ initialize\ ids.eml
WARNING: line over 80 characters
#70: FILE: hw/piix_pci.c:482:
+ .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3
PCI-to-ISA bridge (Step A1)
ERROR: do not use C99 // comments
#70: FILE: hw/piix_pci.c:482:
+ .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3
PCI-to-ISA bridge (Step A1)
total: 1 errors, 1 warnings, 9 lines checked
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-06-30 11:34 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-22 15:58 [Qemu-devel] [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids anthony.perard
2011-06-22 15:58 ` anthony.perard
2011-06-22 17:43 ` [Qemu-devel] " Stefano Stabellini
2011-06-22 17:43 ` Stefano Stabellini
2011-06-22 17:48 ` [Qemu-devel] [Xen-devel] " Anthony PERARD
2011-06-22 17:48 ` Anthony PERARD
2011-06-22 18:00 ` [Qemu-devel] [Xen-devel] " Stefano Stabellini
2011-06-22 18:00 ` Stefano Stabellini
2011-06-30 11:34 ` [Qemu-devel] " Alexander Graf
2011-06-30 11:34 ` Alexander Graf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.