From: Paolo Bonzini <pbonzini@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: virtio-scsi spec (was Re: [PATCH] Add virtio-scsi to the virtio spec)
Date: Thu, 01 Dec 2011 09:49:20 +0100 [thread overview]
Message-ID: <4ED73F90.5050603@redhat.com> (raw)
In-Reply-To: <4ED74E54.3070303@suse.de>
On 12/01/2011 10:52 AM, Hannes Reinecke wrote:
>>>>
>>> I would like to have the other request_queue limitations exposed
>>> here, too.
>>> Most notably we're missing the maximum size of an individual segment
>>> and the maximum size of the overall I/O request.
>>
>> The virtio transport does not put any limit, as far as I know.
>>
> Virtio doesn't, but the underlying device/driver might.
> And if we don't expose these values we cannot format the request correctly.
These limits should be per target/LUN, so it seems like material for
another controlq command when the need arises. For now, I'd really
prefer to have the spec match the implementation (plus a few SAM
bogosities).
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: virtio-scsi spec (was Re: [PATCH] Add virtio-scsi to the virtio spec)
Date: Thu, 01 Dec 2011 09:49:20 +0100 [thread overview]
Message-ID: <4ED73F90.5050603@redhat.com> (raw)
In-Reply-To: <4ED74E54.3070303@suse.de>
On 12/01/2011 10:52 AM, Hannes Reinecke wrote:
>>>>
>>> I would like to have the other request_queue limitations exposed
>>> here, too.
>>> Most notably we're missing the maximum size of an individual segment
>>> and the maximum size of the overall I/O request.
>>
>> The virtio transport does not put any limit, as far as I know.
>>
> Virtio doesn't, but the underlying device/driver might.
> And if we don't expose these values we cannot format the request correctly.
These limits should be per target/LUN, so it seems like material for
another controlq command when the need arises. For now, I'd really
prefer to have the spec match the implementation (plus a few SAM
bogosities).
Paolo
next prev parent reply other threads:[~2011-12-01 8:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 13:50 [PATCH] Add virtio-scsi to the virtio spec Paolo Bonzini
2011-11-30 13:50 ` Paolo Bonzini
2011-11-30 13:50 ` virtio-scsi spec (was Re: [PATCH] Add virtio-scsi to the virtio spec) Paolo Bonzini
2011-11-30 13:50 ` Paolo Bonzini
2011-11-30 14:17 ` Hannes Reinecke
2011-11-30 14:17 ` Hannes Reinecke
2011-11-30 16:36 ` Paolo Bonzini
2011-11-30 16:36 ` Paolo Bonzini
2011-12-01 9:52 ` Hannes Reinecke
2011-12-01 9:52 ` Hannes Reinecke
2011-12-01 8:49 ` Paolo Bonzini [this message]
2011-12-01 8:49 ` Paolo Bonzini
2011-12-01 3:14 ` [PATCH] Add virtio-scsi to the virtio spec Rusty Russell
2011-12-01 3:14 ` Rusty Russell
2011-12-01 8:55 ` Paolo Bonzini
2011-12-01 8:55 ` Paolo Bonzini
2011-12-02 0:51 ` Rusty Russell
2011-12-02 0:51 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED73F90.5050603@redhat.com \
--to=pbonzini@redhat.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.