From: Rusty Russell <rusty@rustcorp.com.au>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] Add virtio-scsi to the virtio spec
Date: Fri, 02 Dec 2011 11:21:44 +1030 [thread overview]
Message-ID: <87ty5jre1r.fsf@rustcorp.com.au> (raw)
In-Reply-To: <4ED74102.6040207@redhat.com>
On Thu, 01 Dec 2011 09:55:30 +0100, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 12/01/2011 04:14 AM, Rusty Russell wrote:
> > I'd prefer to see the spec only cover things
> > which are implemented and tested, otherwise the risk of a flaw in the
> > spec is really high in my experience.
>
> In general I agree, and I did that for virtio-specific things such as
> the eventq and the configuration space. This is also why I don't want
> to add untested controlq requests that people suggested.
>
> However, there's tension between this and providing a complete SCSI
> transport. SCSI is roughly defined as a set of RPC interfaces ("Send
> command", "Abort task", etc.) and transports provide the RPC protocol.
> The SCSI command set changes relatively often, but the RPC interfaces
> are pretty stable. This stability limits the risk, and having a mapping
> for all interfaces also makes future changes less likely.
OK, I expect that someone reading the spec will be SCSI-familiar more
than virtio-familiar, so it's more important that they be comfortable,
than that I be comfortable.
Thanks!
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: virtualization <virtualization@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] Add virtio-scsi to the virtio spec
Date: Fri, 02 Dec 2011 11:21:44 +1030 [thread overview]
Message-ID: <87ty5jre1r.fsf@rustcorp.com.au> (raw)
In-Reply-To: <4ED74102.6040207@redhat.com>
On Thu, 01 Dec 2011 09:55:30 +0100, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 12/01/2011 04:14 AM, Rusty Russell wrote:
> > I'd prefer to see the spec only cover things
> > which are implemented and tested, otherwise the risk of a flaw in the
> > spec is really high in my experience.
>
> In general I agree, and I did that for virtio-specific things such as
> the eventq and the configuration space. This is also why I don't want
> to add untested controlq requests that people suggested.
>
> However, there's tension between this and providing a complete SCSI
> transport. SCSI is roughly defined as a set of RPC interfaces ("Send
> command", "Abort task", etc.) and transports provide the RPC protocol.
> The SCSI command set changes relatively often, but the RPC interfaces
> are pretty stable. This stability limits the risk, and having a mapping
> for all interfaces also makes future changes less likely.
OK, I expect that someone reading the spec will be SCSI-familiar more
than virtio-familiar, so it's more important that they be comfortable,
than that I be comfortable.
Thanks!
Rusty.
next prev parent reply other threads:[~2011-12-02 0:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 13:50 [PATCH] Add virtio-scsi to the virtio spec Paolo Bonzini
2011-11-30 13:50 ` Paolo Bonzini
2011-11-30 13:50 ` virtio-scsi spec (was Re: [PATCH] Add virtio-scsi to the virtio spec) Paolo Bonzini
2011-11-30 13:50 ` Paolo Bonzini
2011-11-30 14:17 ` Hannes Reinecke
2011-11-30 14:17 ` Hannes Reinecke
2011-11-30 16:36 ` Paolo Bonzini
2011-11-30 16:36 ` Paolo Bonzini
2011-12-01 9:52 ` Hannes Reinecke
2011-12-01 9:52 ` Hannes Reinecke
2011-12-01 8:49 ` Paolo Bonzini
2011-12-01 8:49 ` Paolo Bonzini
2011-12-01 3:14 ` [PATCH] Add virtio-scsi to the virtio spec Rusty Russell
2011-12-01 3:14 ` Rusty Russell
2011-12-01 8:55 ` Paolo Bonzini
2011-12-01 8:55 ` Paolo Bonzini
2011-12-02 0:51 ` Rusty Russell [this message]
2011-12-02 0:51 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ty5jre1r.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.