From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: [PATCH 7/7] b43: N-PHY: implement spurious tone avoidance
Date: Sat, 10 Dec 2011 21:06:53 -0600 [thread overview]
Message-ID: <4EE41E4D.3050702@lwfinger.net> (raw)
In-Reply-To: <1323568535-2816-8-git-send-email-zajec5@gmail.com>
On 12/10/2011 07:55 PM, Rafa? Mi?ecki wrote:
>
> Signed-off-by: Rafa? Mi?ecki<zajec5@gmail.com>
> ---
> drivers/net/wireless/b43/phy_n.c | 90 +++++++++++++++++++++++++++++++++++++-
> 1 files changed, 88 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
> index 114c413..6e776d0 100644
> --- a/drivers/net/wireless/b43/phy_n.c
> +++ b/drivers/net/wireless/b43/phy_n.c
> @@ -4023,6 +4023,58 @@ int b43_phy_initn(struct b43_wldev *dev)
> return 0;
> }
>
> +static void b43_nphy_pmu_spur_avoid(struct b43_wldev *dev, bool avoid)
> +{
> + struct bcma_drv_cc *cc =&dev->dev->bdev->bus->drv_cc;
> + u32 pmu_ctl;
> + if (dev->dev->chip_id == 43224 || dev->dev->chip_id == 43225) {
> + if (avoid) {
> + bcma_chipco_pll_write(cc, 0x0, 0x11500010);
> + bcma_chipco_pll_write(cc, 0x1, 0x000C0C06);
> + bcma_chipco_pll_write(cc, 0x2, 0x0F600a08);
> + bcma_chipco_pll_write(cc, 0x3, 0x00000000);
> + bcma_chipco_pll_write(cc, 0x4, 0x2001E920);
> + bcma_chipco_pll_write(cc, 0x5, 0x88888815);
> + } else {
> + bcma_chipco_pll_write(cc, 0x0, 0x11100010);
> + bcma_chipco_pll_write(cc, 0x1, 0x000c0c06);
> + bcma_chipco_pll_write(cc, 0x2, 0x03000a08);
> + bcma_chipco_pll_write(cc, 0x3, 0x00000000);
> + bcma_chipco_pll_write(cc, 0x4, 0x200005c0);
> + bcma_chipco_pll_write(cc, 0x5, 0x88888815);
> + }
> + pmu_ctl = BCMA_CC_PMU_CTL_PLL_UPD;
> + } else if (dev->dev->chip_id == 0x4716) {
> + if (avoid) {
> + bcma_chipco_pll_write(cc, 0x0, 0x11500060);
> + bcma_chipco_pll_write(cc, 0x1, 0x080C0C06);
> + bcma_chipco_pll_write(cc, 0x2, 0x0F600000);
> + bcma_chipco_pll_write(cc, 0x3, 0x00000000);
> + bcma_chipco_pll_write(cc, 0x4, 0x2001E924);
> + bcma_chipco_pll_write(cc, 0x5, 0x88888815);
> + } else {
> + bcma_chipco_pll_write(cc, 0x0, 0x11100060);
> + bcma_chipco_pll_write(cc, 0x1, 0x080c0c06);
> + bcma_chipco_pll_write(cc, 0x2, 0x03000000);
> + bcma_chipco_pll_write(cc, 0x3, 0x00000000);
> + bcma_chipco_pll_write(cc, 0x4, 0x200005c0);
> + bcma_chipco_pll_write(cc, 0x5, 0x88888815);
> + }
> + pmu_ctl = BCMA_CC_PMU_CTL_PLL_UPD | BCMA_CC_PMU_CTL_NOILPONW;
> + } else if (dev->dev->chip_id == 0x4322 || dev->dev->chip_id == 0x4340 ||
> + dev->dev->chip_id == 0x4341) {
> + bcma_chipco_pll_write(cc, 0x0, 0x11100070);
> + bcma_chipco_pll_write(cc, 0x1, 0x1014140a);
> + bcma_chipco_pll_write(cc, 0x5, 0x88888854);
> + if (avoid)
> + bcma_chipco_pll_write(cc, 0x2, 0x05201828);
> + else
> + bcma_chipco_pll_write(cc, 0x2, 0x05001828);
> + pmu_ctl = BCMA_CC_PMU_CTL_PLL_UPD;
> + }
> + bcma_cc_set32(cc, BCMA_CC_PMU_CTL, pmu_ctl);
My gcc is brain dead here and outputs
CC [M] drivers/net/wireless/b43/phy_n.o
drivers/net/wireless/b43/phy_n.c: In function ?b43_nphy_channel_setup.isra.14?:
drivers/net/wireless/b43/phy_n.c:4075:2: warning: ?pmu_ctl? may be used
uninitialized in this function [-Wuninitialized]
drivers/net/wireless/b43/phy_n.c:4029:6: note: ?pmu_ctl? was declared here
The variable is clearly set in all paths, but I still get the warning.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH 7/7] b43: N-PHY: implement spurious tone avoidance
Date: Sat, 10 Dec 2011 21:06:53 -0600 [thread overview]
Message-ID: <4EE41E4D.3050702@lwfinger.net> (raw)
In-Reply-To: <1323568535-2816-8-git-send-email-zajec5@gmail.com>
On 12/10/2011 07:55 PM, Rafał Miłecki wrote:
>
> Signed-off-by: Rafał Miłecki<zajec5@gmail.com>
> ---
> drivers/net/wireless/b43/phy_n.c | 90 +++++++++++++++++++++++++++++++++++++-
> 1 files changed, 88 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
> index 114c413..6e776d0 100644
> --- a/drivers/net/wireless/b43/phy_n.c
> +++ b/drivers/net/wireless/b43/phy_n.c
> @@ -4023,6 +4023,58 @@ int b43_phy_initn(struct b43_wldev *dev)
> return 0;
> }
>
> +static void b43_nphy_pmu_spur_avoid(struct b43_wldev *dev, bool avoid)
> +{
> + struct bcma_drv_cc *cc =&dev->dev->bdev->bus->drv_cc;
> + u32 pmu_ctl;
> + if (dev->dev->chip_id == 43224 || dev->dev->chip_id == 43225) {
> + if (avoid) {
> + bcma_chipco_pll_write(cc, 0x0, 0x11500010);
> + bcma_chipco_pll_write(cc, 0x1, 0x000C0C06);
> + bcma_chipco_pll_write(cc, 0x2, 0x0F600a08);
> + bcma_chipco_pll_write(cc, 0x3, 0x00000000);
> + bcma_chipco_pll_write(cc, 0x4, 0x2001E920);
> + bcma_chipco_pll_write(cc, 0x5, 0x88888815);
> + } else {
> + bcma_chipco_pll_write(cc, 0x0, 0x11100010);
> + bcma_chipco_pll_write(cc, 0x1, 0x000c0c06);
> + bcma_chipco_pll_write(cc, 0x2, 0x03000a08);
> + bcma_chipco_pll_write(cc, 0x3, 0x00000000);
> + bcma_chipco_pll_write(cc, 0x4, 0x200005c0);
> + bcma_chipco_pll_write(cc, 0x5, 0x88888815);
> + }
> + pmu_ctl = BCMA_CC_PMU_CTL_PLL_UPD;
> + } else if (dev->dev->chip_id == 0x4716) {
> + if (avoid) {
> + bcma_chipco_pll_write(cc, 0x0, 0x11500060);
> + bcma_chipco_pll_write(cc, 0x1, 0x080C0C06);
> + bcma_chipco_pll_write(cc, 0x2, 0x0F600000);
> + bcma_chipco_pll_write(cc, 0x3, 0x00000000);
> + bcma_chipco_pll_write(cc, 0x4, 0x2001E924);
> + bcma_chipco_pll_write(cc, 0x5, 0x88888815);
> + } else {
> + bcma_chipco_pll_write(cc, 0x0, 0x11100060);
> + bcma_chipco_pll_write(cc, 0x1, 0x080c0c06);
> + bcma_chipco_pll_write(cc, 0x2, 0x03000000);
> + bcma_chipco_pll_write(cc, 0x3, 0x00000000);
> + bcma_chipco_pll_write(cc, 0x4, 0x200005c0);
> + bcma_chipco_pll_write(cc, 0x5, 0x88888815);
> + }
> + pmu_ctl = BCMA_CC_PMU_CTL_PLL_UPD | BCMA_CC_PMU_CTL_NOILPONW;
> + } else if (dev->dev->chip_id == 0x4322 || dev->dev->chip_id == 0x4340 ||
> + dev->dev->chip_id == 0x4341) {
> + bcma_chipco_pll_write(cc, 0x0, 0x11100070);
> + bcma_chipco_pll_write(cc, 0x1, 0x1014140a);
> + bcma_chipco_pll_write(cc, 0x5, 0x88888854);
> + if (avoid)
> + bcma_chipco_pll_write(cc, 0x2, 0x05201828);
> + else
> + bcma_chipco_pll_write(cc, 0x2, 0x05001828);
> + pmu_ctl = BCMA_CC_PMU_CTL_PLL_UPD;
> + }
> + bcma_cc_set32(cc, BCMA_CC_PMU_CTL, pmu_ctl);
My gcc is brain dead here and outputs
CC [M] drivers/net/wireless/b43/phy_n.o
drivers/net/wireless/b43/phy_n.c: In function ‘b43_nphy_channel_setup.isra.14’:
drivers/net/wireless/b43/phy_n.c:4075:2: warning: ‘pmu_ctl’ may be used
uninitialized in this function [-Wuninitialized]
drivers/net/wireless/b43/phy_n.c:4029:6: note: ‘pmu_ctl’ was declared here
The variable is clearly set in all paths, but I still get the warning.
Larry
next prev parent reply other threads:[~2011-12-11 3:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 1:55 [PATCH 0/7] b43: N-PHY fixes, check dependency before applying Rafał Miłecki
2011-12-11 1:55 ` Rafał Miłecki
2011-12-11 1:55 ` [PATCH 1/7] b43: N-PHY: random trivial fixes for typos, missing writes Rafał Miłecki
2011-12-11 1:55 ` Rafał Miłecki
2011-12-11 1:55 ` [PATCH 2/7] b43: N-PHY: update some init values Rafał Miłecki
2011-12-11 1:55 ` Rafał Miłecki
2011-12-11 1:55 ` [PATCH 3/7] b43: N-PHY: workaround BCM43224 hw bug in writing table id 9 Rafał Miłecki
2011-12-11 1:55 ` Rafał Miłecki
2011-12-11 1:55 ` [PATCH 4/7] b43: N-PHY: add table for antenna software control Rafał Miłecki
2011-12-11 1:55 ` Rafał Miłecki
2011-12-11 1:55 ` [PATCH 5/7] b43: N-PHY: determine various PHY params Rafał Miłecki
2011-12-11 1:55 ` Rafał Miłecki
2011-12-11 1:55 ` [PATCH 6/7] b43: N-PHY: finish 2.4GHz 0x2056 radio setup Rafał Miłecki
2011-12-11 1:55 ` Rafał Miłecki
2011-12-11 1:55 ` [PATCH 7/7] b43: N-PHY: implement spurious tone avoidance Rafał Miłecki
2011-12-11 1:55 ` Rafał Miłecki
2011-12-11 3:06 ` Larry Finger [this message]
2011-12-11 3:06 ` Larry Finger
2011-12-11 4:08 ` Julian Calaby
2011-12-11 3:25 ` [PATCH 0/7] b43: N-PHY fixes, check dependency before applying Larry Finger
2011-12-11 3:25 ` Larry Finger
2011-12-11 3:37 ` Larry Finger
2011-12-11 3:37 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE41E4D.3050702@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.