[PATCH 1/1] remove usbgadget from routerstationpro

[PATCH 1/1] remove usbgadget from routerstationpro

[Zumeng Chen]

  1. No mass storage needed to be accessed by usbgadget.
  2. This is a router station & switch, so it should not
     be taken as a USB_NET device too.

Signed-off-by: Zumeng.chen@windriver.com>
---
 meta-yocto/conf/machine/routerstationpro.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta-yocto/conf/machine/routerstationpro.conf b/meta-yocto/conf/machine/routerstationpro.conf
index 9338ca1..52124d9 100644
--- a/meta-yocto/conf/machine/routerstationpro.conf
+++ b/meta-yocto/conf/machine/routerstationpro.conf
@@ -5,7 +5,7 @@
 require conf/machine/include/tune-mips32.inc
 
 MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
-                    serial usbgadget"
+                    serial"
 
 KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
-- 
1.7.5.4

Re: [PATCH 1/1] remove usbgadget from routerstationpro

[Bruce Ashfield]

On 11-12-14 04:31 AM, Zumeng Chen wrote:
>    1. No mass storage needed to be accessed by usbgadget.
>    2. This is a router station&  switch, so it should not
>       be taken as a USB_NET device too.

Zumeng,

The comment from the bug reporter was also that the target
doesn't have USB slave hardware to support usbgadget. So mentioning
that in the header is probably a good idea as well.

And small comment indicating that as a result of these conditions,
we remove usbgadget from MACHINE_FEATURES, since it can't be used.
Would complete the header.

Cheers,

Bruce

>
> Signed-off-by: Zumeng.chen@windriver.com>
> ---
>   meta-yocto/conf/machine/routerstationpro.conf |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta-yocto/conf/machine/routerstationpro.conf b/meta-yocto/conf/machine/routerstationpro.conf
> index 9338ca1..52124d9 100644
> --- a/meta-yocto/conf/machine/routerstationpro.conf
> +++ b/meta-yocto/conf/machine/routerstationpro.conf
> @@ -5,7 +5,7 @@
>   require conf/machine/include/tune-mips32.inc
>
>   MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
> -                    serial usbgadget"
> +                    serial"
>
>   KERNEL_IMAGETYPE = "vmlinux"
>   KERNEL_ALT_IMAGETYPE = "vmlinux.bin"

Re: [PATCH 1/1] remove usbgadget from routerstationpro

[Zumeng Chen]

于 2011年12月14日 22:20, Bruce Ashfield 写道:
> On 11-12-14 04:31 AM, Zumeng Chen wrote:
>> 1. No mass storage needed to be accessed by usbgadget.
>> 2. This is a router station& switch, so it should not
>> be taken as a USB_NET device too.
>
> Zumeng,
>
> The comment from the bug reporter was also that the target
> doesn't have USB slave hardware to support usbgadget. So mentioning
> that in the header is probably a good idea as well.
OK, will add it, generally speaking MTD can be used as the slave,
but obviously it's meaningless here. Soon V2

Regards,
Zumeng
>
> And small comment indicating that as a result of these conditions,
> we remove usbgadget from MACHINE_FEATURES, since it can't be used.
> Would complete the header.
>
> Cheers,
>
> Bruce
>
>>
>> Signed-off-by: Zumeng.chen@windriver.com>
>> ---
>> meta-yocto/conf/machine/routerstationpro.conf | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta-yocto/conf/machine/routerstationpro.conf 
>> b/meta-yocto/conf/machine/routerstationpro.conf
>> index 9338ca1..52124d9 100644
>> --- a/meta-yocto/conf/machine/routerstationpro.conf
>> +++ b/meta-yocto/conf/machine/routerstationpro.conf
>> @@ -5,7 +5,7 @@
>> require conf/machine/include/tune-mips32.inc
>>
>> MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
>> - serial usbgadget"
>> + serial"
>>
>> KERNEL_IMAGETYPE = "vmlinux"
>> KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
>

[V2 PATCH 1/1] remove usbgadget from routerstationpro

[Zumeng Chen]

  Since the target doesn't have the related requirement
  to use USB slave hardware supporting usb gadget, so
  remove it from MACHINE_FEATURES.

Signed-off-by: Zumeng.chen@windriver.com>
---
 meta-yocto/conf/machine/routerstationpro.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta-yocto/conf/machine/routerstationpro.conf b/meta-yocto/conf/machine/routerstationpro.conf
index 9338ca1..52124d9 100644
--- a/meta-yocto/conf/machine/routerstationpro.conf
+++ b/meta-yocto/conf/machine/routerstationpro.conf
@@ -5,7 +5,7 @@
 require conf/machine/include/tune-mips32.inc
 
 MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
-                    serial usbgadget"
+                    serial"
 
 KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
-- 
1.7.5.4

Re: [V2 PATCH 1/1] remove usbgadget from routerstationpro

[Bruce Ashfield]

On 11-12-14 8:02 PM, Zumeng Chen wrote:
>    Since the target doesn't have the related requirement
>    to use USB slave hardware supporting usb gadget, so
>    remove it from MACHINE_FEATURES.

Indention went a bit out of whack there, but the wording is what
we want.

Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>


>
> Signed-off-by: Zumeng.chen@windriver.com>
> ---
>   meta-yocto/conf/machine/routerstationpro.conf |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta-yocto/conf/machine/routerstationpro.conf b/meta-yocto/conf/machine/routerstationpro.conf
> index 9338ca1..52124d9 100644
> --- a/meta-yocto/conf/machine/routerstationpro.conf
> +++ b/meta-yocto/conf/machine/routerstationpro.conf
> @@ -5,7 +5,7 @@
>   require conf/machine/include/tune-mips32.inc
>
>   MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
> -                    serial usbgadget"
> +                    serial"
>
>   KERNEL_IMAGETYPE = "vmlinux"
>   KERNEL_ALT_IMAGETYPE = "vmlinux.bin"