* [PATCH 1/1] remove usbgadget from routerstationpro
@ 2011-12-14 9:31 Zumeng Chen
2011-12-14 14:20 ` Bruce Ashfield
0 siblings, 1 reply; 5+ messages in thread
From: Zumeng Chen @ 2011-12-14 9:31 UTC (permalink / raw)
To: yocto, Bruce.Ashfield
1. No mass storage needed to be accessed by usbgadget.
2. This is a router station & switch, so it should not
be taken as a USB_NET device too.
Signed-off-by: Zumeng.chen@windriver.com>
---
meta-yocto/conf/machine/routerstationpro.conf | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta-yocto/conf/machine/routerstationpro.conf b/meta-yocto/conf/machine/routerstationpro.conf
index 9338ca1..52124d9 100644
--- a/meta-yocto/conf/machine/routerstationpro.conf
+++ b/meta-yocto/conf/machine/routerstationpro.conf
@@ -5,7 +5,7 @@
require conf/machine/include/tune-mips32.inc
MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
- serial usbgadget"
+ serial"
KERNEL_IMAGETYPE = "vmlinux"
KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] remove usbgadget from routerstationpro
2011-12-14 9:31 [PATCH 1/1] remove usbgadget from routerstationpro Zumeng Chen
@ 2011-12-14 14:20 ` Bruce Ashfield
2011-12-15 1:01 ` Zumeng Chen
2011-12-15 1:02 ` [V2 PATCH " Zumeng Chen
0 siblings, 2 replies; 5+ messages in thread
From: Bruce Ashfield @ 2011-12-14 14:20 UTC (permalink / raw)
To: Zumeng Chen; +Cc: yocto
On 11-12-14 04:31 AM, Zumeng Chen wrote:
> 1. No mass storage needed to be accessed by usbgadget.
> 2. This is a router station& switch, so it should not
> be taken as a USB_NET device too.
Zumeng,
The comment from the bug reporter was also that the target
doesn't have USB slave hardware to support usbgadget. So mentioning
that in the header is probably a good idea as well.
And small comment indicating that as a result of these conditions,
we remove usbgadget from MACHINE_FEATURES, since it can't be used.
Would complete the header.
Cheers,
Bruce
>
> Signed-off-by: Zumeng.chen@windriver.com>
> ---
> meta-yocto/conf/machine/routerstationpro.conf | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta-yocto/conf/machine/routerstationpro.conf b/meta-yocto/conf/machine/routerstationpro.conf
> index 9338ca1..52124d9 100644
> --- a/meta-yocto/conf/machine/routerstationpro.conf
> +++ b/meta-yocto/conf/machine/routerstationpro.conf
> @@ -5,7 +5,7 @@
> require conf/machine/include/tune-mips32.inc
>
> MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
> - serial usbgadget"
> + serial"
>
> KERNEL_IMAGETYPE = "vmlinux"
> KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] remove usbgadget from routerstationpro
2011-12-14 14:20 ` Bruce Ashfield
@ 2011-12-15 1:01 ` Zumeng Chen
2011-12-15 1:02 ` [V2 PATCH " Zumeng Chen
1 sibling, 0 replies; 5+ messages in thread
From: Zumeng Chen @ 2011-12-15 1:01 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: yocto
于 2011年12月14日 22:20, Bruce Ashfield 写道:
> On 11-12-14 04:31 AM, Zumeng Chen wrote:
>> 1. No mass storage needed to be accessed by usbgadget.
>> 2. This is a router station& switch, so it should not
>> be taken as a USB_NET device too.
>
> Zumeng,
>
> The comment from the bug reporter was also that the target
> doesn't have USB slave hardware to support usbgadget. So mentioning
> that in the header is probably a good idea as well.
OK, will add it, generally speaking MTD can be used as the slave,
but obviously it's meaningless here. Soon V2
Regards,
Zumeng
>
> And small comment indicating that as a result of these conditions,
> we remove usbgadget from MACHINE_FEATURES, since it can't be used.
> Would complete the header.
>
> Cheers,
>
> Bruce
>
>>
>> Signed-off-by: Zumeng.chen@windriver.com>
>> ---
>> meta-yocto/conf/machine/routerstationpro.conf | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta-yocto/conf/machine/routerstationpro.conf
>> b/meta-yocto/conf/machine/routerstationpro.conf
>> index 9338ca1..52124d9 100644
>> --- a/meta-yocto/conf/machine/routerstationpro.conf
>> +++ b/meta-yocto/conf/machine/routerstationpro.conf
>> @@ -5,7 +5,7 @@
>> require conf/machine/include/tune-mips32.inc
>>
>> MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
>> - serial usbgadget"
>> + serial"
>>
>> KERNEL_IMAGETYPE = "vmlinux"
>> KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [V2 PATCH 1/1] remove usbgadget from routerstationpro
2011-12-14 14:20 ` Bruce Ashfield
2011-12-15 1:01 ` Zumeng Chen
@ 2011-12-15 1:02 ` Zumeng Chen
2011-12-15 1:47 ` Bruce Ashfield
1 sibling, 1 reply; 5+ messages in thread
From: Zumeng Chen @ 2011-12-15 1:02 UTC (permalink / raw)
To: yocto, Bruce.Ashfield
Since the target doesn't have the related requirement
to use USB slave hardware supporting usb gadget, so
remove it from MACHINE_FEATURES.
Signed-off-by: Zumeng.chen@windriver.com>
---
meta-yocto/conf/machine/routerstationpro.conf | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta-yocto/conf/machine/routerstationpro.conf b/meta-yocto/conf/machine/routerstationpro.conf
index 9338ca1..52124d9 100644
--- a/meta-yocto/conf/machine/routerstationpro.conf
+++ b/meta-yocto/conf/machine/routerstationpro.conf
@@ -5,7 +5,7 @@
require conf/machine/include/tune-mips32.inc
MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
- serial usbgadget"
+ serial"
KERNEL_IMAGETYPE = "vmlinux"
KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [V2 PATCH 1/1] remove usbgadget from routerstationpro
2011-12-15 1:02 ` [V2 PATCH " Zumeng Chen
@ 2011-12-15 1:47 ` Bruce Ashfield
0 siblings, 0 replies; 5+ messages in thread
From: Bruce Ashfield @ 2011-12-15 1:47 UTC (permalink / raw)
To: Zumeng Chen; +Cc: yocto, Wold, Saul
On 11-12-14 8:02 PM, Zumeng Chen wrote:
> Since the target doesn't have the related requirement
> to use USB slave hardware supporting usb gadget, so
> remove it from MACHINE_FEATURES.
Indention went a bit out of whack there, but the wording is what
we want.
Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>
> Signed-off-by: Zumeng.chen@windriver.com>
> ---
> meta-yocto/conf/machine/routerstationpro.conf | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta-yocto/conf/machine/routerstationpro.conf b/meta-yocto/conf/machine/routerstationpro.conf
> index 9338ca1..52124d9 100644
> --- a/meta-yocto/conf/machine/routerstationpro.conf
> +++ b/meta-yocto/conf/machine/routerstationpro.conf
> @@ -5,7 +5,7 @@
> require conf/machine/include/tune-mips32.inc
>
> MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
> - serial usbgadget"
> + serial"
>
> KERNEL_IMAGETYPE = "vmlinux"
> KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-12-15 1:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-14 9:31 [PATCH 1/1] remove usbgadget from routerstationpro Zumeng Chen
2011-12-14 14:20 ` Bruce Ashfield
2011-12-15 1:01 ` Zumeng Chen
2011-12-15 1:02 ` [V2 PATCH " Zumeng Chen
2011-12-15 1:47 ` Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.