From: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
To: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, prakity@marvell.com,
eric.y.miao@gmail.com, linux-arm-kernel@lists.infradead.org,
jason.chagas@marvell.com
Subject: Re: [PATCH v3 2/4] ARM: pxa168: Add SDHCI support
Date: Mon, 19 Dec 2011 10:25:27 +0530 [thread overview]
Message-ID: <4EEEC3BF.6010708@einfochips.com> (raw)
In-Reply-To: <CAN1soZxmKct+qGUE2_W+FZufR+gcYZu6Dsj+TkJ06PaO8rV-TQ@mail.gmail.com>
On Monday 19 December 2011 10:15 AM, Haojian Zhuang wrote:
> On Fri, Dec 16, 2011 at 7:15 AM, Chris Ball<cjb@laptop.org> wrote:
>> Hi Eric and Jason,
>>
>> On Thu, Dec 01 2011, Chris Ball wrote:
>>> Hi Eric, Jason,
>>>
>>> Please could you ACK this patch if you agree with it, and I'll take it
>>> and the rest of the series via the MMC tree? Thanks.
>> Ping?
>>
>> Thanks,
>>
>> - Chris.
>>
> NACK.
>
>>>> +/* Offset defined in arch/arm/mach-mmp/include/mach/regs-apmu.h are for MMP2
>>>> + * PXA168 has different offset */
>>>> +#undef APMU_SDH2
>>>> +#undef APMU_SDH3
>>>> +
>>>> +#define APMU_SDH2 APMU_REG(0xe0)
>>>> +#define APMU_SDH3 APMU_REG(0xe4)
>>>> +
> Please don't use #undef at here. If the register setting is different,
> I prefer to use two different clk operations.
>
Sorry I couldn't get you. Could you please elaborate? Here regs-apmu.h
defines clock register offsets. They are correct for MMP2, but not for
PXA168. So I thought to correct them in a PXA168 specific file. Could
you please point me a better way?
Thanks,
Tanmay
WARNING: multiple messages have this Message-ID (diff)
From: tanmay.upadhyay@einfochips.com (Tanmay Upadhyay)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] ARM: pxa168: Add SDHCI support
Date: Mon, 19 Dec 2011 10:25:27 +0530 [thread overview]
Message-ID: <4EEEC3BF.6010708@einfochips.com> (raw)
In-Reply-To: <CAN1soZxmKct+qGUE2_W+FZufR+gcYZu6Dsj+TkJ06PaO8rV-TQ@mail.gmail.com>
On Monday 19 December 2011 10:15 AM, Haojian Zhuang wrote:
> On Fri, Dec 16, 2011 at 7:15 AM, Chris Ball<cjb@laptop.org> wrote:
>> Hi Eric and Jason,
>>
>> On Thu, Dec 01 2011, Chris Ball wrote:
>>> Hi Eric, Jason,
>>>
>>> Please could you ACK this patch if you agree with it, and I'll take it
>>> and the rest of the series via the MMC tree? Thanks.
>> Ping?
>>
>> Thanks,
>>
>> - Chris.
>>
> NACK.
>
>>>> +/* Offset defined in arch/arm/mach-mmp/include/mach/regs-apmu.h are for MMP2
>>>> + * PXA168 has different offset */
>>>> +#undef APMU_SDH2
>>>> +#undef APMU_SDH3
>>>> +
>>>> +#define APMU_SDH2 APMU_REG(0xe0)
>>>> +#define APMU_SDH3 APMU_REG(0xe4)
>>>> +
> Please don't use #undef at here. If the register setting is different,
> I prefer to use two different clk operations.
>
Sorry I couldn't get you. Could you please elaborate? Here regs-apmu.h
defines clock register offsets. They are correct for MMP2, but not for
PXA168. So I thought to correct them in a PXA168 specific file. Could
you please point me a better way?
Thanks,
Tanmay
next prev parent reply other threads:[~2011-12-19 4:55 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 12:37 [PATCH 2/3] mmc: sdhci-pxa: Add SDHCI driver for PXA16x Tanmay Upadhyay
2011-10-25 12:37 ` Tanmay Upadhyay
2011-11-10 20:09 ` Chris Ball
2011-11-10 20:09 ` Chris Ball
2011-11-21 4:23 ` [PATCH 1/4] mmc: sdhci-pxa: Trivial fix in Kconfig Tanmay Upadhyay
2011-11-21 4:23 ` Tanmay Upadhyay
2011-11-21 4:26 ` [PATCH v3 2/4] ARM: pxa168: Add SDHCI support Tanmay Upadhyay
2011-11-21 4:26 ` Tanmay Upadhyay
2011-12-01 18:05 ` Chris Ball
2011-12-01 18:05 ` Chris Ball
2011-12-15 23:15 ` Chris Ball
2011-12-15 23:15 ` Chris Ball
2011-12-19 4:45 ` Haojian Zhuang
2011-12-19 4:45 ` Haojian Zhuang
2011-12-19 4:55 ` Tanmay Upadhyay [this message]
2011-12-19 4:55 ` Tanmay Upadhyay
2011-12-19 5:02 ` Haojian Zhuang
2011-12-19 5:02 ` Haojian Zhuang
2011-12-19 5:17 ` Tanmay Upadhyay
2011-12-19 5:17 ` Tanmay Upadhyay
2011-12-19 5:24 ` Haojian Zhuang
2011-12-19 5:24 ` Haojian Zhuang
2011-12-20 13:13 ` [PATCH v4 " Tanmay Upadhyay
2011-12-20 13:13 ` Tanmay Upadhyay
2011-12-20 13:25 ` Haojian Zhuang
2011-12-20 13:25 ` Haojian Zhuang
2011-12-20 13:38 ` Haojian Zhuang
2011-12-20 13:38 ` Haojian Zhuang
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 21:03 ` Russell King - ARM Linux
2011-12-20 21:03 ` Russell King - ARM Linux
2011-12-21 1:48 ` Haojian Zhuang
2011-12-21 1:48 ` Haojian Zhuang
2011-12-29 13:43 ` [PATCH " Tanmay Upadhyay
2011-12-29 13:43 ` Tanmay Upadhyay
2011-12-30 0:36 ` Haojian Zhuang
2011-12-30 0:36 ` Haojian Zhuang
2012-01-23 22:45 ` Tanmay Upadhyay
2012-01-23 22:45 ` Tanmay Upadhyay
2011-12-19 5:24 ` [PATCH v3 " Philip Rakity
2011-12-19 5:24 ` Philip Rakity
2011-12-19 5:30 ` Haojian Zhuang
2011-12-19 5:30 ` Haojian Zhuang
2011-11-21 4:26 ` [PATCH v2 3/4] mmc: sdhci-pxa: Add SDHCI driver for PXA16x Tanmay Upadhyay
2011-11-21 4:26 ` Tanmay Upadhyay
[not found] ` <CAMj5Bki3Ev8K63538-dNbyijUw1oNTLChADLd4=Ef-LeCkoacw@mail.gmail.com>
2011-11-25 18:53 ` Philip Rakity
2011-11-25 18:53 ` Philip Rakity
2011-11-21 4:27 ` [PATCH v2 4/4] ARM: pxa168/gplugd: Add support for SD port 1 Tanmay Upadhyay
2011-11-21 4:27 ` Tanmay Upadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEEC3BF.6010708@einfochips.com \
--to=tanmay.upadhyay@einfochips.com \
--cc=cjb@laptop.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=jason.chagas@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.