From: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
To: eric.y.miao@gmail.com, jason.chagas@marvell.com
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>,
prakity@marvell.com, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: pxa168: Add SDHCI support
Date: Mon, 23 Jan 2012 16:45:23 -0600 [thread overview]
Message-ID: <4F1DE303.2020203@einfochips.com> (raw)
In-Reply-To: <CAN1soZwG37noxK8CUe7zMtaNJPTWSok5ROUXj_YvZ+dLEVkomA@mail.gmail.com>
On Thursday 29 December 2011 06:36 PM, Haojian Zhuang wrote:
> On Thu, Dec 29, 2011 at 9:43 PM, Tanmay Upadhyay
> <tanmay.upadhyay@einfochips.com> wrote:
>> v2 - clock register for SDHCI are not common across all MMP SoCs.
>> So, move PXA168 implementation to pxa168.c
>>
>> v3 - sdhci-pxav1 driver code is merged with sdhci-pxav2. So, change
>> the device name accordingly
>> - start sdhci device numbering from 1 as other PXA168 devices
>> does that
>>
>> v4 - Use different names for SD clock registers for PXA168 instead
>> of redefining them in pxa168.c. Suggested by Haojian Zhuang
>>
>> v5 - Have two different clock enable functions for clock block 1& 2
>> & don't change indentation in regs-apmu.h as suggested by Haojian
>> Zhuang
>> - Use device name while adding clock as suggested by Russell King
>>
>> Signed-off-by: Tanmay Upadhyay<tanmay.upadhyay@einfochips.com>
>> Reviewed-by: Philip Rakity<prakity@marvell.com>
>> ---
> Acked-by: Haojian Zhuang<haojian.zhuang@gmail.com>
Hi Eric, Jason,
Does this look good to you?
Thanks,
Tanmay
WARNING: multiple messages have this Message-ID (diff)
From: tanmay.upadhyay@einfochips.com (Tanmay Upadhyay)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: pxa168: Add SDHCI support
Date: Mon, 23 Jan 2012 16:45:23 -0600 [thread overview]
Message-ID: <4F1DE303.2020203@einfochips.com> (raw)
In-Reply-To: <CAN1soZwG37noxK8CUe7zMtaNJPTWSok5ROUXj_YvZ+dLEVkomA@mail.gmail.com>
On Thursday 29 December 2011 06:36 PM, Haojian Zhuang wrote:
> On Thu, Dec 29, 2011 at 9:43 PM, Tanmay Upadhyay
> <tanmay.upadhyay@einfochips.com> wrote:
>> v2 - clock register for SDHCI are not common across all MMP SoCs.
>> So, move PXA168 implementation to pxa168.c
>>
>> v3 - sdhci-pxav1 driver code is merged with sdhci-pxav2. So, change
>> the device name accordingly
>> - start sdhci device numbering from 1 as other PXA168 devices
>> does that
>>
>> v4 - Use different names for SD clock registers for PXA168 instead
>> of redefining them in pxa168.c. Suggested by Haojian Zhuang
>>
>> v5 - Have two different clock enable functions for clock block 1& 2
>> & don't change indentation in regs-apmu.h as suggested by Haojian
>> Zhuang
>> - Use device name while adding clock as suggested by Russell King
>>
>> Signed-off-by: Tanmay Upadhyay<tanmay.upadhyay@einfochips.com>
>> Reviewed-by: Philip Rakity<prakity@marvell.com>
>> ---
> Acked-by: Haojian Zhuang<haojian.zhuang@gmail.com>
Hi Eric, Jason,
Does this look good to you?
Thanks,
Tanmay
next prev parent reply other threads:[~2012-01-23 22:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 12:37 [PATCH 2/3] mmc: sdhci-pxa: Add SDHCI driver for PXA16x Tanmay Upadhyay
2011-10-25 12:37 ` Tanmay Upadhyay
2011-11-10 20:09 ` Chris Ball
2011-11-10 20:09 ` Chris Ball
2011-11-21 4:23 ` [PATCH 1/4] mmc: sdhci-pxa: Trivial fix in Kconfig Tanmay Upadhyay
2011-11-21 4:23 ` Tanmay Upadhyay
2011-11-21 4:26 ` [PATCH v3 2/4] ARM: pxa168: Add SDHCI support Tanmay Upadhyay
2011-11-21 4:26 ` Tanmay Upadhyay
2011-12-01 18:05 ` Chris Ball
2011-12-01 18:05 ` Chris Ball
2011-12-15 23:15 ` Chris Ball
2011-12-15 23:15 ` Chris Ball
2011-12-19 4:45 ` Haojian Zhuang
2011-12-19 4:45 ` Haojian Zhuang
2011-12-19 4:55 ` Tanmay Upadhyay
2011-12-19 4:55 ` Tanmay Upadhyay
2011-12-19 5:02 ` Haojian Zhuang
2011-12-19 5:02 ` Haojian Zhuang
2011-12-19 5:17 ` Tanmay Upadhyay
2011-12-19 5:17 ` Tanmay Upadhyay
2011-12-19 5:24 ` Haojian Zhuang
2011-12-19 5:24 ` Haojian Zhuang
2011-12-20 13:13 ` [PATCH v4 " Tanmay Upadhyay
2011-12-20 13:13 ` Tanmay Upadhyay
2011-12-20 13:25 ` Haojian Zhuang
2011-12-20 13:25 ` Haojian Zhuang
2011-12-20 13:38 ` Haojian Zhuang
2011-12-20 13:38 ` Haojian Zhuang
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 21:03 ` Russell King - ARM Linux
2011-12-20 21:03 ` Russell King - ARM Linux
2011-12-21 1:48 ` Haojian Zhuang
2011-12-21 1:48 ` Haojian Zhuang
2011-12-29 13:43 ` [PATCH " Tanmay Upadhyay
2011-12-29 13:43 ` Tanmay Upadhyay
2011-12-30 0:36 ` Haojian Zhuang
2011-12-30 0:36 ` Haojian Zhuang
2012-01-23 22:45 ` Tanmay Upadhyay [this message]
2012-01-23 22:45 ` Tanmay Upadhyay
2011-12-19 5:24 ` [PATCH v3 " Philip Rakity
2011-12-19 5:24 ` Philip Rakity
2011-12-19 5:30 ` Haojian Zhuang
2011-12-19 5:30 ` Haojian Zhuang
2011-11-21 4:26 ` [PATCH v2 3/4] mmc: sdhci-pxa: Add SDHCI driver for PXA16x Tanmay Upadhyay
2011-11-21 4:26 ` Tanmay Upadhyay
[not found] ` <CAMj5Bki3Ev8K63538-dNbyijUw1oNTLChADLd4=Ef-LeCkoacw@mail.gmail.com>
2011-11-25 18:53 ` Philip Rakity
2011-11-25 18:53 ` Philip Rakity
2011-11-21 4:27 ` [PATCH v2 4/4] ARM: pxa168/gplugd: Add support for SD port 1 Tanmay Upadhyay
2011-11-21 4:27 ` Tanmay Upadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1DE303.2020203@einfochips.com \
--to=tanmay.upadhyay@einfochips.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=jason.chagas@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.