From: Chris Ball <cjb@laptop.org>
To: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
Cc: zhangfei.gao@marvell.com, dwang4@marvell.com, njun@marvell.com,
wuqm@marvell.com, prakity@marvell.com, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] mmc: sdhci-pxa: Add SDHCI driver for PXA16x
Date: Thu, 10 Nov 2011 15:09:54 -0500 [thread overview]
Message-ID: <87r51fwxgt.fsf@laptop.org> (raw)
In-Reply-To: <1319546229-31804-1-git-send-email-tanmay.upadhyay@einfochips.com> (Tanmay Upadhyay's message of "Tue, 25 Oct 2011 18:07:09 +0530")
Hi Tanmay and Philip,
On Tue, Oct 25 2011, Tanmay Upadhyay wrote:
> Signed-off-by: Philip Rakity <prakity@marvell.com>
> Signed-off-by: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
> ---
> drivers/mmc/host/Kconfig | 13 ++
> drivers/mmc/host/Makefile | 1 +
> drivers/mmc/host/sdhci-pxav1.c | 256 +++++++++++++++++++++++++++++++
By my script's count, 215 of the 256 lines in this file (84%) are simply
duplicated from sdhci-pxav2.c, which makes me think we've failed at
abstraction here. Can you have a think about how to do better, please?
My intuition is that since there are only 41 lines of difference (actually,
less, since the only difference on many of these is s/pxav2/pxav1/g), I'd
rather see this become special-cases in the sdhci-pxav2.c code.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] mmc: sdhci-pxa: Add SDHCI driver for PXA16x
Date: Thu, 10 Nov 2011 15:09:54 -0500 [thread overview]
Message-ID: <87r51fwxgt.fsf@laptop.org> (raw)
In-Reply-To: <1319546229-31804-1-git-send-email-tanmay.upadhyay@einfochips.com> (Tanmay Upadhyay's message of "Tue, 25 Oct 2011 18:07:09 +0530")
Hi Tanmay and Philip,
On Tue, Oct 25 2011, Tanmay Upadhyay wrote:
> Signed-off-by: Philip Rakity <prakity@marvell.com>
> Signed-off-by: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
> ---
> drivers/mmc/host/Kconfig | 13 ++
> drivers/mmc/host/Makefile | 1 +
> drivers/mmc/host/sdhci-pxav1.c | 256 +++++++++++++++++++++++++++++++
By my script's count, 215 of the 256 lines in this file (84%) are simply
duplicated from sdhci-pxav2.c, which makes me think we've failed at
abstraction here. Can you have a think about how to do better, please?
My intuition is that since there are only 41 lines of difference (actually,
less, since the only difference on many of these is s/pxav2/pxav1/g), I'd
rather see this become special-cases in the sdhci-pxav2.c code.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-11-10 20:10 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 12:37 [PATCH 2/3] mmc: sdhci-pxa: Add SDHCI driver for PXA16x Tanmay Upadhyay
2011-10-25 12:37 ` Tanmay Upadhyay
2011-11-10 20:09 ` Chris Ball [this message]
2011-11-10 20:09 ` Chris Ball
2011-11-21 4:23 ` [PATCH 1/4] mmc: sdhci-pxa: Trivial fix in Kconfig Tanmay Upadhyay
2011-11-21 4:23 ` Tanmay Upadhyay
2011-11-21 4:26 ` [PATCH v3 2/4] ARM: pxa168: Add SDHCI support Tanmay Upadhyay
2011-11-21 4:26 ` Tanmay Upadhyay
2011-12-01 18:05 ` Chris Ball
2011-12-01 18:05 ` Chris Ball
2011-12-15 23:15 ` Chris Ball
2011-12-15 23:15 ` Chris Ball
2011-12-19 4:45 ` Haojian Zhuang
2011-12-19 4:45 ` Haojian Zhuang
2011-12-19 4:55 ` Tanmay Upadhyay
2011-12-19 4:55 ` Tanmay Upadhyay
2011-12-19 5:02 ` Haojian Zhuang
2011-12-19 5:02 ` Haojian Zhuang
2011-12-19 5:17 ` Tanmay Upadhyay
2011-12-19 5:17 ` Tanmay Upadhyay
2011-12-19 5:24 ` Haojian Zhuang
2011-12-19 5:24 ` Haojian Zhuang
2011-12-20 13:13 ` [PATCH v4 " Tanmay Upadhyay
2011-12-20 13:13 ` Tanmay Upadhyay
2011-12-20 13:25 ` Haojian Zhuang
2011-12-20 13:25 ` Haojian Zhuang
2011-12-20 13:38 ` Haojian Zhuang
2011-12-20 13:38 ` Haojian Zhuang
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 13:44 ` Tanmay Upadhyay
2011-12-20 21:03 ` Russell King - ARM Linux
2011-12-20 21:03 ` Russell King - ARM Linux
2011-12-21 1:48 ` Haojian Zhuang
2011-12-21 1:48 ` Haojian Zhuang
2011-12-29 13:43 ` [PATCH " Tanmay Upadhyay
2011-12-29 13:43 ` Tanmay Upadhyay
2011-12-30 0:36 ` Haojian Zhuang
2011-12-30 0:36 ` Haojian Zhuang
2012-01-23 22:45 ` Tanmay Upadhyay
2012-01-23 22:45 ` Tanmay Upadhyay
2011-12-19 5:24 ` [PATCH v3 " Philip Rakity
2011-12-19 5:24 ` Philip Rakity
2011-12-19 5:30 ` Haojian Zhuang
2011-12-19 5:30 ` Haojian Zhuang
2011-11-21 4:26 ` [PATCH v2 3/4] mmc: sdhci-pxa: Add SDHCI driver for PXA16x Tanmay Upadhyay
2011-11-21 4:26 ` Tanmay Upadhyay
[not found] ` <CAMj5Bki3Ev8K63538-dNbyijUw1oNTLChADLd4=Ef-LeCkoacw@mail.gmail.com>
2011-11-25 18:53 ` Philip Rakity
2011-11-25 18:53 ` Philip Rakity
2011-11-21 4:27 ` [PATCH v2 4/4] ARM: pxa168/gplugd: Add support for SD port 1 Tanmay Upadhyay
2011-11-21 4:27 ` Tanmay Upadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r51fwxgt.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=dwang4@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=njun@marvell.com \
--cc=prakity@marvell.com \
--cc=tanmay.upadhyay@einfochips.com \
--cc=wuqm@marvell.com \
--cc=zhangfei.gao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.