* Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_* [not found] <CAAu8pHty6LknkHcQseB29X4qQxguezAShsC5aGzMYHO1WRpJwg@mail.gmail.com> @ 2012-05-02 13:24 ` Paolo Bonzini 2012-05-02 13:40 ` Andreas Färber 0 siblings, 1 reply; 3+ messages in thread From: Paolo Bonzini @ 2012-05-02 13:24 UTC (permalink / raw) To: Blue Swirl Cc: Lee Essen, Andreas Färber, Jan Kiszka, qemu-devel, Andreas Färber > But that would leave Illumos broken. I'd rather apply this one. Please do. The right solution for 1.2 is to understand the places in which slirp cannot use netinet/tcp.h constants (the MSS for example), and otherwise use that header. Paolo ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_* 2012-05-02 13:24 ` [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_* Paolo Bonzini @ 2012-05-02 13:40 ` Andreas Färber 2012-05-02 13:48 ` Jan Kiszka 0 siblings, 1 reply; 3+ messages in thread From: Andreas Färber @ 2012-05-02 13:40 UTC (permalink / raw) To: Jan Kiszka; +Cc: Blue Swirl, Paolo Bonzini, Lee Essen, qemu-devel Am 02.05.2012 15:24, schrieb Paolo Bonzini: >> But that would leave Illumos broken. For the record, reverting would leave whatever Paolo was fixing broken but would restore Illumos. > I'd rather apply this one. > > Please do. The right solution for 1.2 is to understand the places in which > slirp cannot use netinet/tcp.h constants (the MSS for example), and > otherwise use that header. Jan, should I prepare a mechanical prefix addition as suggested by Blue? Should we apply this ugly-but-least-intrusive build fix? Or do you have any other preference or idea? Andreas ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_* 2012-05-02 13:40 ` Andreas Färber @ 2012-05-02 13:48 ` Jan Kiszka 0 siblings, 0 replies; 3+ messages in thread From: Jan Kiszka @ 2012-05-02 13:48 UTC (permalink / raw) To: Andreas Färber; +Cc: Blue Swirl, Paolo Bonzini, Lee Essen, qemu-devel [-- Attachment #1: Type: text/plain, Size: 843 bytes --] On 2012-05-02 10:40, Andreas Färber wrote: > Am 02.05.2012 15:24, schrieb Paolo Bonzini: >>> But that would leave Illumos broken. > > For the record, reverting would leave whatever Paolo was fixing broken > but would restore Illumos. > >> I'd rather apply this one. >> >> Please do. The right solution for 1.2 is to understand the places in which >> slirp cannot use netinet/tcp.h constants (the MSS for example), and >> otherwise use that header. > > Jan, should I prepare a mechanical prefix addition as suggested by Blue? > Should we apply this ugly-but-least-intrusive build fix? Or do you have > any other preference or idea? I'm fine with a minimal fix like you suggested. The renaming should probably be applied to a broader scope. So it's an exercise to be done systematically and without any hurry. Jan [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 262 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-02 13:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAAu8pHty6LknkHcQseB29X4qQxguezAShsC5aGzMYHO1WRpJwg@mail.gmail.com>
2012-05-02 13:24 ` [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_* Paolo Bonzini
2012-05-02 13:40 ` Andreas Färber
2012-05-02 13:48 ` Jan Kiszka
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.