[Powertop] [PATCH] Fix trying to use libnl-2.0 when only libnl-3.0 is installed

[Powertop] [PATCH] Fix trying to use libnl-2.0 when only libnl-3.0 is installed

[Vinicius Costa Gomes]

[-- Attachment #1: Type: text/plain, Size: 839 bytes --]

From: Vinicius Costa Gomes <vinicius.gomes(a)openbossa.org>

When using libnl-3.0 we need to link with libnl-genl also, if not, we
get a lot of undefined symbols.
---
 configure.ac |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 2d56684..3579b6e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -56,7 +56,7 @@ PKG_CHECK_MODULES([LIBZ], [zlib],[],[
 
 has_libnl_ver=0
 PKG_CHECK_MODULES([LIBNL], [libnl-1], [has_libnl_ver=1], [
-	AC_SEARCH_LIBS([nl_socket_alloc], [nl], [has_libnl_ver=2], [
+	AC_SEARCH_LIBS([nl_socket_alloc], [libnl-2.0], [has_libnl_ver=2], [
 		     PKG_CHECK_MODULES([LIBNL], [libnl-3.0 libnl-genl-3.0], [has_libnl_ver=3],
 				       [AC_SEARCH_LIBS([nl_socket_alloc], [nl-3 nl-genl-3], [has_libnl_ver=3], [], [])])
 	], [])
-- 
1.7.10.1

Re: [Powertop] [PATCH] Fix trying to use libnl-2.0 when only libnl-3.0 is installed

[Kok, Auke-jan H]

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

On Sat, May 12, 2012 at 8:50 AM, Vinicius Costa Gomes <vcgomes(a)gmail.com>wrote:

> From: Vinicius Costa Gomes <vinicius.gomes(a)openbossa.org>
>
> When using libnl-3.0 we need to link with libnl-genl also, if not, we
> get a lot of undefined symbols.
> ---
>  configure.ac |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 2d56684..3579b6e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -56,7 +56,7 @@ PKG_CHECK_MODULES([LIBZ], [zlib],[],[
>
>  has_libnl_ver=0
>  PKG_CHECK_MODULES([LIBNL], [libnl-1], [has_libnl_ver=1], [
> -       AC_SEARCH_LIBS([nl_socket_alloc], [nl], [has_libnl_ver=2], [
> +       AC_SEARCH_LIBS([nl_socket_alloc], [libnl-2.0], [has_libnl_ver=2], [


are you sure you want the linker to check for -llibnl-2.0? that means it's
going to try to find a "liblibnl-2.0.so" (note the double "lib" here).

Auke

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 1604 bytes --]

Re: [Powertop] [PATCH] Fix trying to use libnl-2.0 when only libnl-3.0 is installed

[Arjan van de Ven]

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

On 5/12/2012 1:46 PM, Kok, Auke-jan H wrote:
> 
> 
> On Sat, May 12, 2012 at 8:50 AM, Vinicius Costa Gomes <vcgomes(a)gmail.com
> <mailto:vcgomes(a)gmail.com>> wrote:
> 
>     From: Vinicius Costa Gomes <vinicius.gomes(a)openbossa.org
>     <mailto:vinicius.gomes(a)openbossa.org>>
> 
>     When using libnl-3.0 we need to link with libnl-genl also, if not, we
>     get a lot of undefined symbols.
>     ---
>      configure.ac <http://configure.ac> |    2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/configure.ac <http://configure.ac> b/configure.ac
>     <http://configure.ac>
>     index 2d56684..3579b6e 100644
>     --- a/configure.ac <http://configure.ac>
>     +++ b/configure.ac <http://configure.ac>
>     @@ -56,7 +56,7 @@ PKG_CHECK_MODULES([LIBZ], [zlib],[],[
> 
>      has_libnl_ver=0
>      PKG_CHECK_MODULES([LIBNL], [libnl-1], [has_libnl_ver=1], [
>     -       AC_SEARCH_LIBS([nl_socket_alloc], [nl], [has_libnl_ver=2], [
>     +       AC_SEARCH_LIBS([nl_socket_alloc], [libnl-2.0],
>     [has_libnl_ver=2], [
> 
> 
> are you sure you want the linker to check for -llibnl-2.0? that means
> it's going to try to find a "liblibnl-2.0.so <http://liblibnl-2.0.so>"
> (note the double "lib" here).
> 
> Auke

this autoconf stuff is giving me a headache

maybe we should ask the libnl guys if they have some snippet that they
recommend.... after all I doubt we're the only ones dealing with their
library.

Re: [Powertop] [PATCH] Fix trying to use libnl-2.0 when only libnl-3.0 is installed

[Jan Engelhardt]

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]


On Saturday 2012-05-12 22:54, Arjan van de Ven wrote:
>> 
>>     When using libnl-3.0 we need to link with libnl-genl also, if not, we
>>     get a lot of undefined symbols.
>>     ---
>>      has_libnl_ver=0
>>      PKG_CHECK_MODULES([LIBNL], [libnl-1], [has_libnl_ver=1], [
>>     -       AC_SEARCH_LIBS([nl_socket_alloc], [nl], [has_libnl_ver=2], [
>>     +       AC_SEARCH_LIBS([nl_socket_alloc], [libnl-2.0],
>>     [has_libnl_ver=2], [
>> 
>> are you sure you want the linker to check for -llibnl-2.0? that means
>> it's going to try to find a "liblibnl-2.0.so <http://liblibnl-2.0.so>"
>> (note the double "lib" here).
>
>this autoconf stuff is giving me a headache
>
>maybe we should ask the libnl guys if they have some snippet that they
>recommend.... after all I doubt we're the only ones dealing with their
>library.

libnl2 always has nl_socket_alloc, does it not? Why check for it?

(Why even bother with libnl1 and libnl2 anyway? They are obsolete.)

Re: [Powertop] [PATCH] Fix trying to use libnl-2.0 when only libnl-3.0 is installed

[Arjan van de Ven]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

> 
> (Why even bother with libnl1 and libnl2 anyway? They are obsolete.)

as long as latest Fedora, Debian and Ubuntu have the current one, I
wouldn't mind just ditching support for the old ones...

Re: [Powertop] [PATCH] Fix trying to use libnl-2.0 when only libnl-3.0 is installed

[Jan Engelhardt]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

On Sunday 2012-05-13 00:05, Arjan van de Ven wrote:

>> 
>> (Why even bother with libnl1 and libnl2 anyway? They are obsolete.)
>
>as long as latest Fedora, Debian and Ubuntu have the current one

They do

Re: [Powertop] [PATCH] Fix trying to use libnl-2.0 when only libnl-3.0 is installed

[Chris Ferron]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

On 05/12/2012 03:38 PM, Jan Engelhardt wrote:
> On Sunday 2012-05-13 00:05, Arjan van de Ven wrote:
>
>>> (Why even bother with libnl1 and libnl2 anyway? They are obsolete.)
>> as long as latest Fedora, Debian and Ubuntu have the current one
> They do
Can't ditch the old ones as they are still used by older distributions.
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop