* [PATCH] drm/i915: there's no cxsr on ilk
@ 2012-05-30 15:15 Daniel Vetter
2012-05-30 15:19 ` Eugeni Dodonov
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2012-05-30 15:15 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter, Eugeni Dodonov
Already discovered in
commit 5a117db77e47e3946d1aaa7ce8deafafd9d76746
Author: Eugeni Dodonov <eugeni.dodonov@intel.com>
Date: Thu Jan 5 09:34:29 2012 -0200
drm/i915: there is no pipe CxSR on ironlake
but we've failed to rip out the code from the ironlake specific code.
Cc: Eugeni Dodonov <eugeni.dodonov@intel.com>
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_display.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 68dfc07..0161d94 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4647,16 +4647,8 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
if (is_lvds && has_reduced_clock && i915_powersave) {
I915_WRITE(intel_crtc->pch_pll->fp1_reg, fp2);
intel_crtc->lowfreq_avail = true;
- if (HAS_PIPE_CXSR(dev)) {
- DRM_DEBUG_KMS("enabling CxSR downclocking\n");
- pipeconf |= PIPECONF_CXSR_DOWNCLOCK;
- }
} else {
I915_WRITE(intel_crtc->pch_pll->fp1_reg, fp);
- if (HAS_PIPE_CXSR(dev)) {
- DRM_DEBUG_KMS("disabling CxSR downclocking\n");
- pipeconf &= ~PIPECONF_CXSR_DOWNCLOCK;
- }
}
}
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: there's no cxsr on ilk
2012-05-30 15:15 [PATCH] drm/i915: there's no cxsr on ilk Daniel Vetter
@ 2012-05-30 15:19 ` Eugeni Dodonov
2012-05-31 7:30 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Eugeni Dodonov @ 2012-05-30 15:19 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Intel Graphics Development, Eugeni Dodonov
On 05/30/2012 12:15 PM, Daniel Vetter wrote:
> Already discovered in
>
> commit 5a117db77e47e3946d1aaa7ce8deafafd9d76746
> Author: Eugeni Dodonov<eugeni.dodonov@intel.com>
> Date: Thu Jan 5 09:34:29 2012 -0200
>
> drm/i915: there is no pipe CxSR on ironlake
>
> but we've failed to rip out the code from the ironlake specific code.
>
> Cc: Eugeni Dodonov<eugeni.dodonov@intel.com>
> Signed-Off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
The code newer got called anyway since the last patch, so let's put it
to rest.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: there's no cxsr on ilk
2012-05-30 15:19 ` Eugeni Dodonov
@ 2012-05-31 7:30 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-05-31 7:30 UTC (permalink / raw)
To: eugeni.dodonov; +Cc: Daniel Vetter, Intel Graphics Development
On Wed, May 30, 2012 at 12:19:22PM -0300, Eugeni Dodonov wrote:
> On 05/30/2012 12:15 PM, Daniel Vetter wrote:
> >Already discovered in
> >
> >commit 5a117db77e47e3946d1aaa7ce8deafafd9d76746
> >Author: Eugeni Dodonov<eugeni.dodonov@intel.com>
> >Date: Thu Jan 5 09:34:29 2012 -0200
> >
> > drm/i915: there is no pipe CxSR on ironlake
> >
> >but we've failed to rip out the code from the ironlake specific code.
> >
> >Cc: Eugeni Dodonov<eugeni.dodonov@intel.com>
> >Signed-Off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
>
> Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Queued for -next, thanks for the review.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-31 7:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-30 15:15 [PATCH] drm/i915: there's no cxsr on ilk Daniel Vetter
2012-05-30 15:19 ` Eugeni Dodonov
2012-05-31 7:30 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.