From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
kernel-janitors@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
joe@perches.com, Julia Lawall <julia@diku.dk>
Subject: Re: [PATCH 7/7] drivers/net/can/cc770/cc770_platform.c: adjust suspicious bit operation
Date: Wed, 06 Jun 2012 21:52:18 +0000 [thread overview]
Message-ID: <4FCFD112.1070106@pengutronix.de> (raw)
In-Reply-To: <1339018901-28439-8-git-send-email-Julia.Lawall@lip6.fr>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On 06/06/2012 11:41 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> CPUIF_DSC is 0x40, so it would seem that & is wanted rather than |.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Good catch, Joe Perches has already found and fixed that problem. It has
been fixed in:
dc605db can: cc770: Fix likely misuse of | for &
The commit is currently in David's net/master, and scheduled for the
v3.5 release.
Regards, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
kernel-janitors@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
joe@perches.com, Julia Lawall <julia@diku.dk>
Subject: Re: [PATCH 7/7] drivers/net/can/cc770/cc770_platform.c: adjust suspicious bit operation
Date: Wed, 06 Jun 2012 23:52:18 +0200 [thread overview]
Message-ID: <4FCFD112.1070106@pengutronix.de> (raw)
In-Reply-To: <1339018901-28439-8-git-send-email-Julia.Lawall@lip6.fr>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On 06/06/2012 11:41 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> CPUIF_DSC is 0x40, so it would seem that & is wanted rather than |.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Good catch, Joe Perches has already found and fixed that problem. It has
been fixed in:
dc605db can: cc770: Fix likely misuse of | for &
The commit is currently in David's net/master, and scheduled for the
v3.5 release.
Regards, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-06-06 21:52 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 21:41 [PATCH 0/7] adjust suspicious bit operation Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-06 21:41 ` [PATCH 1/7] drivers/ide/ide-cs.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-07 21:46 ` David Miller
2012-06-07 21:46 ` David Miller
2012-06-07 21:59 ` Joe Perches
2012-06-07 21:59 ` Joe Perches
2012-06-08 5:12 ` Julia Lawall
2012-06-08 5:12 ` Julia Lawall
2012-06-08 5:14 ` Julia Lawall
2012-06-08 5:14 ` Julia Lawall
2012-06-08 7:30 ` walter harms
2012-06-08 7:30 ` walter harms
2012-06-11 23:43 ` David Miller
2012-06-11 23:43 ` David Miller
2012-06-12 14:17 ` Julia Lawall
2012-06-12 14:17 ` Julia Lawall
2012-06-12 22:52 ` David Miller
2012-06-12 22:52 ` David Miller
2012-06-06 21:41 ` [PATCH 2/7] drivers/staging/comedi/drivers/me4000.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-06 21:41 ` [PATCH 3/7] drivers/usb/gadget/pch_udc.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-07 13:00 ` Sergei Shtylyov
2012-06-07 13:00 ` Sergei Shtylyov
2012-06-07 14:23 ` Julia Lawall
2012-06-07 14:23 ` Julia Lawall
2012-06-07 15:05 ` Joe Perches
2012-06-07 15:05 ` Joe Perches
2012-06-08 12:58 ` Dan Carpenter
2012-06-08 12:58 ` Dan Carpenter
2012-06-08 15:28 ` Joe Perches
2012-06-08 15:28 ` Joe Perches
2012-06-06 21:41 ` [PATCH 4/7] fs/direct-io.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-07 14:24 ` Jeff Moyer
2012-06-07 14:24 ` Jeff Moyer
2012-06-06 21:41 ` [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-06 23:43 ` [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit Franky Lin
2012-06-06 23:43 ` [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit operation Franky Lin
2012-06-06 23:43 ` Franky Lin
2012-06-06 21:41 ` [PATCH 6/7] drivers/ata/pata_pcmcia.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-06 21:41 ` [PATCH 7/7] drivers/net/can/cc770/cc770_platform.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-06 21:52 ` Marc Kleine-Budde [this message]
2012-06-06 21:52 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCFD112.1070106@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Julia.Lawall@lip6.fr \
--cc=joe@perches.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.