From: "Franky Lin" <frankyl@broadcom.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Brett Rudley <brudley@broadcom.com>,
kernel-janitors@vger.kernel.org,
Roland Vossen <rvossen@broadcom.com>,
Arend van Spriel <arend@broadcom.com>,
Kan Yan <kanyan@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, joe@perches.com,
Julia Lawall <julia@diku.dk>
Subject: Re: [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit
Date: Wed, 06 Jun 2012 23:43:10 +0000 [thread overview]
Message-ID: <4FCFEB0E.2020206@broadcom.com> (raw)
In-Reply-To: <1339018901-28439-6-git-send-email-Julia.Lawall@lip6.fr>
On 06/06/2012 02:41 PM, Julia Lawall wrote:
> From: Julia Lawall<Julia.Lawall@lip6.fr>
>
> IRQF_TRIGGER_HIGH is 0x00000004, so it seems that& was intended rather than |.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall<julia@diku.dk>
Thanks, Julia. But this has already been fixed by Joe Perches [1] and
the patch has arrived at Linux wireless tree.
Franky
[1] https://lkml.org/lkml/2012/5/30/482
WARNING: multiple messages have this Message-ID (diff)
From: "Franky Lin" <frankyl@broadcom.com>
To: "Julia Lawall" <Julia.Lawall@lip6.fr>
Cc: "Brett Rudley" <brudley@broadcom.com>,
kernel-janitors@vger.kernel.org,
"Roland Vossen" <rvossen@broadcom.com>,
"Arend van Spriel" <arend@broadcom.com>,
"Kan Yan" <kanyan@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, joe@perches.com,
"Julia Lawall" <julia@diku.dk>
Subject: Re: [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit operation
Date: Wed, 6 Jun 2012 16:43:10 -0700 [thread overview]
Message-ID: <4FCFEB0E.2020206@broadcom.com> (raw)
In-Reply-To: <1339018901-28439-6-git-send-email-Julia.Lawall@lip6.fr>
On 06/06/2012 02:41 PM, Julia Lawall wrote:
> From: Julia Lawall<Julia.Lawall@lip6.fr>
>
> IRQF_TRIGGER_HIGH is 0x00000004, so it seems that& was intended rather than |.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall<julia@diku.dk>
Thanks, Julia. But this has already been fixed by Joe Perches [1] and
the patch has arrived at Linux wireless tree.
Franky
[1] https://lkml.org/lkml/2012/5/30/482
WARNING: multiple messages have this Message-ID (diff)
From: "Franky Lin" <frankyl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
To: "Julia Lawall" <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
Cc: "Brett Rudley" <brudley-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Roland Vossen" <rvossen-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"Arend van Spriel"
<arend-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"Kan Yan" <kanyan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org,
"Julia Lawall" <julia-dAYI7NvHqcQ@public.gmane.org>
Subject: Re: [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: adjust suspicious bit operation
Date: Wed, 6 Jun 2012 16:43:10 -0700 [thread overview]
Message-ID: <4FCFEB0E.2020206@broadcom.com> (raw)
In-Reply-To: <1339018901-28439-6-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
On 06/06/2012 02:41 PM, Julia Lawall wrote:
> From: Julia Lawall<Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
>
> IRQF_TRIGGER_HIGH is 0x00000004, so it seems that& was intended rather than |.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall<julia-dAYI7NvHqcQ@public.gmane.org>
Thanks, Julia. But this has already been fixed by Joe Perches [1] and
the patch has arrived at Linux wireless tree.
Franky
[1] https://lkml.org/lkml/2012/5/30/482
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-06-06 23:43 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 21:41 [PATCH 0/7] adjust suspicious bit operation Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-06 21:41 ` [PATCH 1/7] drivers/ide/ide-cs.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-07 21:46 ` David Miller
2012-06-07 21:46 ` David Miller
2012-06-07 21:59 ` Joe Perches
2012-06-07 21:59 ` Joe Perches
2012-06-08 5:12 ` Julia Lawall
2012-06-08 5:12 ` Julia Lawall
2012-06-08 5:14 ` Julia Lawall
2012-06-08 5:14 ` Julia Lawall
2012-06-08 7:30 ` walter harms
2012-06-08 7:30 ` walter harms
2012-06-11 23:43 ` David Miller
2012-06-11 23:43 ` David Miller
2012-06-12 14:17 ` Julia Lawall
2012-06-12 14:17 ` Julia Lawall
2012-06-12 22:52 ` David Miller
2012-06-12 22:52 ` David Miller
2012-06-06 21:41 ` [PATCH 2/7] drivers/staging/comedi/drivers/me4000.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-06 21:41 ` [PATCH 3/7] drivers/usb/gadget/pch_udc.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-07 13:00 ` Sergei Shtylyov
2012-06-07 13:00 ` Sergei Shtylyov
2012-06-07 14:23 ` Julia Lawall
2012-06-07 14:23 ` Julia Lawall
2012-06-07 15:05 ` Joe Perches
2012-06-07 15:05 ` Joe Perches
2012-06-08 12:58 ` Dan Carpenter
2012-06-08 12:58 ` Dan Carpenter
2012-06-08 15:28 ` Joe Perches
2012-06-08 15:28 ` Joe Perches
2012-06-06 21:41 ` [PATCH 4/7] fs/direct-io.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-07 14:24 ` Jeff Moyer
2012-06-07 14:24 ` Jeff Moyer
2012-06-06 21:41 ` [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-06 23:43 ` Franky Lin [this message]
2012-06-06 23:43 ` Franky Lin
2012-06-06 23:43 ` Franky Lin
2012-06-06 21:41 ` [PATCH 6/7] drivers/ata/pata_pcmcia.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-06 21:41 ` [PATCH 7/7] drivers/net/can/cc770/cc770_platform.c: " Julia Lawall
2012-06-06 21:41 ` Julia Lawall
2012-06-06 21:52 ` Marc Kleine-Budde
2012-06-06 21:52 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCFEB0E.2020206@broadcom.com \
--to=frankyl@broadcom.com \
--cc=Julia.Lawall@lip6.fr \
--cc=arend@broadcom.com \
--cc=brudley@broadcom.com \
--cc=joe@perches.com \
--cc=julia@diku.dk \
--cc=kanyan@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=rvossen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.