All of lore.kernel.org
 help / color / mirror / Atom feed
From: Spelic <spelic@shiftmail.org>
To: Mike Snitzer <msnitzer@redhat.com>
Cc: "Lukáš Czerner" <lczerner@redhat.com>,
	"Dave Chinner" <david@fromorbit.com>,
	Spelic <spelic@shiftmail.org>,
	"device-mapper development" <dm-devel@redhat.com>,
	linux-ext4@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: Ext4 and xfs problems in dm-thin on allocation and discard
Date: Tue, 19 Jun 2012 15:52:15 +0200	[thread overview]
Message-ID: <4FE0840F.2050704@shiftmail.org> (raw)
In-Reply-To: <20120619133041.GB6811@redhat.com>

On 06/19/12 15:30, Mike Snitzer wrote:
> I don't recall Spelic saying anything about EOPNOTSUPP. So what has 
> made you zero in on an -EOPNOTSUPP return (which should not be 
> happening)? 

Exactly: I do not know if EOPNOTSUPP is being returned or not.

If this helps, I have configured dm-thin via lvm2
   LVM version:     2.02.95(2) (2012-03-06)
   Library version: 1.02.74 (2012-03-06)
   Driver version:  4.22.0

from dmsetup table I only see one option : "skip_block_zeroing", if and 
only if I configure it with -Zn . I do not see anything regarding 
ignore_discard

      vg1-pooltry1-tpool: 0 20971520 thin-pool 252:1 252:2 2048 0 1 
skip_block_zeroing
      vg1-pooltry1_tdata: 0 20971520 linear 9:20 62922752
      vg1-pooltry1_tmeta: 0 8192 linear 9:20 83894272
      vg1-thinlv1: 0 31457280 thin 252:3 1


and in dmesg:
[   33.685200] device-mapper: thin: Discard unsupported by data device 
(dm-2): Disabling discard passdown.
[   33.709586] device-mapper: thin: Discard unsupported by data device 
(dm-6): Disabling discard passdown.


I do not know what is the mechanism for which xfs cannot unmap blocks 
from dm-thin, but it really can't.
If anyone has dm-thin installed he can try. This is 100% reproducible 
for me.



WARNING: multiple messages have this Message-ID (diff)
From: Spelic <spelic@shiftmail.org>
To: Mike Snitzer <msnitzer@redhat.com>
Cc: xfs@oss.sgi.com,
	"device-mapper development" <dm-devel@redhat.com>,
	Spelic <spelic@shiftmail.org>,
	"Lukáš Czerner" <lczerner@redhat.com>,
	linux-ext4@vger.kernel.org
Subject: Re: Ext4 and xfs problems in dm-thin on allocation and discard
Date: Tue, 19 Jun 2012 15:52:15 +0200	[thread overview]
Message-ID: <4FE0840F.2050704@shiftmail.org> (raw)
In-Reply-To: <20120619133041.GB6811@redhat.com>

On 06/19/12 15:30, Mike Snitzer wrote:
> I don't recall Spelic saying anything about EOPNOTSUPP. So what has 
> made you zero in on an -EOPNOTSUPP return (which should not be 
> happening)? 

Exactly: I do not know if EOPNOTSUPP is being returned or not.

If this helps, I have configured dm-thin via lvm2
   LVM version:     2.02.95(2) (2012-03-06)
   Library version: 1.02.74 (2012-03-06)
   Driver version:  4.22.0

from dmsetup table I only see one option : "skip_block_zeroing", if and 
only if I configure it with -Zn . I do not see anything regarding 
ignore_discard

      vg1-pooltry1-tpool: 0 20971520 thin-pool 252:1 252:2 2048 0 1 
skip_block_zeroing
      vg1-pooltry1_tdata: 0 20971520 linear 9:20 62922752
      vg1-pooltry1_tmeta: 0 8192 linear 9:20 83894272
      vg1-thinlv1: 0 31457280 thin 252:3 1


and in dmesg:
[   33.685200] device-mapper: thin: Discard unsupported by data device 
(dm-2): Disabling discard passdown.
[   33.709586] device-mapper: thin: Discard unsupported by data device 
(dm-6): Disabling discard passdown.


I do not know what is the mechanism for which xfs cannot unmap blocks 
from dm-thin, but it really can't.
If anyone has dm-thin installed he can try. This is 100% reproducible 
for me.


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-06-19 13:52 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18 21:33 Ext4 and xfs problems in dm-thin on allocation and discard Spelic
2012-06-18 21:33 ` Spelic
2012-06-19  1:57 ` Dave Chinner
2012-06-19  1:57   ` Dave Chinner
2012-06-19  3:12   ` Mike Snitzer
2012-06-19  3:12     ` Mike Snitzer
2012-06-19  6:32     ` Lukáš Czerner
2012-06-19  6:32       ` Lukáš Czerner
2012-06-19 11:29       ` Spelic
2012-06-19 11:29         ` Spelic
2012-06-19 12:20         ` Lukáš Czerner
2012-06-19 12:20           ` Lukáš Czerner
2012-06-19 13:34         ` Mike Snitzer
2012-06-19 13:34           ` Mike Snitzer
2012-06-19 13:16       ` Mike Snitzer
2012-06-19 13:16         ` Mike Snitzer
2012-06-19 13:25         ` Lukáš Czerner
2012-06-19 13:25           ` Lukáš Czerner
2012-06-19 13:30           ` Mike Snitzer
2012-06-19 13:30             ` Mike Snitzer
2012-06-19 13:52             ` Spelic [this message]
2012-06-19 13:52               ` Spelic
2012-06-19 14:05               ` Eric Sandeen
2012-06-19 14:05                 ` Eric Sandeen
2012-06-19 14:44               ` Mike Snitzer
2012-06-19 14:44                 ` Mike Snitzer
2012-06-19 18:48                 ` Mike Snitzer
2012-06-19 18:48                   ` Mike Snitzer
2012-06-19 20:06                   ` Dave Chinner
2012-06-19 20:06                     ` Dave Chinner
2012-06-19 20:21                     ` Ted Ts'o
2012-06-19 20:21                       ` Ted Ts'o
2012-06-19 20:39                       ` Dave Chinner
2012-06-19 20:39                         ` Dave Chinner
2012-06-20  9:01                         ` Christoph Hellwig
2012-06-20  9:01                           ` Christoph Hellwig
2012-06-19 21:37                     ` Spelic
2012-06-19 21:37                       ` Spelic
2012-06-19 23:12                       ` Dave Chinner
2012-06-19 23:12                         ` Dave Chinner
2012-06-20 12:11   ` Spelic
2012-06-20 12:11     ` Spelic
2012-06-20 22:53     ` Dave Chinner
2012-06-20 22:53       ` Dave Chinner
2012-06-21 17:47       ` Mike Snitzer
2012-06-21 17:47         ` Mike Snitzer
2012-06-21 23:29         ` Dave Chinner
2012-06-21 23:29           ` Dave Chinner
2012-07-01 14:53         ` Paolo Bonzini
2012-07-01 14:53           ` Paolo Bonzini
2012-07-02 13:00           ` Mike Snitzer
2012-07-02 13:00             ` Mike Snitzer
2012-07-02 13:15             ` Paolo Bonzini
2012-07-02 13:15               ` Paolo Bonzini
2012-06-19 14:09 ` Lukáš Czerner
2012-06-19 14:09   ` Lukáš Czerner
2012-06-19 14:19   ` Ted Ts'o
2012-06-19 14:19     ` Ted Ts'o
2012-06-19 14:23     ` Eric Sandeen
2012-06-19 14:23       ` Eric Sandeen
2012-06-19 14:37     ` Lukáš Czerner
2012-06-19 14:37       ` Lukáš Czerner
2012-06-19 14:43     ` [dm-devel] " Alasdair G Kergon
2012-06-19 14:43       ` Alasdair G Kergon
2012-06-19 15:28       ` Mike Snitzer
2012-06-19 15:28         ` Mike Snitzer
2012-06-19 16:03         ` [dm-devel] " Alasdair G Kergon
2012-06-19 16:03           ` Alasdair G Kergon
2012-06-19 19:58         ` Ted Ts'o
2012-06-19 19:58           ` Ted Ts'o
2012-06-19 20:44           ` Mike Snitzer
2012-06-19 20:44             ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE0840F.2050704@shiftmail.org \
    --to=spelic@shiftmail.org \
    --cc=david@fromorbit.com \
    --cc=dm-devel@redhat.com \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=msnitzer@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.