[PATCH] openpic: Added BRR1 register

[PATCH] openpic: Added BRR1 register

[Bharat Bhushan]

Linux mpic driver uses (changes may be in pipeline to get upstreamed soon)
BRR1. This patch adds the support to emulate readonly BRR1.

Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>
---
 hw/openpic.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/hw/openpic.c b/hw/openpic.c
index 58ef871..244155b 100644
--- a/hw/openpic.c
+++ b/hw/openpic.c
@@ -595,6 +595,8 @@ static void openpic_gbl_write (void *opaque, target_phys_addr_t addr, uint32_t v
     if (addr & 0xF)
         return;
     switch (addr) {
+    case 0x00: /* BRR1 Readonly */
+        break;
     case 0x40:
     case 0x50:
     case 0x60:
@@ -671,6 +673,7 @@ static uint32_t openpic_gbl_read (void *opaque, target_phys_addr_t addr)
     case 0x1090: /* PINT */
         retval = 0x00000000;
         break;
+    case 0x00:
     case 0x40:
     case 0x50:
     case 0x60:
@@ -893,6 +896,9 @@ static uint32_t openpic_cpu_read_internal(void *opaque, target_phys_addr_t addr,
     dst = &opp->dst[idx];
     addr &= 0xFF0;
     switch (addr) {
+    case 0x00: /* BRR1 */
+        retval = 0x00400200;
+        break;
     case 0x80: /* PCTP */
         retval = dst->pctp;
         break;
-- 
1.7.0.4

Re: [PATCH] openpic: Added BRR1 register

[Alexander Graf]

On 07/12/2012 01:07 PM, Bharat Bhushan wrote:
> Linux mpic driver uses (changes may be in pipeline to get upstreamed soon)
> BRR1. This patch adds the support to emulate readonly BRR1.
>
> Signed-off-by: Bharat Bhushan<bharat.bhushan@freescale.com>
> ---
>   hw/openpic.c |    6 ++++++
>   1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/hw/openpic.c b/hw/openpic.c
> index 58ef871..244155b 100644
> --- a/hw/openpic.c
> +++ b/hw/openpic.c
> @@ -595,6 +595,8 @@ static void openpic_gbl_write (void *opaque, target_phys_addr_t addr, uint32_t v
>       if (addr&  0xF)
>           return;
>       switch (addr) {
> +    case 0x00: /* BRR1 Readonly */
> +        break;
>       case 0x40:
>       case 0x50:
>       case 0x60:
> @@ -671,6 +673,7 @@ static uint32_t openpic_gbl_read (void *opaque, target_phys_addr_t addr)
>       case 0x1090: /* PINT */
>           retval = 0x00000000;
>           break;
> +    case 0x00:

Add a comment saying what register this is. We really should be using 
#define's here, but it would be even worse to have it converted only 
half-way, so just stick with the comment for now.

>       case 0x40:
>       case 0x50:
>       case 0x60:
> @@ -893,6 +896,9 @@ static uint32_t openpic_cpu_read_internal(void *opaque, target_phys_addr_t addr,
>       dst =&opp->dst[idx];
>       addr&= 0xFF0;
>       switch (addr) {
> +    case 0x00: /* BRR1 */
> +        retval = 0x00400200;

Please unmagicify this one :)


Alex

> +        break;
>       case 0x80: /* PCTP */
>           retval = dst->pctp;
>           break;

RE: [PATCH] openpic: Added BRR1 register

[Bhushan Bharat-R65777]

> -----Original Message-----
> From: Alexander Graf [mailto:agraf@suse.de]
> Sent: Monday, July 16, 2012 8:25 PM
> To: Bhushan Bharat-R65777
> Cc: qemu-ppc@nongnu.org; kvm-ppc@vger.kernel.org; Bhushan Bharat-R65777
> Subject: Re: [PATCH] openpic: Added BRR1 register
> 
> On 07/12/2012 01:07 PM, Bharat Bhushan wrote:
> > Linux mpic driver uses (changes may be in pipeline to get upstreamed
> > soon) BRR1. This patch adds the support to emulate readonly BRR1.
> >
> > Signed-off-by: Bharat Bhushan<bharat.bhushan@freescale.com>
> > ---
> >   hw/openpic.c |    6 ++++++
> >   1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/hw/openpic.c b/hw/openpic.c index 58ef871..244155b 100644
> > --- a/hw/openpic.c
> > +++ b/hw/openpic.c
> > @@ -595,6 +595,8 @@ static void openpic_gbl_write (void *opaque,
> target_phys_addr_t addr, uint32_t v
> >       if (addr&  0xF)
> >           return;
> >       switch (addr) {
> > +    case 0x00: /* BRR1 Readonly */
> > +        break;
> >       case 0x40:
> >       case 0x50:
> >       case 0x60:
> > @@ -671,6 +673,7 @@ static uint32_t openpic_gbl_read (void *opaque,
> target_phys_addr_t addr)
> >       case 0x1090: /* PINT */
> >           retval = 0x00000000;
> >           break;
> > +    case 0x00:
> 
> Add a comment saying what register this is. We really should be using #define's
> here, but it would be even worse to have it converted only half-way, so just
> stick with the comment for now.

Ok, I have added on write but forgot here.

> 
> >       case 0x40:
> >       case 0x50:
> >       case 0x60:
> > @@ -893,6 +896,9 @@ static uint32_t openpic_cpu_read_internal(void *opaque,
> target_phys_addr_t addr,
> >       dst =&opp->dst[idx];
> >       addr&= 0xFF0;
> >       switch (addr) {
> > +    case 0x00: /* BRR1 */
> > +        retval = 0x00400200;
> 
> Please unmagicify this one :)

/* BRR1 ( Block revision register ) */

#define IPID 0x00400000 /* IP-block ID */
#define IPMJ 0x00000200 /* IP major number */
#define IPMN 0x00000200 /* IP minor number */

        case 0x00: /* BRR1 */
            retval = IPID | IPMJ | IPMN;

Dose this look ok?

Thanks
-Bharat

> 
>
> Alex
> 
> > +        break;
> >       case 0x80: /* PCTP */
> >           retval = dst->pctp;
> >           break;
> 

Re: [PATCH] openpic: Added BRR1 register

[Alexander Graf]

On 16.07.2012, at 18:21, Bhushan Bharat-R65777 <R65777@freescale.com> wrote:

> 
> 
>> -----Original Message-----
>> From: Alexander Graf [mailto:agraf@suse.de]
>> Sent: Monday, July 16, 2012 8:25 PM
>> To: Bhushan Bharat-R65777
>> Cc: qemu-ppc@nongnu.org; kvm-ppc@vger.kernel.org; Bhushan Bharat-R65777
>> Subject: Re: [PATCH] openpic: Added BRR1 register
>> 
>> On 07/12/2012 01:07 PM, Bharat Bhushan wrote:
>>> Linux mpic driver uses (changes may be in pipeline to get upstreamed
>>> soon) BRR1. This patch adds the support to emulate readonly BRR1.
>>> 
>>> Signed-off-by: Bharat Bhushan<bharat.bhushan@freescale.com>
>>> ---
>>>  hw/openpic.c |    6 ++++++
>>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>> 
>>> diff --git a/hw/openpic.c b/hw/openpic.c index 58ef871..244155b 100644
>>> --- a/hw/openpic.c
>>> +++ b/hw/openpic.c
>>> @@ -595,6 +595,8 @@ static void openpic_gbl_write (void *opaque,
>> target_phys_addr_t addr, uint32_t v
>>>      if (addr&  0xF)
>>>          return;
>>>      switch (addr) {
>>> +    case 0x00: /* BRR1 Readonly */
>>> +        break;
>>>      case 0x40:
>>>      case 0x50:
>>>      case 0x60:
>>> @@ -671,6 +673,7 @@ static uint32_t openpic_gbl_read (void *opaque,
>> target_phys_addr_t addr)
>>>      case 0x1090: /* PINT */
>>>          retval = 0x00000000;
>>>          break;
>>> +    case 0x00:
>> 
>> Add a comment saying what register this is. We really should be using #define's
>> here, but it would be even worse to have it converted only half-way, so just
>> stick with the comment for now.
> 
> Ok, I have added on write but forgot here.
> 
>> 
>>>      case 0x40:
>>>      case 0x50:
>>>      case 0x60:
>>> @@ -893,6 +896,9 @@ static uint32_t openpic_cpu_read_internal(void *opaque,
>> target_phys_addr_t addr,
>>>      dst =&opp->dst[idx];
>>>      addr&= 0xFF0;
>>>      switch (addr) {
>>> +    case 0x00: /* BRR1 */
>>> +        retval = 0x00400200;
>> 
>> Please unmagicify this one :)
> 
> /* BRR1 ( Block revision register ) */
> 
> #define IPID 0x00400000 /* IP-block ID */
> #define IPMJ 0x00000200 /* IP major number */
> #define IPMN 0x00000200 /* IP minor number */
> 
>        case 0x00: /* BRR1 */
>            retval = IPID | IPMJ | IPMN;
> 
> Dose this look ok?

Yup :)

Alex

> 
> Thanks
> -Bharat
> 
>> 
>> 
>> Alex
>> 
>>> +        break;
>>>      case 0x80: /* PCTP */
>>>          retval = dst->pctp;
>>>          break;
>> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] openpic: Added BRR1 register

[Scott Wood]

On 07/16/2012 11:21 AM, Bhushan Bharat-R65777 wrote:
>>> +    case 0x00: /* BRR1 */
>>> +        retval = 0x00400200;
>>
>> Please unmagicify this one :)
> 
> /* BRR1 ( Block revision register ) */
> 
> #define IPID 0x00400000 /* IP-block ID */
> #define IPMJ 0x00000200 /* IP major number */
> #define IPMN 0x00000200 /* IP minor number */

IPMN looks wrong.

-Scott

RE: [PATCH] openpic: Added BRR1 register

[Bhushan Bharat-R65777]

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogTW9uZGF5LCBKdWx5IDE2LCAyMDEyIDEwOjM0IFBNDQo+IFRvOiBCaHVzaGFu
IEJoYXJhdC1SNjU3NzcNCj4gQ2M6IEFsZXhhbmRlciBHcmFmOyBxZW11LXBwY0Bub25nbnUub3Jn
OyBrdm0tcHBjQHZnZXIua2VybmVsLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSBvcGVucGlj
OiBBZGRlZCBCUlIxIHJlZ2lzdGVyDQo+IA0KPiBPbiAwNy8xNi8yMDEyIDExOjIxIEFNLCBCaHVz
aGFuIEJoYXJhdC1SNjU3Nzcgd3JvdGU6DQo+ID4+PiArICAgIGNhc2UgMHgwMDogLyogQlJSMSAq
Lw0KPiA+Pj4gKyAgICAgICAgcmV0dmFsID0gMHgwMDQwMDIwMDsNCj4gPj4NCj4gPj4gUGxlYXNl
IHVubWFnaWNpZnkgdGhpcyBvbmUgOikNCj4gPg0KPiA+IC8qIEJSUjEgKCBCbG9jayByZXZpc2lv
biByZWdpc3RlciApICovDQo+ID4NCj4gPiAjZGVmaW5lIElQSUQgMHgwMDQwMDAwMCAvKiBJUC1i
bG9jayBJRCAqLyAjZGVmaW5lIElQTUogMHgwMDAwMDIwMCAvKg0KPiA+IElQIG1ham9yIG51bWJl
ciAqLyAjZGVmaW5lIElQTU4gMHgwMDAwMDIwMCAvKiBJUCBtaW5vciBudW1iZXIgKi8NCj4gDQo+
IElQTU4gbG9va3Mgd3JvbmcuDQoNCk9wcHMgOiBjb3B5IHBhc3RlIGVycm9yIGhlcmUgOikNCg0K
QnR3LCBJIGFtIG5vdCBhd2FyZSBvZiBhbGwgTVBJQyBJUCB2ZXJzaW9ucywgZGlmZmVyZW5jZXMg
aW4gdGhlbSBhbmQgd2hhdCBpcyB0aGUgbGF0ZXN0L2Jlc3QgdmVyc2lvbiB0aGlzIGVtdWxhdGVk
IGNvZGUgc3VwcG9ydHMuIEkgZHJpdmUgdGhpcyB2YWx1ZSBmcm9tIG1wYzg1NDQgUmVmZXJlbmNl
IE1hbnVhbC4NCg0KSSByZXF1ZXN0ZWQgQWxleCB0byBzdWdnZXN0IHRoZSBtb3N0IHVwZGF0ZWQg
dmVyc2lvbi4NCg0KVGhhbmtzDQotQmhhcmF0DQoNCj4gDQo+IC1TY290dA0K

Re: [PATCH] openpic: Added BRR1 register

[Scott Wood]

On 07/16/2012 12:09 PM, Bhushan Bharat-R65777 wrote:
> 
> 
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Monday, July 16, 2012 10:34 PM
>> To: Bhushan Bharat-R65777
>> Cc: Alexander Graf; qemu-ppc@nongnu.org; kvm-ppc@vger.kernel.org
>> Subject: Re: [PATCH] openpic: Added BRR1 register
>>
>> On 07/16/2012 11:21 AM, Bhushan Bharat-R65777 wrote:
>>>>> +    case 0x00: /* BRR1 */
>>>>> +        retval = 0x00400200;
>>>>
>>>> Please unmagicify this one :)
>>>
>>> /* BRR1 ( Block revision register ) */
>>>
>>> #define IPID 0x00400000 /* IP-block ID */ #define IPMJ 0x00000200 /*
>>> IP major number */ #define IPMN 0x00000200 /* IP minor number */
>>
>> IPMN looks wrong.
> 
> Opps : copy paste error here :)
> 
> Btw, I am not aware of all MPIC IP versions, differences in them and what is the latest/best version this emulated code supports. I drive this value from mpc8544 Reference Manual.
> 
> I requested Alex to suggest the most updated version.

QEMU does not have a complete implementation of any version of the FSL MPIC.

-Scott

RE: [PATCH] openpic: Added BRR1 register

[Yoder Stuart-B08248]

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbToga3ZtLXBwYy1vd25lckB2
Z2VyLmtlcm5lbC5vcmcgW21haWx0bzprdm0tcHBjLW93bmVyQHZnZXIua2VybmVsLm9yZ10gT24g
QmVoYWxmIE9mIFNjb3R0IFdvb2QNCj4gU2VudDogTW9uZGF5LCBKdWx5IDE2LCAyMDEyIDEyOjEy
IFBNDQo+IFRvOiBCaHVzaGFuIEJoYXJhdC1SNjU3NzcNCj4gQ2M6IFdvb2QgU2NvdHQtQjA3NDIx
OyBBbGV4YW5kZXIgR3JhZjsgcWVtdS1wcGNAbm9uZ251Lm9yZzsga3ZtLXBwY0B2Z2VyLmtlcm5l
bC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gb3BlbnBpYzogQWRkZWQgQlJSMSByZWdpc3Rl
cg0KPiANCj4gT24gMDcvMTYvMjAxMiAxMjowOSBQTSwgQmh1c2hhbiBCaGFyYXQtUjY1Nzc3IHdy
b3RlOg0KPiA+DQo+ID4NCj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJv
bTogV29vZCBTY290dC1CMDc0MjENCj4gPj4gU2VudDogTW9uZGF5LCBKdWx5IDE2LCAyMDEyIDEw
OjM0IFBNDQo+ID4+IFRvOiBCaHVzaGFuIEJoYXJhdC1SNjU3NzcNCj4gPj4gQ2M6IEFsZXhhbmRl
ciBHcmFmOyBxZW11LXBwY0Bub25nbnUub3JnOyBrdm0tcHBjQHZnZXIua2VybmVsLm9yZw0KPiA+
PiBTdWJqZWN0OiBSZTogW1BBVENIXSBvcGVucGljOiBBZGRlZCBCUlIxIHJlZ2lzdGVyDQo+ID4+
DQo+ID4+IE9uIDA3LzE2LzIwMTIgMTE6MjEgQU0sIEJodXNoYW4gQmhhcmF0LVI2NTc3NyB3cm90
ZToNCj4gPj4+Pj4gKyAgICBjYXNlIDB4MDA6IC8qIEJSUjEgKi8NCj4gPj4+Pj4gKyAgICAgICAg
cmV0dmFsID0gMHgwMDQwMDIwMDsNCj4gPj4+Pg0KPiA+Pj4+IFBsZWFzZSB1bm1hZ2ljaWZ5IHRo
aXMgb25lIDopDQo+ID4+Pg0KPiA+Pj4gLyogQlJSMSAoIEJsb2NrIHJldmlzaW9uIHJlZ2lzdGVy
ICkgKi8NCj4gPj4+DQo+ID4+PiAjZGVmaW5lIElQSUQgMHgwMDQwMDAwMCAvKiBJUC1ibG9jayBJ
RCAqLyAjZGVmaW5lIElQTUogMHgwMDAwMDIwMCAvKg0KPiA+Pj4gSVAgbWFqb3IgbnVtYmVyICov
ICNkZWZpbmUgSVBNTiAweDAwMDAwMjAwIC8qIElQIG1pbm9yIG51bWJlciAqLw0KPiA+Pg0KPiA+
PiBJUE1OIGxvb2tzIHdyb25nLg0KPiA+DQo+ID4gT3BwcyA6IGNvcHkgcGFzdGUgZXJyb3IgaGVy
ZSA6KQ0KPiA+DQo+ID4gQnR3LCBJIGFtIG5vdCBhd2FyZSBvZiBhbGwgTVBJQyBJUCB2ZXJzaW9u
cywgZGlmZmVyZW5jZXMgaW4gdGhlbSBhbmQgd2hhdCBpcyB0aGUgbGF0ZXN0L2Jlc3QgdmVyc2lv
bg0KPiB0aGlzIGVtdWxhdGVkIGNvZGUgc3VwcG9ydHMuIEkgZHJpdmUgdGhpcyB2YWx1ZSBmcm9t
IG1wYzg1NDQgUmVmZXJlbmNlIE1hbnVhbC4NCj4gPg0KPiA+IEkgcmVxdWVzdGVkIEFsZXggdG8g
c3VnZ2VzdCB0aGUgbW9zdCB1cGRhdGVkIHZlcnNpb24uDQo+IA0KPiBRRU1VIGRvZXMgbm90IGhh
dmUgYSBjb21wbGV0ZSBpbXBsZW1lbnRhdGlvbiBvZiBhbnkgdmVyc2lvbiBvZiB0aGUgRlNMIE1Q
SUMuDQoNClNvIHdoYXQgcmV2aXNpb24gbnVtYmVycyBzaG91bGQgd2UgdXNlPw0KDQpTdHVhcnQN
Cg=

Re: [PATCH] openpic: Added BRR1 register

[Scott Wood]

On 07/16/2012 02:29 PM, Yoder Stuart-B08248 wrote:
> 
> 
>> -----Original Message-----
>> From: kvm-ppc-owner@vger.kernel.org [mailto:kvm-ppc-owner@vger.kernel.org] On Behalf Of Scott Wood
>> Sent: Monday, July 16, 2012 12:12 PM
>> To: Bhushan Bharat-R65777
>> Cc: Wood Scott-B07421; Alexander Graf; qemu-ppc@nongnu.org; kvm-ppc@vger.kernel.org
>> Subject: Re: [PATCH] openpic: Added BRR1 register
>>
>> On 07/16/2012 12:09 PM, Bhushan Bharat-R65777 wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Wood Scott-B07421
>>>> Sent: Monday, July 16, 2012 10:34 PM
>>>> To: Bhushan Bharat-R65777
>>>> Cc: Alexander Graf; qemu-ppc@nongnu.org; kvm-ppc@vger.kernel.org
>>>> Subject: Re: [PATCH] openpic: Added BRR1 register
>>>>
>>>> On 07/16/2012 11:21 AM, Bhushan Bharat-R65777 wrote:
>>>>>>> +    case 0x00: /* BRR1 */
>>>>>>> +        retval = 0x00400200;
>>>>>>
>>>>>> Please unmagicify this one :)
>>>>>
>>>>> /* BRR1 ( Block revision register ) */
>>>>>
>>>>> #define IPID 0x00400000 /* IP-block ID */ #define IPMJ 0x00000200 /*
>>>>> IP major number */ #define IPMN 0x00000200 /* IP minor number */
>>>>
>>>> IPMN looks wrong.
>>>
>>> Opps : copy paste error here :)
>>>
>>> Btw, I am not aware of all MPIC IP versions, differences in them and what is the latest/best version
>> this emulated code supports. I drive this value from mpc8544 Reference Manual.
>>>
>>> I requested Alex to suggest the most updated version.
>>
>> QEMU does not have a complete implementation of any version of the FSL MPIC.
> 
> So what revision numbers should we use?

How about 0.0 for now?

-Scott

Re: [PATCH] openpic: Added BRR1 register

[Alexander Graf]

On 16.07.2012, at 21:32, Scott Wood wrote:

> On 07/16/2012 02:29 PM, Yoder Stuart-B08248 wrote:
>> 
>> 
>>> -----Original Message-----
>>> From: kvm-ppc-owner@vger.kernel.org [mailto:kvm-ppc-owner@vger.kernel.org] On Behalf Of Scott Wood
>>> Sent: Monday, July 16, 2012 12:12 PM
>>> To: Bhushan Bharat-R65777
>>> Cc: Wood Scott-B07421; Alexander Graf; qemu-ppc@nongnu.org; kvm-ppc@vger.kernel.org
>>> Subject: Re: [PATCH] openpic: Added BRR1 register
>>> 
>>> On 07/16/2012 12:09 PM, Bhushan Bharat-R65777 wrote:
>>>> 
>>>> 
>>>>> -----Original Message-----
>>>>> From: Wood Scott-B07421
>>>>> Sent: Monday, July 16, 2012 10:34 PM
>>>>> To: Bhushan Bharat-R65777
>>>>> Cc: Alexander Graf; qemu-ppc@nongnu.org; kvm-ppc@vger.kernel.org
>>>>> Subject: Re: [PATCH] openpic: Added BRR1 register
>>>>> 
>>>>> On 07/16/2012 11:21 AM, Bhushan Bharat-R65777 wrote:
>>>>>>>> +    case 0x00: /* BRR1 */
>>>>>>>> +        retval = 0x00400200;
>>>>>>> 
>>>>>>> Please unmagicify this one :)
>>>>>> 
>>>>>> /* BRR1 ( Block revision register ) */
>>>>>> 
>>>>>> #define IPID 0x00400000 /* IP-block ID */ #define IPMJ 0x00000200 /*
>>>>>> IP major number */ #define IPMN 0x00000200 /* IP minor number */
>>>>> 
>>>>> IPMN looks wrong.
>>>> 
>>>> Opps : copy paste error here :)
>>>> 
>>>> Btw, I am not aware of all MPIC IP versions, differences in them and what is the latest/best version
>>> this emulated code supports. I drive this value from mpc8544 Reference Manual.
>>>> 
>>>> I requested Alex to suggest the most updated version.
>>> 
>>> QEMU does not have a complete implementation of any version of the FSL MPIC.
>> 
>> So what revision numbers should we use?
> 
> How about 0.0 for now?

Would guests care (read: break)?


Alex

Re: [PATCH] openpic: Added BRR1 register

[Scott Wood]

On 07/16/2012 03:09 PM, Alexander Graf wrote:
> 
> On 16.07.2012, at 21:32, Scott Wood wrote:
> 
>> On 07/16/2012 02:29 PM, Yoder Stuart-B08248 wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: kvm-ppc-owner@vger.kernel.org [mailto:kvm-ppc-owner@vger.kernel.org] On Behalf Of Scott Wood
>>>> Sent: Monday, July 16, 2012 12:12 PM
>>>> To: Bhushan Bharat-R65777
>>>> Cc: Wood Scott-B07421; Alexander Graf; qemu-ppc@nongnu.org; kvm-ppc@vger.kernel.org
>>>> Subject: Re: [PATCH] openpic: Added BRR1 register
>>>>
>>>> On 07/16/2012 12:09 PM, Bhushan Bharat-R65777 wrote:
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Wood Scott-B07421
>>>>>> Sent: Monday, July 16, 2012 10:34 PM
>>>>>> To: Bhushan Bharat-R65777
>>>>>> Cc: Alexander Graf; qemu-ppc@nongnu.org; kvm-ppc@vger.kernel.org
>>>>>> Subject: Re: [PATCH] openpic: Added BRR1 register
>>>>>>
>>>>>> On 07/16/2012 11:21 AM, Bhushan Bharat-R65777 wrote:
>>>>>>>>> +    case 0x00: /* BRR1 */
>>>>>>>>> +        retval = 0x00400200;
>>>>>>>>
>>>>>>>> Please unmagicify this one :)
>>>>>>>
>>>>>>> /* BRR1 ( Block revision register ) */
>>>>>>>
>>>>>>> #define IPID 0x00400000 /* IP-block ID */ #define IPMJ 0x00000200 /*
>>>>>>> IP major number */ #define IPMN 0x00000200 /* IP minor number */
>>>>>>
>>>>>> IPMN looks wrong.
>>>>>
>>>>> Opps : copy paste error here :)
>>>>>
>>>>> Btw, I am not aware of all MPIC IP versions, differences in them and what is the latest/best version
>>>> this emulated code supports. I drive this value from mpc8544 Reference Manual.
>>>>>
>>>>> I requested Alex to suggest the most updated version.
>>>>
>>>> QEMU does not have a complete implementation of any version of the FSL MPIC.
>>>
>>> So what revision numbers should we use?
>>
>> How about 0.0 for now?
> 
> Would guests care (read: break)?

I can't answer that question for "guests" in general.  They could just
as well break due to the missing functionality.

Linux currently does not look at the version information, though there
are a couple patches posted that do depend on it to check for certain
features.  If it sees 0.0, it won't use features that aren't there.

One thing that might break if we claim 2.0 is that there was a patch
posted over the weekend that assumes an MSI erratum on version 2.0.
This would break if we're directly assigning a non-broken MSI block to
the guest, since the rest of the MPIC is still emulated.  That said, it
wouldn't be QEMU's fault.  It's a combination that doesn't exist in real
hardware and it shouldn't be surprising that the guest might need some
fixing to accommodate it.

-Scott

RE: [PATCH] openpic: Added BRR1 register

[Yin Olivia-R63875]

RllJLCBNUElDIHZlcnNpb24gb24gUDQwODAgaXMgMDQwMS4NCiNkZWZpbmUgSVBNSiAweDAwMDAw
NDAwDQojZGVmaW5lIElQTU4gMHgwMDAwMDAwMQ0KDQpCZXN0IFJlZ2FyZHMsDQpPbGl2aWENCg0K
LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IGt2bS1wcGMtb3duZXJAdmdlci5rZXJu
ZWwub3JnIFttYWlsdG86a3ZtLXBwYy1vd25lckB2Z2VyLmtlcm5lbC5vcmddIE9uIEJlaGFsZiBP
ZiBCaHVzaGFuIEJoYXJhdC1SNjU3NzcNClNlbnQ6IFR1ZXNkYXksIEp1bHkgMTcsIDIwMTIgMTox
MCBBTQ0KVG86IFdvb2QgU2NvdHQtQjA3NDIxDQpDYzogQWxleGFuZGVyIEdyYWY7IHFlbXUtcHBj
QG5vbmdudS5vcmc7IGt2bS1wcGNAdmdlci5rZXJuZWwub3JnDQpTdWJqZWN0OiBSRTogW1BBVENI
XSBvcGVucGljOiBBZGRlZCBCUlIxIHJlZ2lzdGVyDQoNCg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVz
c2FnZS0tLS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+IFNlbnQ6IE1vbmRheSwgSnVs
eSAxNiwgMjAxMiAxMDozNCBQTQ0KPiBUbzogQmh1c2hhbiBCaGFyYXQtUjY1Nzc3DQo+IENjOiBB
bGV4YW5kZXIgR3JhZjsgcWVtdS1wcGNAbm9uZ251Lm9yZzsga3ZtLXBwY0B2Z2VyLmtlcm5lbC5v
cmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gb3BlbnBpYzogQWRkZWQgQlJSMSByZWdpc3Rlcg0K
PiANCj4gT24gMDcvMTYvMjAxMiAxMToyMSBBTSwgQmh1c2hhbiBCaGFyYXQtUjY1Nzc3IHdyb3Rl
Og0KPiA+Pj4gKyAgICBjYXNlIDB4MDA6IC8qIEJSUjEgKi8NCj4gPj4+ICsgICAgICAgIHJldHZh
bCA9IDB4MDA0MDAyMDA7DQo+ID4+DQo+ID4+IFBsZWFzZSB1bm1hZ2ljaWZ5IHRoaXMgb25lIDop
DQo+ID4NCj4gPiAvKiBCUlIxICggQmxvY2sgcmV2aXNpb24gcmVnaXN0ZXIgKSAqLw0KPiA+DQo+
ID4gI2RlZmluZSBJUElEIDB4MDA0MDAwMDAgLyogSVAtYmxvY2sgSUQgKi8gI2RlZmluZSBJUE1K
IDB4MDAwMDAyMDAgLyogDQo+ID4gSVAgbWFqb3IgbnVtYmVyICovICNkZWZpbmUgSVBNTiAweDAw
MDAwMjAwIC8qIElQIG1pbm9yIG51bWJlciAqLw0KPiANCj4gSVBNTiBsb29rcyB3cm9uZy4NCg0K
T3BwcyA6IGNvcHkgcGFzdGUgZXJyb3IgaGVyZSA6KQ0KDQpCdHcsIEkgYW0gbm90IGF3YXJlIG9m
IGFsbCBNUElDIElQIHZlcnNpb25zLCBkaWZmZXJlbmNlcyBpbiB0aGVtIGFuZCB3aGF0IGlzIHRo
ZSBsYXRlc3QvYmVzdCB2ZXJzaW9uIHRoaXMgZW11bGF0ZWQgY29kZSBzdXBwb3J0cy4gSSBkcml2
ZSB0aGlzIHZhbHVlIGZyb20gbXBjODU0NCBSZWZlcmVuY2UgTWFudWFsLg0KDQpJIHJlcXVlc3Rl
ZCBBbGV4IHRvIHN1Z2dlc3QgdGhlIG1vc3QgdXBkYXRlZCB2ZXJzaW9uLg0KDQpUaGFua3MNCi1C
aGFyYXQNCg0KPiANCj4gLVNjb3R0DQpOICAgICByICB5ICAgYiBYICDHp3YgXiAp3rp7Lm4gKyAg
ICBqaXIpICAgdypqZyAgIB4gICAgIN2iai8gICB6IN6WICAyIN6ZICAgJiAp36EgYSAgfyAgHiBH
ICAgaCAPIGo6K3YgICB3INmlDQo