* am33xx: default to status = "disabled"?
@ 2012-08-02 22:58 ` Daniel Mack
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Mack @ 2012-08-02 22:58 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
currently, all devices in arch/arm/boot/dts/am33xx.dtsi are enabled by
default. However, depending on the actual board dts, only some of the
devices should actually be initialized, given that they only make sense
if their pins are actually wired on the board.
On other platform, such devices are marked with status = "disabled", and
the board files re-enable those they really use by overriding that
status again. That approach seems to make sense - shouldn't the same be
done in am33xx.dtsi or am I missing something?
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
* am33xx: default to status = "disabled"?
@ 2012-08-02 22:58 ` Daniel Mack
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Mack @ 2012-08-02 22:58 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Paul Walmsley,
Koen Kooi, Hiremath, Vaibhav, Arnd Bergmann, Tony Lindgren
Hi,
currently, all devices in arch/arm/boot/dts/am33xx.dtsi are enabled by
default. However, depending on the actual board dts, only some of the
devices should actually be initialized, given that they only make sense
if their pins are actually wired on the board.
On other platform, such devices are marked with status = "disabled", and
the board files re-enable those they really use by overriding that
status again. That approach seems to make sense - shouldn't the same be
done in am33xx.dtsi or am I missing something?
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
* am33xx: default to status = "disabled"?
@ 2012-08-02 23:28 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2012-08-02 23:28 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 02 August 2012, Daniel Mack wrote:
> currently, all devices in arch/arm/boot/dts/am33xx.dtsi are enabled by
> default. However, depending on the actual board dts, only some of the
> devices should actually be initialized, given that they only make sense
> if their pins are actually wired on the board.
>
> On other platform, such devices are marked with status = "disabled", and
> the board files re-enable those they really use by overriding that
> status again. That approach seems to make sense - shouldn't the same be
> done in am33xx.dtsi or am I missing something?
I agree, they should be disabled, at least the serial ports, and probably
also the i2c controllers.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: am33xx: default to status = "disabled"?
@ 2012-08-02 23:28 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2012-08-02 23:28 UTC (permalink / raw)
To: Daniel Mack
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Koen Kooi,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
On Thursday 02 August 2012, Daniel Mack wrote:
> currently, all devices in arch/arm/boot/dts/am33xx.dtsi are enabled by
> default. However, depending on the actual board dts, only some of the
> devices should actually be initialized, given that they only make sense
> if their pins are actually wired on the board.
>
> On other platform, such devices are marked with status = "disabled", and
> the board files re-enable those they really use by overriding that
> status again. That approach seems to make sense - shouldn't the same be
> done in am33xx.dtsi or am I missing something?
I agree, they should be disabled, at least the serial ports, and probably
also the i2c controllers.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* am33xx: default to status = "disabled"?
@ 2012-08-03 9:31 ` Hiremath, Vaibhav
0 siblings, 0 replies; 6+ messages in thread
From: Hiremath, Vaibhav @ 2012-08-03 9:31 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 03, 2012 at 04:58:16, Arnd Bergmann wrote:
> On Thursday 02 August 2012, Daniel Mack wrote:
> > currently, all devices in arch/arm/boot/dts/am33xx.dtsi are enabled by
> > default. However, depending on the actual board dts, only some of the
> > devices should actually be initialized, given that they only make sense
> > if their pins are actually wired on the board.
> >
> > On other platform, such devices are marked with status = "disabled", and
> > the board files re-enable those they really use by overriding that
> > status again. That approach seems to make sense - shouldn't the same be
> > done in am33xx.dtsi or am I missing something?
>
> I agree, they should be disabled, at least the serial ports, and probably
> also the i2c controllers.
>
You are right, it needs to be disabled. I will create a patch and submit it.
Thanks,
Vaibhav
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: am33xx: default to status = "disabled"?
@ 2012-08-03 9:31 ` Hiremath, Vaibhav
0 siblings, 0 replies; 6+ messages in thread
From: Hiremath, Vaibhav @ 2012-08-03 9:31 UTC (permalink / raw)
To: Arnd Bergmann, Daniel Mack
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Koen Kooi
On Fri, Aug 03, 2012 at 04:58:16, Arnd Bergmann wrote:
> On Thursday 02 August 2012, Daniel Mack wrote:
> > currently, all devices in arch/arm/boot/dts/am33xx.dtsi are enabled by
> > default. However, depending on the actual board dts, only some of the
> > devices should actually be initialized, given that they only make sense
> > if their pins are actually wired on the board.
> >
> > On other platform, such devices are marked with status = "disabled", and
> > the board files re-enable those they really use by overriding that
> > status again. That approach seems to make sense - shouldn't the same be
> > done in am33xx.dtsi or am I missing something?
>
> I agree, they should be disabled, at least the serial ports, and probably
> also the i2c controllers.
>
You are right, it needs to be disabled. I will create a patch and submit it.
Thanks,
Vaibhav
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-03 9:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-02 22:58 am33xx: default to status = "disabled"? Daniel Mack
2012-08-02 22:58 ` Daniel Mack
2012-08-02 23:28 ` Arnd Bergmann
2012-08-02 23:28 ` Arnd Bergmann
2012-08-03 9:31 ` Hiremath, Vaibhav
2012-08-03 9:31 ` Hiremath, Vaibhav
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.