Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-common: Declare qemu_irq earlier

[Stefan Weil <sw@weilnetz.de>]

Am 24.08.2012 13:56, schrieb Stefan Hajnoczi:
> On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell
> <peter.maydell@linaro.org>  wrote:
>> On 24 August 2012 11:54, Stefan Hajnoczi<stefanha@gmail.com>  wrote:
>>> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
>>>> This allows using qemu_irq in the target specific cpu.h.
>>>>
>>>> Signed-off-by: Stefan Weil<sw@weilnetz.de>
>>>> ---
>>>>   qemu-common.h |    3 ++-
>>>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> I'm not sure if there's a reason why qemu_irq was previously hidden from
>>> cpu.h but the code change itself is fine and no one else has commented.
>>>
>>> Thanks, applied to the trivial patches tree:
>>> https://github.com/stefanha/qemu/commits/trivial-patches
>>
>> Consensus seemed to be that it was better to move qemu_irq
>> into hw/irq.h, as discussed in this mail thread:
>> http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html
>> rather than just doing a move of the typedef within this header.
>
> Fine by me.  I won't send a pull request with this patch yet.
>
> Stefan Weil: Are you happy to use the hw/irq.h patch instead of this?
>
> Stefan

Stefan H., that's OK.

Cheers,
Stefan