* [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier
@ 2012-08-20 4:45 ` Stefan Weil
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Weil @ 2012-08-20 4:45 UTC (permalink / raw)
To: qemu-trivial; +Cc: imammedo, qemu-devel, Stefan Weil
This allows using qemu_irq in the target specific cpu.h.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
qemu-common.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/qemu-common.h b/qemu-common.h
index 74a99d3..88a515e 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -19,6 +19,8 @@ struct Monitor;
typedef struct Monitor Monitor;
typedef struct MigrationParams MigrationParams;
+typedef struct IRQState *qemu_irq;
+
/* we put basic includes here to avoid repeating them in device drivers */
#include <stdlib.h>
#include <stdio.h>
@@ -276,7 +278,6 @@ typedef struct PCIEPort PCIEPort;
typedef struct PCIESlot PCIESlot;
typedef struct MSIMessage MSIMessage;
typedef struct SerialState SerialState;
-typedef struct IRQState *qemu_irq;
typedef struct PCMCIACardState PCMCIACardState;
typedef struct MouseTransformInfo MouseTransformInfo;
typedef struct uWireSlave uWireSlave;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Qemu-devel] [PATCH] qemu-common: Declare qemu_irq earlier
@ 2012-08-20 4:45 ` Stefan Weil
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Weil @ 2012-08-20 4:45 UTC (permalink / raw)
To: qemu-trivial; +Cc: imammedo, qemu-devel, Stefan Weil
This allows using qemu_irq in the target specific cpu.h.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
qemu-common.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/qemu-common.h b/qemu-common.h
index 74a99d3..88a515e 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -19,6 +19,8 @@ struct Monitor;
typedef struct Monitor Monitor;
typedef struct MigrationParams MigrationParams;
+typedef struct IRQState *qemu_irq;
+
/* we put basic includes here to avoid repeating them in device drivers */
#include <stdlib.h>
#include <stdio.h>
@@ -276,7 +278,6 @@ typedef struct PCIEPort PCIEPort;
typedef struct PCIESlot PCIESlot;
typedef struct MSIMessage MSIMessage;
typedef struct SerialState SerialState;
-typedef struct IRQState *qemu_irq;
typedef struct PCMCIACardState PCMCIACardState;
typedef struct MouseTransformInfo MouseTransformInfo;
typedef struct uWireSlave uWireSlave;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier
2012-08-20 4:45 ` [Qemu-devel] " Stefan Weil
@ 2012-08-24 10:54 ` Stefan Hajnoczi
-1 siblings, 0 replies; 10+ messages in thread
From: Stefan Hajnoczi @ 2012-08-24 10:54 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, imammedo, qemu-devel
On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
> This allows using qemu_irq in the target specific cpu.h.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> qemu-common.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
I'm not sure if there's a reason why qemu_irq was previously hidden from
cpu.h but the code change itself is fine and no one else has commented.
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier
@ 2012-08-24 10:54 ` Stefan Hajnoczi
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Hajnoczi @ 2012-08-24 10:54 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, imammedo, qemu-devel
On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
> This allows using qemu_irq in the target specific cpu.h.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> qemu-common.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
I'm not sure if there's a reason why qemu_irq was previously hidden from
cpu.h but the code change itself is fine and no one else has commented.
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-common: Declare qemu_irq earlier
2012-08-24 10:54 ` [Qemu-devel] " Stefan Hajnoczi
@ 2012-08-24 11:06 ` Peter Maydell
-1 siblings, 0 replies; 10+ messages in thread
From: Peter Maydell @ 2012-08-24 11:06 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-trivial, Stefan Weil, qemu-devel, imammedo
On 24 August 2012 11:54, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
>> This allows using qemu_irq in the target specific cpu.h.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> qemu-common.h | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> I'm not sure if there's a reason why qemu_irq was previously hidden from
> cpu.h but the code change itself is fine and no one else has commented.
>
> Thanks, applied to the trivial patches tree:
> https://github.com/stefanha/qemu/commits/trivial-patches
Consensus seemed to be that it was better to move qemu_irq
into hw/irq.h, as discussed in this mail thread:
http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html
rather than just doing a move of the typedef within this header.
-- PMM
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier
@ 2012-08-24 11:06 ` Peter Maydell
0 siblings, 0 replies; 10+ messages in thread
From: Peter Maydell @ 2012-08-24 11:06 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-trivial, Stefan Weil, qemu-devel, imammedo
On 24 August 2012 11:54, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
>> This allows using qemu_irq in the target specific cpu.h.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> qemu-common.h | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> I'm not sure if there's a reason why qemu_irq was previously hidden from
> cpu.h but the code change itself is fine and no one else has commented.
>
> Thanks, applied to the trivial patches tree:
> https://github.com/stefanha/qemu/commits/trivial-patches
Consensus seemed to be that it was better to move qemu_irq
into hw/irq.h, as discussed in this mail thread:
http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html
rather than just doing a move of the typedef within this header.
-- PMM
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-common: Declare qemu_irq earlier
2012-08-24 11:06 ` [Qemu-devel] [Qemu-trivial] " Peter Maydell
@ 2012-08-24 11:56 ` Stefan Hajnoczi
-1 siblings, 0 replies; 10+ messages in thread
From: Stefan Hajnoczi @ 2012-08-24 11:56 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, Stefan Weil, qemu-devel, imammedo
On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 24 August 2012 11:54, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
>>> This allows using qemu_irq in the target specific cpu.h.
>>>
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>> ---
>>> qemu-common.h | 3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> I'm not sure if there's a reason why qemu_irq was previously hidden from
>> cpu.h but the code change itself is fine and no one else has commented.
>>
>> Thanks, applied to the trivial patches tree:
>> https://github.com/stefanha/qemu/commits/trivial-patches
>
> Consensus seemed to be that it was better to move qemu_irq
> into hw/irq.h, as discussed in this mail thread:
> http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html
> rather than just doing a move of the typedef within this header.
Fine by me. I won't send a pull request with this patch yet.
Stefan Weil: Are you happy to use the hw/irq.h patch instead of this?
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier
@ 2012-08-24 11:56 ` Stefan Hajnoczi
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Hajnoczi @ 2012-08-24 11:56 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, Stefan Weil, qemu-devel, imammedo
On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 24 August 2012 11:54, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
>>> This allows using qemu_irq in the target specific cpu.h.
>>>
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>> ---
>>> qemu-common.h | 3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> I'm not sure if there's a reason why qemu_irq was previously hidden from
>> cpu.h but the code change itself is fine and no one else has commented.
>>
>> Thanks, applied to the trivial patches tree:
>> https://github.com/stefanha/qemu/commits/trivial-patches
>
> Consensus seemed to be that it was better to move qemu_irq
> into hw/irq.h, as discussed in this mail thread:
> http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html
> rather than just doing a move of the typedef within this header.
Fine by me. I won't send a pull request with this patch yet.
Stefan Weil: Are you happy to use the hw/irq.h patch instead of this?
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-common: Declare qemu_irq earlier
2012-08-24 11:56 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
@ 2012-08-24 17:33 ` Stefan Weil
-1 siblings, 0 replies; 10+ messages in thread
From: Stefan Weil @ 2012-08-24 17:33 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-trivial, Peter Maydell, qemu-devel, imammedo
Am 24.08.2012 13:56, schrieb Stefan Hajnoczi:
> On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell
> <peter.maydell@linaro.org> wrote:
>> On 24 August 2012 11:54, Stefan Hajnoczi<stefanha@gmail.com> wrote:
>>> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
>>>> This allows using qemu_irq in the target specific cpu.h.
>>>>
>>>> Signed-off-by: Stefan Weil<sw@weilnetz.de>
>>>> ---
>>>> qemu-common.h | 3 ++-
>>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> I'm not sure if there's a reason why qemu_irq was previously hidden from
>>> cpu.h but the code change itself is fine and no one else has commented.
>>>
>>> Thanks, applied to the trivial patches tree:
>>> https://github.com/stefanha/qemu/commits/trivial-patches
>>
>> Consensus seemed to be that it was better to move qemu_irq
>> into hw/irq.h, as discussed in this mail thread:
>> http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html
>> rather than just doing a move of the typedef within this header.
>
> Fine by me. I won't send a pull request with this patch yet.
>
> Stefan Weil: Are you happy to use the hw/irq.h patch instead of this?
>
> Stefan
Stefan H., that's OK.
Cheers,
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier
@ 2012-08-24 17:33 ` Stefan Weil
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Weil @ 2012-08-24 17:33 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-trivial, Peter Maydell, qemu-devel, imammedo
Am 24.08.2012 13:56, schrieb Stefan Hajnoczi:
> On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell
> <peter.maydell@linaro.org> wrote:
>> On 24 August 2012 11:54, Stefan Hajnoczi<stefanha@gmail.com> wrote:
>>> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
>>>> This allows using qemu_irq in the target specific cpu.h.
>>>>
>>>> Signed-off-by: Stefan Weil<sw@weilnetz.de>
>>>> ---
>>>> qemu-common.h | 3 ++-
>>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> I'm not sure if there's a reason why qemu_irq was previously hidden from
>>> cpu.h but the code change itself is fine and no one else has commented.
>>>
>>> Thanks, applied to the trivial patches tree:
>>> https://github.com/stefanha/qemu/commits/trivial-patches
>>
>> Consensus seemed to be that it was better to move qemu_irq
>> into hw/irq.h, as discussed in this mail thread:
>> http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html
>> rather than just doing a move of the typedef within this header.
>
> Fine by me. I won't send a pull request with this patch yet.
>
> Stefan Weil: Are you happy to use the hw/irq.h patch instead of this?
>
> Stefan
Stefan H., that's OK.
Cheers,
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-08-24 17:33 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-20 4:45 [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier Stefan Weil
2012-08-20 4:45 ` [Qemu-devel] " Stefan Weil
2012-08-24 10:54 ` [Qemu-trivial] " Stefan Hajnoczi
2012-08-24 10:54 ` [Qemu-devel] " Stefan Hajnoczi
2012-08-24 11:06 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2012-08-24 11:06 ` [Qemu-devel] [Qemu-trivial] " Peter Maydell
2012-08-24 11:56 ` [Qemu-trivial] [Qemu-devel] " Stefan Hajnoczi
2012-08-24 11:56 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-08-24 17:33 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2012-08-24 17:33 ` [Qemu-devel] [Qemu-trivial] " Stefan Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.