All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Rob Herring <robherring2@gmail.com>
Cc: Cyril Chemparathy <cyril@ti.com>,
	linux-mips@linux-mips.org, x86@kernel.org, a-jacquiot@ti.com,
	mahesh@linux.vnet.ibm.com, linus.walleij@linaro.org,
	grant.likely@secretlab.ca, paul.gortmaker@windriver.com,
	paulus@samba.org, hpa@zytor.com, m.szyprowski@samsung.com,
	jonas@southpole.se, linux@arm.linux.org.uk,
	linux-c6x-dev@linux-c6x.org, nico@linaro.org,
	david.daney@cavium.com, mingo@redhat.com,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	benh@kernel.crashing.org, suzuki@in.ibm.com, linux@openrisc.net,
	arnd@arndb.de, microblaze-uclinux@itee.uq.edu.au,
	devicetree-discuss@lists.ozlabs.org, msalter@redhat.com,
	rob.herring@calxeda.com, tglx@linutronix.de,
	linux-arm-kernel@lists.infradead.org, blogic@openwrt.org,
	dhowells@redhat.com, monstr@monstr.eu,
	linux-kernel@vger.kernel.org, ralf@linux-mips.org, tj@kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] of: specify initrd location using 64-bit
Date: Thu, 13 Sep 2012 08:47:06 +0200	[thread overview]
Message-ID: <5051816A.3050705@linutronix.de> (raw)
In-Reply-To: <505107DF.5020105@gmail.com>

On 09/13/2012 12:08 AM, Rob Herring wrote:
>> Geert is right here. If it is a physical address, it should be
>> phys_addr_t.
>
> While generally true, for the DT specific code I think it should be a
> fixed u64. The size of the address is defined by the FDT, not the
> kernel. It is very likely we could have a FDT that specifies addresses
> in 64-bit values, but then we boot a kernel is compiled for !LPAE.
> phys_addr_t is currently sized based on LPAE setting.

If your kernel is 32bit without PAE and your DTB address is >32ibt than
you can't handle it. If you don't notice this in your dt code than you
remap the wrong memory ioremap().

>
> Rob
>

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-mips@linux-mips.org, a-jacquiot@ti.com,
	mahesh@linux.vnet.ibm.com, linux@openrisc.net,
	paul.gortmaker@windriver.com, paulus@samba.org, hpa@zytor.com,
	m.szyprowski@samsung.com, jonas@southpole.se,
	linux@arm.linux.org.uk, linux-c6x-dev@linux-c6x.org,
	nico@linaro.org, x86@kernel.org, mingo@redhat.com,
	suzuki@in.ibm.com, Cyril Chemparathy <cyril@ti.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linus.walleij@linaro.org, arnd@arndb.de,
	microblaze-uclinux@itee.uq.edu.au,
	devicetree-discuss@lists.ozlabs.org, msalter@redhat.com,
	rob.herring@calxeda.com, tglx@linutronix.de,
	linux-arm-kernel@lists.infradead.org, blogic@openwrt.org,
	dhowells@redhat.com, monstr@monstr.eu, david.daney@cavium.com,
	linux-kernel@vger.kernel.org, ralf@linux-mips.org, tj@kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] of: specify initrd location using 64-bit
Date: Thu, 13 Sep 2012 08:47:06 +0200	[thread overview]
Message-ID: <5051816A.3050705@linutronix.de> (raw)
In-Reply-To: <505107DF.5020105@gmail.com>

On 09/13/2012 12:08 AM, Rob Herring wrote:
>> Geert is right here. If it is a physical address, it should be
>> phys_addr_t.
>
> While generally true, for the DT specific code I think it should be a
> fixed u64. The size of the address is defined by the FDT, not the
> kernel. It is very likely we could have a FDT that specifies addresses
> in 64-bit values, but then we boot a kernel is compiled for !LPAE.
> phys_addr_t is currently sized based on LPAE setting.

If your kernel is 32bit without PAE and your DTB address is >32ibt than
you can't handle it. If you don't notice this in your dt code than you
remap the wrong memory ioremap().

>
> Rob
>

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: bigeasy@linutronix.de (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] of: specify initrd location using 64-bit
Date: Thu, 13 Sep 2012 08:47:06 +0200	[thread overview]
Message-ID: <5051816A.3050705@linutronix.de> (raw)
In-Reply-To: <505107DF.5020105@gmail.com>

On 09/13/2012 12:08 AM, Rob Herring wrote:
>> Geert is right here. If it is a physical address, it should be
>> phys_addr_t.
>
> While generally true, for the DT specific code I think it should be a
> fixed u64. The size of the address is defined by the FDT, not the
> kernel. It is very likely we could have a FDT that specifies addresses
> in 64-bit values, but then we boot a kernel is compiled for !LPAE.
> phys_addr_t is currently sized based on LPAE setting.

If your kernel is 32bit without PAE and your DTB address is >32ibt than
you can't handle it. If you don't notice this in your dt code than you
remap the wrong memory ioremap().

>
> Rob
>

Sebastian

  reply	other threads:[~2012-09-13  6:48 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 16:05 [PATCH] of: specify initrd location using 64-bit Cyril Chemparathy
2012-09-12 16:05 ` Cyril Chemparathy
2012-09-12 16:05 ` Cyril Chemparathy
2012-09-12 16:05 ` Cyril Chemparathy
2012-09-12 16:16 ` Geert Uytterhoeven
2012-09-12 16:16   ` Geert Uytterhoeven
2012-09-12 16:16   ` Geert Uytterhoeven
2012-09-12 18:02   ` Cyril Chemparathy
2012-09-12 18:02     ` Cyril Chemparathy
2012-09-12 18:02     ` Cyril Chemparathy
2012-09-12 18:02     ` Cyril Chemparathy
2012-09-12 18:02     ` Cyril Chemparathy
2012-09-12 19:58     ` Sebastian Andrzej Siewior
2012-09-12 19:58       ` Sebastian Andrzej Siewior
2012-09-12 19:58       ` Sebastian Andrzej Siewior
2012-09-12 22:08       ` Rob Herring
2012-09-12 22:08         ` Rob Herring
2012-09-12 22:08         ` Rob Herring
2012-09-13  6:47         ` Sebastian Andrzej Siewior [this message]
2012-09-13  6:47           ` Sebastian Andrzej Siewior
2012-09-13  6:47           ` Sebastian Andrzej Siewior
2012-09-13 21:02           ` Rob Herring
2012-09-13 21:02             ` Rob Herring
2012-09-13 21:02             ` Rob Herring
2012-09-12 20:23 ` Rob Herring
2012-09-12 20:23   ` Rob Herring
2012-09-12 20:23   ` Rob Herring
2012-09-12 20:31   ` Nicolas Pitre
2012-09-12 20:31     ` Nicolas Pitre
2012-09-12 20:31     ` Nicolas Pitre
2012-09-12 20:56     ` Rob Herring
2012-09-12 20:56       ` Rob Herring
2012-09-12 20:56       ` Rob Herring
2012-09-12 20:56       ` Rob Herring
2012-09-12 23:45   ` Cyril Chemparathy
2012-09-12 23:45     ` Cyril Chemparathy
2012-09-12 23:45     ` Cyril Chemparathy
2012-09-12 23:45     ` Cyril Chemparathy
2012-09-12 23:45     ` Cyril Chemparathy
  -- strict thread matches above, loose matches on Subject: below --
2013-06-21  0:52 [PATCH] of: Specify " Santosh Shilimkar
2013-06-21  0:52 ` Santosh Shilimkar
2013-06-21  0:52 ` Santosh Shilimkar
2013-06-21  0:52 ` Santosh Shilimkar
2013-06-21  0:52 ` Santosh Shilimkar
2013-06-21  4:39 ` Vineet Gupta
2013-06-21  4:39   ` Vineet Gupta
2013-06-21  4:39   ` Vineet Gupta
2013-06-21  4:39   ` Vineet Gupta
2013-06-21  4:39   ` Vineet Gupta
2013-06-21  8:23   ` James Hogan
2013-06-21  8:23     ` James Hogan
2013-06-21  8:23     ` James Hogan
2013-06-21  8:23     ` James Hogan
2013-06-21  8:23     ` James Hogan
2013-06-21 17:12     ` Santosh Shilimkar
2013-06-21 17:12       ` Santosh Shilimkar
2013-06-21 17:12       ` Santosh Shilimkar
2013-06-21 17:12       ` Santosh Shilimkar
2013-06-21 17:12       ` Santosh Shilimkar
2013-06-21  9:04 ` Sebastian Andrzej Siewior
2013-06-21  9:04   ` Sebastian Andrzej Siewior
2013-06-21  9:04   ` Sebastian Andrzej Siewior
2013-06-21  9:04   ` Sebastian Andrzej Siewior
2013-06-21 17:20   ` Santosh Shilimkar
2013-06-21 17:20     ` Santosh Shilimkar
2013-06-21 17:20     ` Santosh Shilimkar
2013-06-21 17:20     ` Santosh Shilimkar
2013-06-21 17:20     ` Santosh Shilimkar
2013-06-27 20:54     ` Rob Herring
2013-06-27 20:54       ` Rob Herring
2013-06-27 20:54       ` Rob Herring
2013-06-27 20:54       ` Rob Herring
2013-06-28  7:54       ` Sebastian Andrzej Siewior
2013-06-28  7:54         ` Sebastian Andrzej Siewior
2013-06-28  7:54         ` Sebastian Andrzej Siewior
2013-06-28  7:54         ` Sebastian Andrzej Siewior
2013-06-28  9:59       ` Grant Likely
2013-06-28  9:59         ` Grant Likely
2013-06-28  9:59         ` Grant Likely
2013-06-28  9:59         ` Grant Likely
2013-06-28 13:49         ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-28 13:49           ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-28 13:49           ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-28 13:49           ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-28 23:43           ` Santosh Shilimkar
2013-06-28 23:43             ` Santosh Shilimkar
2013-06-28 23:43             ` Santosh Shilimkar
2013-06-28 23:43             ` Santosh Shilimkar
2013-06-28 23:43             ` Santosh Shilimkar
2013-06-29  8:34             ` Geert Uytterhoeven
2013-06-29  8:34               ` Geert Uytterhoeven
2013-06-29  8:34               ` Geert Uytterhoeven
2013-06-29  8:34               ` Geert Uytterhoeven
2013-07-01  7:48             ` Sebastian Andrzej Siewior
2013-07-01  7:48               ` Sebastian Andrzej Siewior
2013-07-01  7:48               ` Sebastian Andrzej Siewior
2013-07-01  7:48               ` Sebastian Andrzej Siewior
2013-07-01  7:59               ` Geert Uytterhoeven
2013-07-01  7:59                 ` Geert Uytterhoeven
2013-07-01  7:59                 ` Geert Uytterhoeven
2013-07-01  7:59                 ` Geert Uytterhoeven
2013-07-01  8:09                 ` Sebastian Andrzej Siewior
2013-07-01  8:09                   ` Sebastian Andrzej Siewior
2013-07-01  8:09                   ` Sebastian Andrzej Siewior
2013-07-01  8:09                   ` Sebastian Andrzej Siewior
2013-07-01 13:58                 ` Santosh Shilimkar
2013-07-01 13:58                   ` Santosh Shilimkar
2013-07-01 13:58                   ` Santosh Shilimkar
2013-07-01 13:58                   ` Santosh Shilimkar
2013-07-01 13:58                   ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5051816A.3050705@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=a-jacquiot@ti.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=blogic@openwrt.org \
    --cc=cyril@ti.com \
    --cc=david.daney@cavium.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=grant.likely@secretlab.ca \
    --cc=hpa@zytor.com \
    --cc=jonas@southpole.se \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-c6x-dev@linux-c6x.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linux@openrisc.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=mingo@redhat.com \
    --cc=monstr@monstr.eu \
    --cc=msalter@redhat.com \
    --cc=nico@linaro.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=paulus@samba.org \
    --cc=ralf@linux-mips.org \
    --cc=rob.herring@calxeda.com \
    --cc=robherring2@gmail.com \
    --cc=suzuki@in.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.