All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Archit Taneja <architt@codeaurora.org>, treding@nvidia.com
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	Chris Zhong <zyw@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 0/5] Add mipi dsi support for rk3288
Date: Mon, 08 Feb 2016 11:52:21 +0100	[thread overview]
Message-ID: <5060470.dfeHX20DRa@phil> (raw)
In-Reply-To: <56B869F4.6090507@codeaurora.org>

Hi Archit,

Am Montag, 8. Februar 2016, 15:42:04 schrieb Archit Taneja:
> On 01/06/2016 09:33 AM, Chris Zhong wrote:
> > The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller
> > IP. This series adds support for a Synopsys DesignWare MIPI DSI host
> > controller DRM driver.
> > 
> > The MIPI DSI feature is tested on rk3288 evb board, backport them to
> > chrome os kernel chrome_v3.14, and it can display normally.
> > 
> > This patchset is base on the patchset from Ying.liu@freescale.com.
> > <http://www.spinics.net/lists/dri-devel/msg77181.html>
> > 
> > According to the suggestion from Thierry, I have get rid of the bridge,
> > and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c.
> 
> I've raised this question too late, but what was the reason to not
> implement the DSI block as a bridge driver?

There seems to always be some sort of contention about those being bridge 
drivers - I think I remember Thierry speaking up about that. But I don't 
remember if any different solution was suggested.

Also as we have seen with current shared IPs (dw-hdmi + analogix-dp) there 
are always implementation-specific parts and deciding which needs to land 
where is difficult without the secondary user present.

The first iterations where using a bridge-driver-base for it but I guess it 
was to much hassle without seeing another user on the horizon.


> The drm/hisilicon IP seems to use a very similar DSI Designware IP (the
> register offsets seems to be the same). There is a good potential of
> re-use here by different kms drivers here the way it's already done for
> DW HDMI and the analogix DP driver that's in review process.

I guess, the second user now gets to do the generalization ;-)


Heiko

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 0/5] Add mipi dsi support for rk3288
Date: Mon, 08 Feb 2016 11:52:21 +0100	[thread overview]
Message-ID: <5060470.dfeHX20DRa@phil> (raw)
In-Reply-To: <56B869F4.6090507@codeaurora.org>

Hi Archit,

Am Montag, 8. Februar 2016, 15:42:04 schrieb Archit Taneja:
> On 01/06/2016 09:33 AM, Chris Zhong wrote:
> > The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller
> > IP. This series adds support for a Synopsys DesignWare MIPI DSI host
> > controller DRM driver.
> > 
> > The MIPI DSI feature is tested on rk3288 evb board, backport them to
> > chrome os kernel chrome_v3.14, and it can display normally.
> > 
> > This patchset is base on the patchset from Ying.liu at freescale.com.
> > <http://www.spinics.net/lists/dri-devel/msg77181.html>
> > 
> > According to the suggestion from Thierry, I have get rid of the bridge,
> > and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c.
> 
> I've raised this question too late, but what was the reason to not
> implement the DSI block as a bridge driver?

There seems to always be some sort of contention about those being bridge 
drivers - I think I remember Thierry speaking up about that. But I don't 
remember if any different solution was suggested.

Also as we have seen with current shared IPs (dw-hdmi + analogix-dp) there 
are always implementation-specific parts and deciding which needs to land 
where is difficult without the secondary user present.

The first iterations where using a bridge-driver-base for it but I guess it 
was to much hassle without seeing another user on the horizon.


> The drm/hisilicon IP seems to use a very similar DSI Designware IP (the
> register offsets seems to be the same). There is a good potential of
> re-use here by different kms drivers here the way it's already done for
> DW HDMI and the analogix DP driver that's in review process.

I guess, the second user now gets to do the generalization ;-)


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Archit Taneja <architt@codeaurora.org>, treding@nvidia.com
Cc: Chris Zhong <zyw@rock-chips.com>,
	linux-rockchip@lists.infradead.org, mark.yao@rock-chips.com,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Rob Herring <robh+dt@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org,
	Xinliang Liu <xinliang.liu@linaro.org>
Subject: Re: [PATCH v7 0/5] Add mipi dsi support for rk3288
Date: Mon, 08 Feb 2016 11:52:21 +0100	[thread overview]
Message-ID: <5060470.dfeHX20DRa@phil> (raw)
In-Reply-To: <56B869F4.6090507@codeaurora.org>

Hi Archit,

Am Montag, 8. Februar 2016, 15:42:04 schrieb Archit Taneja:
> On 01/06/2016 09:33 AM, Chris Zhong wrote:
> > The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller
> > IP. This series adds support for a Synopsys DesignWare MIPI DSI host
> > controller DRM driver.
> > 
> > The MIPI DSI feature is tested on rk3288 evb board, backport them to
> > chrome os kernel chrome_v3.14, and it can display normally.
> > 
> > This patchset is base on the patchset from Ying.liu@freescale.com.
> > <http://www.spinics.net/lists/dri-devel/msg77181.html>
> > 
> > According to the suggestion from Thierry, I have get rid of the bridge,
> > and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c.
> 
> I've raised this question too late, but what was the reason to not
> implement the DSI block as a bridge driver?

There seems to always be some sort of contention about those being bridge 
drivers - I think I remember Thierry speaking up about that. But I don't 
remember if any different solution was suggested.

Also as we have seen with current shared IPs (dw-hdmi + analogix-dp) there 
are always implementation-specific parts and deciding which needs to land 
where is difficult without the secondary user present.

The first iterations where using a bridge-driver-base for it but I guess it 
was to much hassle without seeing another user on the horizon.


> The drm/hisilicon IP seems to use a very similar DSI Designware IP (the
> register offsets seems to be the same). There is a good potential of
> re-use here by different kms drivers here the way it's already done for
> DW HDMI and the analogix DP driver that's in review process.

I guess, the second user now gets to do the generalization ;-)


Heiko

  reply	other threads:[~2016-02-08 10:52 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06  4:03 [PATCH v7 0/5] Add mipi dsi support for rk3288 Chris Zhong
2016-01-06  4:03 ` Chris Zhong
2016-01-06  4:03 ` Chris Zhong
2016-01-06  4:03 ` [PATCH v7 1/5] drm/rockchip: return a true clock rate to adjusted_mode Chris Zhong
2016-01-06  4:03   ` Chris Zhong
2016-01-06  4:03   ` Chris Zhong
2016-01-06  4:03 ` [PATCH v7 2/5] Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver Chris Zhong
2016-01-06  4:03   ` Chris Zhong
2016-01-06  4:03 ` [PATCH v7 3/5] drm: rockchip: Support Synopsys DW MIPI DSI Chris Zhong
2016-01-06  4:03   ` Chris Zhong
2016-01-06  4:03   ` Chris Zhong
2016-01-06  6:30   ` Mark yao
2016-01-06  6:30     ` Mark yao
2016-01-06  6:30     ` Mark yao
2016-01-06  7:12     ` [PATCH v7.1 " Chris Zhong
2016-01-06  7:12       ` Chris Zhong
2016-01-06  7:12       ` Chris Zhong
2016-01-06  8:12     ` [PATCH v7.2 " Chris Zhong
2016-01-06  8:12       ` Chris Zhong
2016-01-06  8:12       ` Chris Zhong
2016-01-06  4:03 ` [PATCH v7 4/5] ARM: dts: rockchip: add rk3288 mipi_dsi nodes Chris Zhong
2016-01-06  4:03   ` Chris Zhong
     [not found]   ` <1452053038-32098-5-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-19 15:29     ` Heiko Stuebner
2016-01-19 15:29       ` Heiko Stuebner
2016-01-19 15:29       ` Heiko Stuebner
2016-01-20  0:50       ` Chris Zhong
2016-01-20  0:50         ` Chris Zhong
     [not found] ` <1452053038-32098-1-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-06  4:03   ` [PATCH v7 5/5] ARM: dts: rockchip: add support mipi panel tv080wum-nl0 Chris Zhong
2016-01-06  4:03     ` Chris Zhong
2016-01-06  4:03     ` Chris Zhong
     [not found]     ` <1452053038-32098-6-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-19 19:26       ` Heiko Stuebner
2016-01-19 19:26         ` Heiko Stuebner
2016-01-19 19:26         ` Heiko Stuebner
2016-01-20  1:09         ` Chris Zhong
2016-01-20  1:09           ` Chris Zhong
2016-01-20  1:09           ` Chris Zhong
     [not found]           ` <569EDE2F.6060400-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-20 22:25             ` Heiko Stuebner
2016-01-20 22:25               ` Heiko Stuebner
2016-01-20 22:25               ` Heiko Stuebner
2016-01-06  8:39 ` [PATCH v7 0/5] Add mipi dsi support for rk3288 Mark yao
2016-01-06  8:39   ` Mark yao
2016-01-06  8:39   ` Mark yao
2016-02-08 10:12 ` Archit Taneja
2016-02-08 10:12   ` Archit Taneja
2016-02-08 10:12   ` Archit Taneja
2016-02-08 10:52   ` Heiko Stuebner [this message]
2016-02-08 10:52     ` Heiko Stuebner
2016-02-08 10:52     ` Heiko Stuebner
2016-02-08 12:26     ` Archit Taneja
2016-02-08 12:26       ` Archit Taneja
2016-02-08 12:26       ` Archit Taneja
     [not found]   ` <56B869F4.6090507-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-02-24  9:38     ` Xinliang Liu
2016-02-24  9:38       ` Xinliang Liu
2016-02-24  9:38       ` Xinliang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5060470.dfeHX20DRa@phil \
    --to=heiko@sntech.de \
    --cc=architt@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=treding@nvidia.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.