From: Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: Re: [PATCH v7 5/5] ARM: dts: rockchip: add support mipi panel tv080wum-nl0
Date: Wed, 20 Jan 2016 09:09:03 +0800 [thread overview]
Message-ID: <569EDE2F.6060400@rock-chips.com> (raw)
In-Reply-To: <1649978.zzK0Pex4sR@phil>
Hi Heiko
On 01/20/2016 03:26 AM, Heiko Stuebner wrote:
> Hi Chris,
>
> Am Mittwoch, 6. Januar 2016, 12:03:57 schrieb Chris Zhong:
>> This tv080wum-nl0 panel is a mipi panel, it can use in MIPI_TX socket
>> of rk3288 evb board.
>>
>> Signed-off-by: Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> [...]
>
>> diff --git a/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> b/arch/arm/boot/dts/rk3288-evb-act8846.dts index e662147..7d5475b 100644
>> --- a/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> +++ b/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> @@ -50,6 +50,8 @@
>> gpio = <&gpio7 3 GPIO_ACTIVE_HIGH>;
>> pinctrl-names = "default";
>> pinctrl-0 = <&lcd_en>;
>> + regulator-always-on;
>> + regulator-boot-on;
> Is this only needed for the panel itself and can you try to get the panel
> supplies set up correctly instead in that case please?
It is not only for panel, LCDC_VDD need this supply too.
And rk3288-evb-rk808.dts has set this regulator to always on, so I do
the same thing in here.
>
>
>> regulator-name = "vcc_lcd";
>> vin-supply = <&vcc_io>;
>> };
>> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
>> b/arch/arm/boot/dts/rk3288-evb.dtsi index 4faabdb..0c91858 100644
>> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
>> @@ -47,7 +47,7 @@
>> reg = <0x0 0x80000000>;
>> };
>>
>> - backlight {
>> + backlight: backlight {
>> compatible = "pwm-backlight";
>> brightness-levels = <
>> 0 1 2 3 4 5 6 7
>> @@ -183,6 +183,16 @@
>> status = "okay";
>> };
>>
>> +&mipi_dsi {
>> + status = "okay";
>> + panel {
>> + compatible ="boe,tv080wum-nl0";
>> + reg = <0>;
>> + backlight = <&backlight>;
>> + status = "okay";
> in the evb-schematics I see, vcc_lcd as supply for the panel.
>
> So I'd think the panel node here should have a
> power-supply = <&vcc_lcd>;
> instead of having the always-on above?
>
>
> Thanks
> Heiko
>
>> + };
>> +};
>> +
>> &sdmmc {
>> bus-width = <4>;
>> cap-mmc-highspeed;
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: zyw@rock-chips.com (Chris Zhong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 5/5] ARM: dts: rockchip: add support mipi panel tv080wum-nl0
Date: Wed, 20 Jan 2016 09:09:03 +0800 [thread overview]
Message-ID: <569EDE2F.6060400@rock-chips.com> (raw)
In-Reply-To: <1649978.zzK0Pex4sR@phil>
Hi Heiko
On 01/20/2016 03:26 AM, Heiko Stuebner wrote:
> Hi Chris,
>
> Am Mittwoch, 6. Januar 2016, 12:03:57 schrieb Chris Zhong:
>> This tv080wum-nl0 panel is a mipi panel, it can use in MIPI_TX socket
>> of rk3288 evb board.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> [...]
>
>> diff --git a/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> b/arch/arm/boot/dts/rk3288-evb-act8846.dts index e662147..7d5475b 100644
>> --- a/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> +++ b/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> @@ -50,6 +50,8 @@
>> gpio = <&gpio7 3 GPIO_ACTIVE_HIGH>;
>> pinctrl-names = "default";
>> pinctrl-0 = <&lcd_en>;
>> + regulator-always-on;
>> + regulator-boot-on;
> Is this only needed for the panel itself and can you try to get the panel
> supplies set up correctly instead in that case please?
It is not only for panel, LCDC_VDD need this supply too.
And rk3288-evb-rk808.dts has set this regulator to always on, so I do
the same thing in here.
>
>
>> regulator-name = "vcc_lcd";
>> vin-supply = <&vcc_io>;
>> };
>> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
>> b/arch/arm/boot/dts/rk3288-evb.dtsi index 4faabdb..0c91858 100644
>> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
>> @@ -47,7 +47,7 @@
>> reg = <0x0 0x80000000>;
>> };
>>
>> - backlight {
>> + backlight: backlight {
>> compatible = "pwm-backlight";
>> brightness-levels = <
>> 0 1 2 3 4 5 6 7
>> @@ -183,6 +183,16 @@
>> status = "okay";
>> };
>>
>> +&mipi_dsi {
>> + status = "okay";
>> + panel {
>> + compatible ="boe,tv080wum-nl0";
>> + reg = <0>;
>> + backlight = <&backlight>;
>> + status = "okay";
> in the evb-schematics I see, vcc_lcd as supply for the panel.
>
> So I'd think the panel node here should have a
> power-supply = <&vcc_lcd>;
> instead of having the always-on above?
>
>
> Thanks
> Heiko
>
>> + };
>> +};
>> +
>> &sdmmc {
>> bus-width = <4>;
>> cap-mmc-highspeed;
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Chris Zhong <zyw@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org, mark.yao@rock-chips.com,
treding@nvidia.com, Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 5/5] ARM: dts: rockchip: add support mipi panel tv080wum-nl0
Date: Wed, 20 Jan 2016 09:09:03 +0800 [thread overview]
Message-ID: <569EDE2F.6060400@rock-chips.com> (raw)
In-Reply-To: <1649978.zzK0Pex4sR@phil>
Hi Heiko
On 01/20/2016 03:26 AM, Heiko Stuebner wrote:
> Hi Chris,
>
> Am Mittwoch, 6. Januar 2016, 12:03:57 schrieb Chris Zhong:
>> This tv080wum-nl0 panel is a mipi panel, it can use in MIPI_TX socket
>> of rk3288 evb board.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> [...]
>
>> diff --git a/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> b/arch/arm/boot/dts/rk3288-evb-act8846.dts index e662147..7d5475b 100644
>> --- a/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> +++ b/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> @@ -50,6 +50,8 @@
>> gpio = <&gpio7 3 GPIO_ACTIVE_HIGH>;
>> pinctrl-names = "default";
>> pinctrl-0 = <&lcd_en>;
>> + regulator-always-on;
>> + regulator-boot-on;
> Is this only needed for the panel itself and can you try to get the panel
> supplies set up correctly instead in that case please?
It is not only for panel, LCDC_VDD need this supply too.
And rk3288-evb-rk808.dts has set this regulator to always on, so I do
the same thing in here.
>
>
>> regulator-name = "vcc_lcd";
>> vin-supply = <&vcc_io>;
>> };
>> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
>> b/arch/arm/boot/dts/rk3288-evb.dtsi index 4faabdb..0c91858 100644
>> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
>> @@ -47,7 +47,7 @@
>> reg = <0x0 0x80000000>;
>> };
>>
>> - backlight {
>> + backlight: backlight {
>> compatible = "pwm-backlight";
>> brightness-levels = <
>> 0 1 2 3 4 5 6 7
>> @@ -183,6 +183,16 @@
>> status = "okay";
>> };
>>
>> +&mipi_dsi {
>> + status = "okay";
>> + panel {
>> + compatible ="boe,tv080wum-nl0";
>> + reg = <0>;
>> + backlight = <&backlight>;
>> + status = "okay";
> in the evb-schematics I see, vcc_lcd as supply for the panel.
>
> So I'd think the panel node here should have a
> power-supply = <&vcc_lcd>;
> instead of having the always-on above?
>
>
> Thanks
> Heiko
>
>> + };
>> +};
>> +
>> &sdmmc {
>> bus-width = <4>;
>> cap-mmc-highspeed;
>
>
>
next prev parent reply other threads:[~2016-01-20 1:09 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 4:03 [PATCH v7 0/5] Add mipi dsi support for rk3288 Chris Zhong
2016-01-06 4:03 ` Chris Zhong
2016-01-06 4:03 ` Chris Zhong
2016-01-06 4:03 ` [PATCH v7 1/5] drm/rockchip: return a true clock rate to adjusted_mode Chris Zhong
2016-01-06 4:03 ` Chris Zhong
2016-01-06 4:03 ` Chris Zhong
2016-01-06 4:03 ` [PATCH v7 2/5] Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver Chris Zhong
2016-01-06 4:03 ` Chris Zhong
2016-01-06 4:03 ` [PATCH v7 3/5] drm: rockchip: Support Synopsys DW MIPI DSI Chris Zhong
2016-01-06 4:03 ` Chris Zhong
2016-01-06 4:03 ` Chris Zhong
2016-01-06 6:30 ` Mark yao
2016-01-06 6:30 ` Mark yao
2016-01-06 6:30 ` Mark yao
2016-01-06 7:12 ` [PATCH v7.1 " Chris Zhong
2016-01-06 7:12 ` Chris Zhong
2016-01-06 7:12 ` Chris Zhong
2016-01-06 8:12 ` [PATCH v7.2 " Chris Zhong
2016-01-06 8:12 ` Chris Zhong
2016-01-06 8:12 ` Chris Zhong
2016-01-06 4:03 ` [PATCH v7 4/5] ARM: dts: rockchip: add rk3288 mipi_dsi nodes Chris Zhong
2016-01-06 4:03 ` Chris Zhong
[not found] ` <1452053038-32098-5-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-19 15:29 ` Heiko Stuebner
2016-01-19 15:29 ` Heiko Stuebner
2016-01-19 15:29 ` Heiko Stuebner
2016-01-20 0:50 ` Chris Zhong
2016-01-20 0:50 ` Chris Zhong
[not found] ` <1452053038-32098-1-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-06 4:03 ` [PATCH v7 5/5] ARM: dts: rockchip: add support mipi panel tv080wum-nl0 Chris Zhong
2016-01-06 4:03 ` Chris Zhong
2016-01-06 4:03 ` Chris Zhong
[not found] ` <1452053038-32098-6-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-19 19:26 ` Heiko Stuebner
2016-01-19 19:26 ` Heiko Stuebner
2016-01-19 19:26 ` Heiko Stuebner
2016-01-20 1:09 ` Chris Zhong [this message]
2016-01-20 1:09 ` Chris Zhong
2016-01-20 1:09 ` Chris Zhong
[not found] ` <569EDE2F.6060400-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-20 22:25 ` Heiko Stuebner
2016-01-20 22:25 ` Heiko Stuebner
2016-01-20 22:25 ` Heiko Stuebner
2016-01-06 8:39 ` [PATCH v7 0/5] Add mipi dsi support for rk3288 Mark yao
2016-01-06 8:39 ` Mark yao
2016-01-06 8:39 ` Mark yao
2016-02-08 10:12 ` Archit Taneja
2016-02-08 10:12 ` Archit Taneja
2016-02-08 10:12 ` Archit Taneja
2016-02-08 10:52 ` Heiko Stuebner
2016-02-08 10:52 ` Heiko Stuebner
2016-02-08 10:52 ` Heiko Stuebner
2016-02-08 12:26 ` Archit Taneja
2016-02-08 12:26 ` Archit Taneja
2016-02-08 12:26 ` Archit Taneja
[not found] ` <56B869F4.6090507-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-02-24 9:38 ` Xinliang Liu
2016-02-24 9:38 ` Xinliang Liu
2016-02-24 9:38 ` Xinliang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569EDE2F.6060400@rock-chips.com \
--to=zyw-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.