* [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output.
@ 2012-10-01 12:11 Evgeny Voevodin
2012-10-01 12:30 ` Peter Maydell
0 siblings, 1 reply; 5+ messages in thread
From: Evgeny Voevodin @ 2012-10-01 12:11 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, kyungmin.park, e.gorelkina, Evgeny Voevodin,
aliguori
s->cpu_enabled is a massive, so s->cpu_enabled ? "En" : "Dis" returns
"En" always. We should use s->cpu_enabled[cpu] here.
Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
---
hw/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index 55871fa..4024dae 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
@@ -566,7 +566,7 @@ static void gic_cpu_write(gic_state *s, int cpu, int offset, uint32_t value)
switch (offset) {
case 0x00: /* Control */
s->cpu_enabled[cpu] = (value & 1);
- DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled ? "En" : "Dis");
+ DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled[cpu] ? "En" : "Dis");
break;
case 0x04: /* Priority mask */
s->priority_mask[cpu] = (value & 0xff);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output.
2012-10-01 12:11 [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output Evgeny Voevodin
@ 2012-10-01 12:30 ` Peter Maydell
2012-10-02 3:50 ` Evgeny Voevodin
0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2012-10-01 12:30 UTC (permalink / raw)
To: Evgeny Voevodin; +Cc: kyungmin.park, aliguori, qemu-devel, e.gorelkina
On 1 October 2012 13:11, Evgeny Voevodin <e.voevodin@samsung.com> wrote:
> s->cpu_enabled is a massive, so s->cpu_enabled ? "En" : "Dis" returns
"is an array"
> "En" always. We should use s->cpu_enabled[cpu] here.
>
> Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
...but nice catch.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output.
2012-10-01 12:30 ` Peter Maydell
@ 2012-10-02 3:50 ` Evgeny Voevodin
2012-10-04 11:50 ` Evgeny Voevodin
0 siblings, 1 reply; 5+ messages in thread
From: Evgeny Voevodin @ 2012-10-02 3:50 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, kyungmin.park, e.gorelkina, Evgeny Voevodin,
aliguori
s->cpu_enabled is an array, so s->cpu_enabled ? "En" : "Dis" returns
"En" always. We should use s->cpu_enabled[cpu] here.
Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
---
hw/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index 55871fa..4024dae 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
@@ -566,7 +566,7 @@ static void gic_cpu_write(gic_state *s, int cpu, int offset, uint32_t value)
switch (offset) {
case 0x00: /* Control */
s->cpu_enabled[cpu] = (value & 1);
- DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled ? "En" : "Dis");
+ DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled[cpu] ? "En" : "Dis");
break;
case 0x04: /* Priority mask */
s->priority_mask[cpu] = (value & 0xff);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output.
2012-10-02 3:50 ` Evgeny Voevodin
@ 2012-10-04 11:50 ` Evgeny Voevodin
2012-10-04 11:59 ` Peter Maydell
0 siblings, 1 reply; 5+ messages in thread
From: Evgeny Voevodin @ 2012-10-04 11:50 UTC (permalink / raw)
To: Evgeny Voevodin
Cc: peter.maydell, kyungmin.park, aliguori, qemu-devel, e.gorelkina
On 10/02/2012 07:50 AM, Evgeny Voevodin wrote:
> s->cpu_enabled is an array, so s->cpu_enabled ? "En" : "Dis" returns
> "En" always. We should use s->cpu_enabled[cpu] here.
>
> Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
> ---
> hw/arm_gic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm_gic.c b/hw/arm_gic.c
> index 55871fa..4024dae 100644
> --- a/hw/arm_gic.c
> +++ b/hw/arm_gic.c
> @@ -566,7 +566,7 @@ static void gic_cpu_write(gic_state *s, int cpu, int offset, uint32_t value)
> switch (offset) {
> case 0x00: /* Control */
> s->cpu_enabled[cpu] = (value & 1);
> - DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled ? "En" : "Dis");
> + DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled[cpu] ? "En" : "Dis");
> break;
> case 0x04: /* Priority mask */
> s->priority_mask[cpu] = (value & 0xff);
Did anybody pick this up?
--
Kind regards,
Evgeny Voevodin,
Technical Leader,
Mobile Group,
Samsung Moscow Research Center,
e-mail: e.voevodin@samsung.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output.
2012-10-04 11:50 ` Evgeny Voevodin
@ 2012-10-04 11:59 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2012-10-04 11:59 UTC (permalink / raw)
To: Evgeny Voevodin; +Cc: kyungmin.park, aliguori, qemu-devel, e.gorelkina
On 4 October 2012 12:50, Evgeny Voevodin <e.voevodin@samsung.com> wrote:
> On 10/02/2012 07:50 AM, Evgeny Voevodin wrote:
>>
>> s->cpu_enabled is an array, so s->cpu_enabled ? "En" : "Dis" returns
>> "En" always. We should use s->cpu_enabled[cpu] here.
>
> Did anybody pick this up?
Yeah, I've put it in arm-devs.next.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-04 11:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-01 12:11 [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output Evgeny Voevodin
2012-10-01 12:30 ` Peter Maydell
2012-10-02 3:50 ` Evgeny Voevodin
2012-10-04 11:50 ` Evgeny Voevodin
2012-10-04 11:59 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.