From: Glauber Costa <glommer@parallels.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
Mel Gorman <mgorman@suse.de>, Tejun Heo <tj@kernel.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
kamezawa.hiroyu@jp.fujitsu.com, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
devel@openvz.org, linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH v5 06/14] memcg: kmem controller infrastructure
Date: Fri, 19 Oct 2012 13:10:27 +0400 [thread overview]
Message-ID: <50811903.9000105@parallels.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210181502270.30894@chino.kir.corp.google.com>
On 10/19/2012 02:06 AM, David Rientjes wrote:
> On Thu, 18 Oct 2012, Glauber Costa wrote:
>
>>> Do we actually need to test PF_KTHREAD when current->mm == NULL?
>>> Perhaps because of aio threads whcih temporarily adopt a userspace mm?
>>
>> I believe so. I remember I discussed this in the past with David
>> Rientjes and he advised me to test for both.
>>
>
> PF_KTHREAD can do use_mm() to assume an ->mm but hopefully they aren't
> allocating slab while doing so. Have you considered actually charging
> current->mm->owner for that memory, though, since the kthread will have
> freed the memory before unuse_mm() or otherwise have charged it on behalf
> of a user process, i.e. only exempting PF_KTHREAD?
>
I always charge current->mm->owner.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<cgroups@vger.kernel.org>, Mel Gorman <mgorman@suse.de>,
Tejun Heo <tj@kernel.org>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
<kamezawa.hiroyu@jp.fujitsu.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>, <devel@openvz.org>,
<linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH v5 06/14] memcg: kmem controller infrastructure
Date: Fri, 19 Oct 2012 13:10:27 +0400 [thread overview]
Message-ID: <50811903.9000105@parallels.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210181502270.30894@chino.kir.corp.google.com>
On 10/19/2012 02:06 AM, David Rientjes wrote:
> On Thu, 18 Oct 2012, Glauber Costa wrote:
>
>>> Do we actually need to test PF_KTHREAD when current->mm == NULL?
>>> Perhaps because of aio threads whcih temporarily adopt a userspace mm?
>>
>> I believe so. I remember I discussed this in the past with David
>> Rientjes and he advised me to test for both.
>>
>
> PF_KTHREAD can do use_mm() to assume an ->mm but hopefully they aren't
> allocating slab while doing so. Have you considered actually charging
> current->mm->owner for that memory, though, since the kthread will have
> freed the memory before unuse_mm() or otherwise have charged it on behalf
> of a user process, i.e. only exempting PF_KTHREAD?
>
I always charge current->mm->owner.
next prev parent reply other threads:[~2012-10-19 9:10 UTC|newest]
Thread overview: 177+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 10:16 [PATCH v5 00/14] kmem controller for memcg Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 01/14] memcg: Make it possible to use the stock for more than one page Glauber Costa
2012-10-16 10:16 ` Glauber Costa
[not found] ` <1350382611-20579-2-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-17 22:11 ` Andrew Morton
2012-10-17 22:11 ` Andrew Morton
2012-10-17 22:11 ` Andrew Morton
2012-10-18 16:54 ` Glauber Costa
2012-10-18 16:54 ` Glauber Costa
2012-10-18 16:54 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 02/14] memcg: Reclaim when more than one page needed Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-16 10:16 ` Glauber Costa
[not found] ` <1350382611-20579-3-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-17 21:46 ` David Rientjes
2012-10-17 21:46 ` David Rientjes
2012-10-17 21:46 ` David Rientjes
2012-10-16 10:16 ` [PATCH v5 03/14] memcg: change defines to an enum Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-17 21:50 ` David Rientjes
2012-10-17 21:50 ` David Rientjes
2012-10-16 10:16 ` [PATCH v5 04/14] kmem accounting basic infrastructure Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-16 12:14 ` Michal Hocko
2012-10-16 12:14 ` Michal Hocko
[not found] ` <1350382611-20579-5-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-17 22:08 ` David Rientjes
2012-10-17 22:08 ` David Rientjes
2012-10-17 22:08 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1210171455010.20712-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-10-18 17:01 ` Glauber Costa
2012-10-18 17:01 ` Glauber Costa
2012-10-18 17:01 ` Glauber Costa
2012-10-18 19:47 ` Tejun Heo
2012-10-18 19:47 ` Tejun Heo
2012-10-18 19:37 ` Tejun Heo
2012-10-18 19:37 ` Tejun Heo
2012-10-18 19:37 ` Tejun Heo
2012-10-17 22:12 ` Andrew Morton
2012-10-17 22:12 ` Andrew Morton
[not found] ` <20121017151207.e8bb3db2.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-10-18 17:03 ` Glauber Costa
2012-10-18 17:03 ` Glauber Costa
2012-10-18 17:03 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 05/14] Add a __GFP_KMEMCG flag Glauber Costa
2012-10-16 10:16 ` Glauber Costa
[not found] ` <1350382611-20579-6-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-16 12:15 ` Michal Hocko
2012-10-16 12:15 ` Michal Hocko
2012-10-16 12:15 ` Michal Hocko
2012-10-17 22:09 ` David Rientjes
2012-10-17 22:09 ` David Rientjes
2012-10-17 22:09 ` David Rientjes
2012-10-16 10:16 ` [PATCH v5 06/14] memcg: kmem controller infrastructure Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-17 6:40 ` Kamezawa Hiroyuki
2012-10-17 6:40 ` Kamezawa Hiroyuki
2012-10-17 22:12 ` Andrew Morton
2012-10-17 22:12 ` Andrew Morton
2012-10-18 9:16 ` Glauber Costa
2012-10-18 9:16 ` Glauber Costa
2012-10-18 22:06 ` David Rientjes
2012-10-18 22:06 ` David Rientjes
2012-10-19 9:10 ` Glauber Costa [this message]
2012-10-19 9:10 ` Glauber Costa
2012-10-19 9:31 ` David Rientjes
2012-10-19 9:31 ` David Rientjes
2012-10-19 10:00 ` Glauber Costa
2012-10-19 10:00 ` Glauber Costa
2012-10-17 22:37 ` David Rientjes
2012-10-17 22:37 ` David Rientjes
2012-10-18 9:23 ` Glauber Costa
2012-10-18 9:23 ` Glauber Costa
[not found] ` <507FCA90.8060307-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-18 21:59 ` David Rientjes
2012-10-18 21:59 ` David Rientjes
2012-10-18 21:59 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1210181454100.30894-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-10-19 10:08 ` Glauber Costa
2012-10-19 10:08 ` Glauber Costa
2012-10-19 10:08 ` Glauber Costa
2012-10-19 20:34 ` David Rientjes
2012-10-19 20:34 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1210191331400.17804-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-10-22 12:34 ` Glauber Costa
2012-10-22 12:34 ` Glauber Costa
2012-10-22 12:34 ` Glauber Costa
[not found] ` <50853D47.4030409-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-22 12:51 ` Michal Hocko
2012-10-22 12:51 ` Michal Hocko
2012-10-22 12:51 ` Michal Hocko
2012-10-22 12:52 ` Glauber Costa
2012-10-22 12:52 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-17 22:12 ` Andrew Morton
2012-10-17 22:12 ` Andrew Morton
2012-10-18 9:24 ` Glauber Costa
2012-10-18 9:24 ` Glauber Costa
2012-10-18 9:24 ` Glauber Costa
[not found] ` <507FCADF.20109-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-18 20:44 ` Andrew Morton
2012-10-18 20:44 ` Andrew Morton
2012-10-18 20:44 ` Andrew Morton
[not found] ` <20121017151221.4c420e5a.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-10-18 11:53 ` Glauber Costa
2012-10-18 11:53 ` Glauber Costa
2012-10-18 11:53 ` Glauber Costa
[not found] ` <1350382611-20579-8-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-16 15:31 ` Christoph Lameter
2012-10-16 15:31 ` Christoph Lameter
2012-10-16 15:31 ` Christoph Lameter
[not found] ` <0000013a6a333867-52b0d904-5ca2-4095-8c46-5a4dfc021cde-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-10-16 18:55 ` Glauber Costa
2012-10-16 18:55 ` Glauber Costa
2012-10-16 18:55 ` Glauber Costa
2012-10-17 22:43 ` David Rientjes
2012-10-17 22:43 ` David Rientjes
2012-10-17 22:43 ` David Rientjes
2012-10-16 10:16 ` [PATCH v5 08/14] res_counter: return amount of charges after res_counter_uncharge Glauber Costa
2012-10-16 10:16 ` Glauber Costa
[not found] ` <1350382611-20579-9-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-17 23:23 ` David Rientjes
2012-10-17 23:23 ` David Rientjes
2012-10-17 23:23 ` David Rientjes
2012-10-16 10:16 ` [PATCH v5 09/14] memcg: kmem accounting lifecycle management Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-17 23:28 ` David Rientjes
2012-10-17 23:28 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1210171624540.20813-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-10-18 6:14 ` Michal Hocko
2012-10-18 6:14 ` Michal Hocko
2012-10-18 6:14 ` Michal Hocko
2012-10-18 9:42 ` Glauber Costa
2012-10-18 9:42 ` Glauber Costa
2012-10-18 9:42 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 10/14] memcg: use static branches when code not in use Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 11/14] memcg: allow a memcg with kmem charges to be destructed Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-17 22:12 ` Andrew Morton
2012-10-17 22:12 ` Andrew Morton
2012-10-18 9:33 ` Glauber Costa
2012-10-18 9:33 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 12/14] execute the whole memcg freeing in free_worker Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-17 6:56 ` Kamezawa Hiroyuki
2012-10-17 6:56 ` Kamezawa Hiroyuki
2012-10-16 10:16 ` [PATCH v5 13/14] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-17 22:12 ` Andrew Morton
2012-10-17 22:12 ` Andrew Morton
[not found] ` <20121017151245.f11c4d18.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-10-18 9:37 ` Glauber Costa
2012-10-18 9:37 ` Glauber Costa
2012-10-18 9:37 ` Glauber Costa
2012-10-16 10:16 ` [PATCH v5 14/14] Add documentation about the kmem controller Glauber Costa
2012-10-16 10:16 ` Glauber Costa
2012-10-16 10:16 ` Glauber Costa
[not found] ` <1350382611-20579-15-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-16 12:23 ` Michal Hocko
2012-10-16 12:23 ` Michal Hocko
2012-10-16 12:23 ` Michal Hocko
2012-10-16 18:25 ` Christoph Lameter
2012-10-16 18:25 ` Christoph Lameter
[not found] ` <0000013a6ad26c73-d043cf97-c44a-45c1-9cae-0a962e93a005-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-10-16 18:55 ` Aristeu Rozanski
2012-10-16 18:55 ` Aristeu Rozanski
2012-10-16 18:55 ` Aristeu Rozanski
2012-10-16 19:02 ` Glauber Costa
2012-10-16 19:02 ` Glauber Costa
2012-10-16 19:02 ` Glauber Costa
[not found] ` <507DAF56.9010403-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-16 19:30 ` Christoph Lameter
2012-10-16 19:30 ` Christoph Lameter
2012-10-16 19:30 ` Christoph Lameter
2012-10-17 22:12 ` Andrew Morton
2012-10-17 22:12 ` Andrew Morton
2012-10-18 9:38 ` Glauber Costa
2012-10-18 9:38 ` Glauber Costa
[not found] ` <1350382611-20579-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-17 22:11 ` [PATCH v5 00/14] kmem controller for memcg Andrew Morton
2012-10-17 22:11 ` Andrew Morton
2012-10-17 22:11 ` Andrew Morton
[not found] ` <20121017151142.71e1f3c5.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-10-18 16:51 ` Glauber Costa
2012-10-18 16:51 ` Glauber Costa
2012-10-18 16:51 ` Glauber Costa
[not found] ` <50803379.8000808-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-18 19:21 ` Andrew Morton
2012-10-18 19:21 ` Andrew Morton
2012-10-18 19:21 ` Andrew Morton
[not found] ` <20121018122105.2efc2841.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-10-19 9:55 ` Glauber Costa
2012-10-19 9:55 ` Glauber Costa
2012-10-19 9:55 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50811903.9000105@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=devel@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.